JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision.
Bump the required SWIG version to 3. If my memory serves me well we last bumped the required SWIG version to 2 for Python 3. At that time SWIG 3 had already been around for a while so everyone I know was already using that. It appears that SWIG 3 is the only version that officially supports C++11 which we're using in the typemap. SWIG 3 was released in 2014 so I think it's reasonable to make that the minimally supported version. https://bugs.llvm.org/show_bug.cgi?id=48685 https://reviews.llvm.org/D94244 Files: lldb/cmake/modules/FindLuaAndSwig.cmake lldb/cmake/modules/FindPythonAndSwig.cmake lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst =================================================================== --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -34,7 +34,7 @@ scripting support. * `Python <http://www.python.org/>`_ -* `SWIG <http://swig.org/>`_ 2 or later. +* `SWIG <http://swig.org/>`_ 3 or later. Optional Dependencies ********************* Index: lldb/cmake/modules/FindPythonAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindPythonAndSwig.cmake +++ lldb/cmake/modules/FindPythonAndSwig.cmake @@ -38,7 +38,7 @@ if(Python3_LIBRARIES AND Python3_INCLUDE_DIRS AND Python3_EXECUTABLE AND SWIG_EXECUTABLE) set(PYTHONANDSWIG_FOUND TRUE) else() - find_package(SWIG 2.0) + find_package(SWIG 3.0) if (SWIG_FOUND) FindPython3() else() Index: lldb/cmake/modules/FindLuaAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindLuaAndSwig.cmake +++ lldb/cmake/modules/FindLuaAndSwig.cmake @@ -7,7 +7,7 @@ if(LUA_LIBRARIES AND LUA_INCLUDE_DIR AND SWIG_EXECUTABLE) set(LUAANDSWIG_FOUND TRUE) else() - find_package(SWIG 2.0) + find_package(SWIG 3.0) if (SWIG_FOUND) find_package(Lua 5.3) if(LUA_FOUND AND SWIG_FOUND)
Index: lldb/docs/resources/build.rst =================================================================== --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -34,7 +34,7 @@ scripting support. * `Python <http://www.python.org/>`_ -* `SWIG <http://swig.org/>`_ 2 or later. +* `SWIG <http://swig.org/>`_ 3 or later. Optional Dependencies ********************* Index: lldb/cmake/modules/FindPythonAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindPythonAndSwig.cmake +++ lldb/cmake/modules/FindPythonAndSwig.cmake @@ -38,7 +38,7 @@ if(Python3_LIBRARIES AND Python3_INCLUDE_DIRS AND Python3_EXECUTABLE AND SWIG_EXECUTABLE) set(PYTHONANDSWIG_FOUND TRUE) else() - find_package(SWIG 2.0) + find_package(SWIG 3.0) if (SWIG_FOUND) FindPython3() else() Index: lldb/cmake/modules/FindLuaAndSwig.cmake =================================================================== --- lldb/cmake/modules/FindLuaAndSwig.cmake +++ lldb/cmake/modules/FindLuaAndSwig.cmake @@ -7,7 +7,7 @@ if(LUA_LIBRARIES AND LUA_INCLUDE_DIR AND SWIG_EXECUTABLE) set(LUAANDSWIG_FOUND TRUE) else() - find_package(SWIG 2.0) + find_package(SWIG 3.0) if (SWIG_FOUND) find_package(Lua 5.3) if(LUA_FOUND AND SWIG_FOUND)
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
