[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

labath accepted this revision. labath added a comment. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86261/new/ https://reviews.llvm.org/D86261 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

teemperor added a reviewer: JDevlieghere. teemperor added a comment. Thanks for working on this! This looks good to me, but I wonder if doing this with a dedicated flag instead of an environment variable would be better. But I'll leave that to the others who have a better idea how the dotest fla

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

JDevlieghere added a comment. In D86416#2232966 , @teemperor wrote: > This looks good to me, but I wonder if doing this with a dedicated flag > instead of an environment variable would be better. But I'll leave that to > the others who have a better idea

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

labath added a comment. I actually think tests relying on this should be converted to c++ unit tests. The logic to compile and link against liblldb takes up a considerable chunk of our test buildsystem. Why recreate that logic, when cmake knows how to do that already? TestPluginCommands might b

[Lldb-commits] [PATCH] D86375: Load correct module for linux and android when duplicates exist in minidump.

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. If I correctly understand what this is doing, then I don't think it's a good idea. The base of an (elf) shared library does not have to be mapped executable. These are the mappings I

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

labath created this revision. labath added reviewers: aprantl, shafik. Herald added a project: LLDB. labath requested review of this revision. Herald added a subscriber: JDevlieghere. The function was returning an incorrect (empty) value on the first invocation. Given that this only affected the f

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

labath added a comment. In D86348#2231094 , @aprantl wrote: > This looks nice! I'm somewhat suspicious that the new test doesn't > specifically test the union case of the old test, but I'm assuming that would > still work and your simpler tests covers th

[Lldb-commits] [lldb] 0e301fd - [lldb/Utility] Remove some Scalar type accessors

Author: Pavel Labath Date: 2020-08-24T11:45:30+02:00 New Revision: 0e301fd02386e01ca93a28e8c0484447fbb440a1 URL: https://github.com/llvm/llvm-project/commit/0e301fd02386e01ca93a28e8c0484447fbb440a1 DIFF: https://github.com/llvm/llvm-project/commit/0e301fd02386e01ca93a28e8c0484447fbb440a1.diff

[Lldb-commits] [PATCH] D82853: [LLDB] Support custom expedited register set in gdb-remote

omjavaid updated this revision to Diff 287323. omjavaid added a comment. This reworks previous implementation by returning a vector containing register numbers to be expedited. Default case is minimal set of generic registers or complete register set 0. In the child rev D82855

[Lldb-commits] [PATCH] D82855: [LLDB] Send SVE vg register in custom expedited registerset

omjavaid updated this revision to Diff 287325. omjavaid added a comment. Updated after changes to parent rev D82853 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82855/new/ https://reviews.llvm.org/D82855 Files: lldb/source/Plugins/Process/Linux/Nati

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 287333. omjavaid added a comment. Updated after changes to TestSVERegister.py for detecting SVE support using /proc/cpuinfo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/

[Lldb-commits] [PATCH] D80700: [lldb] common completion for process pids and process names

This revision was automatically updated to reflect the committed changes. Closed by commit rG19311f5c3e9a: [lldb] common completion for process pids and process names (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [lldb] 19311f5 - [lldb] common completion for process pids and process names

Author: Gongyu Deng Date: 2020-08-24T17:30:43+02:00 New Revision: 19311f5c3e9ada9d445e49feb7a2ae00ddaee2fa URL: https://github.com/llvm/llvm-project/commit/19311f5c3e9ada9d445e49feb7a2ae00ddaee2fa DIFF: https://github.com/llvm/llvm-project/commit/19311f5c3e9ada9d445e49feb7a2ae00ddaee2fa.diff L

[Lldb-commits] [lldb] 3cd8d7b - [lldb] Remote disk file/directory completion for platform commands

Author: Gongyu Deng Date: 2020-08-24T17:55:54+02:00 New Revision: 3cd8d7b1727f06a701f41764c1109e5d321284b3 URL: https://github.com/llvm/llvm-project/commit/3cd8d7b1727f06a701f41764c1109e5d321284b3 DIFF: https://github.com/llvm/llvm-project/commit/3cd8d7b1727f06a701f41764c1109e5d321284b3.diff L

[Lldb-commits] [PATCH] D85284: [lldb] Remote disk file/directory completion for platform commands

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cd8d7b1727f: [lldb] Remote disk file/directory completion for platform commands (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I came to the same conclusion when analyzing https://bugs.llvm.org/show_bug.cgi?id=47257 (but you beat me to the punch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

shafik added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix shows this having this additional s

[Lldb-commits] [PATCH] D86348: [lldb/DWARF] More DW_AT_const_value fixes

aprantl added a comment. Sounds good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86348/new/ https://reviews.llvm.org/D86348 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

labath added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix > shows this having

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix > shows this having

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

shafik added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } labath wrote: > davide wrote: > > shafik wrote: > > > Wouldn't it be better to turn `m_byte_size` into an `Optio

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added a subscriber: teemperor. davide added a comment. @labath something we noticed when finding this (and related bugs) is that `frame var` carries a decent diagnostic (int *) l_125 = and the expression parser returns just returns something not particularly useful: (lldb) p l_125

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > labath wrote: > > davide wrote: > > > shafik wrote: > > > > Wouldn't it be better to turn `m_byt

[Lldb-commits] [PATCH] D84124: [lldb] type category name common completion

This revision was automatically updated to reflect the committed changes. Closed by commit rG188f1ac301c5: [lldb] type category name common completion (authored by MrHate, committed by teemperor). Herald added a subscriber: lldb-commits. Changed prior to commit: https://reviews.llvm.org/D84124?

[Lldb-commits] [lldb] 188f1ac - [lldb] type category name common completion

Author: Gongyu Deng Date: 2020-08-24T19:54:23+02:00 New Revision: 188f1ac301c5c6da6d2f5697952510fc39cbdd43 URL: https://github.com/llvm/llvm-project/commit/188f1ac301c5c6da6d2f5697952510fc39cbdd43 DIFF: https://github.com/llvm/llvm-project/commit/188f1ac301c5c6da6d2f5697952510fc39cbdd43.diff L

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak updated this revision to Diff 287451. llunak added a comment. Updated to not use environment variable. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86416/new/ https://reviews.llvm.org/D86416 Files: lldb/packages/Python/lldbsuite/test/configuration.py

[Lldb-commits] [PATCH] D86416: [lldb] -stdlib=libc++ for linking with lldb lib also if LLVM_ENABLE_LIBCXX

llunak marked an inline comment as done. llunak added a comment. In D86416#2232966 , @teemperor wrote: > Out of curiosity, will this also fix the TestPluginCommands.py ? Yes. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 0e6c9a6 - Add hashing of the .text section to ProcessMinidump.

Author: Greg Clayton Date: 2020-08-24T11:43:50-07:00 New Revision: 0e6c9a6e7940a2f8ee624358d828acffdb9ccca5 URL: https://github.com/llvm/llvm-project/commit/0e6c9a6e7940a2f8ee624358d828acffdb9ccca5 DIFF: https://github.com/llvm/llvm-project/commit/0e6c9a6e7940a2f8ee624358d828acffdb9ccca5.diff

[Lldb-commits] [PATCH] D86261: Add hashing of the .text section to ProcessMinidump.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e6c9a6e7940: Add hashing of the .text section to ProcessMinidump. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D86375: Load correct module for linux and android when duplicates exist in minidump.

clayborg added a comment. In D86375#2233054 , @labath wrote: > If I correctly understand what this is doing, then I don't think it's a good > idea. The base of an (elf) shared library does not have to be mapped > executable. These are the mappings I get

[Lldb-commits] [PATCH] D86388: Fix use-after-free in ThreadPlan, and add test.

jingham added a comment. I'm confused as to how this patch actually fixes the problem. When the thread gets removed from the thread list, it should get Destroy called on it - which should set m_destroy_called, causing IsValid to return false.. So I am not clear under what circumstances FindTh

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

shafik updated this revision to Diff 287482. shafik marked 5 inline comments as done. shafik added a comment. -Add REQUIRES x86 - Fix-up the comments in the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86311/new/ https://reviews.llvm.org/D86311 Files: lldb/source/Core/ValueObj

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86389/new/ https://reviews.llvm.org/D86389 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

shafik added inline comments. Comment at: lldb/source/Core/ValueObjectVariable.cpp:136 +if (expr.GetExpressionData(m_data)) { + if (m_data.GetDataStart() && m_data.GetByteSize()) +m_value.SetBytes(m_data.GetDataStart(), m_data.GetByteSize()); la

[Lldb-commits] [PATCH] D86389: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

This revision was automatically updated to reflect the committed changes. Closed by commit rGa842950b62b6: [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D86389

[Lldb-commits] [lldb] a842950 - [lldb] Add a SymbolFileProvider to record and replay calls to dsymForUUID

Author: Jonas Devlieghere Date: 2020-08-24T15:09:08-07:00 New Revision: a842950b62b6d029a392c3c312c6495d6368c2a4 URL: https://github.com/llvm/llvm-project/commit/a842950b62b6d029a392c3c312c6495d6368c2a4 DIFF: https://github.com/llvm/llvm-project/commit/a842950b62b6d029a392c3c312c6495d6368c2a4.d

[Lldb-commits] [lldb] 93b2551 - [LLDB] Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

Author: shafik Date: 2020-08-24T15:17:27-07:00 New Revision: 93b255142bb7025f62cf83dd5b7d3b04aab5445b URL: https://github.com/llvm/llvm-project/commit/93b255142bb7025f62cf83dd5b7d3b04aab5445b DIFF: https://github.com/llvm/llvm-project/commit/93b255142bb7025f62cf83dd5b7d3b04aab5445b.diff LOG: [

[Lldb-commits] [PATCH] D86311: Fix how ValueObjectVariable handles DW_AT_const_value when the DWARFExpression holds the data that represents a constant value

This revision was automatically updated to reflect the committed changes. Closed by commit rG93b255142bb7: [LLDB] Fix how ValueObjectVariable handles DW_AT_const_value when the… (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D86493: Remove unused/misnamed SetObjectModificationTime

kastiglione created this revision. kastiglione added reviewers: clayborg, friss, JDevlieghere, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Remove `SetObjectModificationTime` which is not currently used, and assigns

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace marked 12 inline comments as done. wallace added inline comments. Comment at: lldb/source/Target/Trace.cpp:109 + StringRef load_address_str; + if (!module->GetValueForKeyAsString("loadAddress", load_address_str)) +return SetMissingFieldError(error, "loadAddress", "s

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 287518. wallace added a comment. - Addressed comments. - Added schemas for both the base class and the implementation plugins. - Added two tests checking the error messages along with the schema when parsing failed. - Made some general clean up of the code

[Lldb-commits] [lldb] 4283320 - [LLDB] Fix SVE offset calculation in NativeRegisterContextLinux_arm64

Author: Muhammad Omair Javaid Date: 2020-08-25T03:54:41+05:00 New Revision: 4283320b7286dc94367b22df09499dc934e1fbf9 URL: https://github.com/llvm/llvm-project/commit/4283320b7286dc94367b22df09499dc934e1fbf9 DIFF: https://github.com/llvm/llvm-project/commit/4283320b7286dc94367b22df09499dc934e1fb

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, labath. Herald added subscribers: llvm-commits, dang, hiraditya. Herald added a project: LLVM. JDevlieghere requested review of this revision. Add a reproducer verifier that catches: - Missing or invalid home directory - Miss

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added a comment. This will require a test and maybe some code deduplication in `CommandObjectReproducer` but I already wanted to put the patch up in case I can't get to that today. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86497/new/ https://

[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

wallace updated this revision to Diff 287527. wallace added a comment. - Added a command that shows the schema of a given trace plugin. - Added a test for such command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85705/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D82866: [LLDB] Test SVE dynamic resize with multiple threads

omjavaid updated this revision to Diff 287526. omjavaid added a comment. This update changes this test;s dependence on register offset API. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82866/new/ https://reviews.llvm.org/D82866 Files: lldb/test/API/commands/register/register/aarch6

[Lldb-commits] [PATCH] D82865: [LLDB] Add GetByteOffset to SBValue interface for reading register offset

omjavaid added a comment. In D82865#2225978 , @labath wrote: > The new API looks fairly confusing. This doesn't sound like something that > the SB users should generally know or care about. What would the > GetByteOffset function return in the generic ca

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; Is this lambda missing an assignment to `errors`? Repository:

[Lldb-commits] [PATCH] D82064: [ARM64] Add QEMU testing environment setup guide for SVE testing

omjavaid added a comment. In D82064#2223991 , @JDevlieghere wrote: > I didn't look at the scripts in detail but I have a few general (high level) > comments: > > - I also feel this should go under `lldb/scripts`. > - Can we put the documentations as RST

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; kastiglione wrote: > Is this lambda missing an assignment to `er

[Lldb-commits] [lldb] 2501e91 - [lldb] Don't depend on psutil in TestCompletion.py

Author: Raphael Isemann Date: 2020-08-25T08:30:33+02:00 New Revision: 2501e911a5a174fc1a07a2a1ac687a2bf0f05ef3 URL: https://github.com/llvm/llvm-project/commit/2501e911a5a174fc1a07a2a1ac687a2bf0f05ef3 DIFF: https://github.com/llvm/llvm-project/commit/2501e911a5a174fc1a07a2a1ac687a2bf0f05ef3.dif