labath added inline comments.
================
Comment at: lldb/source/Symbol/Type.cpp:378
m_byte_size_has_value = true;
+ return m_byte_size;
}
----------------
shafik wrote:
> Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix
> shows this having this additional state we carry around is error prone.
IIRC, this was done this way to reduce sizeof(Type). Note that the external
interface is Optional<uint64_t> and the only place that knows (should know?)
about this encoding is this function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86436/new/
https://reviews.llvm.org/D86436
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
