[Lldb-commits] [PATCH] D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval)

jmorse added a comment. Thanks for the patch, comments inline. A couple of things in general: As mentioned on the mailing list thread, it bothers me a little that DbgVariableIntrinsic::getVariableLocation is going to try and return something that isn't a "Real" location. In fact, wouldn't the a

[Lldb-commits] [PATCH] D71452: [lldb][NFC] Remove 'from __future__ import print_function' from all tests that don't actually call 'print()'

teemperor added a comment. Herald added subscribers: wuzish, dexonsmith. I tested this on python2 (macOS) and python3 (Arch Linux) so this shouldn't break any test. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71452/new/ https://reviews.llvm.org/D71452 ___

[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A lot of our tests copied the setUp code from our TestSampleTest.py: def setUp(self): # Call super's setUp(). TestBase.setUp(self)

[Lldb-commits] [lldb] ec109fb - [lldb/cmake] Temporarily revive LLDB_DISABLE_CURSES

Author: Pavel Labath Date: 2019-12-13T10:23:35+01:00 New Revision: ec109fb7edc627d777ead14fd289ea2f2278a4ad URL: https://github.com/llvm/llvm-project/commit/ec109fb7edc627d777ead14fd289ea2f2278a4ad DIFF: https://github.com/llvm/llvm-project/commit/ec109fb7edc627d777ead14fd289ea2f2278a4ad.diff

[Lldb-commits] [PATCH] D71440: Extending step-over range past calls was causing deadlocks, fix that.

labath added a comment. This looks like a tricky bug. Thanks for tracking it down. I have two questions though: :D - could you use c++11 locking primitives in the test? pthreads do not work on windows - what exactly will be the effect of this? Will we start all threads immediately, or will we

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Symbol/ClangExternalASTSourceCommon.cpp:64 +ClangExternalASTSourceCommon::GetMetadata(const clang::Type *object) { + auto It = m_type_metadata.find(object); + if (It != m_type_m

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

labath added a comment. The test looks good. I think it should run fine on linux, and there's a decent chance it might work on windows too. It's fine to let check it in this way, and we can add some skips later if bots start complaining. As for the location, /maybe/ ExecControl would be a bette

[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, these are really annoying. Maybe it would be also good to add some language to TestSampleTest to say that you should only define this method if you actually want to do some work there..

[Lldb-commits] [lldb] 5ab9fa4 - [lldb][NFC] Make metadata tracking type safe

Author: Raphael Isemann Date: 2019-12-13T12:04:42+01:00 New Revision: 5ab9fa44cd60d5bca7b6d809a86bf10be416eb5d URL: https://github.com/llvm/llvm-project/commit/5ab9fa44cd60d5bca7b6d809a86bf10be416eb5d DIFF: https://github.com/llvm/llvm-project/commit/5ab9fa44cd60d5bca7b6d809a86bf10be416eb5d.dif

[Lldb-commits] [PATCH] D71409: [lldb][NFC] Make metadata tracking type safe

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ab9fa44cd60: [lldb][NFC] Make metadata tracking type safe (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71409/new/ https://reviews

[Lldb-commits] [lldb] 4286aca - [lldb][NFC] Add reminder to TestSampleTest that setUp should be deleted if it not needed.

Author: Raphael Isemann Date: 2019-12-13T12:10:05+01:00 New Revision: 4286aca5d5adb2fd07fb07d0dbbc94e2ff16270d URL: https://github.com/llvm/llvm-project/commit/4286aca5d5adb2fd07fb07d0dbbc94e2ff16270d DIFF: https://github.com/llvm/llvm-project/commit/4286aca5d5adb2fd07fb07d0dbbc94e2ff16270d.dif

[Lldb-commits] [lldb] 3ca771b - [lldb][NFC] Remove unused includes in Utility's source files

Author: Raphael Isemann Date: 2019-12-13T12:33:47+01:00 New Revision: 3ca771ba594fbd40da7ef842c04b5842e7b2a83c URL: https://github.com/llvm/llvm-project/commit/3ca771ba594fbd40da7ef842c04b5842e7b2a83c DIFF: https://github.com/llvm/llvm-project/commit/3ca771ba594fbd40da7ef842c04b5842e7b2a83c.dif

[Lldb-commits] [lldb] 9bace26 - [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

Author: Raphael Isemann Date: 2019-12-13T12:34:49+01:00 New Revision: 9bace26a690a778ec0f09a9aae9537dfbdb6f42f URL: https://github.com/llvm/llvm-project/commit/9bace26a690a778ec0f09a9aae9537dfbdb6f42f DIFF: https://github.com/llvm/llvm-project/commit/9bace26a690a778ec0f09a9aae9537dfbdb6f42f.dif

[Lldb-commits] [PATCH] D71454: [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bace26a690a: [lldb][NFC] Remove all `setUp` overrides that only call the parent… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7145

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. I am strongly opposed to ArchSpec owing an Architecture object. The latter is far more complicated -- it reads bytes from target memory and disassembles them -- whereas ArchSpec just returns a bunch of constants. If anything, it should be the other way around. That way t

[Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

mossberg marked an inline comment as done. mossberg added inline comments. Comment at: lldb/source/Target/ThreadPlanStepOut.cpp:136-137 + m_return_addr); + LLDB_LOGF(log, "ThreadPlanStepOut(%p): %s", static_cast(this), +m_cons

[Lldb-commits] [lldb] 3011d55 - [lldb/Host] Use cmakedefine01 for LLDB_ENABLE_POSIX

Author: Jonas Devlieghere Date: 2019-12-13T10:00:59-08:00 New Revision: 3011d55f725e280fe29a49bd70a2e0157587b17a URL: https://github.com/llvm/llvm-project/commit/3011d55f725e280fe29a49bd70a2e0157587b17a DIFF: https://github.com/llvm/llvm-project/commit/3011d55f725e280fe29a49bd70a2e0157587b17a.d

[Lldb-commits] [lldb] 1ef7c42 - [lldb/Test] C++ test should use CXXFLAGS_EXTRAS

Author: Jonas Devlieghere Date: 2019-12-13T10:00:59-08:00 New Revision: 1ef7c4269b453a98cada3ee3d29644e994fbc421 URL: https://github.com/llvm/llvm-project/commit/1ef7c4269b453a98cada3ee3d29644e994fbc421 DIFF: https://github.com/llvm/llvm-project/commit/1ef7c4269b453a98cada3ee3d29644e994fbc421.d

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added subscribers: abidh, mgorny. Herald added a project: LLDB. This matches the naming scheme used by LLVM and all the other optional dependencies in LLDB. Repository: rLLDB LLDB https://reviews.llvm

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

mib added a comment. @davide I ran the Swift test suite both with and without my patch and got the same results :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https://reviews.llvm.org/D71311

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https://reviews.llvm.org/D71311 __

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() I know that the same thing is done above but… what's the point of setting it to `ON` again? Repository: rLLDB LLDB CHANG

[Lldb-commits] [lldb] 2c91d5b - LanguageRuntime: Simplify NSException::GetSummary() output

Author: Med Ismail Bennani Date: 2019-12-13T12:33:31-08:00 New Revision: 2c91d5ba83156900944c82bb8feb1e340adb8ae4 URL: https://github.com/llvm/llvm-project/commit/2c91d5ba83156900944c82bb8feb1e340adb8ae4 DIFF: https://github.com/llvm/llvm-project/commit/2c91d5ba83156900944c82bb8feb1e340adb8ae4.

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

This revision was automatically updated to reflect the committed changes. Closed by commit rG2c91d5ba8315: LanguageRuntime: Simplify NSException::GetSummary() output (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71311/new/ https:/

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() mgorny wrote: > I know that the same thing is done above but… what's the

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

johannes updated this revision to Diff 233856. johannes edited the summary of this revision. johannes added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71487/new/ https://reviews.llvm.org/D71487 Files: lldb/source/Expression/IR

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

johannes created this revision. johannes added reviewers: spyffe, clayborg, jasonmolenda. Herald added a subscriber: aprantl. Herald added a project: LLDB. johannes updated this revision to Diff 233856. johannes edited the summary of this revision. johannes added a comment. typo Fixes PR41237 -

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() JDevlieghere wrote: > mgorny wrote: > > I know that the same thing is done above but… what's the point of setting > > it to `

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() mgorny wrote: > JDevlieghere wrote: > > mgorny wrote: > > > I know that t

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. That seems like a simple mechanical change and the move from DISABLE to ENABLE was IIRC already consensus, so LGTM. Comment at: lldb/source/Commands/CommandObjectType.

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() JDevlieghere wrote: > mgorny wrote: > > JDevlieghere wrote: > > > mgorny wrote: > > > > I know that the same thing is done abo

[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, krytarowski. Herald added a project: LLDB. teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/CommandCompl

[Lldb-commits] [PATCH] D71489: [lldb][NFC] Remove unnecessary includes in source/Commands

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: lldb/source/Commands/CommandCompletions.cpp:12 -#include -#endif - I did this change by hand as both includes are not used at all and the #if can then also go. Repository

[Lldb-commits] [lldb] 4e26cf2 - [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

Author: Jonas Devlieghere Date: 2019-12-13T13:41:11-08:00 New Revision: 4e26cf2cfb2b140a33ec236153cb2f23b5c44127 URL: https://github.com/llvm/llvm-project/commit/4e26cf2cfb2b140a33ec236153cb2f23b5c44127 DIFF: https://github.com/llvm/llvm-project/commit/4e26cf2cfb2b140a33ec236153cb2f23b5c44127.d

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG4e26cf2cfb2b: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] e8af4fd - [lldb/CMake] Initialize LLDB_ENABLE_POSIX based on the UNIX variable.

Author: Jonas Devlieghere Date: 2019-12-13T13:46:43-08:00 New Revision: e8af4fd42da3580f9bda5202f381bf92d07f4b9c URL: https://github.com/llvm/llvm-project/commit/e8af4fd42da3580f9bda5202f381bf92d07f4b9c DIFF: https://github.com/llvm/llvm-project/commit/e8af4fd42da3580f9bda5202f381bf92d07f4b9c.d

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere updated this revision to Diff 233876. JDevlieghere added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake lldb/include/lldb/lldb

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

JDevlieghere updated this revision to Diff 233877. JDevlieghere added a comment. - Rebase - Hide C calls behind C++ abstraction - Improve error handling - Add unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71234/new/ https://reviews.llvm.org/D71234 Files: lldb/include/lldb/C

[Lldb-commits] [PATCH] D71482: [lldb/CMake] Rename LLDB_DISABLE_PYTHON to LLDB_ENABLE_PYTHON

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() +set(default_enable_python ON) + endif() mgorny wrote: > JDevlieghere wrote: > > mgorny wrote: > > > JDevlieghere

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

aprantl added a comment. Whoops. Thanks for fixing it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71310/new/ https://reviews.llvm.org/D71310 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 3a6da11 - [lldb/SWIG] Modulerize lldb.swig so parts of it can be reused.

Author: Jonas Devlieghere Date: 2019-12-13T14:49:44-08:00 New Revision: 3a6da1122b990386edeba0987d0d1fdc9c8dc53d URL: https://github.com/llvm/llvm-project/commit/3a6da1122b990386edeba0987d0d1fdc9c8dc53d DIFF: https://github.com/llvm/llvm-project/commit/3a6da1122b990386edeba0987d0d1fdc9c8dc53d.d

[Lldb-commits] [PATCH] D71405: [lldb] Centralize desugaring of decltype-like types in ClangASTContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. The change LGTM but the test could just be a unit test instead of doing the whole compile->start->attach->expr command cycle. You can just add this to the `TestClangASTContext.cpp` to te

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

aprantl added inline comments. Comment at: lldb/test/Shell/Expr/TestFunctionAddress.lldb:6 +next +expr argv.four() +# CHECK: expr argv.four() This would be better suited for a python test. (You can copy the example test as a starting point). Repository: rG L

[Lldb-commits] [PATCH] D71487: [LLDB] Fix address computation for member function linked with lld

aprantl added inline comments. Comment at: lldb/test/Shell/Expr/TestFunctionAddress.lldb:6 +next +expr argv.four() +# CHECK: expr argv.four() aprantl wrote: > This would be better suited for a python test. (You can copy the example test > as a starting point). T

[Lldb-commits] [PATCH] D71498: Fix ARM32 inferior calls

jankratochvil created this revision. jankratochvil added reviewers: omjavaid, labath. jankratochvil added a project: LLDB. Herald added subscribers: kristof.beyls, aprantl. jankratochvil added a reviewer: jasonmolenda. echo -e '#include \nint main(void){\nsync();return 0;}'|./bin/clang -g -x c

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid Do you still see any regression of this patch after D71498 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540