JDevlieghere marked an inline comment as done. JDevlieghere added inline comments.
================ Comment at: lldb/cmake/modules/LLDBConfig.cmake:43 + else() + set(default_enable_python ON) + endif() ---------------- mgorny wrote: > JDevlieghere wrote: > > mgorny wrote: > > > I know that the same thing is done above but… what's the point of setting > > > it to `ON` again? > > It's just setting the default to the old value. If the value was set, we > > should honor it, both if it was `OFF` or `ON`. > But it's already set to `ON` a few lines above. Do you mean the `DEFINED`? That just checks if the variable exists, not its value. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71482/new/ https://reviews.llvm.org/D71482 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
