teemperor created this revision. teemperor added reviewers: labath, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits.
A lot of our tests copied the setUp code from our TestSampleTest.py: def setUp(self): # Call super's setUp(). TestBase.setUp(self) This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions. Repository: rLLDB LLDB https://reviews.llvm.org/D71454 Files: lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py
Index: lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py =================================================================== --- lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py +++ lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py @@ -13,10 +13,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - @add_test_categories(['pyapi']) def test_with_process_launch_api(self): """Test SBValue::GetValueDidChange""" Index: lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py =================================================================== --- lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py +++ lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py @@ -19,9 +19,6 @@ def test(self): self.structured_data_api_test() - def setUp(self): - TestBase.setUp(self) - @add_test_categories(['pyapi']) def structured_data_api_test(self): error = lldb.SBError() Index: lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py =================================================================== --- lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py +++ lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py @@ -14,10 +14,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def setup_test(self): # Get the full path to our executable to be debugged. self.exe = self.getBuildArtifact("process_io") Index: lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py =================================================================== --- lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py +++ lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py @@ -25,10 +25,6 @@ self.yaml2obj("libDylib.dylib.yaml", self.getBuildArtifact("libDylib.dylib")) self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def do_test(self): lib_name = "libDylib.dylib" target = lldbutil.run_to_breakpoint_make_target(self, exe_name=lib_name) Index: lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py =================================================================== --- lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py +++ lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py @@ -13,10 +13,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - @skipUnlessDarwin @add_test_categories(['pyapi']) def test_with_python_api(self): Index: lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py =================================================================== --- lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py +++ lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py @@ -24,10 +24,6 @@ self.main_source_file = lldb.SBFileSpec("main.c") self.find_app_in_bundle_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def find_app_in_bundle_test(self): """This reads in the .app, makes sure we get the right binary and can run it.""" Index: lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py =================================================================== --- lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py +++ lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py @@ -8,9 +8,6 @@ class TestMixedDwarfBinary(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @no_debug_info_test # Prevent the genaration of the dwarf version of this test @add_test_categories(["dwo"]) @skipUnlessPlatform(["linux"]) Index: lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py +++ lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py @@ -9,9 +9,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipIfFreeBSD @skipIfLinux @skipIfWindows Index: lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py +++ lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py @@ -7,9 +7,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin def test_bridged_type_po(self): self.build() Index: lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py +++ lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py @@ -13,9 +13,6 @@ class TestClangModuleUpdate(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin @skipIf(debug_info=no_match(["gmodules"])) def test_expr(self): Index: lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py +++ lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py @@ -16,10 +16,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - @skipUnlessDarwin @skipIf(macos_version=["<", "10.12"], debug_info=no_match(["gmodules"])) def test_expr(self): Index: lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py +++ lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py @@ -13,9 +13,6 @@ class TestClangModuleHashMismatch(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin @skipIf(debug_info=no_match(["gmodules"])) def test_expr(self): Index: lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py +++ lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py @@ -17,9 +17,6 @@ NO_DEBUG_INFO_TESTCASE = True mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin def test_expr(self): self.build() Index: lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py +++ lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py @@ -13,9 +13,6 @@ class TestClangModuleAppUpdate(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin @skipIf(debug_info=no_match(["gmodules"])) def test_rebuild_app_modules_untouched(self): Index: lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py +++ lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py @@ -38,10 +38,6 @@ self.main_source_file = lldb.SBFileSpec("main.cpp") self.expr_test(False) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def check_value(self, test_var, ivar_value): self.assertTrue(test_var.GetError().Success(), "Invalid valobj: %s"%(test_var.GetError().GetCString())) ivar = test_var.GetChildMemberWithName("ivar") Index: lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py +++ lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py @@ -26,10 +26,6 @@ self.main_source_file = lldb.SBFileSpec("main.cpp") self.sample_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def sample_test(self): (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self, "Break here to get started", self.main_source_file) Index: lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py +++ lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py @@ -27,10 +27,6 @@ self.main_source_file = lldb.SBFileSpec("main.c") self.expr_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def run_and_check_expr(self, num_children, child_type): frame = self.thread.GetFrameAtIndex(0) result = frame.EvaluateExpression("struct Foo *$mine = (struct Foo *) malloc(sizeof(struct Foo)); $mine") Index: lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py +++ lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py @@ -24,10 +24,6 @@ self.build() self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def do_test(self): """Make sure FindTypes actually finds 'struct typename' not just 'typename'.""" exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py +++ lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py @@ -23,10 +23,6 @@ self.build() self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def verify_point(self, frame, var_name, var_typename, x_value, y_value): v = frame.GetValueForVariablePath(var_name) self.assertTrue(v.GetError().Success(), "Make sure we find '%s'" % (var_name)) Index: lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py @@ -24,10 +24,6 @@ self.build() self.tsan_tests() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def tsan_tests(self): exe = self.getBuildArtifact("a.out") self.expect( Index: lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py @@ -24,10 +24,6 @@ self.build() self.tsan_tests() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def tsan_tests(self): exe = self.getBuildArtifact("a.out") self.expect( Index: lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py @@ -24,10 +24,6 @@ self.build() self.tsan_tests() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def tsan_tests(self): exe = self.getBuildArtifact("a.out") self.expect( Index: lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py @@ -24,10 +24,6 @@ self.build() self.tsan_tests() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def tsan_tests(self): exe = self.getBuildArtifact("a.out") self.expect( Index: lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py +++ lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py @@ -14,10 +14,6 @@ mydir = TestBase.compute_mydir(__file__) NO_DEBUG_INFO_TESTCASE = True - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test_backtrace_depth(self): """Test that the max-backtrace-depth setting limits backtraces.""" self.build() Index: lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py @@ -90,6 +90,3 @@ self.assertEqual(frame4.GetDisplayFunctionName(), "main") self.assertFalse(frame2.IsArtificial()) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) Index: lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py +++ lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py @@ -17,10 +17,6 @@ self.build() self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def do_test(self): exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py +++ lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py @@ -10,9 +10,6 @@ class TestStatsAPI(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - def test_stats_api(self): self.build() exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py +++ lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py @@ -11,10 +11,6 @@ mydir = TestBase.compute_mydir(__file__) NO_DEBUG_INFO_TESTCASE = True - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - @skipIf(oslist=no_match(['darwin','macos'])) def test(self): """Test that we find directly linked dylib pre-run.""" Index: lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py +++ lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py @@ -15,9 +15,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipIfDarwin # llvm.org/pr16769: LLDB on Mac OS X dies in function ReadRegisterBytes in GDBRemoteRegisterContext.cpp @skipIfFreeBSD # llvm.org/pr17214 @expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr20231") Index: lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py +++ lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py @@ -23,10 +23,6 @@ """Test the !N and !-N functionality of the command interpreter.""" self.sample_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def sample_test(self): interp = self.dbg.GetCommandInterpreter() result = lldb.SBCommandReturnObject() Index: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py +++ lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py @@ -15,10 +15,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - @no_debug_info_test def test_type_summary_list_with_arg(self): """Test that the 'type summary list' command handles command line arguments properly""" Index: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py +++ lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py @@ -8,9 +8,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - def test_with_run_command(self): """ Test that hardcoded summary formatter matches aren't improperly cached. Index: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py +++ lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py @@ -43,10 +43,6 @@ self.build() self.do_test_bad_options() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def make_target_and_import(self): target = lldbutil.run_to_breakpoint_make_target(self) interp = self.dbg.GetCommandInterpreter() Index: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py +++ lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py @@ -15,11 +15,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - # Find the line number to break inside main(). - def check_location_file(self, bp, loc, test_name): bp_loc = bp.GetLocationAtIndex(loc) addr = bp_loc.GetAddress() Index: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py +++ lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py @@ -58,10 +58,6 @@ return process - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def simple_auto_continue(self): bpno = self.make_target_and_bkpt() process = self.launch_it(lldb.eStateExited) Index: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py +++ lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py @@ -21,10 +21,6 @@ self.build() self.address_breakpoints() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def address_breakpoints(self): """Test that breakpoints set on a bad address say they are bad.""" target, process, thread, bkpt = \ Index: lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py =================================================================== --- lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py +++ lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py @@ -21,10 +21,6 @@ self.build() self.address_breakpoints() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def address_breakpoints(self): """Test address breakpoints set with shared library of SBAddress work correctly.""" exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py +++ lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py @@ -11,10 +11,6 @@ class TestWatchpointSetEnable(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test_disable_works (self): """Set a watchpoint, disable it, and make sure it doesn't get hit.""" self.build() Index: lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py +++ lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py @@ -6,9 +6,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @no_debug_info_test def test_version(self): # Should work even when people patch the output, Index: lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py +++ lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py @@ -25,10 +25,6 @@ self.main_source_file = lldb.SBFileSpec("main.c") self.step_out_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def step_out_test(self): (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self, "Set a breakpoint here", self.main_source_file) Index: lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py +++ lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py @@ -22,9 +22,6 @@ MPX_CONFIG_REGS = ('bndcfgu', 'bndstatus') BND_VALUE = '{' + ' '.join(('0xff' for _ in range(16))) + '}' - def setUp(self): - TestBase.setUp(self) - @skipIf(oslist=no_match(['linux'])) @skipIf(archs=no_match(['x86_64'])) def test_mpx_registers_offset_intersection(self): Index: lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py +++ lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py @@ -15,9 +15,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipIf(compiler="clang") @skipIf(oslist=no_match(['linux'])) @skipIf(archs=no_match(['i386', 'x86_64'])) Index: lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py +++ lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py @@ -23,10 +23,6 @@ self.build() self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def do_test(self): exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py +++ lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py @@ -27,10 +27,6 @@ self.build() self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def check_language(self, thread, frame_no, test_lang): frame = thread.frames[frame_no] self.assertTrue(frame.IsValid(), "Frame %d was not valid."%(frame_no)) Index: lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py +++ lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py @@ -13,9 +13,6 @@ class TestArray(TestBase): mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @skipUnlessDarwin @skipIfDarwinEmbedded # <rdar://problem/33842388> frame diagnose doesn't work for armv7 or arm64 def test_array(self): Index: lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py +++ lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py @@ -26,10 +26,6 @@ self.main_source_file = lldb.SBFileSpec("main.c") self.do_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def run_weak_var_check (self, weak_varname, present): # The expression will modify present_weak_int to signify which branch # was taken. Set it to so we don't get confused by a previous run. Index: lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py +++ lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py @@ -14,10 +14,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test(self): """Test that we can have persistent pointer variables""" self.build() Index: lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py +++ lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py @@ -30,5 +30,3 @@ self.assertTrue(result.IsValid(), "Can't evaluate expression") self.assertEqual(8, result.GetValueAsSigned()) - def setUp(self): - TestBase.setUp(self) Index: lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py +++ lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py @@ -31,10 +31,6 @@ self.main_source_file = lldb.SBFileSpec("main.c") self.expr_options_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def expr_cmd_test(self): (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(self, "Set a breakpoint here", self.main_source_file) Index: lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py +++ lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py @@ -15,10 +15,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test__calculator_mode(self): """Test calling expressions in the dummy target.""" self.expect("expression 11 + 22", "11 + 22 didn't get the expected result", substrs=["33"]) Index: lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py +++ lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py @@ -21,10 +21,6 @@ self.build() self.frame_disassemble_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def frame_disassemble_test(self): """Sample test to ensure SBFrame::Disassemble produces SOME output""" exe = self.getBuildArtifact("a.out") Index: lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py +++ lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py @@ -19,10 +19,6 @@ """Check that we handle an ImportError in a special way when command script importing files.""" self.run_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def run_test(self): """Check that we handle an ImportError in a special way when command script importing files.""" Index: lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py +++ lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py @@ -19,10 +19,6 @@ """Import some Python scripts by path and test them""" self.run_test() - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def run_test(self): """Import some Python scripts by path and test them.""" Index: lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py =================================================================== --- lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py +++ lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py @@ -6,9 +6,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - TestBase.setUp(self) - @no_debug_info_test def test_apropos(self): self.expect("apropos", error=True, Index: lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py =================================================================== --- lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py +++ lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py @@ -17,10 +17,6 @@ mydir = TestBase.compute_mydir(__file__) - def setUp(self): - # Call super's setUp(). - TestBase.setUp(self) - def test_receiving_breakpoint_added(self): """Test that we get breakpoint added events, waiting on event classes on the debugger""" self.build()
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits