teemperor marked an inline comment as done.
teemperor added inline comments.


================
Comment at: lldb/source/Symbol/ClangExternalASTSourceCommon.cpp:64
+ClangExternalASTSourceCommon::GetMetadata(const clang::Type *object) {
+  auto It = m_type_metadata.find(object);
+  if (It != m_type_metadata.end())
----------------
aprantl wrote:
> .lookup(), assuming this is a DenseMap?
We can't use it here as we return a pointer to the internally stored value in 
the map and not a value :(


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71409/new/

https://reviews.llvm.org/D71409



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to