[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

labath added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:28 set(default_disable_python OFF) +set(default_disable_lua OFF) set(default_disable_curses OFF) I think this will tick off some bots (and people) because it means that the default c

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

mstorsjo added a comment. @labath does this one seem sensible and like what you suggested in D70848 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71108/new/ https://reviews.llvm.org/D71108

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

labath added a comment. It looks like this patch already includes some non-trivial functionality, so I think this is a good time to start figuring out how to test this. Another thing, which may not be needed straight away, but which I think we should consider pretty early is creating some sort

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry, I missed this one. Yes, I think this is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71108/new/ https://reviews.llvm.org/D71108

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

labath added a comment. No opinion on the code, but I think the test needs to be cleaned up _a lot_. Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:1 +//===-- main.cpp *- C++ -*-===// +// This file is about

[Lldb-commits] [PATCH] D71235: [lldb/Lua] Generate Lua Bindings and Make Them Available to the Script Interpreter

labath added inline comments. Comment at: lldb/scripts/CMakeLists.txt:61-83 + add_custom_command( +OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapLua.cpp +DEPENDS ${SWIG_SOURCES} +DEPENDS ${SWIG_INTERFACES} +DEPENDS ${SWIG_HEADERS} +COMMAND ${SWIG_EXECUTABLE} +

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

mgorny added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:28 set(default_disable_python OFF) +set(default_disable_lua OFF) set(default_disable_curses OFF) labath wrote: > I think this will tick off some bots (and people) because it means tha

[Lldb-commits] [PATCH] D71251: [lldb] Actually enabled wchar support in Editline when it is defined in the host config

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. teemperor added a comment. If anyone wants to test this pre-commit, that would be appreciated as I fear we'll find some Editline implementations

[Lldb-commits] [PATCH] D71251: [lldb] Actually enabled wchar support in Editline when it is defined in the host config

teemperor added a comment. If anyone wants to test this pre-commit, that would be appreciated as I fear we'll find some Editline implementations that will freak out over this patch. I tested this on Arch Linux and macOS. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D71108: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0f72441c898: [LLDB] [PECOFF] Make sure to set the address byte size in m_data after parsing… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] e9895c6 - [lldb][NFC] Make g_TotalSizeOfMetadata in ClangExternalASTSourceCommon.cpp static

Author: Raphael Isemann Date: 2019-12-10T13:46:12+01:00 New Revision: e9895c612a5a331660020172affa927664e138ad URL: https://github.com/llvm/llvm-project/commit/e9895c612a5a331660020172affa927664e138ad DIFF: https://github.com/llvm/llvm-project/commit/e9895c612a5a331660020172affa927664e138ad.dif

[Lldb-commits] [PATCH] D71251: [lldb] Actually enable wchar support in Editline when it is defined in the host config

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks like there are still some issues with echoing unicode characters on linux, but this is still an improvement over status quo everywhere, so I see no reason to hold it up over that. ===

[Lldb-commits] [PATCH] D71212: [lldb] Centralize type "desugaring" logic in ClangASTContext

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Symbol/ClangASTContext.cpp:2489 +case clang::Type::Typedef: + type = cast(type)->getDecl()->getUnderlyingType(); + break; teemperor wrote: > QualType alre

[Lldb-commits] [lldb] f482708 - [lldb] Centralize type "desugaring" logic in ClangASTContext

Author: Pavel Labath Date: 2019-12-10T14:05:10+01:00 New Revision: f482708149138088f74f6b01668208a8c037563c URL: https://github.com/llvm/llvm-project/commit/f482708149138088f74f6b01668208a8c037563c DIFF: https://github.com/llvm/llvm-project/commit/f482708149138088f74f6b01668208a8c037563c.diff

[Lldb-commits] [PATCH] D71212: [lldb] Centralize type "desugaring" logic in ClangASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGf48270814913: [lldb] Centralize type "desugaring" logic in ClangASTContext (authored by labath). Changed prior to commit: https://reviews.llvm.org/D71212?vs=232868&id=233062#toc Repository: rG LLVM G

[Lldb-commits] [PATCH] D71262: [lldb] "See through" atomic types in ClangASTContext

labath created this revision. labath added reviewers: teemperor, shafik. Herald added a subscriber: jfb. Herald added a project: LLDB. This enables us to display the contents of atomic structs. Calling the removal of _Atomic "desugaring" is not fully correct as it does more than remove sugar, but

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid FYI the JIT error happens for me on `2019-09-26-raspbian-buster` even without this my patch. I will try to debug that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D6354

[Lldb-commits] [lldb] 14f3d13 - [lldb] Actually enable wchar support in Editline when it is defined in the host config

Author: Raphael Isemann Date: 2019-12-10T14:30:41+01:00 New Revision: 14f3d13412cb2eac87f1c0ae74ed2af7ace1580f URL: https://github.com/llvm/llvm-project/commit/14f3d13412cb2eac87f1c0ae74ed2af7ace1580f DIFF: https://github.com/llvm/llvm-project/commit/14f3d13412cb2eac87f1c0ae74ed2af7ace1580f.dif

[Lldb-commits] [PATCH] D71251: [lldb] Actually enable wchar support in Editline when it is defined in the host config

This revision was automatically updated to reflect the committed changes. Closed by commit rG14f3d13412cb: [lldb] Actually enable wchar support in Editline when it is defined in the host… (authored by teemperor). Changed prior to commit: https://reviews.llvm.org/D71251?vs=233042&id=233067#toc

[Lldb-commits] [PATCH] D71262: [lldb] "See through" atomic types in ClangASTContext

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM beside my inline comment about the function name. Comment at: lldb/source/Symbol/ClangASTContext.cpp:2483 + type = cast(type)->getValueType(); + break;

[Lldb-commits] [PATCH] D71262: [lldb] "See through" atomic types in ClangASTContext

labath updated this revision to Diff 233080. labath added a comment. rename to RemoveWrappingTypes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71262/new/ https://reviews.llvm.org/D71262 Files: lldb/source/Symbol/ClangASTContext.cpp lldb/test

lldb-commits@lists.llvm.org

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. This adds support for DWARF5 location lists which are specified indirectly, via an index into the debug_loclists offset table. This includes parsing the DW_AT_loclists_base attribut

[Lldb-commits] [PATCH] D71280: [lldb/Host] Use Host/Config.h entries instead of a global define.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: mgorny. Herald added a project: LLDB. As suggested by Pavel in D71232 > Can we replace this (and maybe python too, while at it) with a Host/Config.h > entry? A

lldb-commits@lists.llvm.org

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:462 + uint64_t header_size = llvm::DWARFListTableHeader::getHeaderSize(DWARF32); + if (loclists_base >=

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

JDevlieghere updated this revision to Diff 233131. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/ https://reviews.llvm.org/D71105 Files: lldb/include/lldb/Utility/GDBRemote.h lldb/include/lldb/Utility/Reproducer.h lldb/source/API/S

[Lldb-commits] [PATCH] D71280: [lldb/Host] Use Host/Config.h entries instead of a global define.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks, this should have been done a long time ago... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71280/new/ https://reviews.llvm.org/D71280 ___

[Lldb-commits] [PATCH] D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC)

aprantl updated this revision to Diff 233134. aprantl added a comment. Make (most) of the Get methods return return values, as Pavel suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71231/new/ https://reviews.llvm.org/D71231 Files: lldb/include/lldb/DataFormatters/FormatCache

[Lldb-commits] [lldb] 7034794 - Replace redundant code in FormatManager and FormatCache with templates (NFC)

Author: Adrian Prantl Date: 2019-12-10T10:27:16-08:00 New Revision: 7034794b314d9de808de004d22b47f18d134757d URL: https://github.com/llvm/llvm-project/commit/7034794b314d9de808de004d22b47f18d134757d DIFF: https://github.com/llvm/llvm-project/commit/7034794b314d9de808de004d22b47f18d134757d.diff

[Lldb-commits] [PATCH] D71231: Replace redundant code in FormatManager and FormatCache with templates (NFC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7034794b314d: Replace redundant code in FormatManager and FormatCache with templates (NFC) (authored by aprantl). Herald a

[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager

aprantl updated this revision to Diff 233145. aprantl added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71233/new/ https://reviews.llvm.org/D71233 Files: lldb/include/lldb/DataFormatters/FormatManager.h lldb/packages/Python/lldbsuite/test/functionalities/data-

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

aprantl created this revision. aprantl added reviewers: jingham, davide. aprantl added a parent revision: D71233: Do not cache hardcoded formats in FormatManager. This refactoring makes the lookup caching easier to reason about. This has no observable effect although it does slightly change what

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

aprantl added a comment. Actually, it's worse, LanguageCategory::Get does its own caching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71289/new/ https://reviews.llvm.org/D71289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

Author: Jonas Devlieghere Date: 2019-12-10T11:16:52-08:00 New Revision: e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf URL: https://github.com/llvm/llvm-project/commit/e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf DIFF: https://github.com/llvm/llvm-project/commit/e81268d03e73aef4f9c7bd8ece8ad02f5b017dcf.d

[Lldb-commits] [lldb] 53acf06 - Fix a -Wsign-compare error around wchar_t vs unsigned int.

Author: Eric Christopher Date: 2019-12-10T11:18:57-08:00 New Revision: 53acf0663f80e1be99bae28769c6b658fff0e097 URL: https://github.com/llvm/llvm-project/commit/53acf0663f80e1be99bae28769c6b658fff0e097 DIFF: https://github.com/llvm/llvm-project/commit/53acf0663f80e1be99bae28769c6b658fff0e097.di

[Lldb-commits] [lldb] d0789e6 - Assert launch success in run_to_breakpoint_do_run

Author: Vedant Kumar Date: 2019-12-10T11:19:17-08:00 New Revision: d0789e6346e489cd84b37ec58964feb0db015de7 URL: https://github.com/llvm/llvm-project/commit/d0789e6346e489cd84b37ec58964feb0db015de7 DIFF: https://github.com/llvm/llvm-project/commit/d0789e6346e489cd84b37ec58964feb0db015de7.diff

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

aprantl added a comment. and again.. it passes in a ValueObject, so it shouldn't be caching. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71289/new/ https://reviews.llvm.org/D71289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D71105: [lldb/Reproducers] Support multiple GDB remotes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe81268d03e73: [lldb/Reproducers] Support multiple GDB remotes (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71105/new/ https://r

[Lldb-commits] [PATCH] D71280: [lldb/Host] Use Host/Config.h entries instead of a global define.

This revision was automatically updated to reflect the committed changes. Closed by commit rG59998b7b7f12: [lldb/Host] Use Host/Config.h entries instead of a global define. (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D71280?vs=233122&id=233159#toc Repository:

lldb-commits@lists.llvm.org

clayborg accepted this revision. clayborg added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71268/new/ https://reviews.llvm.org/D71268 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai updated this revision to Diff 233163. xiaobai added a comment. Add fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69820/new/ https://reviews.llvm.org/D69820 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/include/lldb/Symbo

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This seems reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71289/new/ https://reviews.llvm.org/D71289 ___ lldb-commits maili

Re: [Lldb-commits] [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

Hi Jonas, This appears to be causing crashes in a release asserts build: #3 0x7efe57b613a0 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x123a0) #4 0x7efe54178d00 llvm::raw_ostream::operator<<(llvm::StringRef) sources/llvm-project/llvm/include/llvm/Support/raw_ostream.h:190:7 #5

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

aprantl added a comment. @davide said he's working on a patch that turns the ValueObject parameter into a Language. With that in place the caching it does is sound again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71289/new/ https://reviews.llvm.org/D71289 ___

[Lldb-commits] [lldb] c9e0b35 - Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

Author: Eric Christopher Date: 2019-12-10T12:29:46-08:00 New Revision: c9e0b354e2749ce7ab553974692cb35c8651a869 URL: https://github.com/llvm/llvm-project/commit/c9e0b354e2749ce7ab553974692cb35c8651a869 DIFF: https://github.com/llvm/llvm-project/commit/c9e0b354e2749ce7ab553974692cb35c8651a869.di

Re: [Lldb-commits] [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes

For now I've gone ahead and reverted thusly: echristo@athyra ~/r/llvm-project> git push To github.com:llvm/llvm-project.git a2602bdd731..c9e0b354e27 master -> master Sorry for the very quick turnaround. -eric On Tue, Dec 10, 2019 at 12:21 PM Eric Christopher wrote: > Hi Jonas, > > This ap

[Lldb-commits] [lldb] 7ec933e - [lldb] Add #include to appease the modules build

Author: Vedant Kumar Date: 2019-12-10T12:37:26-08:00 New Revision: 7ec933e50162e2ddc6204f0f1708b75309a9555a URL: https://github.com/llvm/llvm-project/commit/7ec933e50162e2ddc6204f0f1708b75309a9555a DIFF: https://github.com/llvm/llvm-project/commit/7ec933e50162e2ddc6204f0f1708b75309a9555a.diff

[Lldb-commits] [PATCH] D71296: Replace redundant code in LanguageCategory with templates (NFC)

aprantl created this revision. aprantl added reviewers: jingham, davide. This is a cleanup similar to https://reviews.llvm.org/D71231. https://reviews.llvm.org/D71296 Files: lldb/include/lldb/DataFormatters/LanguageCategory.h lldb/source/DataFormatters/LanguageCategory.cpp Index: lldb/sour

[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

aprantl created this revision. aprantl added reviewers: jingham, davide. aprantl added a parent revision: D71296: Replace redundant code in LanguageCategory with templates (NFC). Analogous to https://reviews.llvm.org/D71233 it is not safe to cache something that depends on the actual ValueObject

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

davide created this revision. davide added reviewers: teemperor, JDevlieghere, aprantl, jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. JDevlieghere accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo https://rev

[Lldb-commits] [lldb] e8d955f - [FormatManager] Add a unittest for GetCandidateLanguages()

Author: Davide Italiano Date: 2019-12-10T13:42:59-08:00 New Revision: e8d955f29de7ee4b50d889c418b4efb18add0653 URL: https://github.com/llvm/llvm-project/commit/e8d955f29de7ee4b50d889c418b4efb18add0653 DIFF: https://github.com/llvm/llvm-project/commit/e8d955f29de7ee4b50d889c418b4efb18add0653.dif

[Lldb-commits] [PATCH] D71299: [FormatManager] Add a unittest for GetCandidateLanguages()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d955f29de7: [FormatManager] Add a unittest for GetCandidateLanguages() (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71299/new/ http

[Lldb-commits] [PATCH] D71237: [FormatEntity] Add mangled function name support

mib updated this revision to Diff 233189. mib marked 4 inline comments as done. mib added a comment. Remove unnecessary Language FunctionNameRepresention changes. Rewrote test file. Refactored frame-format FormatEntity. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D71150: [lldb][test] Create a separate LLDB_TEST_SRC var to allow moving tests.

rupprecht added a comment. In D71150#1774575 , @labath wrote: > Hmm... given the lua thread on lldb-dev, maybe we should slow down here, and > consider the potential relationship of these tests and the hypothetical lua > tests that come to be. One of the

[Lldb-commits] [PATCH] D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

davide created this revision. davide added reviewers: aprantl, teemperor. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71305 Files: lldb/include/lldb/DataFormatters/TypeCategory.h lldb/source/DataFormatters/TypeCategory.cpp Index: lldb/sourc

[Lldb-commits] [PATCH] D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This lgtm, but we could go even further and remove VlaueObject from Get() as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71305/new/ h

[Lldb-commits] [PATCH] D71151: [lldb][test] Remove symlink for API tests.

rupprecht added a comment. In D71151#1774586 , @labath wrote: > While I'm not opposed to moving "lldbsuite" to some place closer to the > tests, one thing I'd like to get out of this is to have the actual tests > stand out more prominently. Ditto; my d

[Lldb-commits] [lldb] 90f4355 - Skip TestMultilineCompletion.py on ios testsuite runs.

Author: Jason Molenda Date: 2019-12-10T14:55:04-08:00 New Revision: 90f4355b43eaf9eefa02226b98d8cb43f44ca879 URL: https://github.com/llvm/llvm-project/commit/90f4355b43eaf9eefa02226b98d8cb43f44ca879 DIFF: https://github.com/llvm/llvm-project/commit/90f4355b43eaf9eefa02226b98d8cb43f44ca879.diff

[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager

jingham added a comment. This looks fine to me. So long as there wasn't much strict type-based matching done in the Hardcoded Summary providers, then this shouldn't cause the format matching to get slower. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71233/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine, sorry for leaving it too long in the In tray... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64844/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. And check the Accept checkbox... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71233/new/ https://reviews.llvm.org/D71233 ___ lldb-com

[Lldb-commits] [lldb] bbcdcea - [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

Author: Davide Italiano Date: 2019-12-10T14:59:34-08:00 New Revision: bbcdcea4bf8423041108e22dc619f7d5fdae9870 URL: https://github.com/llvm/llvm-project/commit/bbcdcea4bf8423041108e22dc619f7d5fdae9870 DIFF: https://github.com/llvm/llvm-project/commit/bbcdcea4bf8423041108e22dc619f7d5fdae9870.dif

[Lldb-commits] [PATCH] D71305: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcdcea4bf84: [TypeCategory] IsApplicable gets a LanguageType, not a ValueObject. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71305/n

[Lldb-commits] [lldb] 1d41d1b - Revert "Temporarily revert [lldb] e81268d - [lldb/Reproducers] Support multiple GDB remotes"

Author: Eric Christopher Date: 2019-12-10T15:04:45-08:00 New Revision: 1d41d1bcdfd70cf8f77bb32e2617392395c299a4 URL: https://github.com/llvm/llvm-project/commit/1d41d1bcdfd70cf8f77bb32e2617392395c299a4 DIFF: https://github.com/llvm/llvm-project/commit/1d41d1bcdfd70cf8f77bb32e2617392395c299a4.di

Re: [Lldb-commits] [lldb] 90f4355 - Skip TestMultilineCompletion.py on ios testsuite runs.

I don't think that it's terribly valuable testing autocompletion on device, but we should try to avoid calling `run` directly to avoid these sort of issues. On Tue, Dec 10, 2019 at 2:55 PM Jason Molenda via lldb-commits wrote: > > > Author: Jason Molenda > Date: 2019-12-10T14:55:04-08:00 > New Re

[Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

Author: Jason Molenda Date: 2019-12-10T15:15:25-08:00 New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154 URL: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154 DIFF: https://github.com/llvm/llvm-project/commit/b0937be06e44c0cdc1c1aac16b76746150e70154.diff

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mgorny, xiaobai. Herald added a subscriber: abidh. Herald added a project: LLDB. Recently there has been some discussion about how we deal with optional dependencies in LLDB. The common approach in LLVM is to make things wo

[Lldb-commits] [lldb] f387b99 - [DataFormatters] Change the Get() method to take a LanguageType.

Author: Davide Italiano Date: 2019-12-10T15:21:24-08:00 New Revision: f387b99745101d5843d397a2a65dc4102c6f8e14 URL: https://github.com/llvm/llvm-project/commit/f387b99745101d5843d397a2a65dc4102c6f8e14 DIFF: https://github.com/llvm/llvm-project/commit/f387b99745101d5843d397a2a65dc4102c6f8e14.dif

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere added inline comments. Comment at: lldb/cmake/modules/LLDBConfig.cmake:28 set(default_disable_python OFF) +set(default_disable_lua OFF) set(default_disable_curses OFF) mgorny wrote: > labath wrote: > > I think this will tick off some bots (and peop

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere updated this revision to Diff 233203. JDevlieghere marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake lldb/include/l

[Lldb-commits] [PATCH] D71309: [FormatEntity] Add mangled function name support

mib created this revision. mib added a project: LLDB. Add `function.mangled-name` key for FormatEntity to show the mangled function names in backtraces. rdar://54088244 Signed-off-by: Med Ismail Bennani LanguageRuntime: Simplify NSException::GetSummary() output Right now, NSException::GetSumm

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. Herald added a subscriber: mgorny. Data formatter Validators are completely wired up all the way to the SBAPI, but as far as I can tell they are not used anywhere (including swift-lldb) and also are not tested. I'm pu

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

xiaobai added a comment. I personally prefer the third approach. To make sure I understand correctly, I'll write it in my own words so you can correct me if I misunderstood. Try to find the dependency, and if we find it then use it. If not, then we can print out something like "Didn't find `DEPE

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

mib created this revision. mib added a project: LLDB. Right now, NSException::GetSummary() has the following output: "name: $exception_name - reason: $exception_reason" It would be better to simplify the output by removing the name and only showing the exception's reason. This way, annotations wo

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

I think it would be better to stick the equivalent of skipIfRemote in the Expect base class. > On Dec 10, 2019, at 3:15 PM, Jason Molenda via lldb-commits > wrote: > > > Author: Jason Molenda > Date: 2019-12-10T15:15:25-08:00 > New Revision: b0937be06e44c0cdc1c1aac16b76746150e70154 > > URL:

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

mgorny added a comment. I'm going to be blunt but if you dislike what LLVM does, improve that rather than proliferating inconsistencies between subprojects. That said, there are few things that could improve this. We could print a nice summary of which dependencies were found and which were not

Re: [Lldb-commits] [lldb] b0937be - Skip TestGuiBasic.py on ios etc device testing.

That was my first inclination -- I don't see how it can work correctly on a remote setup, just like TestMultilineCompletion.py which I added the same skip to -- but I know people are doing remote linux testing for android and this doesn't seem to have been a problem for them? I went the conserv

[Lldb-commits] [lldb] 62a6d97 - Do not cache hardcoded formats in FormatManager

Author: Adrian Prantl Date: 2019-12-10T15:53:40-08:00 New Revision: 62a6d9770450f93a2dcdf04710a73341af2f54fa URL: https://github.com/llvm/llvm-project/commit/62a6d9770450f93a2dcdf04710a73341af2f54fa DIFF: https://github.com/llvm/llvm-project/commit/62a6d9770450f93a2dcdf04710a73341af2f54fa.diff

[Lldb-commits] [PATCH] D71306: [RFC] Change how we deal with optional dependencies

JDevlieghere added a comment. In D71306#1778484 , @mgorny wrote: > I'm going to be blunt but if you dislike what LLVM does, improve that rather > than proliferating inconsistencies between subprojects. I think LLVM's behavior makes sense for LLVM but ma

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjNSException.py:30 '(NSException *) except1 = ', -'name: @"TheGuyWhoHasNoName~1" - reason: @

[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71297/new/ https://reviews.llvm.org/D71297 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide added a comment. This one looks fine -- can you please check that this patch applied on swift still produces something reasonable for mixed obj-C/swift formatters? My guess is that it will, and you probably just need to update some tests. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D71309: [FormatEntity] Add mangled function name support

mib added a comment. Duplicate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71309/new/ https://reviews.llvm.org/D71309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D71233: Do not cache hardcoded formats in FormatManager

This revision was automatically updated to reflect the committed changes. Closed by commit rG62a6d9770450: Do not cache hardcoded formats in FormatManager (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 70e3d0e - [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

Author: Adrian Prantl Date: 2019-12-10T15:57:53-08:00 New Revision: 70e3d0ea55e8b9385168d389fcba16a283f20214 URL: https://github.com/llvm/llvm-project/commit/70e3d0ea55e8b9385168d389fcba16a283f20214 DIFF: https://github.com/llvm/llvm-project/commit/70e3d0ea55e8b9385168d389fcba16a283f20214.diff

[Lldb-commits] [PATCH] D71289: [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG70e3d0ea55e8: [FormatManager] Move Language lookup into the obviously non-cached part (NFC) (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere updated this revision to Diff 233218. JDevlieghere added a comment. Reuse IOHandlerEditline for the Lua interpreter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Plugins/S

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

jingham added a comment. Adrian and I talked about this some more. Apparently the idea was that you have some type Foo and you want to look for some error state in instances of that type (Foo::a + Foo::b < 10). So you add a Type Validator for Foo that does this check, and every time lldb prin

[Lldb-commits] [PATCH] D71313: [AST] Split parent map traversal logic into ParentMapContext.h

rnk created this revision. rnk added reviewers: bkramer, klimek, rsmith. Herald added subscribers: lldb-commits, kbarton, mgorny, nemanjai. Herald added projects: clang, LLDB. The only part of ASTContext.h that requires most AST types to be complete is the parent map. Nothing in Clang proper uses

[Lldb-commits] [PATCH] D71232: [lldb/Lua] Add Boilerplate for a Lua Script Interpreter

JDevlieghere updated this revision to Diff 233219. JDevlieghere added a comment. ^ updated the wrong patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71232/new/ https://reviews.llvm.org/D71232 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/include/lldb/Host/Config.h.cmake lld

[Lldb-commits] [PATCH] D71310: RFC: Remove "Validators"

davide added a comment. In D71310#1778534 , @jingham wrote: > Adrian and I talked about this some more. Apparently the idea was that you > have some type Foo and you want to look for some error state in instances of > that type (Foo::a + Foo::b < 10).

[Lldb-commits] [PATCH] D71296: Replace redundant code in LanguageCategory with templates (NFC)

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM, in the same vein as D71231 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71296/new/ https://reviews.llvm.org/D71296 ___

[Lldb-commits] [PATCH] D71234: [lldb/Lua] Implement a Simple Lua Script Interpreter Prototype

JDevlieghere updated this revision to Diff 233220. JDevlieghere added a comment. Reuse IOHandlerEditline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71234/new/ https://reviews.llvm.org/D71234 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Plugins/ScriptInterpreter/Lua/CMak

[Lldb-commits] [lldb] b3801de - Replace redundant code in LanguageCategory with templates (NFC)

Author: Adrian Prantl Date: 2019-12-10T16:11:10-08:00 New Revision: b3801de7c50faa2b730e62e1cfabeec8c5cebae2 URL: https://github.com/llvm/llvm-project/commit/b3801de7c50faa2b730e62e1cfabeec8c5cebae2 DIFF: https://github.com/llvm/llvm-project/commit/b3801de7c50faa2b730e62e1cfabeec8c5cebae2.diff

[Lldb-commits] [lldb] 2fb07b9 - Remove unsound caching in LanguageCategory

Author: Adrian Prantl Date: 2019-12-10T16:11:10-08:00 New Revision: 2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1 URL: https://github.com/llvm/llvm-project/commit/2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1 DIFF: https://github.com/llvm/llvm-project/commit/2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1.diff

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

jingham added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109 + if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) && + !reason_str_summary.Empty()) { +stream.Printf("%s", reason_str_summary.GetData()); --

[Lldb-commits] [PATCH] D71296: Replace redundant code in LanguageCategory with templates (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3801de7c50f: Replace redundant code in LanguageCategory with templates (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D71296?vs=233179&id=2

[Lldb-commits] [PATCH] D71297: Remove unsound caching in LanguageCategory

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb07b90dc1c: Remove unsound caching in LanguageCategory (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D71311: LanguageRuntime: Simplify NSException::GetSummary() output

davide added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/NSException.cpp:107-109 + if (NSStringSummaryProvider(*reason_sp, reason_str_summary, options) && + !reason_str_summary.Empty()) { +stream.Printf("%s", reason_str_summary.GetData()); ---

[Lldb-commits] [PATCH] D71316: [FormatManager] Upstream and test swift bits for GetCandidateLanguages().

davide created this revision. davide added reviewers: teemperor, aprantl, labath, friss, jingham. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71316 Files: lldb/source/DataFormatters/FormatManager.cpp lldb/unittests/DataFormatter/FormatManager

[Lldb-commits] [PATCH] D71319: [lldb][dotest] Improve libc++ detection

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a reviewer: EricWF. Herald added subscribers: lldb-commits, ldionne. Herald added a project: LLDB. The test logic for running libc++ tests only looks to see if `/usr/include/c++/v1` exists. This adds a fallback for

  1   2   >