labath added a comment. No opinion on the code, but I think the test needs to be cleaned up _a lot_.
================ Comment at: lldb/test/Shell/Settings/Inputs/main.cpp:1 +//===-- main.cpp ------------------------------------------------*- C++ -*-===// +// ---------------- This file is about 70 lines longer than necessary to test this functionality, and it contains a #include statement in the middle of the file which is completely bogus ================ Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:2 +# UNSUPPORTED: system-windows +# RUN: %clangxx_host -std=c++14 -g -O0 %S/Inputs/main.cpp -o %t.out +# RUN: %lldb -x -b -s %s %t.out | FileCheck %s ---------------- The -std argument doesn't seem relevant here. ================ Comment at: lldb/test/Shell/Settings/TestFrameFormatMangling.test:3 +# RUN: %clangxx_host -std=c++14 -g -O0 %S/Inputs/main.cpp -o %t.out +# RUN: %lldb -x -b -s %s %t.out | FileCheck %s +br set -p "Set break" ---------------- -x not needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71237/new/ https://reviews.llvm.org/D71237 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
