[Lldb-commits] [lldb] r367201 - [lldb][NFC] Remove DiagnosticManager::CopyDiagnostics

Author: teemperor Date: Mon Jul 29 00:37:17 2019 New Revision: 367201 URL: http://llvm.org/viewvc/llvm-project?rev=367201&view=rev Log: [lldb][NFC] Remove DiagnosticManager::CopyDiagnostics The Diagnostic class in LLDB is suppossed to be inherited from, so just copying the diagnostics like this i

[Lldb-commits] [lldb] r367207 - [lldb][NFC] Split emitting and parsing in LLDBOptionDefEmitter

Author: teemperor Date: Mon Jul 29 01:22:41 2019 New Revision: 367207 URL: http://llvm.org/viewvc/llvm-project?rev=367207&view=rev Log: [lldb][NFC] Split emitting and parsing in LLDBOptionDefEmitter Splitting the different logic is cleaner and we it will be easier to implement the enum emitting (

[Lldb-commits] [lldb] r367228 - [lldb] [test] Mark three new tests XFAIL on NetBSD

Author: mgorny Date: Mon Jul 29 07:32:40 2019 New Revision: 367228 URL: http://llvm.org/viewvc/llvm-project?rev=367228&view=rev Log: [lldb] [test] Mark three new tests XFAIL on NetBSD Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py lldb/trunk/packages

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

teemperor created this revision. teemperor added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh. Herald added a project: LLDB. teemperor added a comment. For the sake of completeness, that's how Clang would warn about unimplemented options: llvm-project/lldb/source/Com

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

teemperor added a comment. For the sake of completeness, that's how Clang would warn about unimplemented options: llvm-project/lldb/source/Commands/CommandObjectSettings.cpp:102:15: warning: enumeration value 'Global' not handled in switch [-Wswitch] switch (*opt) { ^

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

jryans accepted this revision. jryans added a comment. Current version looks great to me! 😁 Comment at: lldb/docs/resources/build.rst:90 + + > git clone https://github.com/llvm/llvm-project.git This could be done in a separate patch, but I happened to notice

[Lldb-commits] [PATCH] D65353: [lldb] Also include the array definition in Properties.inc

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM beside a small nit pick. Comment at: lldb/utils/TableGen/LLDBPropertyDefEmitter.cpp:150 OS << "#ifdef " << NeededMacro << "\n"; + // OS << "enum {\n"; for (

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

sammccall added subscribers: chandlerc, sammccall. sammccall added inline comments. Comment at: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:77 +#define LLDB_PROPERTIES_dynamicloaderdarwinkernel +#include "Properties.inc" +}; --

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall created this revision. sammccall added reviewers: JDevlieghere, labath, chandlerc. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. labath added a comment. I am not sure about the consistency argument (on the other CL), as it seems to me that most/all llvm .inc fil

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

labath added a comment. I have one remark about the consumeError+LLDB_LOG pattern. As for whether this is better than status quo or not, I still don't have an opinion on that. :) Comment at: source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp:80-84 +llvm::consumeE

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath added a comment. If we're going to be mentioning test dependencies, then it probably makes sense to mention lld too. AFAIK, lld is required for running the (dotest) test suite on windows. On other platforms it is not required, but there are tests which will only get run if lld is enabled

[Lldb-commits] [PATCH] D64995: [lldb] Fix crash when tab-completing in multi-line expr

teemperor updated this revision to Diff 212163. teemperor added a comment. - Added test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64995/new/ https://reviews.llvm.org/D64995 Files: lldb/packages/Python/lldbsuite/test/expression_command/multiline-completion/Makefile lldb/packa

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

labath added a comment. I am not sure about the consistency argument (on the other CL), as it seems to me that most/all llvm .inc files *which are produced by tblgen" are included by via just their bare names. However, these files generally have unique names, which is usually achieved by just e

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212166. sammccall added a comment. Herald added a subscriber: mgorny. Herald added a reviewer: jdoerfert. Give the files distinct names instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https:

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

labath added a comment. How about codegenning the entire implementation of `SetOptionValue`? That way the user won't have to write any switch statements at all. Ideally, the option-setting code would be something like: void (Status?, Error?) SetOptionForce(StringRef arg, ExecutionContext *ctx

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall updated this revision to Diff 212167. sammccall added a comment. Fix one straggler Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 Files: lldb/source/Core/CMakeLists.txt lldb/source/Core/CoreP

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. In D65397#1604416 , @labath wrote: > I am not sure about the consistency argument (on the other CL), as it seems > to me that most/all llvm .inc files *which are produced by tblgen" are > included by via just their bare names.

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks. This looks fine to me, and I think that the new file names fit pretty organically into the existing lldb conventions (as well as being mostly consistent with how llvm handles tablegene

[Lldb-commits] [PATCH] D64995: [lldb] Fix crash when tab-completing in multi-line expr

labath accepted this revision. labath added a comment. Thanks. The test looks good to me. You might want to consider marking it as `NO_DEBUG_INFO_TESTCASE`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64995/new/ https://reviews.llvm.org/D64995 _

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

labath added a comment. Unfortunately this patch has raced with the latest tablegen changes, and it no longer applies cleanly. Could you please rebase on the current trunk? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.l

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM, thanks. BTW, I was pretty much a python noob too when starting with lldb, but our test suite has forced me to become somewhat of an expert. :) Comment at: lldb/tools/

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

sgraenitz added a comment. Thanks for your feedback. In D65330#1604355 , @labath wrote: > lld is required for running the (dotest) test suite on windows. On other > platforms it is not required, but there are tests which will only get run if > lld is en

[Lldb-commits] [PATCH] D65282: ObjectFileELF: permit thread-local sections with overlapping file addresses

labath added a comment. Thanks for sharing your knowledge about linkers and dynamic loaders. I have found it very useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65282/new/ https://reviews.llvm.org/D65282 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

labath accepted this revision. labath added a comment. Thanks for putting this together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65330/new/ https://reviews.llvm.org/D65330 ___ lldb-commits mailin

[Lldb-commits] [lldb] r367231 - SymbolVendor: Make SectionAddressesChanged a passthrough

Author: labath Date: Mon Jul 29 08:53:36 2019 New Revision: 367231 URL: http://llvm.org/viewvc/llvm-project?rev=367231&view=rev Log: SymbolVendor: Make SectionAddressesChanged a passthrough Summary: This moves the implementation of the function into the SymbolFile class, making it possible to exc

[Lldb-commits] [PATCH] D65266: SymbolVendor: Make SectionAddressesChanged a passthrough

This revision was automatically updated to reflect the committed changes. Closed by commit rL367231: SymbolVendor: Make SectionAddressesChanged a passthrough (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/tools/lldb-test/lldb-test.cpp:979 ModuleList::GetGlobalModuleListProperties().SetEnableExternalLookup(false); + // There is no SB API for settings in general like: + // GetG

[Lldb-commits] [lldb] r367234 - [lldb] Increase testsuite packet-timeout 5secs -> 1min

Author: jankratochvil Date: Mon Jul 29 09:10:16 2019 New Revision: 367234 URL: http://llvm.org/viewvc/llvm-project?rev=367234&view=rev Log: [lldb] Increase testsuite packet-timeout 5secs -> 1min rL357954 did increase `packet-timeout` 1sec -> 5secs. Which is IMO about the maximum timeout reasonabl

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. labath added a parent revision: D65329: SymbolVendor: Move locking into the Symbol Files. The last responsibility of the SymbolVendor was to hold an owning reference to the object file (in case symbols are bein

[Lldb-commits] [PATCH] D65271: Increase testsuite packet-timeout 5secs -> 1min

This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rL367234: [lldb] Increase testsuite packet-timeout 5secs -> 1min (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subsc

[Lldb-commits] [lldb] r367238 - [lldb] Also include the array definition in Properties.inc

Author: jdevlieghere Date: Mon Jul 29 09:41:30 2019 New Revision: 367238 URL: http://llvm.org/viewvc/llvm-project?rev=367238&view=rev Log: [lldb] Also include the array definition in Properties.inc Right now our Properties.inc only generates the initializer for the options list but not the array

[Lldb-commits] [PATCH] D65353: [lldb] Also include the array definition in Properties.inc

This revision was automatically updated to reflect the committed changes. Closed by commit rL367238: [lldb] Also include the array definition in Properties.inc (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[Lldb-commits] [lldb] r367241 - [lldb] Qualify includes of Properties[Enum].inc files. NFC

Author: rupprecht Date: Mon Jul 29 10:22:10 2019 New Revision: 367241 URL: http://llvm.org/viewvc/llvm-project?rev=367241&view=rev Log: [lldb] Qualify includes of Properties[Enum].inc files. NFC Summary: This is a bit more explicit, and makes it possible to build LLDB without varying the -I lines

[Lldb-commits] [PATCH] D65330: [lldb][docs] Update documentation for monorepo and CMake caches

stella.stamenova accepted this revision. stella.stamenova added a comment. I think you need one small change for lld still - to make it clear that it is required on Windows in the Windows section, but it looks good otherwise. Please fix that before committing. Comment at: lld

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

rupprecht added a comment. Committed this for you as r367241, including a rebase past r367238 (which I really hope I didn't mess up -- `ninja check-lldb` passed, at least). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL367241: [lldb] Qualify includes of Properties[Enum].inc files. NFC (authored by rupprecht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

sammccall added a comment. Thanks @rupprecht! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: compnerd, labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. Replaced Cmake option based check with the preprocessor macro as CMAKE_SYSTEM_PROCESSOR doesn't work as expected o

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

xbolva00 added inline comments. Comment at: Common/CMakeLists.txt:25 # TODO add support for ARM (NT) and ARM64 -# TODO build these unconditionally as we cannot do cross-debugging or WoW -if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64") - target_sources(lldbPluginProcessWindows

[Lldb-commits] [PATCH] D65329: SymbolVendor: Move locking into the Symbol Files

clayborg added a comment. We will need to watch future submissions closely as this increases the chance that someone will extend a SymbolFile by overriding a virtual function and forget to lock. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65329/new/ https://reviews.llvm.org/D65329

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

tatyana-krasnukha added inline comments. Comment at: Common/CMakeLists.txt:25 # TODO add support for ARM (NT) and ARM64 -# TODO build these unconditionally as we cannot do cross-debugging or WoW -if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64") - target_sources(lldbPluginProce

[Lldb-commits] [PATCH] D62931: [lldb-server] Add setting to force 'g' packet use

guiandrade updated this revision to Diff 212200. guiandrade added a comment. Adding support for tablegen generated properties introduced in https://reviews.llvm.org/D65185 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62931/new/ https://reviews.ll

[Lldb-commits] [PATCH] D65401: SymbolVendor: Remove the object file member variable

clayborg added a comment. So previously the SymbolVendor would only make a strong reference to the object file if it didn't match the object file of the module. Now it always makes one. Might be ok since the Module owns the SymbolVendor and thus owns the SymbolFile. We should make sure we don't

[Lldb-commits] [PATCH] D65129: Test load unloading of modules with libraries-svr4

This revision was automatically updated to reflect the committed changes. Closed by commit rL367247: Test load unloading of modules with libraries-svr4 (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D65397: Qualify includes of Properties[Enum].inc files. NFC

JDevlieghere added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65397/new/ https://reviews.llvm.org/D65397 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

jingham added a comment. It worries me a little bit that we are making it harder and harder to figure out "where does the option for "-t" get stored once this CommandObject's options have been parsed. Can you show the steps I would have to go through to get from "-f" to OptionEnumSettingsSet::

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212210. xiaobai added a comment. Fix incorrect error logging pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h include/lldb/Symb

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. In D65122#1604352 , @labath wrote: > I have one remark about the consumeError+LLDB_LOG pattern. As for whether > this is better than status quo or not, I still don't have an opinion on that. > :) Thanks for pointing out LLDB_LO

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

JDevlieghere added inline comments. Comment at: source/API/SBModule.cpp:525 module_sp->GetTypeSystemForLanguage(eLanguageTypeC); - if (type_system) { -CompilerType compiler_type = type_system->GetBuiltinTypeByName(name); + if (auto err = type_system_o

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

clayborg added a comment. In D65386#1604927 , @jingham wrote: > It worries me a little bit that we are making it harder and harder to figure > out "where does the option for "-t" get stored once this CommandObject's > options have been parsed. Can you s

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

aprantl added a comment. Did you see this recent commit? commit 515d1306ffb1e159c65b19d4cbe6c2f0997dfbf6 Author: Adrian Prantl Date: Fri Mar 29 16:12:27 2019 + Don't abort() in lldb_assert and document why. rdar://problem/49356014 Differential Revis

[Lldb-commits] [PATCH] D64267: lldb_assert: abort when assertions are enabled.

aprantl added a comment. Actually, it looks like this patch fixed an oversight in that commit. So all is good :-) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64267/new/ https://reviews.llvm.org/D64267 ___ lldb-comm

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik created this revision. shafik added reviewers: jingham, aprantl, clayborg, teemperor, davide. The change D55575 modified `ClangASTContext::CreateParameterDeclaration` to call `decl_ctx->addDecl(decl);` this caused a regression since the existing code in

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

clayborg added a comment. Looks fine to me. Be nice to clarify the test with comments a bit. I can't really tell what the test is doing or how it is verifying the fix in ClangASTContext.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

aprantl added a comment. So basically this is reverting an untested and incomplete/incorrect fix for another bug, while fixing a regression. I'm fine with the change assuming that it won't break the Windows test suite. The Makefile can be simplified though. Comment at: packa

[Lldb-commits] [PATCH] D65386: [lldb][NFC] Use an enum instead of chars when handling options [WIP]

JDevlieghere added a comment. In D65386#1604927 , @jingham wrote: > It worries me a little bit that we are making it harder and harder to figure > out "where does the option for "-t" get stored once this CommandObject's > options have been parsed. Can y

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

jasonmolenda added a comment. I'm not sure it's really relevant when lit is the driver, but I would often use --no-multiprocess with dotest to see the full trace output of a single test while it was running. In multiprocess mode that wasn't displayed iirc. That's my only use of it. I do use

[Lldb-commits] [lldb] r367258 - [Reproducers] Pass FileCollector around as a shared_ptr (NFC)

Author: jdevlieghere Date: Mon Jul 29 13:54:02 2019 New Revision: 367258 URL: http://llvm.org/viewvc/llvm-project?rev=367258&view=rev Log: [Reproducers] Pass FileCollector around as a shared_ptr (NFC) Instead of passing the FileCollector around as a reference or raw pointer, use a shared_ptr. Thi

[Lldb-commits] [PATCH] D65409: [ProcessWindows] Choose a register context file by prepocessor

compnerd added inline comments. Comment at: Common/CMakeLists.txt:28 +target_sources(lldbPluginProcessWindowsCommon PRIVATE + x86/RegisterContextWindows_x86.cpp) At this point, I would say its better to just merge it into the main source list. ===

[Lldb-commits] [lldb] r367261 - [Symbolication] Remove a duplicate assignment.

Author: davide Date: Mon Jul 29 14:25:45 2019 New Revision: 367261 URL: http://llvm.org/viewvc/llvm-project?rev=367261&view=rev Log: [Symbolication] Remove a duplicate assignment. Modified: lldb/trunk/examples/python/symbolication.py Modified: lldb/trunk/examples/python/symbolication.py URL:

[Lldb-commits] [lldb] r367260 - [Symbolication] Fix unicode compatibility between 2 and 3.

Author: davide Date: Mon Jul 29 14:25:37 2019 New Revision: 367260 URL: http://llvm.org/viewvc/llvm-project?rev=367260&view=rev Log: [Symbolication] Fix unicode compatibility between 2 and 3. Triples are always ASCII for now, but we were handed out a unicode object. Modified: lldb/trunk/ex

[Lldb-commits] [lldb] r367262 - [Symbolication] Remove some dead code. Nothing exciting.

Author: davide Date: Mon Jul 29 14:25:51 2019 New Revision: 367262 URL: http://llvm.org/viewvc/llvm-project?rev=367262&view=rev Log: [Symbolication] Remove some dead code. Nothing exciting. Modified: lldb/trunk/examples/python/symbolication.py Modified: lldb/trunk/examples/python/symbolicati

[Lldb-commits] [PATCH] D65311: [dotest] Remove multiprocessing

JDevlieghere added a comment. In D65311#1605147 , @jasonmolenda wrote: > I'm not sure it's really relevant when lit is the driver, but I would often > use --no-multiprocess with dotest to see the full trace output of a single > test while it was running

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik updated this revision to Diff 212231. shafik added a comment. Addressing comments: - Simplifying Makefile - Adding comments to the test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 Files: packages/Python/lldbsuite/test/lang/cpp/bre

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik added a comment. @aprantl @clayborg Thank you for the comments, I think I have addressed your concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added inline comments. Comment at: source/API/SBModule.cpp:525 module_sp->GetTypeSystemForLanguage(eLanguageTypeC); - if (type_system) { -CompilerType compiler_type = type_system->GetBuiltinTypeByName(name); + if (auto err = type_system_or_err

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212232. xiaobai added a comment. Small logic change in SBModule CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h include/lldb/Symbol/Ty

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

JDevlieghere added inline comments. Comment at: source/API/SBModule.cpp:525 module_sp->GetTypeSystemForLanguage(eLanguageTypeC); - if (type_system) { -CompilerType compiler_type = type_system->GetBuiltinTypeByName(name); + if (auto err = type_system_o

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik updated this revision to Diff 212243. shafik added a comment. Simplifying Makefile even more CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 Files: packages/Python/lldbsuite/test/lang/cpp/breakpoint_in_member_func_w_non_primitive_param

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

shafik added a comment. @stella.stamenova this could potentially break the windows build, could you please verify before I land this change. Thank you in advance! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. I'll run some tests and let you know the result. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

jingham added a comment. It might be good to see if you can trigger the bug more directly (for instance by getting the SBType for the method and pulling out its arguments?) The reason that a breakpoint triggers this at present is that lldb reads the debug info for the function to find the prol

[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

This revision was automatically updated to reflect the committed changes. Closed by commit rL367273: [CMake] Move project() call to main CMake file (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb updated this revision to Diff 212252. jfb added a comment. Significantly simplify the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 Files: llvm/include/llvm/Support/AlignOf.h llvm/unittests

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1603431 , @BillyONeal wrote: > (In fact I observe many patterns in this review like: > > enum { Foo = alignof(void*); } > aligned_storage_t<1234, Foo> x; > > and then a bunch of casting to treat it as a char buffer; if it wa

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I think this change has introduced a dependence on x64. I tried building with the 32b Visual Studio compiler and there are a number of undefined registers in registercontextwindows_x64.cpp. This is because the version of _CONTEXT included by winnt.h is for x32 and not x6

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I have concerns that some of the patches that you landed prior to this will cause issues with old versions of MSVC, but in isolation, this is fine, and if anyone complains, we can address it on a ca

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added a comment. In D62213#1605521 , @asmith wrote: > I think this change has introduced a dependence on x64. > > I tried building with the 32b Visual Studio compiler and there are a number > of undefined registers in registercontextwindows_x64.cp

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

asmith marked 11 inline comments as done. asmith added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:95 + +// Resume the debug loop. +ExceptionRecordSP active_exception = amccarth wrote: > This code appe

[Lldb-commits] [PATCH] D65414: Fix ClangASTContext::CreateParameterDeclaration to not call addDecl

stella.stamenova added a comment. One failure: Error : no member named 'argc' in namespace '$__lldb_local_vars' from LLDB :: SymbolFile/NativePDB/local-variables.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1605523 , @rnk wrote: > I have concerns that some of the patches that you landed prior to this will > cause issues with old versions of MSVC, but in isolation, this is fine, and > if anyone complains, we can address it on a

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

asmith added a comment. I can confirm this is reproducible with the master branch of llvm-project cloned from GitHub. You can reproduce the build failure from an x64 command prompt with this cmake command line: cmake path-to-llvm-project/llvm -Thost=x64 -DLLVM_ENABLE_PROJECTS="clang;lld;lld

[Lldb-commits] [lldb] r367285 - [lldb] [test] Mark newly running test XFAIL on NetBSD

Author: mgorny Date: Mon Jul 29 23:12:03 2019 New Revision: 367285 URL: http://llvm.org/viewvc/llvm-project?rev=367285&view=rev Log: [lldb] [test] Mark newly running test XFAIL on NetBSD The test was not previously run due to decorator bug (fixed in r366903). It is not a regression and is probabl