jfb added a comment. In D65249#1605523 <https://reviews.llvm.org/D65249#1605523>, @rnk wrote:
> I have concerns that some of the patches that you landed prior to this will > cause issues with old versions of MSVC, but in isolation, this is fine, and > if anyone complains, we can address it on a case-by-case basis. lgtm IIUC Billy correctly, the issue was just with `aligned_storage`, but if you roll your own (as I have) we're fine. If I'm wrong, these tests will fail on MSVC bots :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
