compnerd added inline comments.
================ Comment at: Common/CMakeLists.txt:28 +target_sources(lldbPluginProcessWindowsCommon PRIVATE + x86/RegisterContextWindows_x86.cpp) ---------------- At this point, I would say its better to just merge it into the main source list. ================ Comment at: Common/x64/RegisterContextWindows_x64.h:47 + +#endif // defined(__x86_64__) || defined(__amd64__) || defined(_M_X64) || defined(_M_AMD64) ---------------- Can you push this inside the include guards please? ================ Comment at: Common/x86/RegisterContextWindows_x86.h:51 + +#endif // defined(__i386__) || defined(_M_IX86) ---------------- Can you sink the check here inside the include guards please? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65409/new/ https://reviews.llvm.org/D65409 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
