aprantl added a comment. So basically this is reverting an untested and incomplete/incorrect fix for another bug, while fixing a regression. I'm fine with the change assuming that it won't break the Windows test suite. The Makefile can be simplified though.
================ Comment at: packages/Python/lldbsuite/test/lang/cpp/breakpoint_in_member_func_w_non_primitive_params/Makefile:5 + +CFLAGS_LIMIT = -c $(CXXFLAGS) +CFLAGS_NO_LIMIT = -c $(CXXFLAGS) ---------------- This looks like it is copied and pasted form another testcase and not actually necessary. What you want is ``` CFLAGS_EXTRAS = $(MANDATORY_CXXMODULE_BUILD_CFLAGS) ``` and then you should be able to delete all lines starting with $(CXX) because the default build rules should just work. ================ Comment at: packages/Python/lldbsuite/test/lang/cpp/breakpoint_in_member_func_w_non_primitive_params/TestBreakpointInMemberFuncWNonPrimitiveParams.py:10 + + @skipUnlessDarwin + @add_test_categories(["gmodules"]) ---------------- This shouldn't be necessary. We want this everywhere where gmodules is supported, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65414/new/ https://reviews.llvm.org/D65414 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
