[Lldb-commits] [PATCH] D63813: Adjust variable formatting table

lubgr created this revision. lubgr added a reviewer: jingham. lubgr added a project: LLDB. Herald added subscribers: lldb-commits, abidh. While the in-place hints on valid formats are up to date (e.g. when choosing an invalid format `expr -f nonExisting -- 42`), the corresponding online docs tab

[Lldb-commits] [PATCH] D63802: Handle nested register definition xml files from the remote serial protocol stub

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. few nits, but looks good. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4584-4585 }); +} +else { + XMLNode feature_node = xml_doc

[Lldb-commits] [PATCH] D61233: Refactor ObjectFile::GetSDKVersion

clayborg added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61233/new/ https://reviews.llvm.org/D61233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r364443 - [dotest] Add the ability to set environment variables for the inferior.

Author: jdevlieghere Date: Wed Jun 26 09:12:08 2019 New Revision: 364443 URL: http://llvm.org/viewvc/llvm-project?rev=364443&view=rev Log: [dotest] Add the ability to set environment variables for the inferior. This patch adds a dotest flag for setting environment variables for the inferior. This

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; Still seems weird that any language can white

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

davide added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; clayborg wrote: > Still seems weird that any lan

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham requested changes to this revision. jingham added inline comments. This revision now requires changes to proceed. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetNam

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; davide wrote: > clayborg wrote: > > Still seem

[Lldb-commits] [lldb] r364457 - [Reproducers] Copy over access/modification time in the FileCollector.

Author: jdevlieghere Date: Wed Jun 26 11:14:31 2019 New Revision: 364457 URL: http://llvm.org/viewvc/llvm-project?rev=364457&view=rev Log: [Reproducers] Copy over access/modification time in the FileCollector. Copy over access and modification time for the files included in the reproducer. This i

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

aprantl added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; jingham wrote: > clayborg wrote: > > davide wro

[Lldb-commits] [PATCH] D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints

mgorny updated this revision to Diff 206723. mgorny added a comment. Removed XFAIL for tests fixed by this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63792/new/ https://reviews.llvm.org/D63792 Files: lldb/packages/Python/lldbsuite/test/functionalities/watchpoint/hello_watchlocat

[Lldb-commits] [lldb] r364465 - [x86-64] Use `//` for integer division in the target definition.

Author: davide Date: Wed Jun 26 12:51:57 2019 New Revision: 364465 URL: http://llvm.org/viewvc/llvm-project?rev=364465&view=rev Log: [x86-64] Use `//` for integer division in the target definition. This forces integer division and works with python 2 and python 3. Modified: lldb/trunk/exam

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; aprantl wrote: > jingham wrote: > > clayborg w

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

aprantl added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; clayborg wrote: > aprantl wrote: > > jingham wr

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; apran

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

clayborg added a comment. Jim: do you have any other solutions that could make this work? Comment at: source/Core/ValueObject.cpp:1706-1708 + for (auto *runtime : process->GetLanguageRuntimes()) { +if (runtime->IsWhitelistedRuntimeValue(GetName())) + return false; ---

[Lldb-commits] [lldb] r364481 - Use the // integer divide operator in these

Author: jmolenda Date: Wed Jun 26 14:41:07 2019 New Revision: 364481 URL: http://llvm.org/viewvc/llvm-project?rev=364481&view=rev Log: Use the // integer divide operator in these target definition files, like Davide's change to x86_64_target_definition.py. Modified: lldb/trunk/examples/pytho

Re: [Lldb-commits] [lldb] r364481 - Use the // integer divide operator in these

Thank you Jason! On Wed, Jun 26, 2019 at 2:41 PM Jason Molenda via lldb-commits wrote: > > Author: jmolenda > Date: Wed Jun 26 14:41:07 2019 > New Revision: 364481 > > URL: http://llvm.org/viewvc/llvm-project?rev=364481&view=rev > Log: > Use the // integer divide operator in these > target defin

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added a comment. Shouldn't ValueObjectVariables figure out their runtime language from their defining frame, not their CompilerType? For a ValueObject you get from an expression, you probably can't do that. But we're always talking about hiding locals or args here - i.e. they are all

[Lldb-commits] [lldb] r364484 - Support nested target.xml register definition files, lack of reg group markers.

Author: jmolenda Date: Wed Jun 26 14:59:39 2019 New Revision: 364484 URL: http://llvm.org/viewvc/llvm-project?rev=364484&view=rev Log: Support nested target.xml register definition files, lack of reg group markers. The qemu x86_64 target returns a target.xml register definition file which include

[Lldb-commits] [PATCH] D63802: Handle nested register definition xml files from the remote serial protocol stub

This revision was automatically updated to reflect the committed changes. Closed by commit rL364484: Support nested target.xml register definition files, lack of reg group markers. (authored by jmolenda, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1559913 , @jingham wrote: > Shouldn't ValueObjectVariables figure out their runtime language from their > defining frame, not their CompilerType? For a ValueObject you get from an > expression, you probably can't do th

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added a comment. In D63240#1559931 , @xiaobai wrote: > In D63240#1559913 , @jingham wrote: > > > Shouldn't ValueObjectVariables figure out their runtime language from their > > defining frame, not their Com

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1559994 , @jingham wrote: > To be more precise, "frame" is the wrong word to use, Variables have > "scopes"... All Variables have a scope, though not every scope is contained > in a Function. > > But just to back up a

[Lldb-commits] [PATCH] D63853: [Symbol] Add DeclVendor::FindTypes

xiaobai created this revision. xiaobai added reviewers: jingham, labath, JDevlieghere. Herald added a subscriber: mgorny. Following up on the plan I outlined in D63622 , we can remove the dependence on clang in all the places where we only want to find the types f

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

jingham added a comment. In D63240#1560038 , @xiaobai wrote: > In D63240#1559994 , @jingham wrote: > > > To be more precise, "frame" is the wrong word to use, Variables have > > "scopes"... All Variables have a sc

[Lldb-commits] [PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka created this revision. vitalybuka added a reviewer: pcc. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CodeGenFunc

[Lldb-commits] [PATCH] D63854: [NFC] Convert large lambda into method

vitalybuka updated this revision to Diff 206771. vitalybuka added a comment. remove unrelated file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63854/new/ https://reviews.llvm.org/D63854 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/C

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai added a comment. In D63240#1560074 , @jingham wrote: > I was talking specifically about which runtime should be asked the question. > It seemed to me most straightforward to invert the order in which the > question was asked, but another way to

[Lldb-commits] [lldb] r364494 - [Reproducers] Fix flakiness and off-by-one during replay.

Author: jdevlieghere Date: Wed Jun 26 19:03:34 2019 New Revision: 364494 URL: http://llvm.org/viewvc/llvm-project?rev=364494&view=rev Log: [Reproducers] Fix flakiness and off-by-one during replay. This fixes two replay issues that caused the tests to behave erratically: 1. It fixes an off-by-one