clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

few nits, but looks good.



================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4584-4585
       });
+    }
+    else {
+      XMLNode feature_node = xml_document.GetRootElement("feature");
----------------
```
} else {
```


================
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4655-4657
+  if (GetGDBServerRegisterInfoXMLAndProcess (arch_to_use, "target.xml", 
cur_reg_num, reg_offset)) {
+    this->m_register_info.Finalize(arch_to_use);
+  }
----------------
remove {}


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63802/new/

https://reviews.llvm.org/D63802



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to