ki.stfu added a comment.
I perceive it as a simple patch, so I am going to go ahead.
http://reviews.llvm.org/D13158
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu requested changes to this revision.
This revision now requires changes to proceed.
Comment at: include/lldb/API/SBTypeSummary.h:125-126
@@ -124,1 +124,4 @@
+
+bool
+DoesPrintValue (const SBValue& value);
You can use clang-format t
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.h:58
@@ -57,3 +57,3 @@
bool GetCompositeValue(const bool vbPrintFieldNames, CMICmnMIValueTuple
&vwrMiValueTuple, const MIuint vnDepth = 1) const;
-
+bool TryGetValueSummary(CMIUtilString &vrV
evgeny777 added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:191-193
@@ -182,1 +190,5 @@
{
+CMIUtilString summary;
+if (TryGetValueSummary(summary))
+return summary;
+
ki.stfu wrote:
> ```
> const CMIUtilString summary = Get
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248566: Allow to construct CMIUtilString using std::string
directly + cleanup… (authored by ki.stfu).
Changed prior to commit:
http://reviews.llvm.org/D13158?vs=35703&id=35708#toc
Repository:
rL LLVM
Author: ki.stfu
Date: Fri Sep 25 03:28:58 2015
New Revision: 248566
URL: http://llvm.org/viewvc/llvm-project?rev=248566&view=rev
Log:
Allow to construct CMIUtilString using std::string directly + cleanup
CMIUtilString (MI)
Summary:
Allow to construct CMIUtilString using std::string directly + cl
ki.stfu added inline comments.
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:191-193
@@ -182,1 +190,5 @@
{
+CMIUtilString summary;
+if (TryGetValueSummary(summary))
+return summary;
+
evgeny777 wrote:
> ki.stfu wrote:
> > ```
> > const CMIUti
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Change oat symbolization code for android to work on non-rooted devices
On android when debugging an apk we run lldb-server as
Author: tberghammer
Date: Fri Sep 25 07:50:51 2015
New Revision: 248571
URL: http://llvm.org/viewvc/llvm-project?rev=248571&view=rev
Log:
Eliminate a potential crash in the struct layout code with a gracefull fallback
Differential revision: http://reviews.llvm.org/D12963
Modified:
lldb/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248571: Eliminate a potential crash in the struct layout
code with a gracefull fallback (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12963?vs=35084&id=35717#toc
Reposito
evgeny777 added inline comments.
Comment at: source/API/SBTypeSummary.cpp:290
@@ +289,3 @@
+bool
+SBTypeSummary::DoesPrintValue(const SBValue& value)
+{
ki.stfu wrote:
> ditto
I used clang-format with style file taken from lldb directory here, but
formatting didn
evgeny777 updated this revision to Diff 35725.
evgeny777 added a comment.
Revised with changes requested by ki.stfu
http://reviews.llvm.org/D13058
Files:
include/lldb/API/SBTypeSummary.h
source/API/SBTypeSummary.cpp
test/tools/lldb-mi/variable/TestMiGdbSetShowPrint.py
test/tools/lldb-mi
Author: emaste
Date: Fri Sep 25 10:36:30 2015
New Revision: 248574
URL: http://llvm.org/viewvc/llvm-project?rev=248574&view=rev
Log:
Re-enable some skipped tests on FreeBSD
These tests were skipped because they hung the old FreeBSD buildbot.
They pass (and do not hang) when run locally so enable
+100, great :) Once it's in it will be much more easy to press for others
to move their platform specific bits into this module, or to do it myself
when I'm writing platform specific stuff.
On Thu, Sep 24, 2015 at 9:56 PM Todd Fiala wrote:
> tfiala added a comment.
>
> > That's a good idea. I'm
Author: emaste
Date: Fri Sep 25 11:10:40 2015
New Revision: 248577
URL: http://llvm.org/viewvc/llvm-project?rev=248577&view=rev
Log:
Re-enable FreeBSD tests do not hang locally
These tests used to hang on the old FreeBSD buildbot, which has been
retired. They do not hang when run locally, but do
tfiala added a comment.
In http://reviews.llvm.org/D13124#253476, @zturner wrote:
> +100, great :)
:-)
http://reviews.llvm.org/D13124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
KLapshin updated the summary for this revision.
KLapshin updated this revision to Diff 35740.
KLapshin added a comment.
Patch reworked for suggested "-exec-run --start" manner, no "CLI" interpreter
use and check if --start option supported via -list-features.
Repository:
rL LLVM
http://revie
KLapshin marked an inline comment as done.
KLapshin added a comment.
"CLI" intepreter not used in ExecRun handler in reworked patch.
Repository:
rL LLVM
http://reviews.llvm.org/D12977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
Author: dperchik
Date: Fri Sep 25 13:08:45 2015
New Revision: 248597
URL: http://llvm.org/viewvc/llvm-project?rev=248597&view=rev
Log:
[lldb-mi] Fix assignment operator in CMIUtilString
Fix assignment operator in CMIUtilString to not crash the debugger if it
is passed a NULL pointer, which can ha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248597: [lldb-mi] Fix assignment operator in CMIUtilString
(authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D13094?vs=35620&id=35741#toc
Repository:
rL LLVM
http://reviews.ll
Author: dperchik
Date: Fri Sep 25 13:23:50 2015
New Revision: 248601
URL: http://llvm.org/viewvc/llvm-project?rev=248601&view=rev
Log:
Add comment in StringExtractor::GetHexU8
Modified:
lldb/trunk/source/Utility/StringExtractor.cpp
Modified: lldb/trunk/source/Utility/StringExtractor.cpp
URL:
ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Minor comments
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:231
@@ +230,3 @@
+
+size_t n = m_conn.Read(buffer, sizeof(buffer), 1000 * (timeout_ms -
ela
dawn accepted this revision.
dawn added a comment.
lgtm. Much improved.
Comment at: tools/lldb-mi/MICmdCmdSupportList.cpp:78
@@ +77,3 @@
+CMICmnMIValueList miValueList(true);
+// Some of features may depend on host or/and target, decide what to add
below
+miValueLi
Author: spyffe
Date: Fri Sep 25 17:47:07 2015
New Revision: 248631
URL: http://llvm.org/viewvc/llvm-project?rev=248631&view=rev
Log:
Moved ClangExpressionHelper.h into the Clang expression parser plug-in.
Added:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionHelper.h
-
tfiala updated this revision to Diff 35788.
tfiala added a comment.
Work in progess.
This patch is working and timing out consistently on Linux (on a Jenkins bot),
and is running normally on OS X. I haven't coerced a timeout on OS X yet.
I'll be adding some tests for the timeout and core gener
tfiala added inline comments.
Comment at: test/dosep.py:245
@@ +244,3 @@
+# binary should have called the results-generation code.
+raise Exception("no test results were generated whatsoever")
+return process_driver.results
This message should
I won't be able to have a serious look until Monday, as I'm still remote.
Hopefully you arent working on weekends :)
On Fri, Sep 25, 2015 at 6:30 PM Todd Fiala wrote:
> tfiala added inline comments.
>
>
> Comment at: test/dosep.py:245
> @@ +244,3 @@
> +# binary should ha
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It looks like this CL is introducing additional latency when destroying process
- I noticed 10 seconds delay when destroying Android process and got logs for
code with this CL and without:
1443231085.125153000 Process::StopForDestroy
tfiala added a comment.
In http://reviews.llvm.org/D13124#254082, @zturner wrote:
> I won't be able to have a serious look until Monday, as I'm still remote.
Oh no worries.
> Hopefully you arent working on weekends :)
:-P
http://reviews.llvm.org/D13124
__
ki.stfu accepted this revision.
ki.stfu added a comment.
lgtm
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ki.stfu added a comment.
But you still should get lgtm from @clayborg and @granata.enrico before landing.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
31 matches
Mail list logo
