Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

[Eugene Leviant via lldb-commits]

evgeny777 added inline comments.

================
Comment at: tools/lldb-mi/MICmnLLDBUtilSBValue.cpp:191-193
@@ -182,1 +190,5 @@
 {
+    CMIUtilString summary;
+    if (TryGetValueSummary(summary))
+        return summary;
+
----------------
ki.stfu wrote:
> ```
> const CMIUtilString summary = GetValueSummary();
> if (!summary.empty())
>     return summary;
> ```
const CMIUtilString**&** summary = GetValueSummary();  ???


http://reviews.llvm.org/D13058



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits