ovyalov accepted this revision.
ovyalov added a comment.
This revision is now accepted and ready to land.
Minor comments
================
Comment at: source/Plugins/Platform/Android/AdbClient.cpp:231
@@ +230,3 @@
+
+ size_t n = m_conn.Read(buffer, sizeof(buffer), 1000 * (timeout_ms -
elapsed_time), status, &error);
+ message.insert(message.end(), &buffer[0], &buffer[n]);
----------------
Could you add checks for error and that n > 0?
================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:340
@@ -346,1 +339,3 @@
[this](std::string* s) {
+ AdbClient adb(m_device_id);
+
----------------
Could you reuse adb variable defined before - e.g., wrap with shared_ptr?
================
Comment at: source/Plugins/Platform/Android/PlatformAndroid.cpp:361
@@ +360,3 @@
+ std::string output;
+ error = adb.Shell(command.GetData(), 60000 /* ms */, &output);
+ if (error.Fail())
----------------
s/&output/nullptr ?
http://reviews.llvm.org/D13162
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
