I won't be able to have a serious look until Monday, as I'm still remote.
Hopefully you arent working on weekends :)
On Fri, Sep 25, 2015 at 6:30 PM Todd Fiala <todd.fi...@gmail.com> wrote:
> tfiala added inline comments.
>
> ================
> Comment at: test/dosep.py:245
> @@ +244,3 @@
> + # binary should have called the results-generation code.
> + raise Exception("no test results were generated whatsoever")
> + return process_driver.results
> ----------------
> This message should include the filename.
>
> ================
> Comment at: test/process_control.py:273
> @@ +272,3 @@
> +
> + def create_piped_process(self, command, new_process_group=True):
> + if new_process_group:
> ----------------
> This will want to store the popen_process.using_process_groups property
> like I do on the Posix side if the terminate would do something different
> based on the presence or absence of using process groups. Oversight for
> not storing.
>
>
> http://reviews.llvm.org/D13124
>
>
>
>
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
