[Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

sagar created this revision. sagar added reviewers: jaydeep, clayborg. sagar added subscribers: bhushan, mohit.bhakkad, nitesh.jain, lldb-commits. sagar set the repository for this revision to rL LLVM. This patch adds MSA branch instruction emulation for MIPS64. Repository: rL LLVM http://revi

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

jaydeep requested changes to this revision. This revision now requires changes to proceed. Comment at: source/Plugins/Instruction/MIPS64/EmulateInstructionMIPS64.cpp:3117 @@ +3116,3 @@ +else +target = pc + 4; + This should be pc + 8. If branch is not t

Re: [Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

dawn abandoned this revision. dawn added a comment. This patch works on a small set of tests but fails in the same way that r237053 does when dotest is run on the entire set of lldb tests. Please accept http://reviews.llvm.org/D12329 until someone can investigate this further and provide a pro

Re: [Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

tberghammer added inline comments. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:469 @@ -457,1 +468,3 @@ +if (error.Fail()) +return LLDB_INVALID_INDEX32; This should be "return false" Comment at: so

Re: [Lldb-commits] [lldb] r246004 - In SendContinuePacketAndWaitForResponse there is a special bit of

On 26 August 2015 at 05:07, Jason Molenda via lldb-commits wrote: > There's a timeout where we wait to get this second stop reply packet > in SendContinuePacketAndWaitForResponse, currently 1ms. For a slow > remote target, it may take longer than that to send the second stop > reply packet. If t

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

tberghammer added a subscriber: tberghammer. tberghammer added a comment. You added 10 new function to the emulator where the first 8 functions and the last 2 functions are almost identical. I know that the rest of the MIPS64 instruction emulator is having the same issue but I would like to see

[Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus, ADodds. EwanCrawford set the repository for this revision to rL LLVM. Currently the RS breakpoint command can only find a kernel if it's in an already load

[Lldb-commits] [PATCH] D12363: Read module list from mini dump

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. http://reviews.llvm.org/D12363 Files: source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.h Index: source/Plugi

Re: [Lldb-commits] [PATCH] D12327: Treat cleanup errors separately from test failures

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12327 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I'll defer to Jim since he added this option. http://reviews.llvm.org/D12158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

Re: [Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

clayborg added a comment. Isn't fixing this as simple as having the TestDisassemble_VST1_64.py restore the platform correctly? http://reviews.llvm.org/D12303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This test passes fine when running dosep.py so I would prefer to set this to expected failure Repository: rL LLVM http://reviews.llvm.org/D12329 __

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

ted added a comment. The error also happens on Linux; this test should be turned off everywhere. Repository: rL LLVM http://reviews.llvm.org/D12329 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Fix the incorrect bool return values and this will be good to go. http://reviews.llvm.org/D12328 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will defer to MIPS experts here. You might thing about adding tberghammer as a reviewer. Repository: rL LLVM http://reviews.llvm.org/D12356

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

ted added a comment. The problem with this test is it gets python in a bad state, so after it's run, all tests after error out. It runs fine on its own, but something like: dotest.py python_api/ will give a lot of errors after this test runs. Repository: rL LLVM http://reviews.llvm.org/D123

Re: [Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

ted added a comment. I tried deleting the target and setting the platform to the host platform at the end of the test in TestDisassemble_VST1_64.py, but that didn't solve the problem. http://reviews.llvm.org/D12303 ___ lldb-commits mailing list ll

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good for now, but we should add a way so that plug-ins can extend the "breakpoint set", "breakpoint delete", and other breakpoint commands so we don't have a bunch of fragmented extr

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

tberghammer added a comment. I though a bit more about the abstraction you plan to introduce (DWARFDIE) and I started to believe we don't need it at all. If we use lldb::user_id_t in the NameToDIE indexes where the first 4 byte is the compile unit offset (for dwo) or the compile unit index (for

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

dawn added a comment. Greg, please reconsider. There are many options which dosep.py does not support, and the only way to get that functionality is by running dotest.py. There is no workaround. Thank you for understanding. Repository: rL LLVM http://reviews.llvm.org/D12329 __

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. In http://reviews.llvm.org/D12291#233274, @tberghammer wrote: > I though a bit more about the abstraction you plan to introduce (DWARFDIE) > and I started to believe we don't need it at all. If we use lldb::user_id_t > in the NameToDIE indexes where the first 4 byte is

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted after 6 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ah expected failing it won't help the tests pass. My bad. Check this in for now until we can fix it properly. Repository: rL LLVM http://reviews.llvm.org/D12329

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This is fine. This is an obvious grammar fix, those don't really need reviewing. http://reviews.llvm.org/D12158 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

dawn added a comment. Thanks Greg! Comment at: test/python_api/disassemble-raw-data/TestDisassemble_VST1_64.py:15 @@ -14,2 +14,3 @@ +@skipIfDarwin # llvm.org/pr24575: all ERRORs in dotest.py on OSX after this @python_api_test FYI - I will change this

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. So there are two issues I see here. The first is that you seem to have invented a parallel mechanism to the breakpoint resolver mechanism to handle re-resolving breakpoints on shar

[Lldb-commits] [PATCH] D12374: Code cleanup in preparation of adding split dwarf support

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Code cleanup in preparation of adding split dwarf support * Remove some unused code * Remove usage of DWARFDebugInfoEntry::Attributes where usage isn't reasonable * Cleanup DWA

[Lldb-commits] [lldb] r246043 - Skip test which is causing ERRORs in dotest.py after r237053

Author: dperchik Date: Wed Aug 26 13:16:45 2015 New Revision: 246043 URL: http://llvm.org/viewvc/llvm-project?rev=246043&view=rev Log: Skip test which is causing ERRORs in dotest.py after r237053 This test runs fine on its own, but leaves python in a bad state to where all tests that run after it

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

This revision was automatically updated to reflect the committed changes. Closed by commit rL246043: Skip test which is causing ERRORs in dotest.py after r237053 (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D12329?vs=33101&id=33229#toc Repository: rL LLVM http://

Re: [Lldb-commits] [Diffusion] rL237053: Fix selecting the Platform in TargetList::CreateTargetInternal()

dawn accepted this commit. dawn added a comment. While it is still unknown why this change triggered the dotest ERRORs as reported in llvm.org/pr24575, we're assuming the problem lies in the python API and not this change. The offending test was skipped in r246043 as a workaround. Users: te

Re: [Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

This revision was automatically updated to reflect the committed changes. Closed by commit rL246045: Error checking correction in AArch64 hardware watchpoint code (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D12328?vs=33099&id=33230#toc Repository: rL LLVM http:/

[Lldb-commits] [lldb] r246045 - Error checking correction in AArch64 hardware watchpoint code

Author: omjavaid Date: Wed Aug 26 13:23:27 2015 New Revision: 246045 URL: http://llvm.org/viewvc/llvm-project?rev=246045&view=rev Log: Error checking correction in AArch64 hardware watchpoint code Differential Revision: http://reviews.llvm.org/D12328 Modified: lldb/trunk/source/Plugins/Proc

[Lldb-commits] [lldb] r246061 - XFAIL environment variable setting test on Windows.

Author: zturner Date: Wed Aug 26 14:44:36 2015 New Revision: 246061 URL: http://llvm.org/viewvc/llvm-project?rev=246061&view=rev Log: XFAIL environment variable setting test on Windows. Fixing this is tracked by https://llvm.org/pr24579 Modified: lldb/trunk/test/settings/TestSettings.py Mod

[Lldb-commits] [lldb] r246062 - On Windows, use 'del' instead of 'rm' to delete the test executable.

Author: zturner Date: Wed Aug 26 14:44:45 2015 New Revision: 246062 URL: http://llvm.org/viewvc/llvm-project?rev=246062&view=rev Log: On Windows, use 'del' instead of 'rm' to delete the test executable. This is a nasty hack to work around the issue described in https://llvm.org/pr24589 Modified:

[Lldb-commits] [lldb] r246063 - Don't throw an exception when module cleanup fails.

Author: zturner Date: Wed Aug 26 14:44:56 2015 New Revision: 246063 URL: http://llvm.org/viewvc/llvm-project?rev=246063&view=rev Log: Don't throw an exception when module cleanup fails. Just because one test fails to clean up correctly, it should not prevent other tests from attempting to run. M

[Lldb-commits] [lldb] r246060 - Disable Objective C test on non-Darwin platforms.

Author: zturner Date: Wed Aug 26 14:44:28 2015 New Revision: 246060 URL: http://llvm.org/viewvc/llvm-project?rev=246060&view=rev Log: Disable Objective C test on non-Darwin platforms. Modified: lldb/trunk/test/lang/objc/modules/TestObjCModules.py Modified: lldb/trunk/test/lang/objc/modules/T

[Lldb-commits] [PATCH] D12380: Comment out DWARFCompileUnit printf spam

tfiala created this revision. tfiala added a reviewer: sivachandra. tfiala added a subscriber: lldb-commits. Comment out a line of diagnostic information that is printed many times during test runs when using DWARFCompileUnit.cpp to build the address range table. http://reviews.llvm.org/D12380

[Lldb-commits] [lldb] r246084 - Fix missing override warnings

Author: enrico Date: Wed Aug 26 16:39:52 2015 New Revision: 246084 URL: http://llvm.org/viewvc/llvm-project?rev=246084&view=rev Log: Fix missing override warnings Modified: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h lldb/trunk/source/Plugins/DynamicLo

Re: [Lldb-commits] [PATCH] D12380: Comment out DWARFCompileUnit printf spam

sivachandra accepted this revision. This revision is now accepted and ready to land. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:445 @@ -444,3 +444,3 @@ debug_aranges->AppendRange(cu_offset, range.GetRangeBase(), range.GetRangeEnd());

Re: [Lldb-commits] [PATCH] D12380: Comment out DWARFCompileUnit printf spam

sas added a subscriber: sas. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:445 @@ -444,3 +444,3 @@ debug_aranges->AppendRange(cu_offset, range.GetRangeBase(), range.GetRangeEnd()); -printf ("0x%8.8x: [0x%16.16" P

Re: [Lldb-commits] [PATCH] D12380: Comment out DWARFCompileUnit printf spam

tfiala added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:445 @@ -444,3 +444,3 @@ debug_aranges->AppendRange(cu_offset, range.GetRangeBase(), range.GetRangeEnd()); -printf ("0x%8.8x: [0x%16.16"

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

ybelkadi added a comment. Sorry if this wasn't the expected way to submit trivial patches. (I don't have commit access) http://reviews.llvm.org/D12158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] r246091 - http://reviews.llvm.org/D12380: remove DWARFCompileUnit printf spam.

Author: tfiala Date: Wed Aug 26 17:08:26 2015 New Revision: 246091 URL: http://llvm.org/viewvc/llvm-project?rev=246091&view=rev Log: http://reviews.llvm.org/D12380: remove DWARFCompileUnit printf spam. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Modified: lldb/t

Re: [Lldb-commits] [PATCH] D12380: Comment out DWARFCompileUnit printf spam

tfiala closed this revision. tfiala added a comment. Committed: Sendingsource/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp Transmitting file data . Committed revision 246091. http://reviews.llvm.org/D12380 ___ lldb-commits mailing list lld

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. I got my DWARFDIE stuff in with: % svn commit Sendinginclude/lldb/Core/dwarf.h Sendinginclude/lldb/Symbol/ClangASTContext.h Sendinginclude/lldb/Symbol/TypeSystem.h Sendinglldb.xcodeproj/project.pbxproj Sending source/Pl

[Lldb-commits] [PATCH] D12388: Silence some MSVC warnings.

sas created this revision. sas added a reviewer: zturner. sas added a subscriber: lldb-commits. Just `assert("string" && false)` instead of `assert("string" == NULL)`. This avoid errors like [...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation on address of string cons

Re: [Lldb-commits] [PATCH] D12388: Silence some MSVC warnings.

Thanks for fixing these. Feel free to commit trivial warning fixes without review. On Wed, Aug 26, 2015 at 4:43 PM Stephane Sezer wrote: > sas created this revision. > sas added a reviewer: zturner. > sas added a subscriber: lldb-commits. > > Just `assert("string" && false)` instead of `assert(

[Lldb-commits] [lldb] r246123 - Silence some MSVC warnings.

Author: sas Date: Wed Aug 26 18:55:14 2015 New Revision: 246123 URL: http://llvm.org/viewvc/llvm-project?rev=246123&view=rev Log: Silence some MSVC warnings. Summary: Just `assert("string" && false)` instead of `assert("string" == NULL)`. This avoid errors like [...]\Core\SourceManager.cpp(

Re: [Lldb-commits] [PATCH] D12388: Silence some MSVC warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246123: Silence some MSVC warnings. (authored by sas). Changed prior to commit: http://reviews.llvm.org/D12388?vs=33275&id=33276#toc Repository: rL LLVM http://reviews.llvm.org/D12388 Files: lldb/

[Lldb-commits] [lldb] r246130 - Switch data formatters over to using std::function for their callbacks instead of raw function pointers. NFC

Author: enrico Date: Wed Aug 26 19:45:33 2015 New Revision: 246130 URL: http://llvm.org/viewvc/llvm-project?rev=246130&view=rev Log: Switch data formatters over to using std::function for their callbacks instead of raw function pointers. NFC Modified: lldb/trunk/include/lldb/DataFormatters/F

[Lldb-commits] [lldb] r246131 - Add functionality to the platforms to figure out the proper name for a dynamic library on the system given a basename

Author: enrico Date: Wed Aug 26 19:53:57 2015 New Revision: 246131 URL: http://llvm.org/viewvc/llvm-project?rev=246131&view=rev Log: Add functionality to the platforms to figure out the proper name for a dynamic library on the system given a basename This will do things like, given mylibrary, ret

[Lldb-commits] [PATCH] D12396: Fix lldb build on older OSX versions after svn commit r244716

dawn created this revision. dawn added a reviewer: jasonmolenda. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. Older OSX versions don't define NSOperatingSystemVersion, so building lldb gets: ../tools/lldb/tools/debugserver/source/MacOSX/MachProce

Re: [Lldb-commits] [PATCH] D12396: Fix lldb build on older OSX versions after svn commit r244716

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good, thanks, I wasn't sure about whether this API would be available on older releases. Repository: rL LLVM http://reviews.llvm.org/D12396 ___

[Lldb-commits] [lldb] r246138 - Fix lldb build on older OSX versions after svn commit r244716

Author: dperchik Date: Wed Aug 26 22:42:56 2015 New Revision: 246138 URL: http://llvm.org/viewvc/llvm-project?rev=246138&view=rev Log: Fix lldb build on older OSX versions after svn commit r244716 Older OSX versions don't define NSOperatingSystemVersion, so building lldb gets: error: unknown type

Re: [Lldb-commits] [PATCH] D12396: Fix lldb build on older OSX versions after svn commit r244716

This revision was automatically updated to reflect the committed changes. Closed by commit rL246138: Fix lldb build on older OSX versions after svn commit r244716 (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D12396?vs=33294&id=33297#toc Repository: rL LLVM http:/

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

dawn added a subscriber: lldb-commits. http://reviews.llvm.org/rL245090 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

dawn added a subscriber: dawn. dawn added a comment. Hi Greg, While I really appreciate that you're making lldb less Clang specific (e.g. renaming ClangASTType to CompilerType), I'm concerned about this commit because it moves DWARF knowledge from the SymbolFileDWARF plugin into ClangASTContex

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

jaydeep updated this revision to Diff 33301. jaydeep added a comment. Addressed review comments. Address conversions are handled in Address class. This is a reduced version of the original patch where address conversions are handled for breakpoints only. Repository: rL LLVM http://reviews.ll