tfiala added inline comments. ================ Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:445 @@ -444,3 +444,3 @@ debug_aranges->AppendRange(cu_offset, range.GetRangeBase(), range.GetRangeEnd()); - printf ("0x%8.8x: [0x%16.16" PRIx64 " - 0x%16.16" PRIx64 ")\n", GetOffset(), range.GetRangeBase(), range.GetRangeEnd()); + // printf ("0x%8.8x: [0x%16.16" PRIx64 " - 0x%16.16" PRIx64 ")\n", GetOffset(), range.GetRangeBase(), range.GetRangeEnd()); } ---------------- sas wrote: > sivachandra wrote: > > I do not know the policy around such debug print statements; I would just > > remove it. > Yeah removing (or redirecting to an actual log channel maybe?) might be a > better fix than commenting out. I'll just go ahead and remove it. It would be easy enough to add back in if somebody wants it, and they would be in a better position to determine what they'd want to enshrine in a log message. This one is very spammy.
Thanks, all! http://reviews.llvm.org/D12380 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits