sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
Just `assert("string" && false)` instead of `assert("string" == NULL)`.
This avoid errors like
[...]\Core\SourceManager.cpp(647): warning C4130: '==' : logical operation
on address of string constant
http://reviews.llvm.org/D12388
Files:
source/Core/SourceManager.cpp
Index: source/Core/SourceManager.cpp
===================================================================
--- source/Core/SourceManager.cpp
+++ source/Core/SourceManager.cpp
@@ -644,14 +644,14 @@
else
{
// Some lines have been populated, start where we last left off
- assert("Not implemented yet" == NULL);
+ assert("Not implemented yet" && false);
}
}
else
{
// Calculate all line offsets up to "line"
- assert("Not implemented yet" == NULL);
+ assert("Not implemented yet" && false);
}
return false;
}
Index: source/Core/SourceManager.cpp
===================================================================
--- source/Core/SourceManager.cpp
+++ source/Core/SourceManager.cpp
@@ -644,14 +644,14 @@
else
{
// Some lines have been populated, start where we last left off
- assert("Not implemented yet" == NULL);
+ assert("Not implemented yet" && false);
}
}
else
{
// Calculate all line offsets up to "line"
- assert("Not implemented yet" == NULL);
+ assert("Not implemented yet" && false);
}
return false;
}
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
