Re: [Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

[Tamas Berghammer via lldb-commits]

tberghammer added inline comments.

================
Comment at: 
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:469
@@ -457,1 +468,3 @@
+    if (error.Fail())
+        return LLDB_INVALID_INDEX32;
 
----------------
This should be "return false"

================
Comment at: 
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:490
@@ +489,3 @@
+        if (error.Fail())
+            return LLDB_INVALID_INDEX32;
+
----------------
This should be "return false"

================
Comment at: 
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:618
@@ -583,1 +617,3 @@
+    if (error.Fail())
+        return LLDB_INVALID_INDEX32;
 
----------------
This should be "return false"


http://reviews.llvm.org/D12328



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits