[Lldb-commits] [PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230131. hintonda added a comment. - Add back original llvm::cantFail signatures so they'll still be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70259/new/ https://reviews.llvm.org/D70259 Files: clang-tool

[Lldb-commits] [PATCH] D70259: [Error] Add source location to cantFail

hintonda updated this revision to Diff 230125. hintonda added a comment. Herald added subscribers: lldb-commits, cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added projects: clang, LLDB. - Replace macro magic with matching 3-parameter template functions. - Refactor cantFail move in

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

hintonda accepted this revision. hintonda added a comment. In D63544#1551939 , @tatyana-krasnukha wrote: > Finally updated versions - `target_sources` supports using > `$` since CMake 3.5.0. Great, thanks for narrowing that down, Still LGTM! Reposit

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

hintonda added inline comments. Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $) tatyana-krasnukha wrote: > hintonda wrote: > > Just wanted to let you know that using `$` in anything > > other th

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda added a comment. I just reviewed all the release notes, and while 3.9 relaxed the usage of TARGET_OBJECTS, cmake doesn't explicitly mention allowing them in `target_link_libraries` until release 3.15. I don't have any of those versions, but it looks like 3.15 is probably the version y

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda accepted this revision. hintonda added a comment. This revision is now accepted and ready to land. Otherwise, LGTM, thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63544/new/ https://reviews.llvm.org/D63544

[Lldb-commits] [PATCH] D63544: Add a worlaround for unsupported cmake feature

hintonda added inline comments. Comment at: tools/lldb/unittests/tools/lldb-mi/utils/CMakeLists.txt:16 +else() + target_sources(LLDBMiUtilTests PRIVATE $) +endif() I'm assuming from your comment, that this is a performance issue. If so, could you add a comment

[Lldb-commits] [PATCH] D55653: [lldb-mi] Check raw pointers before passing them to std::string ctor/assignment

hintonda added inline comments. Comment at: lldb/trunk/unittests/tools/lldb-mi/utils/CMakeLists.txt:12 + +target_sources(LLDBMiUtilTests PRIVATE $) Just wanted to let you know that using `$` in anything other than `add_library` and `add_executable` wasn't added

[Lldb-commits] [PATCH] D61956: [CMake] Add first CMake cache files

hintonda added a comment. Btw, options on the command line always override what's in the cache. Has nothing to do with FORCE. All FORCE does is make sure the set command actually changes an existing cache value. So it's an ordering issue. If the `-D` comes before the `-C` then using FORCE w

[Lldb-commits] [PATCH] D43432: [cmake] Fix LLDB_CODESIGN_IDENTITY logic.

hintonda added a comment. This is causing test failures due debugserver not found. The fix should be to add DEBUGSERVER_PATH to the cache -- it was originally available in the root scope. I hope to have a fix in as soon as I validated the fix locally, but if this is causing an issue for anyon

[Lldb-commits] [PATCH] D39578: Fix a couple of self-assignments using memcpy.

hintonda updated this revision to Diff 122730. hintonda added a comment. - Address comments. https://reviews.llvm.org/D39578 Files: source/Core/RegisterValue.cpp source/Core/Value.cpp Index: source/Core/Value.cpp === --- sour

[Lldb-commits] [PATCH] D39578: Fix a couple of self-assignments using memcpy.

hintonda added a comment. ping? https://reviews.llvm.org/D39578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#912810, @clayborg wrote: > I was unhappy when we went over two pointers for a FileSpec when m_syntax was > added due to the extra size. Anything we can do to make this smaller would be > great, so the type on the enum would work, but

[Lldb-commits] [PATCH] D39580: Quash a few 'warning: comparison of function 'compression_decode_buffer' not equal to a null pointer is always true [-Wtautologica l-pointer-compare]'

hintonda created this revision. Quash several warnings of this type using clang's suggested fix: [2741/3631] Building CXX object tools/lldb/source/Plugins/Process/gdb-remote/CMakeFiles/lldbPluginProcessGDBRemote.dir/GDBRemoteCommunication.cpp.o /Users/dhinton/projects/llvm_project/llvm/tools/lld

[Lldb-commits] [PATCH] D39578: Fix a couple of self-assignments using memcpy.

hintonda created this revision. These two methods are essentially assignents, but don't check for self-assignment and use memcpy for member variables. Since they aren't actually operator=(), it's unclear what should be done: - check and shortcut - assert - allow but s/memcpy/memmove/ https://r

[Lldb-commits] [PATCH] D39574: Add type to FileSpec::PathSyntax enum.

hintonda created this revision. Add type to FileSpec::PathSyntax enum to decrease size for FileSpec on systems with 32 bit pointers. Thanks to @zturner for pointing this out. https://reviews.llvm.org/D39574 Files: include/lldb/Utility/FileSpec.h Index: include/lldb/Utility/FileSpec.h =

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda updated this revision to Diff 121350. hintonda added a comment. I realize this probably isn't an acceptable change, but it was a good learing experience for me, as I'd never looked at the lldb code before last Sunday, so I figured I'd go ahead and complete it. While the basic technique r

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added inline comments. Comment at: include/lldb/Utility/FileSpec.h:65-69 + enum PathSyntax : unsigned char { ePathSyntaxPosix, ePathSyntaxWindows, ePathSyntaxHostNative }; zturner wrote: > hintonda wrote: > > zturner wrote: > > > This

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda abandoned this revision. hintonda added a comment. Okay, got the message. Sorry for the noise. https://reviews.llvm.org/D39436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added inline comments. Comment at: include/lldb/Utility/FileSpec.h:65-69 + enum PathSyntax : unsigned char { ePathSyntaxPosix, ePathSyntaxWindows, ePathSyntaxHostNative }; zturner wrote: > This is actually a very nice change, as it red

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda updated this revision to Diff 121214. hintonda added a comment. Addressed @clayborg's comments. - Added FileSpec ctor that takes an explicit RegularExpression object when using FileSpec as a regex pattern. - Removed the RegularExpression member variable, added a flag, and create the r

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#912910, @zturner wrote: > >> I haven't had time to really look into this, but it seems that maintaining >> two independent strings, one for directory and one for basename, is just for >> convenience. We could easily keep it in a

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#912829, @clayborg wrote: > In https://reviews.llvm.org/D39436#912828, @zturner wrote: > > > In https://reviews.llvm.org/D39436#912810, @clayborg wrote: > > > > > I was unhappy when we went over two pointers for a FileSpec when m_syntax

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. Actually, it wouldn't matter for this one due to alignment. https://reviews.llvm.org/D39436 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911875, @clayborg wrote: > A few general things: don't modify FileSpec, we have many of these objects > and we can't increase their size without directly affecting memory usage. > FileSpec objects represent one file on disk, not mul

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda updated this revision to Diff 120933. hintonda added a comment. - Remove prefix and add options. https://reviews.llvm.org/D39436 Files: include/lldb/Utility/FileSpec.h source/Commands/CommandObjectBreakpoint.cpp source/Utility/FileSpec.cpp Index: source/Utility/FileSpec.cpp

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoints.

hintonda created this revision. Add regex support to file and module names when setting breakpoints. This solution is enabled via a "regex:" prefix, and doesn't require any other api changes. In this example, setting breakpoints for a particular function was twice as fast using "regex:.*/clang/.*

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911296, @jingham wrote: > In https://reviews.llvm.org/D39436#911293, @hintonda wrote: > > > In https://reviews.llvm.org/D39436#911260, @jingham wrote: > > > > > I don't like this change. > > > > > > First off, the whole point of having

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911274, @jingham wrote: > BTW, to Z's comment: you can't really resolve the regex pattern when you make > the breakpoint. What if another library gets loaded later on, which has > source files that match the source file pattern the u

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911264, @jingham wrote: > Zachary's suggestion is better than adding regex patterns to FileSpec, but I > still don't like the idea of encoding option types in the option values. Are you talking about fnmatch? Is that portable? If n

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911260, @jingham wrote: > I don't like this change. > > First off, the whole point of having options in the commands is so that we > don't have to have magic encodings in the values. > > We also don't have FileSpec's that resolve to mu

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911263, @zturner wrote: > In https://reviews.llvm.org/D39436#911254, @hintonda wrote: > > > In https://reviews.llvm.org/D39436#911237, @zturner wrote: > > > > > Hmm, weird. Maybe it already is? Even though I didn't see it on the > >

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911237, @zturner wrote: > Hmm, weird. Maybe it already is? Even though I didn't see it on the > original email. Anyway, ignore my last suggestion. > > On to actual comments: I'm not really crazy about the `regex:` prefix. Seems >

[Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

hintonda added a comment. In https://reviews.llvm.org/D39436#911233, @zturner wrote: > Would you mind deleting and re-creating this revision with lldb-commits added > as a subscriber? I don't think it's sufficient to just "add" it as a > subscriber after the fact, I think it has to be done as

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120629. hintonda added a comment. - Remove whitespace. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.py @@ -0,0 +

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120628. hintonda added a comment. - Add support for individual DiagID's, and print out number of breakpoints added. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120538. hintonda added a comment. - Add ability to add breakpoints matching -W warnings. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/nul

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120518. hintonda added a comment. - Maintain process id map for diagtool. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/cla

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Is there a way to associate a particular diagtool variable to an exe_ctx? https://reviews.llvm.org/D36347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120492. hintonda added a comment. - Remove debugging print statement, and enhance help message. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. In https://reviews.llvm.org/D36347#908186, @zturner wrote: > Do I understand correctly that this will insert breakpoints on *all* clang > diagnostics? That's not necessarily bad, but I was under the impression > originally that it would let you pick the diagnostics yo

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120459. hintonda added a comment. - Enhance diagtool option to check, reset, print out current value. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py ===

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Thanks for the feedback (addressed below). btw, where should this module go? Since it's intended for clang, and clang based tool, developers, I put it in `clang/utils`, but Zackery suggested `lldb/examples/python` might be a better place. Please let me know if anyone

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120360. hintonda added a comment. - Add diagtool option used to set arbitrary diagtool path. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added inline comments. Comment at: utils/clangdiag.py:83 +# Remove all diag breakpoints. +bkpts = lldb.SBBreakpointList(target) +target.FindBreakpointsByName("clang::Diagnostic", bkpts) Can't use iterator because it gets invalidated and not a

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120340. hintonda edited the summary of this revision. hintonda added a comment. Herald added a subscriber: ilya-biryukov. - Addressed comments. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py =

[Lldb-commits] [PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Thanks for the quick feedback. I'll make all you suggested changes, but need to think a little more about `diagtool`. Comment at: utils/clangdiag.py:75-78 +diagtool = os.path.join(exe.GetDirectory(), 'diagtool') +if not os.path.exists(diagtoo

[Lldb-commits] [PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda updated this revision to Diff 120308. hintonda added a comment. Reimplement at a python module. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.p

[Lldb-commits] [PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda added a comment. Thanks for all the feedback. I'll report back once I've addressed all your suggestions. Thanks again... https://reviews.llvm.org/D36347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda added a comment. In https://reviews.llvm.org/D36347#901885, @zturner wrote: > One possible reason for why this never got any traction is that > `lldb-commits` wasn't added as a subscriber. While it's true that the tagged > people should have chimed in, having the whole commits list wi