hintonda added a comment. In https://reviews.llvm.org/D39436#911264, @jingham wrote:
> Zachary's suggestion is better than adding regex patterns to FileSpec, but I > still don't like the idea of encoding option types in the option values. Are you talking about fnmatch? Is that portable? If not, i can rewrite it,. > Moreover, this doesn't really apply to the main use of -f - file & line > breakpoints. The only plausible use for a source file filter for file & line > breakpoints is when you want to restrict breaking on inlined code to a subset > of the files that inline it. But in that case you would want a separate > option, since you need to specify the inlined file = with the -f option - and > the inlining files - with some other option. > > Wouldn't it be better to add a --source-file-regex option, pick some free > single letter, and use that if you want to provide a pattern for the "-p" > breakpoint option. Then we could also use it when specifying some other file > filter. This is valid for all breakpoints, not just those created via the '-p' option. I can gen up patch that add `--source-file-regex` to all breakpoints, but I also want to use it from python, so that api change might be problematic -- can we add additional default parameters without breaking ABI? Btw, here's an example of how I want to use it -- cuts time to create breakpoint by over half, from 15 seconds down to 7 -- which makes my clangdiag module load much faster: br s -n "DiagnosticsEngine::Report" -f "regex:.*/clang/.*" https://reviews.llvm.org/D39436 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
