[Lldb-commits] [clang] [lldb] [C++20][Modules] Do not update the generation number if the redeclaration chain completion was delayed. (PR #129982)

2025-03-07 Thread Michael Park via lldb-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Docstrings] Fix some poorly formatted Docstrings (PR #129605)

2025-03-07 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/129605 >From 6c8f3ee0b033917213c802ddd978c63f8947616b Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 3 Mar 2025 15:12:29 -0800 Subject: [PATCH 1/2] Drop markdown backticks for codeblock --- lldb/bindings/int

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

2025-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/117500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 61efe36 - [lldb] Avoid unnecessary regex check in dwim-print (#114608)

2025-03-07 Thread via lldb-commits
Author: Dave Lee Date: 2025-03-07T21:57:05-08:00 New Revision: 61efe360f9ba70736ca27ad289277c5c8268ffc0 URL: https://github.com/llvm/llvm-project/commit/61efe360f9ba70736ca27ad289277c5c8268ffc0 DIFF: https://github.com/llvm/llvm-project/commit/61efe360f9ba70736ca27ad289277c5c8268ffc0.diff LOG:

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread via lldb-commits
dyung wrote: @anjenner The unittest you added at `unittests/Support/Caching.cpp` seems to be randomly failing on a Windows bot: - https://lab.llvm.org/buildbot/#/builders/46/builds/13196 - https://lab.llvm.org/buildbot/#/builders/46/builds/13202 - https://lab.llvm.org/buildbot/#/builders/46/buil

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread Teresa Johnson via lldb-commits
teresajohnson wrote: @anjenner are you looking at the remaining reported buildbot failures? E.g. the unit testing failure below. Please fix or revert this change. > LLVM Buildbot has detected a new failure on builder > `llvm-nvptx-nvidia-ubuntu` running on `as-builder-7` while building > `lld

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/114608 >From a974b175a67a40fbf1f9a422731be3771734a357 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 1 Nov 2024 14:38:19 -0700 Subject: [PATCH] [lldb] Avoid unnecessary regex check in dwim-print --- lldb/sour

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/15] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS for macOS configuration (PR #130381)

2025-03-07 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer edited https://github.com/llvm/llvm-project/pull/130381 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS to build.rst for macOS configuration (PR #130381)

2025-03-07 Thread via lldb-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS to build.rst for macOS configuration (PR #130381)

2025-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Julius Alexandre (wizardengineer) Changes Referenced here: https://github.com/llvm/llvm-project/issues/130171#issuecomment-2707058235 I think this will allow for issues relating towards missing modules for test suites to be more manageabl

[Lldb-commits] [lldb] [lldb][docs] Added LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS to build.rst for macOS configuration (PR #130381)

2025-03-07 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer created https://github.com/llvm/llvm-project/pull/130381 Referenced here: https://github.com/llvm/llvm-project/issues/130171#issuecomment-2707058235 I think this will allow for issues relating towards missing modules for test suites to be more manageable. cc

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/14] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5bc166728abe3c80a271d3883d12805161b96335 e1c631e49474027c65fc8f14a0d6baafbbf704be --e

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/114608 >From e1c631e49474027c65fc8f14a0d6baafbbf704be Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 1 Nov 2024 14:38:19 -0700 Subject: [PATCH] [lldb] Avoid unnecessary regex check in dwim-print --- lldb/sour

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/114608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid unnecessary regex check in dwim-print (PR #114608)

2025-03-07 Thread Dave Lee via lldb-commits
kastiglione wrote: @adrian-prantl @JDevlieghere I'm going to merge this, since this change improves performance and doesn't introduce the logic being discussed. I'm happy to do a follow up, but it's still unclear to me what exactly that looks like. https://github.com/llvm/llvm-project/pull/114

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -65,6 +65,19 @@ This will attach to a process `a.out` whose process ID is 123: } ``` +You can also use the variable substituion `${command:PickProcess}` to select a +process at the start of the debug session instead of setting the pid manually: + +```javascript +{ + "type

[Lldb-commits] [clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-07 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/129868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8eec3d7 - [lldb][tests] Add ability to run API tests with qemu-user simulator (#89765)

2025-03-07 Thread via lldb-commits
Author: ita-sc Date: 2025-03-06T09:57:03Z New Revision: 8eec3d77a93aa3111426a2988fc0a3ac927899a0 URL: https://github.com/llvm/llvm-project/commit/8eec3d77a93aa3111426a2988fc0a3ac927899a0 DIFF: https://github.com/llvm/llvm-project/commit/8eec3d77a93aa3111426a2988fc0a3ac927899a0.diff LOG: [lldb]

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -162,6 +171,13 @@ "type": "string", "markdownDescription": "The absolute path to the LLDB debug adapter executable to use." }, + "debugAdapterArgs": { +"type": "array", +"items": { +

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-07 Thread via lldb-commits
@@ -969,12 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } -static uint64_t -GetLargestRangeSize(const std::vector &ranges) { - uint64_t max_size = 0; - for (const auto &core_range : ranges) -max_size = std::max(max_size, core_range.ran

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-07 Thread via lldb-commits
@@ -969,6 +969,84 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/10] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/13] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/12] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-07 Thread David Peixotto via lldb-commits
https://github.com/dmpots updated https://github.com/llvm/llvm-project/pull/129593 >From bca07d83152df179f7784d0003262fa54834 Mon Sep 17 00:00:00 2001 From: David Peixotto Date: Wed, 26 Feb 2025 13:55:35 -0800 Subject: [PATCH 1/5] Avoid force loading symbol files in statistics collection T

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-07 Thread David Peixotto via lldb-commits
@@ -718,3 +720,40 @@ TEST_F(SymtabTest, TestDecodeCStringMaps) { Symtab::eVisibilityAny); ASSERT_NE(symbol, nullptr); } + +TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { + auto ExpectedFile = TestFile::fromYaml(R"( +--- !ELF

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/11] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 01/10] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb] Remove progress report coalescing (PR #130329)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/130329 >From b3055ce5680f22f9b044f8653e39ce625527e6ba Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 7 Mar 2025 10:52:36 -0800 Subject: [PATCH 1/2] [lldb] Remove progress report coalescing Remove sup

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien edited https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-07 Thread Greg Clayton via lldb-commits
@@ -718,3 +720,40 @@ TEST_F(SymtabTest, TestDecodeCStringMaps) { Symtab::eVisibilityAny); ASSERT_NE(symbol, nullptr); } + +TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { + auto ExpectedFile = TestFile::fromYaml(R"( +--- !ELF

[Lldb-commits] [lldb] Add complete ObjectFileJSON support for sections. (PR #129916)

2025-03-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/129916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbol files in statistics collection (PR #129593)

2025-03-07 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,31 @@ +# RUN: %clang_host -g %S/Inputs/main.c -o %t-main.exe + +# When we enable symbol preload and dump stats there should be a non-zero +# time for parsing symbol tables for the main module. +# RUN: %lldb %t-main.exe \ +# RUN: -O "settings set plugin.jit-loader.

[Lldb-commits] [lldb] 8ac359b - Add complete ObjectFileJSON support for sections. (#129916)

2025-03-07 Thread via lldb-commits
Author: Greg Clayton Date: 2025-03-07T15:34:27-08:00 New Revision: 8ac359ba0d7ec1f1e7334a50405f0f20983b997a URL: https://github.com/llvm/llvm-project/commit/8ac359ba0d7ec1f1e7334a50405f0f20983b997a DIFF: https://github.com/llvm/llvm-project/commit/8ac359ba0d7ec1f1e7334a50405f0f20983b997a.diff

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien edited https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add complete ObjectFileJSON support for sections. (PR #129916)

2025-03-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 024362f413dbfcf8188003762c9cc299f274d76e...48fec8f9fd6fd19426943f0daf3eb6fcaf6fe8f0 lldb/

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/129262 >From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Fri, 28 Feb 2025 11:08:25 -0500 Subject: [PATCH 1/6] allow providing debug adapter arguments --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: I have an idea for using lldb's process list logic, although it's a bit of code. 1. Don't use `"${command:pickProcess}"` at all. We need to bypass the regular command logic. You could use a wildcard like `${pickProcess}`. 2. In the debug config resolution logic, which is

[Lldb-commits] [lldb] Add complete ObjectFileJSON support for sections. (PR #129916)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/129916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add complete ObjectFileJSON support for sections. (PR #129916)

2025-03-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/129916 >From 150bbe0d8c3e2fb4e2dd324a0d9080a462eda156 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Wed, 5 Mar 2025 11:21:40 -0800 Subject: [PATCH 1/2] Add complete ObjectFileJSON support for sections. Sections n

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Walter Erquinigo via lldb-commits
@@ -66,19 +70,17 @@ async function findDAPExecutable(): Promise { } async function getDAPExecutable( - session: vscode.DebugSession, + folder: vscode.WorkspaceFolder | undefined, walter-erquinigo wrote: call this workspaceFolder because this is not any fold

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { -...executable?.options?.env, ...configEnvironment, ...env, }, }; -const dbgArgs = executable?.args ?? []; matthewbastie

[Lldb-commits] [lldb] [lldb][lldb-dap] Return optional from json utils (PR #129919)

2025-03-07 Thread Walter Erquinigo via lldb-commits
@@ -13,8 +13,8 @@ using namespace lldb_dap; BreakpointBase::BreakpointBase(DAP &d, const llvm::json::Object &obj) -: dap(d), condition(std::string(GetString(obj, "condition"))), - hitCondition(std::string(GetString(obj, "hitCondition"))) {} +: dap(d), condition(st

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/129262 >From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Fri, 28 Feb 2025 11:08:25 -0500 Subject: [PATCH 1/5] allow providing debug adapter arguments --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { -...executable?.options?.env, ...configEnvironment, ...env, }, }; -const dbgArgs = executable?.args ?? []; +const dbgArgs = getDAPArg

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { -...executable?.options?.env, ...configEnvironment, ...env, }, }; -const dbgArgs = executable?.args ?? []; +const dbgArgs = getDAPArg

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien edited https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -93,13 +93,33 @@ async function getDAPExecutable( return undefined; } +function getDAPArguments(session: vscode.DebugSession): string[] { + // Check the debug configuration for arguments first + const debugConfigArgs = session.configuration.debugAdapterArgs; + if ( +

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/129262 >From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Fri, 28 Feb 2025 11:08:25 -0500 Subject: [PATCH 1/4] allow providing debug adapter arguments --- lldb/

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `lldb,llvm` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/2433 Here is the relevant piece of the build l

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `lldb,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2436 Here is the relevan

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-07 Thread David Spickett via lldb-commits
@@ -292,6 +292,13 @@ def create_parser(): metavar="platform-working-dir", help="The directory to use on the remote platform.", ) +group.add_argument( +"--platform-available-ports", +dest="lldb_platform_available_ports", +type=lamb

[Lldb-commits] [lldb] [lldb-dap] Adding support for well typed events. (PR #130104)

2025-03-07 Thread Adrian Vogelsgesang via lldb-commits
@@ -316,6 +316,36 @@ struct Source { bool fromJSON(const llvm::json::Value &, Source &, llvm::json::Path); llvm::json::Value toJSON(const Source &); +// MARK: Events + +// "ExitedEvent": { +// "allOf": [ { "$ref": "#/definitions/Event" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-07 Thread David Peixotto via lldb-commits
dmpots wrote: I looked into why this test (and TestGdbRemoteFork.py) is so slow. Turns out its nothing related to lldb itself, but the build step that occurs as part of the test. These tests methods pretty much all call to `build()` (directly or indirectly) https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb][test] Skip libsanitizers tests for now (PR #130305)

2025-03-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/130305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6cc8b0b - [lldb][test] Skip libsanitizers tests for now (#130305)

2025-03-07 Thread via lldb-commits
Author: Michael Buch Date: 2025-03-07T21:04:24Z New Revision: 6cc8b0bef07f4270303bec0fc203f251a2fde262 URL: https://github.com/llvm/llvm-project/commit/6cc8b0bef07f4270303bec0fc203f251a2fde262 DIFF: https://github.com/llvm/llvm-project/commit/6cc8b0bef07f4270303bec0fc203f251a2fde262.diff LOG:

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `lldb,llvm` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/5513 Here is the relevan

[Lldb-commits] [lldb] [lldb] Remove progress report coalescing (PR #130329)

2025-03-07 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Makes sense, I also figured it could be restored from history if needed if we're not keeping it around, thanks for explaining! https://github.com/llvm/llvm-project/pull/130329 ___ lldb-commits ma

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-07 Thread Adrian Vogelsgesang via lldb-commits
@@ -137,53 +157,59 @@ export class LLDBDapDescriptorFactory const dbgOptions = { env: { -...executable?.options?.env, ...configEnvironment, ...env, }, }; -const dbgArgs = executable?.args ?? []; vogelsgesang

[Lldb-commits] [lldb] [lldb] Remove progress report coalescing (PR #130329)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/130329 Remove support for coalescing progress reports in LLDB. This functionality was motivated by Xcode, which wanted to listen for less frequent, aggregated progress events at the cost of losing some detail. Se

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in { Global, DefaultStringValue<"${ansi.normal}">, Desc<"When displaying progress in a color-enabled terminal, use the ANSI terminal code specified in this format immediately after the progress message.">; + def Sh

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-win` running on `as-builder-8` while building `lldb,llvm` at step 7 "test-build-unified-tree-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/155/builds/7284 Here is t

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for taking the time to review and try this out, @DavidSpickett! > I will find this out looking at the code shortly, but - does this mean that > if you disable the statusline, you get the current progress reporting > implementation, or no progress reporting at all?

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-nvptx-nvidia-ubuntu` running on `as-builder-7` while building `lldb,llvm` at step 6 "test-build-unified-tree-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/14226 Here is

[Lldb-commits] [lldb] [lldb][test] Skip libsanitizers tests for now (PR #130305)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Greg Clayton via lldb-commits
clayborg wrote: > > Is there a way we can use the LLDB platform layer to pick processes? > > See discussion further up in the thread ([first > comment](https://github.com/llvm/llvm-project/pull/128943#issuecomment-2686308012) > and follow-up messages). It seems the [final > blocker](https://g

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-07 Thread via lldb-commits
https://github.com/anjenner closed https://github.com/llvm/llvm-project/pull/115331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ce9e1d3 - Modify the localCache API to require an explicit commit on CachedFile… (#115331)

2025-03-07 Thread via lldb-commits
Author: anjenner Date: 2025-03-07T17:58:36Z New Revision: ce9e1d3c15ed6290f1cb07b482939976fa8115cd URL: https://github.com/llvm/llvm-project/commit/ce9e1d3c15ed6290f1cb07b482939976fa8115cd DIFF: https://github.com/llvm/llvm-project/commit/ce9e1d3c15ed6290f1cb07b482939976fa8115cd.diff LOG: Modi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
@@ -243,6 +243,19 @@ Status Debugger::SetPropertyValue(const ExecutionContext *exe_ctx, // Prompt colors changed. Ping the prompt so it can reset the ansi // terminal codes. SetPrompt(GetPrompt()); +} else if (property_path == + g_debugger_p

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/128943 >From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Wed, 26 Feb 2025 11:18:21 -0500 Subject: [PATCH 01/23] add a process picker for attaching by PID --- l

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/128943 >From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Wed, 26 Feb 2025 11:18:21 -0500 Subject: [PATCH 01/21] add a process picker for attaching by PID --- l

[Lldb-commits] [lldb] [LLDB][Telemetry]Define telemetry::CommandInfo (PR #129354)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129354 >From 5a992aff351a93ff820d15ace3ebc2bea59dd5fc Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Fri, 28 Feb 2025 23:03:35 -0500 Subject: [PATCH 01/23] [LLDB][Telemetry]Defind telemetry::CommandInfo and collect te

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined { export class LLDBDapConfigurationProvider implements vscode.DebugConfigurationProvider { + resolveDebugConfiguration( +_folder: vscode.WorkspaceFolder | undefined, +debugConfiguration: vsc

[Lldb-commits] [lldb] [lldb][test] Skip libsanitizers tests for now (PR #130305)

2025-03-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/130305 These are macOS tests only and are currently failing on the x86_64 CI and on arm64 on recent versions of macOS/Xcode. The tests are failing because we're stopping in: ``` Process 17458 stopped * thread #1: t

[Lldb-commits] [lldb] [LLDB][Docstrings] Fix some poorly formatted Docstrings (PR #129605)

2025-03-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Is there a good place to add a blurb about these swig gotcha's? Maybe a `.md` > in `bindings/swig`? That's a great question. There's a lot of institutional knowledge about how SWIG is used in LLDB that hasn't been written down. I think it'd be worth it to have a page on

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined { export class LLDBDapConfigurationProvider implements vscode.DebugConfigurationProvider { + resolveDebugConfiguration( +_folder: vscode.WorkspaceFolder | undefined, +debugConfiguration: vsc

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/128943 >From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Wed, 26 Feb 2025 11:18:21 -0500 Subject: [PATCH 01/20] add a process picker for attaching by PID --- l

[Lldb-commits] [lldb] [lldb][test] Skip libsanitizers tests for now (PR #130305)

2025-03-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes These are macOS tests only and are currently failing on the x86_64 CI and on arm64 on recent versions of macOS/Xcode. The tests are failing because we're stopping in: ``` Process 17458 stopped * thread #1:

[Lldb-commits] [lldb] [lldb][test] Skip libsanitizers tests for now (PR #130305)

2025-03-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/130305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I was going to bikeshed (or indeed bike shed) "statusline" vs. "status line" but I see that NeoVim spells it this way. That's popular already, so one word is fine with me. Going to try this locally now. https://github.com/llvm/llvm-project/pull/1218

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-03-07 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127834 >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH 1/9] [LLDB][Telemetry]Define TargetInfo for collecting data about a

[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

2025-03-07 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/129964 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,171 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -1925,6 +1959,17 @@ void Debugger::CancelForwardEvents(const ListenerSP &listener_sp) { m_forward_listener_sp.reset(); } +bool Debugger::StatuslineSupported() { + if (GetShowStatusline()) { +if (lldb::LockableStreamFileSP stream_sp = GetOutputStreamSP()) { + Fi

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/128943 >From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Wed, 26 Feb 2025 11:18:21 -0500 Subject: [PATCH 01/11] add a process picker for attaching by PID --- l

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
@@ -0,0 +1,42 @@ +import * as path from "path"; +import * as vscode from "vscode"; +import { createProcessTree } from "../process-tree"; + +interface ProcessQuickPick extends vscode.QuickPickItem { + processId: number; +} + +/** + * Prompts the user to select a running process. +

[Lldb-commits] [lldb] [lldb-dap] Restore the override FD used by the output redirect on stop. (PR #129964)

2025-03-07 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/14956 Here is the relevant

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: I had to try some Unicode of course. I think you have a TODO in there about this already but just because it was fun... ``` >>> "東".encode() b'\xe6\x9d\xb1' >>> "a".encode() b'a' ``` I can get way more 'a' before I get the '...' than '東'. Same for an emoji, which is a more

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-07 Thread David Spickett via lldb-commits
@@ -243,6 +243,19 @@ Status Debugger::SetPropertyValue(const ExecutionContext *exe_ctx, // Prompt colors changed. Ping the prompt so it can reset the ansi // terminal codes. SetPrompt(GetPrompt()); +} else if (property_path == + g_debugger_p

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/128943 >From b9083ea16c7b1dba70cc04acf78f5001f0fb86c6 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Wed, 26 Feb 2025 11:18:21 -0500 Subject: [PATCH 01/17] add a process picker for attaching by PID --- l

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread via lldb-commits
https://github.com/Da-Viper requested changes to this pull request. https://github.com/llvm/llvm-project/pull/128943 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread via lldb-commits
@@ -34,6 +34,23 @@ function convertToInteger(value: any): number | undefined { export class LLDBDapConfigurationProvider implements vscode.DebugConfigurationProvider { + resolveDebugConfiguration( +_folder: vscode.WorkspaceFolder | undefined, +debugConfiguration: vsc

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-07 Thread via lldb-commits
@@ -0,0 +1,57 @@ +import * as path from "path"; +import * as vscode from "vscode"; +import { createProcessTree } from "../process-tree"; + +interface ProcessQuickPick extends vscode.QuickPickItem { + processId?: number; +} + +/** + * Prompts the user to select a running process.

  1   2   >