[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg updated this revision to Diff 463102. clayborg added a comment. Don't constify SBError::GetCString anymore. We can fix this in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 Files

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

clayborg added a comment. In D134333#3812653 , @jingham wrote: > In D134333#3812448 , @clayborg > wrote: > >> I just did a search through our test sources and we use >> GetError().GetCString() 34 times in our te

[Lldb-commits] [lldb] 79e522f - Revert "Skip crashing test"

Author: Adrian Prantl Date: 2022-09-26T17:17:47-07:00 New Revision: 79e522fb44e1761e5ad90835f95c5dadcf8d8406 URL: https://github.com/llvm/llvm-project/commit/79e522fb44e1761e5ad90835f95c5dadcf8d8406 DIFF: https://github.com/llvm/llvm-project/commit/79e522fb44e1761e5ad90835f95c5dadcf8d8406.diff

[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added a comment. In D133858#3805630 , @labath wrote: > I am afraid that this patch misses one method of initiating a debug session > -- connecting to a running debug server (`process connect`, > `SBTarget::ConnectRemote`). The breakpoint hit co

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. In D133036#3816002 , @aeubanks wrote: > @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? attempt in https://reviews.llvm.org/D134669 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. @vitalybuka can we turn on -fsanitize-memory-param-retval by default upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ lld

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

mstorsjo added a comment. In D134037#3815240 , @DavidSpickett wrote: >> I might add the AArch64 and Arm equivalent if I have some spare time. > > I looked into this and there's a detail that makes this work on x86 only. So > I'll leave it as is, it's ge

[Lldb-commits] [PATCH] D134574: [lldb][test] 2 - Add gmodules test category explicitly where previously done implicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c6826e8fc6d: [lldb][test] 2 - Add gmodules test category explicitly where previously done… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D134524: [lldb][test] 1 - Don't do test-replication for gmodules debug_info variant

This revision was automatically updated to reflect the committed changes. Closed by commit rG12502ee55123: [lldb][test] 1 - Don't do test-replication for gmodules debug_info variant (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 1c6826e - [lldb][test] 2 - Add gmodules test category explicitly where previously done implicitly

Author: Michael Buch Date: 2022-09-26T19:54:24+01:00 New Revision: 1c6826e8fc6d5c47c3573efd8d080939a932 URL: https://github.com/llvm/llvm-project/commit/1c6826e8fc6d5c47c3573efd8d080939a932 DIFF: https://github.com/llvm/llvm-project/commit/1c6826e8fc6d5c47c3573efd8d080939a932.diff

[Lldb-commits] [lldb] 12502ee - [lldb][test] 1 - Don't do test-replication for gmodules debug_info variant

Author: Michael Buch Date: 2022-09-26T19:54:24+01:00 New Revision: 12502ee551236375516b714cfdfb75d85b3b7e3e URL: https://github.com/llvm/llvm-project/commit/12502ee551236375516b714cfdfb75d85b3b7e3e DIFF: https://github.com/llvm/llvm-project/commit/12502ee551236375516b714cfdfb75d85b3b7e3e.diff

[Lldb-commits] [PATCH] D134661: [lldb][TypeSystemClang] Honor DW_AT_rvalue_reference when creating C++ FunctionPrototypes

Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently funciton lookup in the express

[Lldb-commits] [lldb] c418f00 - [lldb] Fix completion of 'settings set' values

Author: Dave Lee Date: 2022-09-26T11:26:13-07:00 New Revision: c418f00536001169f40d09bf3bff568aacfc9c30 URL: https://github.com/llvm/llvm-project/commit/c418f00536001169f40d09bf3bff568aacfc9c30 DIFF: https://github.com/llvm/llvm-project/commit/c418f00536001169f40d09bf3bff568aacfc9c30.diff LOG:

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

This revision was automatically updated to reflect the committed changes. Closed by commit rGc418f0053600: [lldb] Fix completion of 'settings set' values (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134515/new/ https://re

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

jasonmolenda added a comment. In D134581#3813757 , @alvinhochun wrote: > Thanks for the comment. > > In D134581#3813484 , @jasonmolenda > wrote: > >> I probably misunderstand the situation DynamicLoaderWindows f

[Lldb-commits] [PATCH] D134645: [lldb] Skip tests incompatible with older versions of Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG10a35632d55b: [lldb] Skip tests incompatible with older versions of Clang (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134645/new/

[Lldb-commits] [lldb] 10a3563 - [lldb] Skip tests incompatible with older versions of Clang

Author: Felipe de Azevedo Piovezan Date: 2022-09-26T13:27:51-04:00 New Revision: 10a35632d55bb05004fe3d0c2d4432bb74897ee7 URL: https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb74897ee7 DIFF: https://github.com/llvm/llvm-project/commit/10a35632d55bb05004fe3d0c2d4432bb7

[Lldb-commits] [PATCH] D134656: [LLDB][NativePDB] Add class/union layout bit size.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Missing it causes lldb to crash or give incorrect result. Repository: rG LLVM G

[Lldb-commits] [PATCH] D134574: [lldb][test] 2 - Add gmodules test category explicitly where previously done implicitly

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134574/new/ https://reviews.llvm.org/D134574 __

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

DavidSpickett added a comment. > I might add the AArch64 and Arm equivalent if I have some spare time. I looked into this and there's a detail that makes this work on x86 only. So I'll leave it as is, it's getting tested somewhere, and that's what matters. If you're curious this is the spanner

[Lldb-commits] [PATCH] D134645: [lldb] Skip tests incompatible with older versions of Clang

fdeazeve created this revision. fdeazeve added a reviewer: aprantl. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The coroutine tests require a standard library implementation of coroutines, which was

[Lldb-commits] [PATCH] D134642: Propagate FORK events back to client

irinasha created this revision. Herald added a subscriber: emaste. Herald added a project: All. irinasha requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We want to allow the client to detect when the process forks and to attach the debugge

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

Michael137 added a comment. In D134493#3814761 , @werat wrote: > In D134493#3811253 , @labath wrote: > >> lol, I knew about the last two parts (not that I agree with them, but I >> think we have about an equal am

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

werat added a comment. In D134493#3811253 , @labath wrote: > lol, I knew about the last two parts (not that I agree with them, but I think > we have about an equal amount of code which relies on it, and that which > tries to work around it), but the fir

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

mstorsjo added a reviewer: jasonmolenda. mstorsjo added a subscriber: jasonmolenda. mstorsjo added a comment. The test runs fine on Windows, but I'm not familiar with these aspects of lldb to (yet) have a good opinion on it; adding @jasonmolenda to the review who commented on the previous one to

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun added a comment. In D134581#3813757 , @alvinhochun wrote: > In D134581#3813484 , @jasonmolenda > wrote: > >> I probably misunderstand the situation DynamicLoaderWindows finds itself in, >> but in Dy

[Lldb-commits] [PATCH] D134636: [lldb][Windows] Always call SetExecutableModule on debugger connected

alvinhochun created this revision. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In `ProcessWindows::OnDebuggerConnected` (triggered from `CREATE_PROCESS_DEBUG_EVENT`), we should always call `Targe

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun updated this revision to Diff 462860. alvinhochun added a comment. Fixed test again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134581/new/ https://reviews.llvm.org/D134581 Files: lldb/source/Target/Target.cpp lldb/test/Shell/Tar

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll \ +# RUN: %if windows-msvc %{-Wl,-implib:%t.shlib.lib} \ +# RUN: %else %{-Wl,--

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun updated this revision to Diff 462858. alvinhochun added a comment. Updated test, thanks to @mstorsjo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134581/new/ https://reviews.llvm.org/D134581 Files: lldb/source/Target/Target.cpp ll

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#before"

[Lldb-commits] [lldb] 0e91241 - [LLDB] Add an llvm::Optional version of GetRegisterInfo

Author: David Spickett Date: 2022-09-26T10:54:34Z New Revision: 0e912417c67db2dc32d32c98213dba42b9b607a6 URL: https://github.com/llvm/llvm-project/commit/0e912417c67db2dc32d32c98213dba42b9b607a6 DIFF: https://github.com/llvm/llvm-project/commit/0e912417c67db2dc32d32c98213dba42b9b607a6.diff LOG

[Lldb-commits] [PATCH] D134536: [LLDB] Add an llvm::Optional version of GetRegisterInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e912417c67d: [LLDB] Add an llvm::Optional version of GetRegisterInfo (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134536/new/

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#befor

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#before"

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#before"

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#befor

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

alvinhochun added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#befor

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Would help if I actually clicked the buttons yes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#before"

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. In D134585#3814463 , @DavidSpickett wrote: >> MSVC/link.exe doesn't write symbols into linked PE images at all. > > So by the time we get to a debugger, it's not an issue anyway. Yep, most of these patches about symbol table ha

[Lldb-commits] [PATCH] D134581: [lldb] Prevent re-adding a module that is already loaded

mstorsjo added inline comments. Comment at: lldb/test/Shell/Target/dependent-modules-nodupe-windows.test:7 +# RUN: %clang_host -g0 -O0 -shared %S/Inputs/shlib.c -o %t.shlib.dll +# RUN: %clang_host -g0 -O0 %S/Inputs/main.c %t.shlib.dll -o %t.main.exe +# RUN: %lldb -b -o "#before"

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. > MSVC/link.exe doesn't write symbols into linked PE images at all. So by the time we get to a debugger, it's not an issue anyway. Then this LGTM. Thanks for all these improvements btw, I expect Linaro's Windows on Arm efforts appreciate them too. Repository:

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. In D134585#3814458 , @DavidSpickett wrote: > You're the expert on what the linker does and the code looks fine. > > Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way > that could cause a problem? Wors

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

DavidSpickett added a comment. You're the expert on what the linker does and the code looks fine. Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way that could cause a problem? Worst that happens is we get a bunch of symbols available in expressions that shouldn't be?

[Lldb-commits] [PATCH] D134515: [lldb] Fix completion of 'settings set' values

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134515/new/ https://reviews.llvm.org/D134515

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a3597d73c8f: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D134037?vs=462454&id=462836#toc

[Lldb-commits] [lldb] 8a3597d - [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

Author: Martin Storsjö Date: 2022-09-26T11:05:42+03:00 New Revision: 8a3597d73c8f694ca8c991d8cb4bb97a4ac8ba8c URL: https://github.com/llvm/llvm-project/commit/8a3597d73c8f694ca8c991d8cb4bb97a4ac8ba8c DIFF: https://github.com/llvm/llvm-project/commit/8a3597d73c8f694ca8c991d8cb4bb97a4ac8ba8c.diff

[Lldb-commits] [PATCH] D134037: [lldb] Fix CommandInterpreter::DidProcessStopAbnormally() with multiple threads

mstorsjo added inline comments. Comment at: lldb/test/Shell/Driver/CommandOnCrashMultiThreaded.test:1 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) DavidSpickett wrote: > mstorsjo wrote: > > DavidSpickett wrote: > > > Isn't this fi

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D134585: [lldb][COFF] Map symbols without base+complex type as 'Data' type

mstorsjo added a comment. This LGTM, but I'll leave it to some LLDB maintainer to formally approve. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/ https://reviews.llvm.org/D134585 ___ lldb-com