[Lldb-commits] [PATCH] D134645: [lldb] Skip tests incompatible with older versions of Clang

[Felipe de Azevedo Piovezan via Phabricator via lldb-commits]

fdeazeve created this revision.
fdeazeve added a reviewer: aprantl.
Herald added a project: All.
fdeazeve requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

The coroutine tests require a standard library implementation of
coroutines, which was only made available some time _after_ Clang 13.
The first such Clang tested by the LLDB matrix bot is 15.0.1

The TestObjCExceptions test forces the use of the system's libcxx. For
the lldb matrix bot, the first Clang version compatible with the bot's
libraries is 13.0.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134645

Files:
  
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
  lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py


Index: lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
===================================================================
--- lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
+++ lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
@@ -13,6 +13,7 @@
 
 class ObjCExceptionsTestCase(TestBase):
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_throw(self):
         self.build()
 
@@ -123,6 +124,7 @@
         for n in ["objc_exception_throw", "foo(int)", "main"]:
             self.assertIn(n, names, "%s is in the exception backtrace (%s)" % 
(n, names))
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_abort(self):
         self.build()
 
@@ -179,6 +181,7 @@
         for n in ["objc_exception_throw", "foo(int)", "rethrow(int)", "main"]:
             self.assertEqual(len([f for f in history_thread.frames if 
f.GetFunctionName() == n]), 1)
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_cxx_exceptions_at_abort(self):
         self.build()
 
Index: 
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
===================================================================
--- 
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
+++ 
lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
@@ -79,5 +79,6 @@
         self.do_test(USE_LIBSTDCPP)
 
     @add_test_categories(["libc++"])
+    @skipIf(compiler="clang", compiler_version=['<', '15.0'])
     def test_libcpp(self):
         self.do_test(USE_LIBCPP)



Index: lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
===================================================================
--- lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
+++ lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
@@ -13,6 +13,7 @@
 
 class ObjCExceptionsTestCase(TestBase):
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_throw(self):
         self.build()
 
@@ -123,6 +124,7 @@
         for n in ["objc_exception_throw", "foo(int)", "main"]:
             self.assertIn(n, names, "%s is in the exception backtrace (%s)" % (n, names))
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_objc_exceptions_at_abort(self):
         self.build()
 
@@ -179,6 +181,7 @@
         for n in ["objc_exception_throw", "foo(int)", "rethrow(int)", "main"]:
             self.assertEqual(len([f for f in history_thread.frames if f.GetFunctionName() == n]), 1)
 
+    @skipIf(compiler="clang", compiler_version=['<', '13.0'])
     def test_cxx_exceptions_at_abort(self):
         self.build()
 
Index: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
===================================================================
--- lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
+++ lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/coroutine_handle/TestCoroutineHandle.py
@@ -79,5 +79,6 @@
         self.do_test(USE_LIBSTDCPP)
 
     @add_test_categories(["libc++"])
+    @skipIf(compiler="clang", compiler_version=['<', '15.0'])
     def test_libcpp(self):
         self.do_test(USE_LIBCPP)

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits