mstorsjo added a comment. In D134585#3814458 <https://reviews.llvm.org/D134585#3814458>, @DavidSpickett wrote:
> You're the expert on what the linker does and the code looks fine. > > Is it possible that msvc uses these `IMAGE_SYM_TYPE_NULL` in a different way > that could cause a problem? Worst that happens is we get a bunch of symbols > available in expressions that shouldn't be? MSVC/link.exe doesn't write symbols into linked PE images at all. But at the object file stage, they do express data symbols in the same way (which is the default marking for symbols that have no other types set). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134585/new/ https://reviews.llvm.org/D134585 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
