mstorsjo added inline comments.
================ Comment at: lldb/test/Shell/Driver/CommandOnCrashMultiThreaded.test:1 +# XFAIL: system-windows +# REQUIRES: native && (target-x86 || target-x86_64) ---------------- DavidSpickett wrote: > mstorsjo wrote: > > DavidSpickett wrote: > > > Isn't this fixing an issue that you saw on Windows as well? > > Yes, that was the place where I observed the issue (as Windows apparently, > > under some circumstances, can have a couple of extra threads running that > > haven't been spawned by the code of the process itself), but it's easily > > reproducible on any platform as long as you make sure there's more than one > > thread running. > > > > I copied the basis for the test from > > `Shell/Register/x86-multithreaded-read.test` - most of the tests there > > under `Shell/Register` seem to have such an XFAIL, not sure exactly why. > > (In this particular test, at least the `-pthread` linker flag might be a > > trivial platform specific difference that might break it, which would need > > to be abstracted somewhere.) > Yeah I didn't notice the pthread flag, that could be it. Makes sense to me. Actually, it turns out that this test does pass on Windows (I hadn't tested before, I had just inherited the XFAIL from the test I based it on) - as `-pthread` isn't a linker flag but a compiler driver flag, the msvc target in clang just does nothing about it. So I'll remove the XFAIL here before pushing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134037/new/ https://reviews.llvm.org/D134037 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
