clayborg updated this revision to Diff 147587.
clayborg added a comment.
- Fixed Pavel's issues
- If user specifies "" as the first directory in PathMappingList, it will match
"."
- User can specify "/" as the first directory to remap all absolute paths
- Fixed FileSpec::IsAbsolute() and added te
labath added a comment.
In https://reviews.llvm.org/D46889#1104882, @aemerson wrote:
> In https://reviews.llvm.org/D46889#1104823, @aprantl wrote:
>
> > Thanks for jumping on this Amara — I just wanted to point out that we
> > ususally don't revert lldb changes that only break the lldb-xcode bot
> On May 18, 2018, at 11:25 AM, Amara Emerson via Phabricator
> wrote:
>
> aemerson added a comment.
>
> In https://reviews.llvm.org/D46889#1104823, @aprantl wrote:
>
>> Thanks for jumping on this Amara — I just wanted to point out that we
>> ususally don't revert lldb changes that only bre
aemerson added a comment.
In https://reviews.llvm.org/D46889#1104823, @aprantl wrote:
> Thanks for jumping on this Amara — I just wanted to point out that we
> ususally don't revert lldb changes that only break the lldb-xcode bot if they
> pass on the lldb-cmake bot at the same time. When this
Thanks for jumping on this Amara — I just wanted to point out that we ususally
don't revert lldb changes that only break the lldb-xcode bot if they pass on
the lldb-cmake bot at the same time. When this happens it usually means that
the lldb Xcode project must be updated and it's too much to ask
aprantl added subscribers: jingham, jasonmolenda, labath.
aprantl added a comment.
Thanks for jumping on this Amara — I just wanted to point out that we ususally
don't revert lldb changes that only break the lldb-xcode bot if they pass on
the lldb-cmake bot at the same time. When this happens it
clayborg added a comment.
I will make the fixes and also test out mapping "" to "." as suggested.
Comment at: source/Target/PathMappingList.cpp:194
+ // path and any path we appended would end up being relative.
+ fixed.SetFile(path_ref, false);
+} else {
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr)
-print("Command invoked: %s" % ' '.join(command), file=sys.stderr)
+print("Reproduce with: lld
aemerson reopened this revision.
aemerson added a comment.
This revision is now accepted and ready to land.
Hi Pavel,
I reverted this in r332730 due to the bot breaking. Please have a look and
commit again when ready.
Thanks,
Amara
Repository:
rL LLVM
https://reviews.llvm.org/D46889
___
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
In https://reviews.llvm.org/D47062#1104558, @davide wrote:
> Can you commit the whitespace fixes separately?
Sure.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAI
aemerson added a comment.
This caused a failure in green dragon:
http://green.lab.llvm.org/green/job/lldb-xcode/6644
Can you please fix or revert this change, thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D46889
___
lldb-commits mailing
aprantl added inline comments.
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr)
-print("Command invoked: %s" % ' '.join(command), file=sys.stderr)
+print("Reproduce with: lld
davide added a comment.
Can you commit the whitespace fixes separately?
Repository:
rL LLVM
https://reviews.llvm.org/D47062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath added inline comments.
Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17
// RUN: FileCheck --check-prefix=EMPTY %s
+//
+// RUN: clang %s -g -c -o %t --target=x86_64-apple-macosx
JDevlieghere wrote:
> `%t.o`?
I prefer %t, as that makes the RUN
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332719: [DWARF] Extract indexing code into a separate class
hierarchy (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D468
Author: labath
Date: Fri May 18 07:15:46 2018
New Revision: 332719
URL: http://llvm.org/viewvc/llvm-project?rev=332719&view=rev
Log:
[DWARF] Extract indexing code into a separate class hierarchy
Summary:
This places the `if(m_using_apple_tables)` branches inside the
SymbolFileDWARF class behind a
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lit/SymbolFile/DWARF/find-basic-function.cpp:17
// RUN: FileCheck --check-prefix=EMPTY %s
+//
+// RUN: clang %s -g -c -o %t --target=x86_64-a
labath created this revision.
labath added reviewers: JDevlieghere, clayborg.
Herald added subscribers: ioeric, ilya-biryukov, aprantl.
Now that we are able to parse MachO files everywhere, we can write some
cross-platform tests for handling of apple accelerator tables. This
reruns the same lookup
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, davide, aprantl.
Rather than trying to figure out what arguments to pass to `dotest.py`, suggest
using `lldb-dotest`. Athough this obviously won't work for all invocations
(i.e. when you're passing custom arguments to `lld
Author: labath
Date: Fri May 18 05:54:21 2018
New Revision: 332710
URL: http://llvm.org/viewvc/llvm-project?rev=332710&view=rev
Log:
Add back #ifdef __APPLE__ to
RegisterContextDarwin_xxx::NumSupportedHardwareWatchpoints
It turns out these class still contained some os-specific functionality,
bu
Author: labath
Date: Fri May 18 04:35:46 2018
New Revision: 332702
URL: http://llvm.org/viewvc/llvm-project?rev=332702&view=rev
Log:
Make ObjectFileMachO work on non-darwin platforms
Summary:
Before this patch we were unable to write cross-platform MachO tests
because the parsing code did not com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332702: Make ObjectFileMachO work on non-darwin platforms
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D46934
Files:
lld
labath added a comment.
Although it may not seem that way from the number of comments, the change looks
good to me. The main thing is the moving of the test file, as that will fail in
the cmake build. And it also looks like some code can be simplified if my
assumption about not converting "" to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL332700: Fix _NSCFBoolean data formatter. (authored by
JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47014?vs=147312&id=147449#toc
Repository:
rL LLVM
https://revie
Author: jdevlieghere
Date: Fri May 18 02:14:45 2018
New Revision: 332700
URL: http://llvm.org/viewvc/llvm-project?rev=332700&view=rev
Log:
Fix _NSCFBoolean data formatter.
In r265181 the test for the NSCFBoolean data formatter was removed.
Later, in r279353 and r279446 a new implementation was pr
25 matches
Mail list logo
