aprantl added inline comments.
================
Comment at: packages/Python/lldbsuite/test/dosep.py:122
print("[%s FAILED]%s" % (name, timeout_str), file=sys.stderr)
- print("Command invoked: %s" % ' '.join(command), file=sys.stderr)
+ print("Reproduce with: lldb-dotest -f {}".format(name),
file=sys.stderr)
update_progress(name)
----------------
JDevlieghere wrote:
> aprantl wrote:
> > What do you think about adding the full path to lldb-dotest? I usually have
> > at least three concurrent checkouts of lldb at any time.
> Me too, but how would we get that information here? On of `lldb-dotest`'s
> goals is that you can execute it from anywhere, so you'd either have to pass
> it explicitly to `dotest.py` (either using a custom argument and cmake
> variable combo, or by assuming it lives in the same directory as the current
> lldb and appending `-dotest`) but that feels like it might not be worth it.
> Maybe there's another solution you had in mind?
The --executable option that dotest receives should point to an lldb that ought
to have a matching lldb-dotest next to it. I don't think that that is
particularly ugly.
Repository:
rL LLVM
https://reviews.llvm.org/D47062
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
