Author: jmolenda
Date: Fri Mar 10 00:38:19 2017
New Revision: 297441
URL: http://llvm.org/viewvc/llvm-project?rev=297441&view=rev
Log:
Add a distinction in an apple accelerator table between IsValid and
HasContent. If we have a valid accelerator table which has no
content, we want to depend on th
Author: jmolenda
Date: Thu Mar 9 23:33:27 2017
New Revision: 297440
URL: http://llvm.org/viewvc/llvm-project?rev=297440&view=rev
Log:
Mark this as skipped for now. There is a race condition with
SectionLoadList exposed by this test. Greg tried to chase it down
& got pretty far but the isn't cor
zturner created this revision.
`FileSpec::EnumerateDirectory` has a bunch of platform-specific gunk in it for
posix and non-posix platforms. We can get rid of all this by using LLVM's
easy-to-use directory iterators.
Ideally I would like to just remove this entire `EnumerateDirectory` function
zturner added a comment.
Agree that it will be nice to see this gone. I suspect there is even more
complexity than what you have here that can be removed if we aren't supporting
this, but this seems like a good start.
Comment at: packages/Python/lldbsuite/test/dotest.py:1204
amccarth added inline comments.
Comment at: lldb/source/Commands/CommandCompletions.cpp:108
+ StringList &matches,
+ TildeExpressionResolver *Resolver) {
+ // Use the default resolver if one isn't explicitly speci
zturner added a comment.
In https://reviews.llvm.org/D30789#696870, @jingham wrote:
> What is the motivation behind of the "2" versions of the functions you added?
Ahh yea. I can call them something else if you have a better name. But
basically in a unit test I don't have an instance of a `C
jingham added a comment.
What is the motivation behind of the "2" versions of the functions you added?
https://reviews.llvm.org/D30789
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
zturner created this revision.
Herald added a subscriber: mgorny.
There were a couple of problems with this function on Windows. Different
separators and differences in how tilde expressions are resolved for starters,
but in addition there was no clear indication of what the function's inputs o
Author: zturner
Date: Thu Mar 9 13:54:23 2017
New Revision: 297405
URL: http://llvm.org/viewvc/llvm-project?rev=297405&view=rev
Log:
Make the LLDB test suite work with MSVC 2017 on Windows.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
Modified: lldb/trunk/packages
labath created this revision.
Herald added a subscriber: danalbert.
This has been broken at least since the new test result framework was
added, which was over a year ago. It looks like nobody has missed it
since.
Removing this makes the gmodules handling code saner, as it already did
not know ho
Author: labath
Date: Thu Mar 9 04:16:15 2017
New Revision: 297369
URL: http://llvm.org/viewvc/llvm-project?rev=297369&view=rev
Log:
cmake: Increase LINK_INTERFACE_MULTIPLICITY of lldbCore
This is necessary to get debug builds of unit tests working on linux.
I think we are at a point where remov
This revision was automatically updated to reflect the committed changes.
Closed by commit rL297368: Fix remaining threading issues in Log.h (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D30702?vs=90994&id=91147#toc
Repository:
rL LLVM
https://reviews.llvm.org/D307
Author: labath
Date: Thu Mar 9 04:16:07 2017
New Revision: 297368
URL: http://llvm.org/viewvc/llvm-project?rev=297368&view=rev
Log:
Fix remaining threading issues in Log.h
Summary:
This fixes two threading issues in the logging code. The access to the
mask and options flags had data races when w
labath added a comment.
Comment at: source/Utility/Log.cpp:82
+ if (mask | flags) {
+m_options.store(options, std::memory_order_release);
+m_stream_sp = stream_sp;
zturner wrote:
> Might as well use `memory_order_relaxed` here.
Done. I missed that one
14 matches
Mail list logo
