amccarth added inline comments.
================
Comment at: lldb/source/Commands/CommandCompletions.cpp:108
+ StringList &matches,
+ TildeExpressionResolver *Resolver) {
+ // Use the default resolver if one isn't explicitly specified.
----------------
I know you're not inventing this API, but since you're changing it, can you do
something about the `bool` and `bool &` parameters? It makes reading the call
sites difficult without referring back here to see what those mean.
================
Comment at: lldb/source/Commands/CommandCompletions.cpp:112
+ if (!Resolver)
+ Resolver = &SR;
+
----------------
This leaves the caller with no way to say the don't want a tilde resolver. I
didn't expect that from reading the API. Perhaps a comment on the API could
clarify that you're going to get this default behavior if you specify nullptr.
https://reviews.llvm.org/D30789
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
