labath added a comment.
================
Comment at: source/Utility/Log.cpp:82
+ if (mask | flags) {
+ m_options.store(options, std::memory_order_release);
+ m_stream_sp = stream_sp;
----------------
zturner wrote:
> Might as well use `memory_order_relaxed` here.
Done. I missed that one.
================
Comment at: unittests/Utility/LogTest.cpp:16
#include "llvm/Support/Threading.h"
+#include <future>
#include <thread>
----------------
zturner wrote:
> Is this included needed?
Not anymore. I had tried implementing the test with futures, but I couldn't get
tsan to work with them properly.
https://reviews.llvm.org/D30702
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
