Author: enrico
Date: Wed Sep 16 20:13:12 2015
New Revision: 247875
URL: http://llvm.org/viewvc/llvm-project?rev=247875&view=rev
Log:
Visual Studio seems to consider this invocation ambiguous. Try to clarify what
I mean
Modified:
lldb/trunk/include/lldb/DataFormatters/FormatManager.h
Modifie
jasonmolenda added a comment.
I chatted with Jim and Greg about this today. We have a
"`stop-disassembly-display`" setting right now. It can be one of three values:
never: never show assembly
no-source: show assembly when we have no debug information
always: always show assembly
"no-source" i
Author: enrico
Date: Wed Sep 16 19:14:50 2015
New Revision: 247872
URL: http://llvm.org/viewvc/llvm-project?rev=247872&view=rev
Log:
Add the ability for formatter categories to be bound to one or more languages
What that does is it restricts formatters in those categories to only match to
types
Author: chaoren
Date: Wed Sep 16 18:36:41 2015
New Revision: 247863
URL: http://llvm.org/viewvc/llvm-project?rev=247863&view=rev
Log:
XFAIL TestCppNsImport for gcc-4.9 inclusive.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
Modified: lldb/trunk/test/lang/cpp/nsimport/TestCp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247857: Fix Makefile for Windows to Android tests. (authored
by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12909?vs=34905&id=34929#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: chaoren
Date: Wed Sep 16 16:51:51 2015
New Revision: 247857
URL: http://llvm.org/viewvc/llvm-project?rev=247857&view=rev
Log:
Fix Makefile for Windows to Android tests.
Reviewers: zturner
Subscribers: tberghammer, lldb-commits, danalbert
Differential Revision: http://reviews.llvm.org/D1
dawn updated this revision to Diff 34928.
dawn added a comment.
Tests changed as requested by Ilia. Ok to commit?
Repository:
rL LLVM
http://reviews.llvm.org/D12115
Files:
test/tools/lldb-mi/symbol/Makefile
test/tools/lldb-mi/symbol/TestMiSymbol.py
test/tools/lldb-mi/symbol/main.cpp
Author: chaoren
Date: Wed Sep 16 16:32:48 2015
New Revision: 247855
URL: http://llvm.org/viewvc/llvm-project?rev=247855&view=rev
Log:
XFAIL TestCppNsImport for gcc-4.9.
Works for gcc-4.8. A bug in gcc perhaps.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
Modified: lldb/tru
dawn marked 3 inline comments as done.
dawn added a comment.
Ilia, thank you for your review - I think I understand what you are asking for
now.
Repository:
rL LLVM
http://reviews.llvm.org/D12115
___
lldb-commits mailing list
lldb-commits@lists.
Author: ribrdb
Date: Wed Sep 16 16:20:44 2015
New Revision: 247852
URL: http://llvm.org/viewvc/llvm-project?rev=247852&view=rev
Log:
Add an OperatingSystem plugin to support goroutines
The Go runtime schedules user level threads (goroutines) across real threads.
This adds an OS plugin to create m
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247852: Add an OperatingSystem plugin to support goroutines
(authored by ribrdb).
Changed prior to commit:
http://reviews.llvm.org/D5871?vs=34914&id=34925#toc
Repository:
rL LLVM
http://reviews.llvm
zturner closed this revision.
zturner added a comment.
Sorry this took so long, I forgot about it. It has been committed in r247842.
http://reviews.llvm.org/D12672
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
dawn added a comment.
Ilia, You did the initial implementation of -symbol-list-lines right? I've
fixed a major bug in your code with this commit! You have -symbol-list-lines
including lines from header files in the compilation unit! Give the test in
this patch a try and you will see. It me
Author: zturner
Date: Wed Sep 16 15:14:01 2015
New Revision: 247842
URL: http://llvm.org/viewvc/llvm-project?rev=247842&view=rev
Log:
add a dependency on terminfo library if llvm uses it
Ncurses related symbols can either all be found in libnurses or split
between libncurses and libtinfo. The mai
Author: zturner
Date: Wed Sep 16 15:13:53 2015
New Revision: 247841
URL: http://llvm.org/viewvc/llvm-project?rev=247841&view=rev
Log:
Fix log disable command in ProcessWindowsLog.
The implications of this bug where that "log disable windows" would
not actually disable the log, and worse it would
clayborg accepted this revision.
clayborg added a comment.
Looks good then. I know there are things that are wrong with the current OS
plug-ins, so lets just work on improving them to be as useful as possible as I
am sure there will be things that need fixing.
Eventual goals could be to allow s
ribrdb marked 2 inline comments as done.
ribrdb added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D5871
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ribrdb updated this revision to Diff 34914.
ribrdb added a comment.
> I am confused as to why we need to do this. If you have a memory thread, it
> might be backed by a real thread, or it might not. If it is backed by a
> real thread, we should be asking the real thread why it really stopp
clayborg added a comment.
Sean is the best person to answer your questions. I will ping him and have him
comment.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
On 16 September 2015 at 00:42, Greg Clayton via lldb-commits
wrote:
> Author: gclayton
> Date: Tue Sep 15 19:42:50 2015
> New Revision: 247764
>
> URL: http://llvm.org/viewvc/llvm-project?rev=247764&view=rev
> Log:
> Fix MacOSX since "imported" and "Imported::imported" are ambiguous. Test that
>
Author: paulherman
Date: Wed Sep 16 13:48:30 2015
New Revision: 247836
URL: http://llvm.org/viewvc/llvm-project?rev=247836&view=rev
Log:
Add using directives to the clang::DeclContext and fix decls for variables
inside namespaces
Summary: Supports the parsing of the "using namespace XXX" and "us
paulherman updated this revision to Diff 34911.
paulherman added a comment.
Add using directives to the clang::DeclContext and fix decls for variables
inside namespaces
Rebased the patch.
http://reviews.llvm.org/D12897
Files:
include/lldb/Symbol/SymbolFile.h
source/Expression/ClangExpress
Author: enrico
Date: Wed Sep 16 13:28:11 2015
New Revision: 247831
URL: http://llvm.org/viewvc/llvm-project?rev=247831&view=rev
Log:
Move hardcoded formatters from the FormatManager to the Language plugins
Modified:
lldb/trunk/include/lldb/DataFormatters/FormatClasses.h
lldb/trunk/includ
Author: zturner
Date: Wed Sep 16 13:19:06 2015
New Revision: 247830
URL: http://llvm.org/viewvc/llvm-project?rev=247830&view=rev
Log:
Remove XFAIL from TestCppNsImport.
This test seems to be working now, probably due to r244764.
Modified:
lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247829: Add first tests for mini-dump debugging. (authored
by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12888?vs=34906&id=34909#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
Author: amccarth
Date: Wed Sep 16 13:17:11 2015
New Revision: 247829
URL: http://llvm.org/viewvc/llvm-project?rev=247829&view=rev
Log:
Add first tests for mini-dump debugging.
Differential Revision: http://reviews.llvm.org/D12888
Added:
lldb/trunk/test/functionalities/postmortem/
lldb/tru
sivachandra added a comment.
Ping. Any suggestion on how to take this forward?
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: zturner
Date: Wed Sep 16 13:08:33 2015
New Revision: 247825
URL: http://llvm.org/viewvc/llvm-project?rev=247825&view=rev
Log:
Last set of XFAILs for Windows.
Modified:
lldb/trunk/test/api/multiple-debuggers/TestMultipleDebuggers.py
lldb/trunk/test/expression_command/test/TestExprs
Author: zturner
Date: Wed Sep 16 13:08:45 2015
New Revision: 247826
URL: http://llvm.org/viewvc/llvm-project?rev=247826&view=rev
Log:
Silence compiler warnings about unhandled switch cases.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTCont
looks fine.
On Wed, Sep 16, 2015 at 11:02 AM Adrian McCarthy
wrote:
> amccarth updated this revision to Diff 34906.
> amccarth added a comment.
>
> Addressed earlier comments and moved to functionalities\postmortem\minidump
>
>
> http://reviews.llvm.org/D12888
>
> Files:
> test/functionalities
Author: gclayton
Date: Wed Sep 16 13:05:08 2015
New Revision: 247823
URL: http://llvm.org/viewvc/llvm-project?rev=247823&view=rev
Log:
Add newline at end of file to avoid compiler warning.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
Modified: lldb/trunk/sourc
amccarth updated this revision to Diff 34906.
amccarth added a comment.
Addressed earlier comments and moved to functionalities\postmortem\minidump
http://reviews.llvm.org/D12888
Files:
test/functionalities/postmortem/minidump/TestMiniDump.py
test/functionalities/postmortem/minidump/fizzbuz
amccarth added a comment.
In http://reviews.llvm.org/D12888#247212, @zturner wrote:
> In http://reviews.llvm.org/D12888#247195, @amccarth wrote:
>
> > > Instead of test/functionalities/minidump, I would probably call this
> > > test/functionalities/core-file/windows.
> >
> >
> > Hmm...
> >
> > T
Author: emaste
Date: Wed Sep 16 13:00:09 2015
New Revision: 247822
URL: http://llvm.org/viewvc/llvm-project?rev=247822&view=rev
Log:
Decorate flaky FreeBSD test
ExprCommandWithTimeoutsTestCase::expectedFailureFreeBSD had an
expectedFailureFreeBSD decorator, removed in r247799. It had been flakey
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
http://reviews.llvm.org/D12909
Files:
test/make/Makefile.rules
Index: test/make/Makefile.rules
=
clayborg added a comment.
If "qfThreadInfo" responds with OK, it seems to imply "this is a supported
packet, but I have no threads to report". So it seems like we should assume
that there are no threads in this case. If we got $#00 back, then it would mean
that qfThreadInfo ins't supported. So
zturner added a comment.
In http://reviews.llvm.org/D12888#247195, @amccarth wrote:
> > Instead of test/functionalities/minidump, I would probably call this
> > test/functionalities/core-file/windows.
>
>
> Hmm...
>
> There is talk of (eventually) debugging minidumps on other platforms. Also
>
ovyalov closed this revision.
ovyalov added a comment.
Files:
/lldb/trunk/include/lldb/Core/PluginManager.h
/lldb/trunk/source/Core/PluginManager.cpp
/lldb/trunk/source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
/lldb/trunk/source/Plugins/JITLoader/GDB/JITLoaderGDB.h
Users:
ovyalov (Autho
Author: ovyalov
Date: Wed Sep 16 12:38:36 2015
New Revision: 247821
URL: http://llvm.org/viewvc/llvm-project?rev=247821&view=rev
Log:
Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader
breakpoint optional.
http://reviews.llvm.org/D12890
Modified:
lldb/trunk/include
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation and it makes sense. Looks good.
http://reviews.llvm.org/D12897
___
lldb-commits mailing list
lldb-commits@lists.ll
paulherman added a comment.
The need for ParseDeclsInContext is to get a list of namespaces that are
contained within a using-directive. This does not actually parse anything but
DW_TAG_imported_namespace and DW_TAG_imported_decl. The actual contents of the
namespace are parsed only when the se
amccarth marked 2 inline comments as done.
amccarth added a comment.
> Instead of test/functionalities/minidump, I would probably call this
> test/functionalities/core-file/windows.
Hmm...
There is talk of (eventually) debugging minidumps on other platforms. Also
some crash capture tools can
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few more little things with respect to not calling accessors multiple times
in if statements and this will be good to go.
Comment at: source/Core/Address.cpp:
clayborg added a comment.
If you can explain the need for ParseDeclsForContext() as mentioned in the
inlined comment that would help me understand this change better.
Also, Sean suggested that we might be able to fix all of this in another way
that might make it easier on everyone: don't do any
zturner added a comment.
Instead of test/functionalities/minidump, I would probably call this
test/functionalities/core-file/windows.
I'm using core-file instead of minidump because it's the most generic term that
will make sense on all platforms, and other platforms will essentially want to
a
jingham added a subscriber: jingham.
jingham added a comment.
The point of the file name check is to catch the case where you had nested
inlines that share the same address, and the compiler (errantly, but...)
decided to emit duplicate entries at the same address for the two levels of
inlining.
tfiala closed this revision.
tfiala added a comment.
Checked in here:
SendingCMakeLists.txt
Sendingcmake/modules/LLDBConfig.cmake
Sendingtools/driver/CMakeLists.txt
Transmitting file data ...
Committed revision 247810.
http://reviews.llvm.org/D12899
Author: tfiala
Date: Wed Sep 16 10:34:06 2015
New Revision: 247810
URL: http://llvm.org/viewvc/llvm-project?rev=247810&view=rev
Log:
cmake fixes for lldb target.
ninja lldb now does the following:
* forces the python post-build step to fire, which sets up the python lldb
module properly.
* on Da
tfiala added a comment.
In http://reviews.llvm.org/D12899#247092, @emaste wrote:
> In http://reviews.llvm.org/D12899#246881, @tfiala wrote:
>
> > @emaste, I'm adding you because I have no idea what the state of the *BSD
> > world is with regards to lldb-server. It looks like you might still use
tfiala added a comment.
I'll check this in if I don't hear boo in the next few minutes...
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala added a comment.
> Yeah... it is starting to get a bit over-engineered. :)
It's all good :-)
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
tfiala marked 5 inline comments as done.
tfiala added a comment.
I think this covers everything.
http://reviews.llvm.org/D12899
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tfiala updated this revision to Diff 34894.
tfiala added a comment.
Adds an orthogonal can-use-debugserver flag. Flips it on for Darwin.
I'm okay with the Darwin cmake build building both of those for the lldb target
since I want the consistency checks between the two running on Darwin.
http:
labath added inline comments.
Comment at: tools/driver/CMakeLists.txt:12
@@ +11,3 @@
+if ( LLDB_CAN_USE_LLDB_SERVER )
+ add_dependencies(lldb lldb-server)
+endif()
tfiala wrote:
> labath wrote:
> > In case of darwin you need *debugserver* to be able to debug loca
tfiala added inline comments.
Comment at: tools/driver/CMakeLists.txt:12
@@ +11,3 @@
+if ( LLDB_CAN_USE_LLDB_SERVER )
+ add_dependencies(lldb lldb-server)
+endif()
labath wrote:
> In case of darwin you need *debugserver* to be able to debug locally.
> lldb-serve
labath added a comment.
Comment at: tools/driver/CMakeLists.txt:12
@@ +11,3 @@
+if ( LLDB_CAN_USE_LLDB_SERVER )
+ add_dependencies(lldb lldb-server)
+endif()
In case of darwin you need *debugserver* to be able to debug locally.
lldb-server is only used for re
tfiala added a comment.
In http://reviews.llvm.org/D12899#247074, @zturner wrote:
> Just a drive by comment since I don't have a vested interest in lldb-server
> or this CL at the moment. But adding lldb-server as a dependency of lldb
> seems strange to me. I mean I get it, it just seems stra
tfiala added a comment.
In http://reviews.llvm.org/D12899#247098, @tfiala wrote:
> Adjustments to set indirect variable for whether lldb can use lldb-server.
> If so, then we'll add the dependency for lldb-server on lldb at the time we
> declare the lldb target.
Also adds lldb-server depende
tfiala updated this revision to Diff 34893.
tfiala added a comment.
Adjustments to set indirect variable for whether lldb can use lldb-server. If
so, then we'll add the dependency for lldb-server on lldb at the time we
declare the lldb target.
http://reviews.llvm.org/D12899
Files:
CMakeLis
emaste added a comment.
In http://reviews.llvm.org/D12899#247074, @zturner wrote:
> They're not really dependencies in the normal sense.
They're not build dependencies, but they are dependencies in the sense that
lldb-server is required for lldb to be usable in the normal use case. In my
opin
emaste added a comment.
In http://reviews.llvm.org/D12899#246881, @tfiala wrote:
> @emaste, I'm adding you because I have no idea what the state of the *BSD
> world is with regards to lldb-server. It looks like you might still use the
> process monitor bits so lldb-server might not be interest
Author: labath
Date: Wed Sep 16 09:52:36 2015
New Revision: 247805
URL: http://llvm.org/viewvc/llvm-project?rev=247805&view=rev
Log:
Upgrading TestCreateDuringInstructionStep from XFLAKY to XFAIL on android arm
the test is very often failing two times in a row, causing noise on the
buildbots.
M
Just a drive by comment since I don't have a vested interest in lldb-server
or this CL at the moment. But adding lldb-server as a dependency of lldb
seems strange to me. I mean I get it, it just seems strange. They're not
really dependencies in the normal sense. If you just use "ninja" instead
tfiala added a comment.
> Okay I'll make an adjustment to turn it on for Darwin and setting it based on
> a flag.
I'm going to do it slightly differently --- I'll set a flag in the modules
config that indicates if lldb *wants* lldb-server. The logic on whether to
build it or not should, as b
tfiala added a comment.
> (These have already diverged as you are only doing this for Linux, but
> lldb-server is built on FreeBSD as well.)
Hi Bruce,
My primary goal was to make sure 'ninja lldb' builds the parts that are
necessary for lldb to run and be tested. Linux cannot debug a local e
Author: emaste
Date: Wed Sep 16 09:05:20 2015
New Revision: 247801
URL: http://llvm.org/viewvc/llvm-project?rev=247801&view=rev
Log:
Remove expectedFailureFreeBSD from passing watchpoint tests
llvm.org/pr18832
Modified:
lldb/trunk/test/functionalities/watchpoint/hello_watchlocation/TestWatc
Author: emaste
Date: Wed Sep 16 08:59:16 2015
New Revision: 247800
URL: http://llvm.org/viewvc/llvm-project?rev=247800&view=rev
Log:
Remove expectedFailureFreeBSD from passing test
ExprCommandCallUserDefinedFunction::test_with_dwarf
llvm.org/pr21142
Modified:
lldb/trunk/test/functionalitie
Author: emaste
Date: Wed Sep 16 08:55:15 2015
New Revision: 247799
URL: http://llvm.org/viewvc/llvm-project?rev=247799&view=rev
Log:
Remove expectedFailureFreeBSD from passing test
ExprCommandWithTimeoutsTestCase::expectedFailureFreeBSD
This test passes locally but was marked XFAIL due to failur
This revision was automatically updated to reflect the committed changes.
tberghammer marked an inline comment as done.
Closed by commit rL247789: Add support for the DWARFLocationList used by
split-dwarf (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12880?vs=3480
Author: tberghammer
Date: Wed Sep 16 07:37:06 2015
New Revision: 247789
URL: http://llvm.org/viewvc/llvm-project?rev=247789&view=rev
Log:
Add support for the DWARFLocationList used by split-dwarf
Split-dwarf uses a different header format to specify the address range
for the elements of the locat
This revision was automatically updated to reflect the committed changes.
Closed by commit rL247788: Fix prologue end handling when code compiled by gcc
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12757?vs=34435&id=34886#toc
Repository:
rL LLVM
http://review
Author: tberghammer
Date: Wed Sep 16 07:36:37 2015
New Revision: 247788
URL: http://llvm.org/viewvc/llvm-project?rev=247788&view=rev
Log:
Fix prologue end handling when code compiled by gcc
GCC don't use the is_prologue_end flag to mark the first instruction
after the prologue. Instead of it it i
tberghammer marked an inline comment as done.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:36-228
@@ -37,1 +35,195 @@
+static int
+print_dwarf_exp_op (Stream &s,
+const DWARFDataExtractor& data,
+lldb::offset_t *offs
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579
@@ +3578,3 @@
+*/
+if (!response.IsNormalResponse() && thread_ids.size() == 0 &&
IsConnected())
+{
jaydeep wrote:
> labath w
jaydeep added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579
@@ +3578,3 @@
+*/
+if (!response.IsNormalResponse() && thread_ids.size() == 0 &&
IsConnected())
+{
labath wrote:
> labath w
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579
@@ +3578,3 @@
+*/
+if (!response.IsNormalResponse() && thread_ids.size() == 0 &&
IsConnected())
+{
labath wrote:
> The probl
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3579
@@ +3578,3 @@
+*/
+if (!response.IsNormalResponse() && thread_ids.size() == 0 &&
IsConnected())
+{
The problem behind the fa
tberghammer added a comment.
The line number is not always the same for the 2 entry (the first one points to
the open '{' and the second one to the first instruction of the function). I
added the check for the file name, but I would be quite surprised if we find a
scenario when the file names d
dsanders added a comment.
This patch does the trick for me but I'm not certain it's the right fix
overall. Could someone take a look?
http://reviews.llvm.org/D12900
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi
dsanders created this revision.
dsanders added a subscriber: lldb-commits.
http://reviews.llvm.org/D12900
Files:
tools/lldb-server/CMakeLists.txt
Index: tools/lldb-server/CMakeLists.txt
===
--- tools/lldb-server/CMakeLists.txt
+++
labath added a subscriber: labath.
labath added a comment.
Hi, this commit has caused failure on all remote tests using lldb-server. I
have reverted it while I investigate what is happening.
Repository:
rL LLVM
http://reviews.llvm.org/D12876
___
Author: labath
Date: Wed Sep 16 05:27:57 2015
New Revision: 247783
URL: http://llvm.org/viewvc/llvm-project?rev=247783&view=rev
Log:
Revert "[LLDB][MIPS] Debug bare-iron targets lacking support for qC
/qfThreadInfo"
This reverts commit r247773, because it breaks remote debugging support for
lld
Author: ewancrawford
Date: Wed Sep 16 05:02:57 2015
New Revision: 247782
URL: http://llvm.org/viewvc/llvm-project?rev=247782&view=rev
Log:
Add names to RenderScript kernel breakpoints.
Use Breakpoint::AddName to mark all RenderScript kernel breakpoints with the
name 'RenderScriptKernel'.
Also up
brucem added a subscriber: brucem.
Comment at: test/lang/go/goroutines/TestGoroutines.py:14
@@ +13,3 @@
+@python_api_test
+@skipIfRemote # Not remote test suit ready
+@skipUnlessGoInstalled
Minor typo: should be "suite"
Repository:
rL LLVM
http://
brucem added a subscriber: brucem.
Comment at: tools/driver/CMakeLists.txt:13
@@ +12,3 @@
+ add_dependencies(lldb lldb-server)
+endif()
+
labath wrote:
> We should probably add a dependency on debugserver on darwin for consistency,
> since some people use cmake
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for fixing this.
Comment at: tools/driver/CMakeLists.txt:13
@@ +12,3 @@
+ add_dependencies(lldb lldb-server)
+endif()
+
We should probably
86 matches
Mail list logo
