amccarth added a comment. In http://reviews.llvm.org/D12888#247212, @zturner wrote:
> In http://reviews.llvm.org/D12888#247195, @amccarth wrote: > > > > Instead of test/functionalities/minidump, I would probably call this > > > test/functionalities/core-file/windows. > > > > > > Hmm... > > > > There is talk of (eventually) debugging minidumps on other platforms. Also > > some crash capture tools can make minidumps, even on Mac and Linux hosts. > > I could imagine you might also want to be able to debug a core file from a > > non-Windows host on a Windows host. So core-file/windows could end up > > being confusing/misleading in the long run. > > > > How about > > > > test/functionalities/crash_files/core-files > > > > and > > > > test/functionalities/crash_files/mini-dumps > > > > ? > > > Are the "mini dumps" you're referring to that can be created on a Mac or > Linux host the same file format? I think we need some way to capture the > distinction between the two file formats. All of the different formats have > one thing in common though. They support *postmortem* debugging. So maybe > it could be: > > test/functionalities/postmortem/elf > > test/functionalities/postmortem/windows > > I don't think having it be called "windows" precludes being able to use the > functionality on non-windows hosts (provided we ever write a library that can > process them on non-Windows), I just can't think of a better way to describe > the format itself. Note that Breakpad uses the Windows minidump format for all platforms: https://code.google.com/p/google-breakpad/wiki/GettingStartedWithBreakpad#The_minidump_file_format So it makes sense to distinguish based on crash file type rather than platform. Thus, per offline discussion, we'll go with: test/functionalities/postmortem/minidump In the future, we can add tests for core files in: test/functionalities/postmortem/core http://reviews.llvm.org/D12888 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
