[PATCH 2/2] sound: ppc: keywest: drop using attach adapter

As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang --- sound/ppc/keywest.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/sound/ppc/keywest.c b

[PATCH 1/2] macintosh: therm_windtunnel: drop using attach adapter

As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang --- drivers/macintosh/therm_windtunnel.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a

[PATCH 0/2] i2c: rework last users of 2.4 style attach_adapter

I used for ARM compilation is here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/attach_adapter_removal_with_arm_compile-experimental Thanks, Wolfram Wolfram Sang (2): macintosh: therm_windtunnel: drop using attach adapter sound: ppc: keywest: drop using attach ad

Re: [opensuse-ppc] HELP: test kernel patches on the real thing

On Mon, Apr 20, 2015 at 08:43:24PM -0400, larrystot...@netscape.net wrote: > -Original Message- > From: Wolfram Sang > > Quoted from the opensuse-ppc mailing list > > >I'm Wolfram Sang, maintainer of the I2C subsystem of the Linux Kernel. I > >want to ge

[PATCH] i2c: powermac: don't workaround for keywest

must go to GrowlTiger from Gentoo bug report #469132 for bisecting. Reported-by: Dan DeVoto Signed-off-by: Wolfram Sang Tested-by: Dan DeVoto Tested-by: Mark Elliott Fixes: 3a3dd0186f619b ("i2c/powermac: Improve detection of devices from device-tree") --- drivers/i2c/busses/i2c-powermac.c |

[PATCH RESEND] sound: ppc: keywest: drop using attach adapter

As we now have deferred probing, we can use a custom mechanism and finally get rid of this legacy interface from the i2c core. Signed-off-by: Wolfram Sang Tested-by: Dan DeVoto Tested-by: Mark Elliott --- Changes since last time: Added two test tags from the Debian PPC list. I'd love to

Re: [PATCH] i2c: powermac: don't workaround for keywest

On Sat, May 09, 2015 at 07:23:33PM +0200, Wolfram Sang wrote: > Commit 3a3dd0186f619b ("i2c/powermac: Improve detection of devices from > device-tree") added a codec device instantiation workaround > unconditionally although it is only needed for onyx. Do it conditionally >

[RFC] sound: ppc: keywest: check if DEQ was already instantiated

because the sound driver failed when instantiating the DEQ for the second time. Signed-off-by: Wolfram Sang --- Dan, Mark: I hope I found a generic but not too intrusive solution to the doubled instantiation problem. Can you please test this patch on top of this one "sound: ppc: keywest: drop

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

On Thu, May 28, 2015 at 09:33:27AM +0200, Takashi Iwai wrote: > At Tue, 26 May 2015 02:19:34 -0700, > Dan DeVoto wrote: > > > > Hi, > > > > I applied this patch ("check if DEQ was already instantiated") on top of > > "sound: ppc: keywest: drop using attach adapter" and sound works great. > > Eve

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

> Do you think from which stable kernel version can this be applied? The offending commit is 3a3dd0186f619b74e61e6f29dddcaf59af7d3cac ("i2c/powermac: Improve detection of devices from device-tree") which came in with v3.6 if I read correctly. signature.asc Description: Digital signature ___

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

On Fri, May 29, 2015 at 01:44:38PM +0200, Takashi Iwai wrote: > At Fri, 29 May 2015 20:06:09 +0900, > Wolfram Sang wrote: > > > > > Do you think from which stable kernel version can this be applied? > > > > The offending commit is 3a3dd0186f619b74e61e6f29dd

[PATCH] macintosh: therm_pm72: delete deprecated driver

The new driver is around for more than 2 years now, so the old one can go. Getting rid of it helps the removal of the legacy .attach_adapter callback of the I2C subsystem. Signed-off-by: Wolfram Sang --- drivers/macintosh/Kconfig | 10 - drivers/macintosh/Makefile |1 - drivers

Re: [PATCH] macintosh: therm_pm72: delete deprecated driver

On Thu, Nov 06, 2014 at 01:19:36PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2014-11-06 at 02:45 +0100, Wolfram Sang wrote: > > The new driver is around for more than 2 years now, so the old one can > > go. Getting rid of it helps the removal of the legacy .attach_adapter >

Re: [PATCH] macintosh: therm_pm72: delete deprecated driver

On Thu, Nov 06, 2014 at 08:50:04PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2014-11-06 at 10:25 +0100, Wolfram Sang wrote: > > On Thu, Nov 06, 2014 at 01:19:36PM +1100, Benjamin Herrenschmidt wrote: > > > On Thu, 2014-11-06 at 02:45 +0100, Wolfram Sang wrote: > > >

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

> If we wanted to be on the safe side and strict (since we are not sure that the > hardware is 100% compatible), we maybe should add a fsl,qoriq-i2c compatible > to > the driver that does the same as mpc8543-i2c. Or you leave the driver as is and use both compatibles: compatible = "fsl,qoriq-i2

Re: [PATCH] i2c: Driver to expose PowerNV platform i2c busses

Hi, I am basically fine if this goes via the powerpc-tree and I was hoping that I could ack it right now. However, the driver looks a bit rushed and definately needs updates before it is ready to go. On Mon, Nov 10, 2014 at 11:35:39AM +0530, Neelesh Gupta wrote: > The patch exposes the available

Re: [PATCH] i2c: Driver to expose PowerNV platform i2c busses

> > Please sort the includes. > > Ugh ? Since when do we do that ? :-) Since I realised it is more readable and reduces likeliness of duplicated includes. > > > + rc = opal_i2c_request(token, bus_id, req); > > > + if (rc != OPAL_ASYNC_COMPLETION) { > > > + rc = -EIO; > > > + got

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

> > > > If we're going to change the device tree I'd rather just add a property > > to say what the prescaler is. > > We would however, leave the boards' device trees that use things like > "fsl,mpc8543-i2c" as is and introduce the prescaler for the others requiring > it. > > > Now the drawb

Re: [PATCH v2] i2c: Driver to expose PowerNV platform i2c busses

On Thu, Nov 20, 2014 at 07:52:08PM +0530, Neelesh Gupta wrote: > > On 11/16/2014 10:47 PM, Neelesh Gupta wrote: > >The patch exposes the available i2c busses on the PowerNV platform > >to the kernel and implements the bus driver to support i2c and > >smbus commands. > >The driver uses the platform

Re: [PATCH v2] i2c: Driver to expose PowerNV platform i2c busses

On Tue, Nov 25, 2014 at 03:32:17PM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2014-11-24 at 13:18 +0100, Wolfram Sang wrote: > > > > I think there are now 3 drivers in my queue which are not fully I2C > > compatible but more supporting the very minimum to, say, read an

Re: [PATCH v2] i2c: Driver to expose PowerNV platform i2c busses

On Sun, Nov 16, 2014 at 10:47:46PM +0530, Neelesh Gupta wrote: > The patch exposes the available i2c busses on the PowerNV platform > to the kernel and implements the bus driver to support i2c and > smbus commands. > The driver uses the platform device infrastructure to probe the busses > on the pl

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

On Mon, Nov 17, 2014 at 07:28:03PM -0600, Scott Wood wrote: > On Fri, 2014-11-14 at 09:28 +0100, Wolfram Sang wrote: > > > > > > > > If we're going to change the device tree I'd rather just add a property > > > > to say what the prescaler is.

Re: [PATCH v2] i2c: Driver to expose PowerNV platform i2c busses

> Suuure, let's create more process and committees, and make sure nothing > gets done in any reasonable amount of time. Have we gone completely > insane ? I did not invent DT bindings. I did not invent that DT is/should be a hardware description. For me, it is a burden that I (as a subsystem main

Re: [PATCH] i2c: mpc: add register documentation to Freescale I2C driver

On Sat, Nov 29, 2014 at 01:58:42PM -0800, Danielle Costantino wrote: > i2c: mpc: add register documentation to Freescale I2C driver This should be in one patch. > > return -ETIMEDOUT for all time-out error conditions This should be in a seperate patch. > and warn on arbitration lost. And this

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

> I saw that this patch was marked as not applicable, but on most qoriq > devices the pre-scaler is 2 especially for p2020/p2010 devices > arch/powerpc/boot/dts/fsl/p2020si-post.dtsi Just for completeness: "Not applicable" given from patchwork of the i2c subsystem means this patch is not for the

[RFC 2/2] sound: ppc: keywest: drop using attach adapter

As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang --- sound/ppc/keywest.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/sound/ppc/keywest.c b

[RFC 1/2] macintosh: therm_windtunnel: drop using attach adapter

As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang --- drivers/macintosh/therm_windtunnel.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a

[RFC 0/2] get rid of remaining users of attach_adapter

. If they could be applied, we can _finally_ get rid of this legacy mechanism and clean up the i2c core. The branch I used for ARM compilation is here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/attach_adapter_removal_with_arm_compile-experimental Thanks, Wolfram

Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter

> > + > > + /* We assume Macs have consecutive I2C bus numbers starting at 0 */ > > + while (adap) { > > + err = keywest_attach_adapter(adap); > > + if (!err) > > + break; > > + i2c_put_adapter(adap); > > + adap = i2c_get_adapter(++i);

Re: [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses

On Tue, Dec 09, 2014 at 07:13:15AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2014-12-08 at 12:06 +0530, Neelesh Gupta wrote: > > The patch exposes the available i2c busses on the PowerNV platform > > to the kernel and implements the bus driver to support i2c and > > smbus commands. > > The dri

Re: [PATCH v3] i2c: Driver to expose PowerNV platform i2c busses

If you are ok with the driver and are happy for me to take it, > please send an Ack. "Happy" is not the correct word, but let's just go over with it. Maybe like this: Acked-by: Wolfram Sang (I2C part, excluding the bindings) > From a binding perspective, it's just a pi

Re: [PATCH] macintosh: therm_pm72: delete deprecated driver

On Thu, Nov 06, 2014 at 08:50:04PM +1100, Benjamin Herrenschmidt wrote: > On Thu, 2014-11-06 at 10:25 +0100, Wolfram Sang wrote: > > On Thu, Nov 06, 2014 at 01:19:36PM +1100, Benjamin Herrenschmidt wrote: > > > On Thu, 2014-11-06 at 02:45 +0100, Wolfram Sang wrote: > > >

[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

ixed a coccinelle bug on the way :) Wolfram Sang (28): ARM: mach-exynos: drop owner assignment from platform_drivers mips: lantiq: xway: drop owner assignment from platform_drivers mips: pci: drop owner assignment from platform_drivers char: ipmi: drop owner assignment from platform_driver

[PATCH 13/28] pci: host: drop owner assignment from platform_drivers

This platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches

[PATCH 28/28] macintosh: drop owner assignment from platform_drivers

This platform_driver does not need to set an owner, it will be populated by the driver core. Signed-off-by: Wolfram Sang --- Generated with coccinelle. SmPL file is in the introductory msg. The big cleanup was pulled in this merge window. This series catches the bits fallen through. The patches

Re: [PATCH] macintosh: therm_pm72: delete deprecated driver

> > So, I haven't seen this coming in via ppc. I am going to send another > > pull request to Linus tomorrow and will include it unless somebody > > objects soon. > > Sorry, communication break down between Ben & I. I'm happy for you to take it. It is already upstream :) But thanks! signature

Re: [PATCH] i2c-qoriq: modified compatibility for correct prescaler

On Tue, Dec 23, 2014 at 02:23:01PM +0100, Valentin Longchamp wrote: > Wolfgang, Scott, Wolfram, please. > > What is then the agreement here ? Add a clock-div to the device trees ? Or > > do > > something similar to mpc_i2c_get_sec_cfg_8xxx() ? > > > > I think the clock-div property is better a

[RFC 03/11] i2c: at91: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-at91.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 636fd2efad88..8be7cf6e2747 100644 --- a/drivers/i2c/busses/i2c

[RFC 05/11] i2c: qup: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-qup.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 4dad23bdffbe..fdcbdab808e9 100644 --- a/drivers/i2c/busses/i2c-qup.c +++ b

[RFC 00/11] i2c: add generic quirk infrastructure

t i2c/quirks Thanks, Wolfram Wolfram Sang (11): i2c: add quirk structure to describe adapter flaws i2c: add quirk checks to core i2c: at91: make use of the new infrastructure for quirks i2c: opal: make use of the new infrastructure for quirks i2c: qup: make use of the new infrastru

[RFC 01/11] i2c: add quirk structure to describe adapter flaws

stabilization period for this description. Signed-off-by: Wolfram Sang --- include/linux/i2c.h | 35 +++ 1 file changed, 35 insertions(+) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index e3a1721c8354..f8a642713706 100644 --- a/include/linux/i2c.h +++ b

[RFC 02/11] i2c: add quirk checks to core

Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 53 ++ 1 file changed, 53 insertions(+) diff --git a/drivers/i2c/i2c-core.c b

[RFC 04/11] i2c: opal: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-opal.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c index 16f90b1a7508..f463eae44bf2 100644 --- a/drivers/i2c/busses/i2c-opal.c

[RFC 06/11] i2c: cpm: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-cpm.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index 2d466538b2e2..714bdc837769 100644 --- a/drivers/i2c/busses/i2c-cpm.c +++ b

[RFC 07/11] i2c: axxia: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-axxia.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-axxia.c b/drivers/i2c/busses/i2c-axxia.c index 768a598d8d03..488c5d3bf9db 100644 --- a/drivers/i2c/busses/i2c-axxia.c +++ b

[RFC 09/11] i2c: powermac: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 60a53c169ed2..6abcf696e359 100644 --- a/drivers/i2c/busses/i2c-powermac.c

[RFC 08/11] i2c: dln2: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-dln2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c index b3fb86af4cbb..b6f9ba7eb175 100644 --- a/drivers/i2c/busses/i2c-dln2.c +++ b/drivers

[RFC 10/11] i2c: viperboard: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-viperboard.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index 7533fa34d737..47e88adf2011 100644 --- a/drivers/i2c/busses/i2c

[RFC 11/11] i2c: pmcmsp: make use of the new infrastructure for quirks

Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-pmcmsp.c | 42 - 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index 44f03eed00dd..e06efee9fa70 100644 --- a/drivers

Re: [RFC 02/11] i2c: add quirk checks to core

On Fri, Jan 09, 2015 at 10:35:27PM +0300, Sergei Shtylyov wrote: > Hello. > > On 01/09/2015 08:21 PM, Wolfram Sang wrote: > > >Let the core do the checks if HW quirks prevent a transfer. Saves code > >from drivers and adds consistency. > > >Signed-off-by: Wolf

Re: [RFC 02/11] i2c: add quirk checks to core

> I am not sure it will perfectly fit at91 quirks. I think it does. > The hardware can handle two messages by using the internal address > feature. The internal address size is from one byte to three bytes. Then > the length of the first message is limited to three but we don't have > this const

[PATCH 1/2] drivers/macintosh: Remove obsolete cleanup for clientdata

A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang --- drivers/macintosh/windfarm_smu_sat.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/macintosh

Re: [PATCH 0/8] misc: remove boundary checks from bin attr users

Vladimir, On Mon, Jul 27, 2015 at 12:18:22AM +0300, Vladimir Zapolskiy wrote: > This change removes a number of redundant checks on bin attribute > client's side, the same checks are done by sysfs_kf_bin_read() or > sysfs_kf_bin_write() caller from fs/sysfs/file.c. > > Note, drivers/misc/pch_phub

Re: [PATCH 0/8] misc: remove boundary checks from bin attr users

> if we're talking about this particular series, you should have them in > your mailbox, since you have them applied in wsa/i2c/for-next: Those are already in linus tree. I mean all drivers which use struct i2c_driver. Or do you prefer they go via Greg? I am fine with both. signature.asc Descr

Re: [PATCH 0/8] misc: remove boundary checks from bin attr users

On Sat, Aug 08, 2015 at 03:51:54PM +0300, Vladimir Zapolskiy wrote: > Hi Wolfram, > > On 08.08.2015 01:34, Wolfram Sang wrote: > > > >> if we're talking about this particular series, you should have them in > >> your mailbox, since you have them applied i

[PATCH] i2c: powermac: fix return path on error

We want to bail out immediately if i2c_add_adapter failed and not try to register child nodes with a nilled adapter structure. Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c

[PATCH] i2c: move of helpers into the core

. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang --- Documentation/acpi/enumeration.txt |1 - drivers/i2c/busses/i2c-at91.c |3 - drivers/i2c/busses/i2c-cpm.c|6 -- drivers/i2c/busses/i2c-davinci.c

[PATCH RESEND] i2c: move of helpers into the core

. So, fix the drivers and documentation, too. Signed-off-by: Wolfram Sang --- Sigh, hitting the CC threshold on vger again. So resending to the lists only. BTW this patch is based on -rc4 and was tested on an AT91 board. More tests very welcome. Thanks! Documentation/acpi/enumeration.txt

Re: [PATCH RESEND] i2c: move of helpers into the core

> However this patch fails to apply onto either v3.11-rc4 or v3.11-rc6: Argh, did not drop the MPC patch before rebasing :( So either pick the patch "i2c: powermac: fix return path on error" before, pull the branch [1], or force me to resend ;) Thanks! [1] git://git.kernel.org/pub/scm/linux/ker

Re: [PATCH RESEND] i2c: move of helpers into the core

On Mon, Aug 19, 2013 at 09:46:04PM +0200, Thierry Reding wrote: > On Mon, Aug 19, 2013 at 07:59:40PM +0200, Wolfram Sang wrote: > [...] > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > [...] > > +#if IS_ENABLED(CONFIG_OF) > > +static void of_

[PATCH V2] i2c: move of helpers into the core

. So, fix the drivers and documentation, too. Acked-by: Sylwester Nawrocki Acked-by: Rob Herring Reviewed-by: Felipe Balbi Acked-by: Rafael J. Wysocki Signed-off-by: Wolfram Sang --- V1 -> V2: * Add #else branch to #if CONFIG_OF * EXPORT_SYMBOLs got attached to wrong functi

[PATCH V3] i2c: move of helpers into the core

. So, fix the drivers and documentation, too. Acked-by: Rob Herring Reviewed-by: Felipe Balbi Acked-by: Rafael J. Wysocki Tested-by: Sylwester Nawrocki Signed-off-by: Wolfram Sang --- V2->V3: Was trying to be too smart by only fixing includes needed. Took a more general approach t

Re: [PATCH V3] i2c: move of helpers into the core

On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote: > I2C of helpers used to live in of_i2c.c but experience (from SPI) shows > that it is much cleaner to have this in the core. This also removes a > circular dependency between the helpers and the core, and so we can > fina

[PATCH] Revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"

l irq failed, not which level it had. Signed-off-by: Wolfram Sang Cc: Sebastian Andrzej Siewior Cc: Anatolij Gustschin --- Have I been on CC when the original patch was sent? arch/powerpc/platforms/52xx/mpc52xx_pic.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [PATCH] Revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"

Hi, On Tue, Oct 01, 2013 at 09:54:51AM +0200, Sebastian Andrzej Siewior wrote: > On 10/01/2013 09:26 AM, Wolfram Sang wrote: > > This reverts commit 6391f697d4892a6f233501beea553e13f7745a23. The > > compiler warning it wants to fix does not appear with my gcc 4.6.2. IMO &g

Re: [PATCH] Revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"

o. I would drop that comment but then > someone might clean that up :P Yup. But I just remembered a better solution: From: Wolfram Sang Subject: [PATCH] ppc: mpc52xx: silence false positive from old GCC So people can compile with -Werror. Signed-off-by: Wolfram Sang --- arch/powerpc/platfo

[PATCH] Kind of revert "powerpc: 52xx: provide a default in mpc52xx_irqhost_map()"

rq failed, not which level it had. Signed-off-by: Wolfram Sang Cc: Sebastian Andrzej Siewior Cc: Anatolij Gustschin --- arch/powerpc/platforms/52xx/mpc52xx_pic.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/po

[PATCH] arch/powerpc/platforms/83xx: Remove obsolete cleanup for clientdata

A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit or error. This is obsolete meanwhile, the core will do it. Signed-off-by: Wolfram Sang --- arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

g for / relying on the NULL > return value. > > This could be cleaned up kernel-wide but for now just take the baby > step and remove from the i2c subsystem. > > Reported-by: Wolfram Sang > Reported-by: Stephen Warren > Signed-off-by: Doug Anderson Applied, thanks! __

Status of I2C mac-drivers needing attach_adapter?

Hi Ben, because I will push a patch to get rid of detach_adapter() from the I2C core in the next merge window, I was curious to find out about the status of attach_adapter(). I found commit 6cd3209967469f6e89d329deda6bb0b4700e7b62 (powerpc/powermac: New windfarm driver for PowerMac G5 (AGP) and X

Re: [PATCH v3 REPOST 2/4] i2c: i2c-ibm-iic: perform the transfer in the interrupt handler

Hi, thanks for the submission! > --- a/drivers/i2c/busses/i2c-ibm_iic.c > +++ b/drivers/i2c/busses/i2c-ibm_iic.c > @@ -58,6 +58,8 @@ static bool iic_force_fast; > module_param(iic_force_fast, bool, 0); > MODULE_PARM_DESC(iic_force_fast, "Force fast mode (400 kHz)"); > > +#define FIFO_FLUSH_T

Re: [PATCH v3 REPOST 4/4] i2c: i2c-ibm-iic: Implements a polling mode

On Fri, Dec 20, 2013 at 04:12:56PM +0100, jean-jacques hiblot wrote: > From: jean-jacques hiblot > > When no valid interrupt is defined for the controller, use polling to handle > the transfers. > The polling mode can also be forced with the "iic_force_poll" module > parameter. > > Signed-off-b

Re: [PATCH v3 REPOST 3/4] i2c: i2c-ibm-iic: Implements transfer abortion

On Fri, Dec 20, 2013 at 04:12:55PM +0100, jean-jacques hiblot wrote: > From: jean-jacques hiblot > > Clean-up properly when a transfer fails for whatever reason. > Cancel the transfer when the process is signaled. Please describe what you do a little. I wonder how you can remove so much code whi

Re: [PATCH] i2c-cpm: Fix build by adding of_address.h and of_irq.h

On Tue, Mar 18, 2014 at 04:10:24PM -0500, Scott Wood wrote: > Fixes a build break due to the undeclared use of irq_of_parse_and_map() > and of_iomap(). This build break was apparently introduced while the > driver was unbuildable due to the bug fixed by > 62c19c9d29e65086e5ae76df371ed2e6b23f00cd (

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

Hi, > This can describe the behavior of our current upstream driver[1], which > only support combine write-then-read. > > After checking with Xudong & HW guys, it seems our HW can do more. > On MT8135, it can support at most 2 messages, no matter read or write, > with the limitation that the len

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

> > + struct i2c_adapter_quirks *quirks; > > }; > > #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) > > > > I suggest to add const. > const struct i2c_adapter_quirks *quirks; > > also, in i2c-core.c, should modify: > const struct i2c_adapter_quirks *q = adap-

[PATCH] i2c: drop ancient protection against sysfs refcounting issues

ode before really nobody knows/understands anymore what this was for and if it has a subtle use. Reported-by: Pantelis Antoniou Signed-off-by: Wolfram Sang Cc: Greg Kroah-Hartman Cc: Jean Delvare Cc: Julia Lawall --- Of course, more testing is appreciated. Here is the coccinelle script

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

On Mon, Jan 19, 2015 at 07:12:10PM +, Russell King - ARM Linux wrote: > On Mon, Jan 19, 2015 at 07:55:56PM +0100, Wolfram Sang wrote: > > Back in the days, sysfs seemed to have refcounting issues and subsystems > > needed a completion to be safe. This is not the case anym

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

> > @@ -1184,8 +1183,7 @@ EXPORT_SYMBOL_GPL(i2c_new_dummy); > > > > static void i2c_adapter_dev_release(struct device *dev) > > { > > - struct i2c_adapter *adap = to_i2c_adapter(dev); > > - complete(&adap->dev_released); > > + /* empty, but the driver core insists we need a release functi

Re: [PATCH] i2c: drop ancient protection against sysfs refcounting issues

> > Right, and I'm not saying it should be, just move the existing logic > > into the release callback, and the code flow should be the same and we > > don't end up with an "empty" release callback. But as Russell says, even if we don't have the empty callback, we still create the problem shown b

Re: [PATCH] i2c/mpc: Fix ISR return value

On Fri, Jan 30, 2015 at 10:24:10AM +, Amit Tomar wrote: > ISR should not return IRQ_HANDLED for not handling anything. > This patch fixes the return value of ISR for the same case. > > > Signed-off-by: Amit Singh Tomar I can't apply the patch. There seem to be whitespace problems. Please f

Re: [RFC 02/11] i2c: add quirk checks to core

> > + if (msgs[i].flags & I2C_M_RD) { > > + if (i2c_quirk_exceeded(len, max_read)) > > + return i2c_quirk_error(adap, &msgs[i], "msg > > too long"); > > + } else { > > + if (i2c_quirk_exceeded(le

Re: [RFC 02/11] i2c: add quirk checks to core

On Mon, Jan 12, 2015 at 12:08:14PM +, Russell King - ARM Linux wrote: > On Fri, Jan 09, 2015 at 06:21:32PM +0100, Wolfram Sang wrote: > > +static int i2c_quirk_error(struct i2c_adapter *adap, struct i2c_msg *msg, > > char *err_msg) > > +{ > > + dev_err(&ada

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

On Mon, Jan 19, 2015 at 04:05:15PM +0100, Wolfram Sang wrote: > > > > + struct i2c_adapter_quirks *quirks; > > > }; > > > #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) > > > > > > > I suggest to add const. > >

[RFC V2 00/12] i2c: describe adapter quirks in a generic way

From: Wolfram Sang Here is the second version of the patch series to describe i2c adapter quirks in a generic way. For the motivation, please read description of patch 1. This is still RFC because I would like to do some more tests on my own, but I need to write a tool for that. However, I&#

[RFC V2 03/12] i2c: at91: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-at91.c | 32 +++- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 636fd2efad8850..b3a70e8fc653c5 100644

[RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-opal.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-opal.c b/drivers/i2c/busses/i2c-opal.c index 16f90b1a750894..b2788ecad5b3cb 100644 --- a/drivers

[RFC V2 02/12] i2c: add quirk checks to core

From: Wolfram Sang Let the core do the checks if HW quirks prevent a transfer. Saves code from drivers and adds consistency. Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/drivers

[RFC V2 05/12] i2c: qup: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-qup.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c index 4dad23bdffbe90..fdcbdab808e9fc 100644 --- a/drivers/i2c

[RFC V2 01/12] i2c: add quirk structure to describe adapter flaws

From: Wolfram Sang The number of I2C adapters which are not fully I2C compatible is rising, sadly. Drivers usually do handle the flaws, still the user receives only some errno for a transfer which normally can be expected to work. This patch introduces a formal description of flaws. One

[RFC V2 06/12] i2c: cpm: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-cpm.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index 2d466538b2e2c9..714bdc837769fd 100644 --- a/drivers/i2c

[RFC V2 10/12] i2c: viperboard: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-viperboard.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-viperboard.c b/drivers/i2c/busses/i2c-viperboard.c index 7533fa34d73711..47e88adf2011e1 100644 --- a

[RFC V2 07/12] i2c: axxia: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-axxia.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-axxia.c b/drivers/i2c/busses/i2c-axxia.c index 768a598d8d03ad..488c5d3bf9dba7 100644 --- a/drivers/i2c/busses

[RFC V2 09/12] i2c: powermac: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-powermac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-powermac.c b/drivers/i2c/busses/i2c-powermac.c index 60a53c169ed2b3..6abcf696e3594b 100644 --- a/drivers

[RFC V2 12/12] i2c: bcm-iproc: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-bcm-iproc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c index d3c89157b33774..f9f2c2082151e2 100644 --- a

[RFC V2 08/12] i2c: dln2: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-dln2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-dln2.c b/drivers/i2c/busses/i2c-dln2.c index b3fb86af4cbb14..b6f9ba7eb17564 100644 --- a/drivers/i2c/busses

[RFC V2 11/12] i2c: pmcmsp: make use of the new infrastructure for quirks

From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-pmcmsp.c | 42 - 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/drivers/i2c/busses/i2c-pmcmsp.c b/drivers/i2c/busses/i2c-pmcmsp.c index d37d9db6681e7b

Re: [RFC V2 03/12] i2c: at91: make use of the new infrastructure for quirks

On Wed, Feb 25, 2015 at 05:01:54PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Signed-off-by: Wolfram Sang Hi Ludovic, if you have a few minutes, could you please test this series? I'd like to include it in 4.1. and because at91 is using the quirk infrastructure in a mo

Re: [RFC V2 03/12] i2c: at91: make use of the new infrastructure for quirks

> You can add my > > Acked-by and Tested-By: Ludovic Desroches > > Tested on sama5d3, some problems with at24 eeprom on sama5d4 but it > doesn't come from the i2c quirks patch series. Thanks for testing! Are the eeprom problems something which needs fixing upstream? signature.asc Descripti

Re: [RFC V2 04/12] i2c: opal: make use of the new infrastructure for quirks

> I think we can't land up here by-passing the check for quirks so above > checks are duplicated here.. True. So, as Ben seems OK with write-then-anything, can you send me your changes as an incremental patch to mine with your Signed-off, please? Thanks, Wolfram signature.asc Description

  1   2   3   4   5   6   7   >