Hi Wolfram,yes, I'm still here. However, I don't have the hardware anymore to test the patch.Thanks, Jochen Am 29.06.2019 13:34 schrieb Wolfram Sang :On Sun, Jun 23, 2019 at 11:13:53PM +0200, Vasyl Gomonovych wrote:
> From: Vasyl
>
> Generated by: alloc_cast.cocci
>
> Signed-off-by: Vasyl
From: Vasyl
Generated by: alloc_cast.cocci
Signed-off-by: Vasyl
Acked-by: Jochen Friedrich
---
drivers/i2c/busses/i2c-cpm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
index 187900594e3d
Hi Sachin,
looks good to me.
Acked-By: Jochen Friedrich
Signed-off-by: Sachin Surendran mailto:sachin.surend...@alliedtelesis.co.nz>>
---
drivers/i2c/busses/i2c-cpm.c |8
1 file changed, 8 insertions(+)
diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c
Mark Ware schrieb:
> Recent DMA changes result in a BUG() when NULL is passed to
> dma_alloc_coherent in place of a device.
This seems to have happened in 4ae0ff606e848fa4957ebf8f97e5db5fdeec27be.
> Signed-off-by: Mark Ware
Acked-by: Jochen Friedrich
Thank
Hi Grant,
The following structure elements duplicate the information in
'struct device.of_node' and so are being eliminated. This patches
makes all readers of the following elements use device.of_node instead.
struct dev_archdata.prom_node (sparc)
struct dev_archdata.of_node (powerpc)
struct o
Wolfram Sang wrote:
Drop NO_IRQ as 0 is the preferred way to describe 'no irq'
Signed-off-by: Wolfram Sang
Acked-by: Grant Likely
Acked-by: Jochen Friedrich
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs
t; on the upper layers.
Makes sense. I2C transactions better shouldn't be interrupted or
data loss might happen.
> Signed-off-by: Bruno Morelli
> Signed-off-by: Michael Trimarchi
Acked-by: Jochen Friedrich
Thanks,
Jochen
___
Linuxppc-dev
Acked-by: Jochen Friedrich
Am 08.05.2023 um 22:51 schrieb Uwe Kleine-König:
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ig
Acked-By: Jochen Friedrich
Am 06.12.2023 um 23:24 schrieb Christophe Leroy:
sparse reports an error on some data that gets converted from be32.
That's because that data is typed u32 instead of __be32.
The type is correct, the be32_to_cpu() conversion is not.
Remove the conversion.
Rep
out_8(&cpm->i2c_reg->i2mod, 0x00);
- out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);/* Master mode */
+ out_8(&cpm->i2c_reg->i2com, I2COM_MASTER);/* Host mode */
I2COM_MASTER might be coming from the datasheet.
Maybe we can just drop the comment? The value we write is pret
Acked-by: Jochen Friedrich
Am 23.09.2020 um 16:08 schrieb nico.vi...@gmail.com:
From: Nicolas VINCENT
the i2c_ram structure is missing the sdmatmp field mentionned in
datasheet for MPC8272 at paragraph 36.5. With this field missing, the
hardware would write past the allocated memory done
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc866ads.dts | 10 +
arch/powerpc/boot/dts/mpc885ads.dts | 10 +
arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 +
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/bus
Hi Anton,
> Jochen, I kept your Signed-off-by, though this isn't your original
> patch. Hope you're okay with it. I also hope you'll test it. ;-)
>
that's OK.
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/ma
Hi Vitaly,
> I had an attempt a while ago to do this but haven't had enough time to get it
> completed, so
> I am glad to see it finally picked up. There was some sort of discussion that
> time, you seem to have some of those points
> addressed but something not, please
> check: http://lkml.org
Hi Anton,
> I also hope you'll test it. ;-)
yes.
> +int cpm_init_par_io(void)
> +{
> + struct device_node *np;
> + const u32 *num_ports;
> +
> + np = of_find_node_by_name(NULL, "fsl,cpm1-pario");
> + if (!np)
> + return -ENOENT;
> +
I guess this should be:
This patch adds device tree source, default config and setup code for
DBox2 devices.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/dbox2.dts | 263
arch/powerpc/configs/dbox2_defconfig | 1042 ++
arch/p
This patch adds device tree source, default config and setup code for
DBox2 devices.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/dbox2.dts | 263
arch/powerpc/configs/dbox2_defconfig | 1042 ++
arch/p
Jochen Friedrich schrieb:
> This patch adds device tree source, default config and setup code for
> DBox2 devices.
please ignore this posting. This patch doesn't compile cleanly, i'll repost a
fixed patch.
Thanks,
Jochen
___
Linuxppc-
This patch adds device tree source, default config and setup code for
DBox2 devices.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/dbox2.dts | 263
arch/powerpc/configs/dbox2_defconfig | 1042 ++
arch/p
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions
from the cpm dependent include file to common cpm.h
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
include/asm-powerpc/commproc.h | 65 ---
include/asm-powerpc/cpm.h
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 +
arch/powerpc/boot/dts/mpc866ads.dts | 10 +
arch/powerpc/boot/dts/mpc885ads.dts | 10 +
arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 +
drivers/i2c/bu
Hi David,
>> +[EMAIL PROTECTED] {
>> +compatible = "betaresearch,dbox2-localbus";
>
> Is this bus interface really board specific? I would have thought the
> localbus bridge would have been part of the SoC in which case the
> compatible string should mention the 823 rather than t
Hi Arnd,
>> This patch adds device tree source, default config and setup code for
>> DBox2 devices.
>
ia > Cool stuff. I used to have one of these boxes myself, maybe I should
> get one again when it's hitting mainline.
>
> Is this already a complete port, or do you also need some device
> drive
Hi David,
+ // Port D is LCD exclusive. Don't export as GPIO
+ CPM1_PIO: [EMAIL PROTECTED] {
+ compatible = "fsl,cpm1-pario";
+ reg = <970 180>;
+ num-ports = <3>;
t the watchdog in early board setup. Later, a kernel timer
is used to reset the watchdog until the watchdog driver is opened from
user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and
mpc83xx_wdt.c (untested on this platform).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
If a freescale watchdog device node is present, reset the watchdog
while waiting for serial input.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/cpm-serial.c | 33 -
1 files changed, 32 insertions(+), 1 deletions(-)
diff --git
This patch adds device tree source, default config and setup code for
DBox2 devices.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/Makefile |4 +-
arch/powerpc/boot/cuboot-dbox2.c | 280
arch/powerpc/boot/dts/dbo
Update .gitignore as needed by dtc addition.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/.gitignore |1 +
arch/powerpc/boot/dtc-src/.gitignore |3 +++
2 files changed, 4 insertions(+), 0 deletions(-)
create mode 100644 arch/powerpc/boot/d
Hi Jon,
> Convert MPC i2c driver from being a platform_driver to an open firmware
> version. Error returns were improved. Routine names were changed from fsl_ to
> mpc_ to make them match the file name
I did the same for my i2c-cpm. Tested with the frontprocessor driver (dbox2
specific) conver
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 +
arch/powerpc/boot/dts/mpc866ads.dts | 10 +
arch/powerpc/boot/dts/mpc885ads.dts | 10 +
arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 +
drivers/i2c/bu
Hi Scott,
> These unit addresses look wrong.
I know. These have (hopefully) been fixed in v3.
> What does dbox2-config mean?
I used it to search for the vendor info byte in the flash. It has been moved to
the boot wrapper in v3.
Later this should all be moved to u-boot, IMHO.
>> +
Hi David,
>> +/ {
>> +model = "unknown,dbox2"; // boot wrapper fills in correct manufacturer
>
> Probably better just to leave model out of the dts and let the
> bootwrapper add it.
Unfortunately, dtc requires a model:
$ dtc arch/powerpc/boot/dts/dbox2.dts
DTC: dts->dts on file "arch/power
Hi Jon,
>>> The following series implements standard linux module aliasing for i2c
>>> modules on arch=powerpc. It then converts the mpc i2c driver from being a
>>> platform driver to an open firmware one. I2C device names are picked up
>>> from the device tree. Module aliasing is used to trans
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/Kconfig |2 +
arch/powerpc/sysdev/commproc.c | 162 +++-
2 files changed, 163 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/8xx/Kconfig
b/arch/p
t the watchdog in early board setup. Later, a kernel timer
is used to reset the watchdog until the watchdog driver is opened from
user space. This replaces mpc8xx_wdt.c (only usable for ARCH=ppc) and
mpc83xx_wdt.c (untested on this platform).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
If a freescale watchdog device node is present, reset the watchdog
while waiting for serial input.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/Makefile |2 +-
arch/powerpc/boot/cpm-serial.c |6
arch/powerpc/boot/cuboot-8xx.c |1 +
arch/p
Hi Grant,
>> arch/powerpc/platforms/8xx/Kconfig |2 +
>> arch/powerpc/sysdev/commproc.c | 162
>> +++-
>
> Is this 8xx only? Can it live in arch/powerpc/platforms/8xx?
According to the freescale docs, the GPIO ports are part of the CPM1. So I've
put th
Hi Kumar,
> Why are you commenting on mpc83xx_wdt with respect to pq1_wdt?
>
> Also, is this driver just for PQ1 platforms or PQ1 & PQ2? If its just
> pq1 we should probably call it pq1_wdt*
It should be for pq1, pq2 and pq2pro. However, i only have the possibility
to test this on pq1.
>> arc
Hi Kumar,
>> http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048473.html
>>
>> ^^ fixed phy support for fs_enet. Needed for some other boards, I
>> presume.
>
> Hmm, its vitaly picking this one up? if not I can.
That would be great. Jeff Garzik agreed to have this patch go through the
P
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid
of the arch dependent includes in mpc8xx.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/mpc885ads_setup.c |2 +
include/asm-powerpc/mpc8xx.h
m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc
tree. Remove it.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/ppc/syslib/ppc8xx_pic.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/ppc/syslib/ppc8xx_pic.h b/arch/ppc/
Hi Kumar,
>> Ok now that makes sense, thanks
>
> So I'll ask, what serial input are you waiting for from the boot wrapper?
It's the editor for the kernel command line.
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left
in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only
defined in the headers. Remove this dead code.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
Hi,
this is a series against paulus for-2.6.25 tree to clean up various 8xx related
stuff.
The series can be pulled from git://git.bocc.de/dbox2.git cleanup.
[POWERPC] Remove unused m8xx_cpm_hostalloc/free/dump()
[POWERPC] Rename m8xx_pic_init to mpc8xx_pics_init
[POWERPC] Remove unneeded and mi
If a freescale watchdog device node is present, reset the watchdog
while waiting for serial input.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/Makefile |2 +-
arch/powerpc/boot/cpm-serial.c |6 +++
arch/powerpc/boot/cuboot-8xx.c |1 +
arch/p
m8xx_calibrate_decr seems to be a misspelled prototype for
mpc8xx_calibrate_decr. As it's not needed anyways, just remove it.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/m8xx_setup.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
d
Scott Wood schrieb:
>> +void watchdog_poke(void)
>> +{
>> +if (wdt) {
>> +out_be16(&wdt->swsrr, 0x556c);
>> +out_be16(&wdt->swsrr, 0xaa39);
>> +}
>> +}
>
> This should be a function pointer, to allow for other watchdog types.
Thanks for the comments. Stephen Rothwell also
Hi Alan,
>> If a freescale watchdog device node is present, reset the watchdog
>> while waiting for serial input.
>
> Why ? We normally rely on user space for watchdog management as only the
> fact user space is behaving really proves a box is happy ?
This is in the boot wrapper code, not in the
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the
function to use the same name space as the rest of the mpc8xx
specific funtions and to be more meaningful.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |2 +-
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific
prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now
unneeded sysdev/commproc.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |3 +--
arch/p
Hi Kumar,
> I'm sure I missed some patches for 2.6.25, so please point any out that
> people would like to see get in.
What about this one, now that the fixed phy parts are in:
http://patchwork.ozlabs.org/linuxppc/patch?person=1023&id=15654
Thanks,
Jochen
___
Hi Jean,
> Do you have an updated patch addressing Stephen's comment?
>
> Note: you'd rather send updates of this patch to the i2c list rather
> than LKML.
I'm currently looking at that last patches from Jon and try to make this
driver fit in there (+ the class override stuff).
Note: will do. I
Hi,
this is a series against paulus for-2.6.25 tree to clean up various 8xx related
stuff.
The series can be pulled from git://git.bocc.de/dbox2.git cleanup.
Patch 6 has been modified to remove the #ifdefs as suggested by Arndt Bergmann.
Patch 8 is a new one.
[POWERPC] Remove unused m8xx_cpm_hos
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left
in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only
defined in the headers. Remove this dead code.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
m8xx_calibrate_decr seems to be a misspelled prototype for
mpc8xx_calibrate_decr. As it's not needed anyways, just remove it.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/m8xx_setup.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
d
m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc
tree. Remove it.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/ppc/syslib/ppc8xx_pic.h |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/ppc/syslib/ppc8xx_pic.h b/arch/ppc/
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific
prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now
unneeded sysdev/commproc.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |3 +--
arch/p
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid
of the arch dependent includes in mpc8xx.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/mpc885ads_setup.c |2 +
include/asm-powerpc/mpc8xx.h
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also
rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the
includes accordingly.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |2 +-
arch/p
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions
from the cpm dependent include file to common cpm.h
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
include/asm-powerpc/cpm.h | 73
include/asm-powerpc/cpm1.h
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the
function to use the same name space as the rest of the mpc8xx
specific funtions and to be more meaningful.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c
Hi Kumar,
> Do we really need the prototypes you moved into asm/mpc8xx.h here? can
> they just live in platforms/8xx/8xx.h or something like that?
At least drivers/pcmcia/m8xx_pcmcia.c uses the symbol m8xx_pcmcia_ops
which is conditionally defined in platforms/8xx/m8xx_setup.c. However,
this dr
Hi,
this is a series against paulus for-2.6.25 tree to clean up various 8xx related
stuff.
The series can be pulled from git://git.bocc.de/dbox2.git cleanup.
Old patches 2+4 have been merged into Patch 2. Patch 4 has been modified to
move the
prototypes into a new platforms/8xx/mpc8xx.h. Patch 5
m8xx_cpm_hostalloc is still defined in commproc.c, but no users are left
in the kernel tree. m8xx_cpm_hostfree and m8xx_cpm_hostdump are only
defined in the headers. Remove this dead code.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
m8xx_pic_init calls both mpc8xx_pic_init and cpm_pic_init. Renaming the
function to use the same name space as the rest of the mpc8xx
specific funtions and to be more meaningful.
m8xx_pic_init is declared in ppc8xx_pic.h but defined nowhere in the ppc
tree. Remove it.
Signed-off-by: Jochen
m8xx_calibrate_decr seems to be a misspelled prototype for
mpc8xx_calibrate_decr. As it's not needed anyways, just remove it.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/m8xx_setup.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
d
Move cpm1 specific prototypes to asm/commproc.h and mpc8xx specific
prototypes to asm/mpc8xx.h. Adjust includes accordingly. Remove now
unneeded sysdev/commproc.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |2 +-
arch/p
Directly include mpc885ads.h from mpc885ads_setup.c. Now we can get rid
of the arch dependent includes in mpc8xx.h.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/m8xx_setup.c |3 +--
arch/powerpc/platforms/8xx/mpc885ads_setup.c |1 +
inclu
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also
rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the
includes accordingly.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |1 +
arch/p
Buffer descriptors are used by both CPM1 and CPM2. Move the definitions
from the cpm dependent include file to common cpm.h
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
include/asm-powerpc/cpm.h | 73
include/asm-powerpc/cpm1.h
Hi Kumar,
>> drivers/net/fec.c |8
>> drivers/net/fec.h |2 +-
>
> asm-m68knommu/commproc.h ?? these are only built on coldfire.
Yes. Here I just removed dead code (commented out using #ifdef on coldfire).
Apparently the dri
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 +
arch/powerpc/boot/dts/mpc866ads.dts | 10 +
arch/powerpc/boot/dts/mpc885ads.dts | 10 +
arch/powerpc/platforms/8xx/mpc885ads_setup.c |5 +
drivers/i2c/bu
fec.c is only used on M68k Coldfire CPUs. Remove leftover
PowerPC code from this driver.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/net/fec.c | 136 +---
1 files changed, 3 insertions(+), 133 deletions(-)
diff --git a/d
Rename commproc.[ch] to cpm1.[ch] to be more consistent with cpm2. Also
rename cpm2_common.c to cpm2.c as suggested by Scott Wood. Adjust the
includes accordingly.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/ep88xc.c |1 +
arch/p
Hi Frans,
> Jochen Friedrich wrote:
>> +++ b/drivers/net/fec.c
>> @@ -23,6 +23,9 @@
>> *
>> * Bug fixes and cleanup by Philippe De Muyter ([EMAIL PROTECTED])
>> * Copyright (c) 2004-2006 Macq Electronique SA.
>> + *
>> + * This driver is
Hi Anton,
> +static void qe_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
> +{
> + struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
> + struct port_regs *regs = mm_gc->regs;
> + u32 pin_mask;
> + u32 tmp_val;
> +
> + /* calculate pin location */
> + pin_
Hi Bryan,
>> +
>> + /* register new adapter to i2c module... */
>> +
>> + result = i2c_add_adapter(&cpm->adap);
>
> As I was pointed before, please use the new style i2c driver interface:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=991dee591a99d035796
Hi Grant,
> Currently, the kernel uses CONFIG_DEVICE_TREE to wrap a kernel image
> with a fdt blob which means for any given configuration only one dts
> file can be selected and so support for only one board can be built
>
> This patch moves the selection of the default .dts file out of the kern
Add CPM i2c support for mpc8272, mpc866 and mpc885 boards.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++
arch/powerpc/boot/dts/mpc866ads.dts | 10 ++
arch/powerpc/boot/dts/mpc885ads.dts
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-cpm.c | 759 ++
3 files changed, 770 insertions(+), 0 deletions(-)
create mode 100644 driver
Hi Rognlien,
> The latest commits to powerpc.git removes commproc.h files used by
> arch/powerpc/platforms/8xx/adder875.c
>
> The kernel fails to build for the adder configs.
This should fix it:
diff --git a/arch/powerpc/platforms/8xx/adder875.c
b/arch/powerpc/platforms/8xx/adder875.c
index c
Hi Rognlien,
> Hi Rognlien,
>
>> The latest commits to powerpc.git removes commproc.h files used by
>> arch/powerpc/platforms/8xx/adder875.c
>>
>> The kernel fails to build for the adder configs.
>
> This should fix it:
>
> diff --git a/arch/powerpc/platforms/8xx/adder875.c
> b/arch/powerpc/p
Hi Yuri,
> Here is the patch which makes Linux-2.6 swap routines operate correctly on
> the ppc-8xx-based machines.
is there any 8xx board left which isn't ported to ARCH=powerpc?
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
h
Hi Yuri,
> Does anybody use swap with some of the 8xx-based boards supported in
> powerpc branch ?
modded DBox2 boxes do. Unfortunately, i don't have such a modded box.
The tuxbox project currently uses a really ugly hack to support swapping:
http://git.bocc.de/cgi-bin/gitweb.cgi?p=dbox2.git;a=
Hi Nima,
> I've got a couple of comments about the above patch - I'm not quite sure
> how to add my comments to the ozlab.org site.
simply replying to the original mail will add your comments.
> 1 -
> -- a/arch/powerpc/boot/dts/mpc8272ads.dts
> [snip]
> + [EMAIL PROTECTED]
Hi Jean,
>> +/*
>> + * Wait for patch from Jon Smirl
>> + * #include "powerpc-common.h"
>> + */
>
> It doesn't make sense to merge this comment upstream.
I know you don't like the patch from Jon Smirl and you also explained your
reasons.
Fortunately, I2c no longer uses numeric device IDs but na
Hi Olof,
>> 2. record the I2c name in the dts tree, either as seperate tag (like
>> linux,i2c-name="")
>>or as additional compatible entry (like compatible="...",
>> "linux,").
>
> I have to say no on this one. The device tree is not supposed to know
> about how linux uses devices, there ar
Hi Olof,
> And even if you DO decide to go that route, guess what? You need a
> translation table just as with (3) anyway!
True.
3. use a glue layer with a translation map.
>>> In my opinion this is an OK solution since the same information has to
>>> be added somewhere already anyway -- ei
ned!
ERROR: "cpmp" [drivers/net/fs_enet/fs_enet.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: Scott Wood <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c|3 +++
arch/pow
/kernel/built-in.o:(__ksymtab+0x198): undefined reference to
`cpm_free_handler'
arch/powerpc/kernel/built-in.o:(__ksymtab+0x1a0): undefined reference to
`cpm_install_handler'
make: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Signed-off-by:
Hi,
this is a resend of 4 patches i've sent to linuxppc-embedded before. Later i
found the MAINTAINERS entry has been updated.
The series can be pulled from git://git.bocc.de/dbox2.git for-2.6.24
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-de
This patch moves the CPM command handling into commproc.c
for CPM1 and cpm2_common.c. This is yet another preparation
to get rid of drivers accessing the CPM via the global cpmp.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
ned!
ERROR: "cpmp" [drivers/net/fs_enet/fs_enet.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: Scott Wood <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c|3 +++
arch/pow
fpi->cp_command should be overwritten only if CONFIG_PPC_CPM_NEW_BINDING
is NOT set. Otherwise it is already set from the device tree.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Cc
PORTA and PORTB have odr registers, as well. However, the PORTB odr
register is only 16bit.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: Scott Wood <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c | 19 ---
1 files changed, 16 insertions(+),
Hi Grant,
> Is this really a good idea? A globally accessable pointer to the region?
No it's not. But drivers are actually using the pointer and due to the
missing export, they currently don't compile as module.
>> +EXPORT_SYMBOL(cpm_setbrg);
>
> EXPORT_SYMBOL_GPL?
Agreed.
Thanks,
Jochen
___
Hi Vitaly,
>>> + printk(KERN_ERR "%s(): Not able to issue CPM command\n",
>>> + __FUNCTION__);
>>> + return -EIO;
>>>
>> Do these need to be protected with a spin lock?
>>
> Even that might be not enough - we may have simultaneous call of this func in
> non
This patch moves the CPM command handling into commproc.c
for CPM1 and cpm2_common.c. This is yet another preparation
to get rid of drivers accessing the CPM via the global cpmp.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
This patch moves the CPM command handling into commproc.c
for CPM1 and cpm2_common.c. This is yet another preparation
to get rid of drivers accessing the CPM via the global cpmp.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
Hi Vitaly,
>> Maybe this is a stupid question, but why did you choose
>> EXPORT_SYMBOL_GPL and not EXPORT_SYMBOL?
>>
> To prevent using those pointers from within non-GPL modules. kind of policy
> now...
In particular in this case, as these pointers are currently not exported, at
all. They
are
1 - 100 of 202 matches
Mail list logo
