Scott Wood schrieb: >> +void watchdog_poke(void) >> +{ >> + if (wdt) { >> + out_be16(&wdt->swsrr, 0x556c); >> + out_be16(&wdt->swsrr, 0xaa39); >> + } >> +} > > This should be a function pointer, to allow for other watchdog types.
Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c is too generic. I think the pq watchdog is easy enough to keep it in the generic watchdog.c file, but the function pointer definitely is the way to go. I'll resubmit. Thanks, Jochen _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev