[PATCH 07/10] 8xx: Restore _PAGE_WRITETHRU

2009-11-15 Thread Joakim Tjernlund
8xx has not had WRITETHRU due to lack of bits in the pte. After the recent rewrite of the 8xx TLB code, there are two bits left. Use one of them to WRITETHRU. Perhaps use the last SW bit to PAGE_SPECIAL or PAGE_FILE? Signed-off-by: Joakim Tjernlund --- arch/powerpc/include/asm/pte-8xx.h |5

[PATCH 08/10] 8xx: start using dcbX instructions in various copy routines

2009-11-15 Thread Joakim Tjernlund
Now that 8xx can fixup dcbX instructions, start using them where possible like every other PowerPc arch do. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/misc_32.S | 18 -- arch/powerpc/lib/copy_32.S| 24 2 files changed, 0 insertions

[PATCH 09/10] 8xx: Remove DIRTY pte handling in DTLB Error.

2009-11-15 Thread Joakim Tjernlund
There is no need to do set the DIRTY bit directly in DTLB Error. Trap to do_page_fault() and let the generic MM code do the work. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 96 1 files changed, 0 insertions(+), 96 deletions

[PATCH 10/10] 8xx: DTLB Miss cleanup

2009-11-15 Thread Joakim Tjernlund
Use symbolic constant for PRESENT and avoid branching. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S index 2e9f9c0

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-16 Thread Joakim Tjernlund
Scott Wood wrote on 16/11/2009 22:27:41: > > On Mon, Nov 16, 2009 at 03:00:09PM -0600, Scott Wood wrote: > > On Sun, Nov 15, 2009 at 06:09:27PM +0100, Joakim Tjernlund wrote: > > > [I used the wrong branch, this will hopefully not conflict] > > > > > > Thi

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-17 Thread Joakim Tjernlund
Scott Wood wrote on 17/11/2009 01:40:11: > From: > > Scott Wood > > To: > > Joakim Tjernlund > > Cc: > > "linuxppc-...@ozlabs.org" , Rex Feany > > > Date: > > 17/11/2009 01:40 > > Subject: > > Re: [PATCH 00/10] Fix 8xx M

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-18 Thread Joakim Tjernlund
Scott Wood wrote on 18/11/2009 22:08:24: > > Joakim Tjernlund wrote: > > Scott Wood wrote on 17/11/2009 01:40:11: > >> No... I only meant that the ITLB pinning got rid of the boot hang. > >> > >> When I mentioned the EFAULTs before you said, "N

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-18 Thread Joakim Tjernlund
Scott Wood wrote on 18/11/2009 22:58:26: > > Joakim Tjernlund wrote: > > Yeah, those are the ones that will trigger a dcbX TLB fault, > > copy_tofrom_user would be my guess. Perhaps I missed something > > in the conversions? That is, maybe some of these routines are

[PATCH 00/10 v6] Fix 8xx MMU/TLB

2009-11-20 Thread Joakim Tjernlund
Yet again an iteration of the series. Rex & Scott, please test and signoff. Changes since last version: - Fix rlwimi insn(from Scott) Joakim Tjernlund (10): 8xx: invalidate non present TLBs 8xx: Update TLB asm so it behaves as linux mm expects. 8xx: Tag DAR with 0x00f0 to catch b

[PATCH 01/10] 8xx: invalidate non present TLBs

2009-11-20 Thread Joakim Tjernlund
8xx sometimes need to load a invalid/non-present TLBs in it DTLB asm handler. These must be invalidated separaly as linux mm don't. Signed-off-by: Joakim Tjernlund --- arch/powerpc/mm/fault.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/mm/fa

[PATCH 02/10] 8xx: Update TLB asm so it behaves as linux mm expects.

2009-11-20 Thread Joakim Tjernlund
when a page has been made dirty. - Proper RO/RW mapping of user space. - Free up 2 SW TLB bits in the linux pte(add back _PAGE_WRITETHRU ?) - kernel RO/user NA support. Cons: - A few more instructions in the TLB Miss routines. Signed-off-by: Joakim Tjernlund --- arch/powerpc/include/asm/pte

[PATCH 03/10] 8xx: Tag DAR with 0x00f0 to catch buggy instructions.

2009-11-20 Thread Joakim Tjernlund
dcbz, dcbf, dcbi, dcbst and icbi do not set DAR when they cause a DTLB Error. Dectect this by tagging DAR with 0x00f0 at every exception exit that modifies DAR. Test for DAR=0x00f0 in DataTLBError and bail to handle_page_fault(). Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel

[PATCH 04/10] 8xx: Always pin kernel instruction TLB

2009-11-20 Thread Joakim Tjernlund
Various kernel asm modifies SRR0/SRR1 just before executing a rfi. If such code crosses a page boundary you risk a TLB miss which will clobber SRR0/SRR1. Avoid this by always pinning kernel instruction TLB space. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S |2 +- 1

[PATCH 05/10] 8xx: Fixup DAR from buggy dcbX instructions.

2009-11-20 Thread Joakim Tjernlund
This is an assembler version to fixup DAR not being set by dcbX, icbi instructions. There are two versions, one uses selfmodifing code, the other uses a jump table but is much bigger(default). Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 147

[PATCH 06/10] 8xx: Add missing Guarded setting in DTLB Error.

2009-11-20 Thread Joakim Tjernlund
only DTLB Miss did set this bit, DTLB Error needs too otherwise the setting is lost when the page becomes dirty. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH 07/10] 8xx: Restore _PAGE_WRITETHRU

2009-11-20 Thread Joakim Tjernlund
8xx has not had WRITETHRU due to lack of bits in the pte. After the recent rewrite of the 8xx TLB code, there are two bits left. Use one of them to WRITETHRU. Perhaps use the last SW bit to PAGE_SPECIAL or PAGE_FILE? Signed-off-by: Joakim Tjernlund --- arch/powerpc/include/asm/pte-8xx.h |5

[PATCH 08/10] 8xx: start using dcbX instructions in various copy routines

2009-11-20 Thread Joakim Tjernlund
Now that 8xx can fixup dcbX instructions, start using them where possible like every other PowerPc arch do. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/misc_32.S | 18 -- arch/powerpc/lib/copy_32.S| 24 2 files changed, 0 insertions

[PATCH 09/10] 8xx: Remove DIRTY pte handling in DTLB Error.

2009-11-20 Thread Joakim Tjernlund
There is no need to do set the DIRTY bit directly in DTLB Error. Trap to do_page_fault() and let the generic MM code do the work. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 96 1 files changed, 0 insertions(+), 96 deletions

[PATCH 10/10] 8xx: DTLB Miss cleanup

2009-11-20 Thread Joakim Tjernlund
Use symbolic constant for PRESENT and avoid branching. Signed-off-by: Joakim Tjernlund --- arch/powerpc/kernel/head_8xx.S | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S index 36af721

Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB

2009-11-21 Thread Joakim Tjernlund
Rex Feany wrote on 20/11/2009 21:28:38: > > Thus spake Joakim Tjernlund (joakim.tjernl...@transmode.se): > > > Yet again an iteration of the series. > > Rex & Scott, please test and signoff. > > Changes since last version: > > - Fix rlwimi insn(from Scott

Re: [PATCH] zlib: Optimize inffast when copying direct from output

2009-11-26 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 24/11/2009 04:12:43: > > On Tue, 2009-11-10 at 10:00 +0100, Joakim Tjernlund wrote: > > JFFS2 uses lesser compression ratio and inflate always > > ends up in "copy direct from output" case. > > This patch tries to optimize t

Re: [PATCH] zlib: Optimize inffast when copying direct from output

2009-11-26 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 26/11/2009 09:46:58: > > On Thu, 2009-11-26 at 09:30 +0100, Joakim Tjernlund wrote: > > > I'm not sure its going to work to use get_unaligned() like that on all > > > archs .. it might be definitely something to discuss on some more &

Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB

2009-11-27 Thread Joakim Tjernlund
Scott and Rex, I think we need you s-o-b to make it into the kernel proper. Marcelo and Vitaly, I noticed you guys are listed as 8xx maintainers. Have you seen this? What do you think? Jocke Joakim Tjernlund wrote on 20/11/2009 11:21:01: > > Yet again an iteration of the series.

Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB

2009-11-30 Thread Joakim Tjernlund
Scott Wood wrote on 30/11/2009 23:25:30: > > Benjamin Herrenschmidt wrote: > > On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: > >> Scott and Rex, I think we need you s-o-b to make it into the kernel proper. > >> > >> Marcelo and Vitaly, I noticed

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Joakim Tjernlund
> > Ben Dooks said the following: > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > >> wrote: > >> > This fixes MAL (arbitration lost) bug caused by illegal use of > >> > RSTA (repeated START) after STOP condition generate

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-12-03 Thread Joakim Tjernlund
> > On Thu, Dec 03, 2009 at 04:09:57PM +0100, Michael Lawnick wrote: > > Ben Dooks said the following: > > > On Tue, May 26, 2009 at 01:30:21PM +0200, Esben Haabendal wrote: > > >> On Tue, May 19, 2009 at 7:22 AM, Esben Haabendal > > >> wrote: > > >> > This fixes MAL (arbitration lost) bug caused

Re: [PATCH 00/10 v6] Fix 8xx MMU/TLB

2009-12-08 Thread Joakim Tjernlund
Scott Wood wrote on 30/11/2009 23:25:30: > > Benjamin Herrenschmidt wrote: > > On Fri, 2009-11-27 at 11:57 +0100, Joakim Tjernlund wrote: > >> Scott and Rex, I think we need you s-o-b to make it into the kernel proper. > >> > >> Marcelo and Vitaly, I noticed

Re: [PATCH 04/10] 8xx: Always pin kernel instruction TLB

2009-12-08 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 09/12/2009 05:19:59: > From: Benjamin Herrenschmidt > To: Joakim Tjernlund > Cc: Scott Wood , "linuxppc-...@ozlabs.org" d...@ozlabs.org>, Rex Feany > Date: 09/12/2009 05:20 > Subject: Re: [PATCH 04/10] 8xx: Always pin kernel instruc

Re: [PATCH 04/10] 8xx: Always pin kernel instruction TLB

2009-12-09 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 09/12/2009 09:56:35: > > On Wed, 2009-12-09 at 08:39 +0100, Joakim Tjernlund wrote: > > The later isn't as simple :) I believe the bulk of such code in > > entry_32.S. > > Yeah but it would be useful for hash I suppose if one reall

Re: Deprecating of_platform, the path from here...

2009-12-11 Thread Joakim Tjernlund
> > On Thursday 10 December 2009, Grant Likely wrote: > > On Wed, Dec 9, 2009 at 5:21 PM, David Miller wrote: > > > From: David Miller > > > Date: Wed, 09 Dec 2009 16:15:50 -0800 (PST) > > >> What a shame, it's one of the cleanest driver probing models > > >> in the tree. > > > > > > And BTW, hav

ucc_geth broken w.r.t fixed_link PHY

2009-03-20 Thread Joakim Tjernlund
Trying to upgrade to latest linus latest just to see if it still works I get this: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0151270 Oops: Kernel access of bad area, sig: 11 [#1] TMCUTU NIP: c0151270 LR: c0151270 CTR: c0017760 REGS: cf8

Fw: [PATCH] ucc_geth: Correct fixed_link OOPS.

2009-03-20 Thread Joakim Tjernlund
hmm, this mail didn't seem to reach the lists. Resending Jocke - Forwarded by Joakim Tjernlund/Transmode on 20/03/2009 20:42 - From: Joakim Tjernlund To: le...@freescale.com, net...@vger.kernel.org, linuxppc-dev@ozlabs.org Cc: Joakim Tjernlund Date: 20/03/2009 18:01 Subject: [

Re: Fw: [PATCH] ucc_geth: Correct fixed_link OOPS.

2009-03-20 Thread Joakim Tjernlund
Anton Vorontsov wrote on 20/03/2009 21:07:40: > > On Fri, Mar 20, 2009 at 08:43:56PM +0100, Joakim Tjernlund wrote: > > hmm, this mail didn't seem to reach the lists. Resending > > > > Jocke > > - Forwarded by Joakim Tjernlund/Transmode on 20/03/2009 20:

[PATCH] ucc_geth: Convert to net_device_ops

2009-03-23 Thread Joakim Tjernlund
Signed-off-by: Joakim Tjernlund --- Sorry for the WS damaged patch, but my current company mailer cannot handle inline patches. Due to this we are setting up a new mail system but it will be a few days before this is ready. Therefore I am attaching this patch as well, use that one to apply

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread Joakim Tjernlund
David Miller wrote on 23/03/2009 19:49:28: > > From: Joakim Tjernlund > Date: Mon, 23 Mar 2009 11:17:39 +0100 > > > Sorry for the WS damaged patch, but my current company mailer cannot > > handle inline patches. Due to this we are setting up a new mail system >

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread Joakim Tjernlund
David Miller wrote on 24/03/2009 22:22:09: > > From: Joakim Tjernlund > Date: Tue, 24 Mar 2009 11:37:11 +0100 > > > David Miller wrote on 23/03/2009 19:49:28: > > > > > > From: Joakim Tjernlund > > > Date: Mon, 23 Mar 2009 11:17:39 +0100 > >

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread Joakim Tjernlund
David Miller wrote on 24/03/2009 23:49:02: > > From: Joakim Tjernlund > Date: Tue, 24 Mar 2009 23:45:13 +0100 > > > I don't follow. Are these mandatory now? They were not in the old > > impl. either. > > See ether_setup() which is called indirectly via a

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread Joakim Tjernlund
David Miller wrote on 25/03/2009 00:29:13: > From: Joakim Tjernlund > Date: Wed, 25 Mar 2009 00:08:53 +0100 > > > David Miller wrote on 24/03/2009 23:49:02: > > > > > > From: Joakim Tjernlund > > > Date: Tue, 24 Mar 2009 23:45:13 +0100 > > &g

[PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund Date: Tue, 24 Mar 2009 10:19:27 +0100 Subject: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context. Also increase NAPI weight somewhat. This will make the system alot more responsive wh

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
Eric Dumazet wrote on 25/03/2009 15:04:26: > Joakim Tjernlund a écrit : > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > > From: Joakim Tjernlund > > Date: Tue, 24 Mar 2009 10:19:27 +0100 > > Subject: [PATCH] ucc_geth: Move freeing

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
Anton Vorontsov wrote on 25/03/2009 15:25:40: > > On Wed, Mar 25, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: > > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > > From: Joakim Tjernlund > > Date: Tue, 24 Mar 2009 10:19:27 +0100

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
Anton Vorontsov wrote on 25/03/2009 15:25:40: > On Wed, Mar 25, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: > > >>From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 > > From: Joakim Tjernlund > > Date: Tue, 24 Mar 2009 10:19:27 +0100 > >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread Joakim Tjernlund
David Miller wrote on 25/03/2009 22:40:41: > > From: Eric Dumazet > Date: Wed, 25 Mar 2009 15:04:26 +0100 > > > Joakim Tjernlund a écrit : > > > + /* Tx event processing */ > > > + spin_lock(&ugeth->lock); > > > + for (i = 0; i <

[PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-26 Thread Joakim Tjernlund
The line: if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) break; in ucc_geth_tx() didn not make sense to me. Rework & cleanup this logic to something understandable. Signed-off-by: Joakim Tjernlund --- drivers/net/uc

[PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-26 Thread Joakim Tjernlund
Also set NAPI weight to 64 as this is a common value. This will make the system alot more responsive while ping flooding the ucc_geth ethernet interaface. Signed-off-by: Joakim Tjernlund --- drivers/net/ucc_geth.c | 32 drivers/net/ucc_geth.h |1 - 2 files

Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-26 Thread Joakim Tjernlund
Anton Vorontsov wrote on 26/03/2009 14:39:18: > > Hi Joakim, Hi Anton > > On Thu, Mar 26, 2009 at 01:54:37PM +0100, Joakim Tjernlund wrote: > > The line: > > if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) > >break; >

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-26 Thread Joakim Tjernlund
Eric Dumazet wrote on 26/03/2009 15:15:25: > > Joakim Tjernlund a écrit : > > Also set NAPI weight to 64 as this is a common value. > > This will make the system alot more responsive while > > ping flooding the ucc_geth ethernet interaface. > > >

[PATCH] ucc_geth: Rework the TX logic.

2009-03-26 Thread Joakim Tjernlund
The line: if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) break; in ucc_geth_tx() didn not make sense to me. Rework & cleanup this logic to something understandable. --- Reworked the patch according to Antons comments. drivers/net/ucc_geth.c | 66 ++

Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-26 Thread Joakim Tjernlund
Anton Vorontsov wrote on 26/03/2009 19:05:43: > On Thu, Mar 26, 2009 at 05:43:25PM +0100, Joakim Tjernlund wrote: > [...] > > > bd == ugeth->confBd[txQ] > > > and > > > !in_be32((u32 __iomem *)(bd+4)) > > > > > > Are not equivalent

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-26 Thread Joakim Tjernlund
Anton Vorontsov wrote on 26/03/2009 19:03:54: > > On Thu, Mar 26, 2009 at 06:44:05PM +0100, Joakim Tjernlund wrote: > > The line: > > if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) > >break; > > in ucc_geth_tx() didn not ma

Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
David Miller wrote on 27/03/2009 08:42:37: > > > These patches don't apply to the current tree, could you please > respin your final version against at the very least Linus's tree? That is strange, had a look at linus tree and I don't see any changes in his tree that touches the same area/funct

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 10:45:12: > On Fri, Mar 27, 2009 at 1:44 AM, Joakim Tjernlund > wrote: > > The line: > > if ((bd == ugeth->txBd[txQ]) && (netif_queue_stopped(dev) == 0)) > > break; > > in ucc_geth_tx() didn not make sense

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 11:39:07: > On Fri, Mar 27, 2009 at 6:23 PM, Joakim Tjernlund > >> > - /* We freed a buffer, so now we can restart > > transmission */ > >> > - if (netif_queue_stopped(dev)) > >> >

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-27 Thread Joakim Tjernlund
pku@gmail.com wrote on 27/03/2009 11:50:09: > > On Thu, Mar 26, 2009 at 8:54 PM, Joakim Tjernlund > wrote: > > Also set NAPI weight to 64 as this is a common value. > > This will make the system alot more responsive while > > ping flooding the ucc_geth ethernet int

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-28 Thread Joakim Tjernlund
timur.t...@gmail.com wrote on 27/03/2009 19:50:30: > > On Tue, Mar 24, 2009 at 6:08 PM, Joakim Tjernlund > wrote: > > > + .ndo_change_mtu = eth_change_mtu, > > I have an old patch for change_mtu support for ucc_geth which I've > been meaning to

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Joakim Tjernlund
pku@gmail.com wrote on 30/03/2009 09:36:21: > > On Fri, Mar 27, 2009 at 7:52 PM, Joakim Tjernlund > wrote: > > pku@gmail.com wrote on 27/03/2009 11:50:09: > >> > >> On Thu, Mar 26, 2009 at 8:54 PM, Joakim Tjernlund > >> wrote: > >> >

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Joakim Tjernlund
pku@gmail.com wrote on 30/03/2009 11:36:36: > > On Mon, Mar 30, 2009 at 5:21 PM, Joakim Tjernlund > wrote: > > pku@gmail.com wrote on 30/03/2009 10:34:47: > >> > >> On Thu, Mar 26, 2009 at 1:51 AM, Joakim Tjernlund > >> wrote: > >>

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread Joakim Tjernlund
pku@gmail.com wrote on 30/03/2009 10:34:47: > > On Thu, Mar 26, 2009 at 1:51 AM, Joakim Tjernlund > wrote: > > Anton Vorontsov wrote on 25/03/2009 15:25:40: > >> On Wed, Mar 25, 2009 at 02:30:49PM +0100, Joakim Tjernlund wrote: > >> > >>From 1c2f23

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-30 Thread Joakim Tjernlund
Scott Wood wrote on 27/03/2009 14:26:00: > > Joakim Tjernlund wrote: > > This is a bit better than the current type casts. Moving over to qe_bd > > accesses is a bigger cleanup that will have to be a seperate patch. > > I am not sure it is an all win as you probably loose

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-30 Thread Joakim Tjernlund
Scott Wood wrote on 30/03/2009 19:22:03: > > Joakim Tjernlund wrote: > > gianfar does not seem to use in_/out_ functions for the BDs. Works just > > fine that too it seems. > > It does now that it has explicit barriers in a few places. Before they In 2.6.29 or later?

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-30 Thread Joakim Tjernlund
Scott Wood wrote on 30/03/2009 19:45:17: > > Joakim Tjernlund wrote: > > Scott Wood wrote on 30/03/2009 19:22:03: > >> Joakim Tjernlund wrote: > >>> gianfar does not seem to use in_/out_ functions for the BDs. Works > > just > >>> fine that

Re: [PATCH] ucc_geth: Rework the TX logic.

2009-03-31 Thread Joakim Tjernlund
Scott Wood wrote on 30/03/2009 21:32:23: > > Joakim Tjernlund wrote: > >> different since descriptors are in MURAM which is ioremap()ed -- though > >> switching to a cacheable mapping with barriers should be a performance > >> improvement. > > > &

OF PCI howto?

2009-04-15 Thread Joakim Tjernlund
I have just started to add PCI support to our custom MPC832x board and I have a hard time figuring out how to describe this in the dts. Looking at mpc832x_mds.dts I see: pci0: p...@e0008500 { cell-index = <1>; interrupt-map-mask = <0xf800 0x0 0x0 0x7>;

Re: OF PCI howto?

2009-04-16 Thread Joakim Tjernlund
Kumar Gala wrote on 15/04/2009 17:20:21: > On Apr 15, 2009, at 8:08 AM, Wolfram Sang wrote: > > > On Wed, Apr 15, 2009 at 02:54:57PM +0200, Joakim Tjernlund wrote: > > > >> dts fragment correct for my setup? If not, is there a better > >> example I can >

Re: [PATCH v3 09/13] net: Rework ucc_geth driver to use of_mdio infrastructure

2009-04-26 Thread Joakim Tjernlund
Change in fixed link case, see inline. > > From: Grant Likely > > This patch simplifies the driver by making use of more common code. > > Signed-off-by: Grant Likely > Acked-by: Andy Fleming > --- > > drivers/net/ucc_geth.c | 47 --- > drivers

Re: [PATCH 04/10] 8xx: Always pin kernel instruction TLB

2009-12-29 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 09/12/2009 09:56:35: > From: Benjamin Herrenschmidt > To: Joakim Tjernlund > Cc: "linuxppc-...@ozlabs.org" , Rex Feany > , Scott Wood > Date: 09/12/2009 09:56 > Subject: Re: [PATCH 04/10] 8xx: Always pin kernel instruction TLB >

[PATCH] 8xx: fix user space TLB walk in dcbX fixup

2010-01-08 Thread Joakim Tjernlund
The newly added fixup for buggy dcbX insn's has a bug that always trigger a kernel TLB walk so a user space dcbX insn will cause a Kernel Machine Check if it hits DTLB error. Signed-off-by: Joakim Tjernlund --- I found this problem in 2.4 and forward ported it to 2.6. I cannot test it

Re: linux-next: origin tree build failure

2010-01-11 Thread Joakim Tjernlund
Stephen Rothwell wrote on 12/01/2010 00:58:05: > > Hi all, > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > > cc1: error: include/linux/autoconf.h: No such file or directory > > (while building the boot wrappers - lots more of the same) > > Caused by commit ac4c2a3bbe5db5

Re: [PATCH] 8xx: fix user space TLB walk in dcbX fixup

2010-01-11 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 12/01/2010 03:40:45: > > On Fri, 2010-01-08 at 17:46 +0100, Joakim Tjernlund wrote: > > The newly added fixup for buggy dcbX insn's has > > a bug that always trigger a kernel TLB walk so a user space > > dcbX insn will cause a Kernel

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-11 Thread Joakim Tjernlund
Anton Blanchard wrote on 12/01/2010 03:21:51: > > > commit ac4c2a3bbe5db5fc570b1d0ee1e474db7cb22585 (zlib: optimize inffast when > copying direct from output) referenced include/linux/autoconf.h which > is now called include/generated/autoconf.h. > > Signed-off-by: Anton Blanchard > --- > > Index

Re: [PATCH] 8xx: fix user space TLB walk in dcbX fixup

2010-01-12 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 12/01/2010 09:44:09: > > On Tue, 2010-01-12 at 08:07 +0100, Joakim Tjernlund wrote: > > Benjamin Herrenschmidt wrote on 12/01/2010 > > 03:40:45: > > > > > > On Fri, 2010-01-08 at 17:46 +0100, Joakim Tjernlund wrote: > >

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-12 Thread Joakim Tjernlund
/generated/autoconf.h. > > Even with this fix, you cannot build with a separate object directory. > See my other posting "linux-next: origin tree build failure" ... > -- How does this work for you? >From 044f40d169bf5fe189d5cb058f56b7cd72675ca4 Mon Sep 17 00:00:00 2001

Re: linux-next: origin tree build failure

2010-01-12 Thread Joakim Tjernlund
C maintainer tells me that defining __KERNEL__ in the > BOOTFLAGS is wrong and should have been noticed. Is this any better w.r.t __KERNEL__? >From 1a79993a42e17be665d3488663d81c0513b8bbfe Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund Date: Tue, 12 Jan 2010 13:31:58 +0100 Subject: [PATCH] p

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-13 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 13/01/2010 21:02:43: > > On Wed, 2010-01-13 at 12:54 -0600, Kumar Gala wrote: > > > > > > > BOOTCFLAGS += -I$(obj) -I$(srctree)/$(obj) > > > -BOOTCFLAGS += -include include/linux/autoconf.h -Iarch/powerpc/include > > > -BOOTCFLAGS += -Iinclude > > > +BOOTCFLAG

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-14 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 14/01/2010 09:57:11: > Subject: Re: [PATCH]: powerpc: Fix build breakage due to incorrect location > ofautoconf.h > > > > Seen it now as it is in Linus tree: > > > > 1) IMHO it would have been nicer to use #ifdef __KERNEL__ > >instead of CONFIG_HAVE_EFFICIENT_U

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-14 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 14/01/2010 10:43:44: > On Thu, 2010-01-14 at 10:12 +0100, Joakim Tjernlund wrote: > > > No, that was on purpose. If an arch doesn't have efficient unaligned > > > accesses, then they should not use the optimization since it will &g

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-14 Thread Joakim Tjernlund
Benjamin Herrenschmidt wrote on 14/01/2010 10:43:44: > > On Thu, 2010-01-14 at 10:12 +0100, Joakim Tjernlund wrote: > > > No, that was on purpose. If an arch doesn't have efficient unaligned > > > accesses, then they should not use the optimization since it will

Re: jffs2_gcd_mtdx thread and umount problem.

2010-01-17 Thread Joakim Tjernlund
> > Hi All, > > I have a customized MPC8313 (ppc arch) board with SPANSION 64MB NOR > flash, everything works fine but I found a abnormal about JFFS2 flahs > filesystem. > > The system will mount JFFS2 to /mnt/mtd when system boot up. I try to > execute umount /mnt/mtd or sync or reboot right away

Re: jffs2_gcd_mtdx thread and umount problem.

2010-01-18 Thread Joakim Tjernlund
Johnny Hung wrote on 18/01/2010 09:26:26: > Please don't top post. > Yes, umount / reboot command doesn't hang after first boot + wait for > 20 minutes. The jffs2_gcd_mtdx will re-erase empty blocks but how do I > know it is finished? You don't or just monitor jffs2_gcd_mtdx until it is finished

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-25 Thread Joakim Tjernlund
ment in the Makefile about not using > >autoconf.h/-D__KERNEL__ > > That's true :-) So I fixed the new inflate to be endian independent and now all arches can use the optimized version. Here goes: >From 4e769486e2520e34f532a2d4bf13ab13f05e3e76 Mon Sep 17 00:00:00 2001 Fro

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-27 Thread Joakim Tjernlund
to be endian independent and now > all arches can use the optimized version. Here goes: No comments so far, I guess that is a good thing :) Ben, Andrew could either of you carry this patch for me? Jocke > > > From 4e769486e2520e34f532a2d4bf13ab13f05e3e76 Mon Sep 17 00:00:00 2001 &

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-28 Thread Joakim Tjernlund
Andrew Morton wrote on 2010/01/28 02:05:36: > > On Mon, 25 Jan 2010 09:19:59 +0100 > Joakim Tjernlund wrote: > > > Commit 6846ee5ca68d81e6baccf0d56221d7a00c1be18b made the > > new optimized inflate only available on arch's that > > define CONFIG_HAVE_EFFICIENT_

Re: [PATCH]: powerpc: Fix build breakage due to incorrect location of autoconf.h

2010-01-30 Thread Joakim Tjernlund
Andrew Morton wrote on 2010/01/30 00:49:24: > > On Thu, 28 Jan 2010 09:52:41 +0100 > Joakim Tjernlund wrote: > > > Commit 6846ee5ca68d81e6baccf0d56221d7a00c1be18b made the > > new optimized inflate only available on arch's that > > define CONFIG_HAVE_EFFICI

Endian/__BYTE_ORDER question

2010-02-11 Thread Joakim Tjernlund
I am getting confused about on how to test for Endian in the kernel code. In user space one uses #if __BYTE_ORDER == __LITTLE_ENDIAN or #if __BYTE_ORDER == __BIG_ENDIAN I can see lots of kernel headers using this test too, but it doesn't seem to be an arch specific file #defining __BYTE_ORDER.

Re: Endian/__BYTE_ORDER question

2010-02-11 Thread Joakim Tjernlund
> > I am getting confused about on how to test for Endian in the kernel code. In > user > space one uses #if __BYTE_ORDER == __LITTLE_ENDIAN or #if __BYTE_ORDER == > __BIG_ENDIAN > > I can see lots of kernel headers using this test too, but it doesn't seem > to be an arch specific file #defining

Re: Endian/__BYTE_ORDER question

2010-02-11 Thread Joakim Tjernlund
Andreas Schwab wrote on 2010/02/11 17:35:54: > > Joakim Tjernlund writes: > > > I am getting confused about on how to test for Endian in the kernel code. > > In user > > space one uses #if __BYTE_ORDER == __LITTLE_ENDIAN or #if __BYTE_ORDER == > > __BIG_ENDIAN

Re: Endian/__BYTE_ORDER question

2010-02-11 Thread Joakim Tjernlund
Adrian Reber wrote on 2010/02/11 17:33:29: > > On Thu, Feb 11, 2010 at 05:17:37PM +0100, Joakim Tjernlund wrote: > > I am getting confused about on how to test for Endian in the kernel code. > > In user > > space one uses #if __BYTE_ORDER == __LITTLE_EN

Re: Endian/__BYTE_ORDER question

2010-02-11 Thread Joakim Tjernlund
Wolfgang Denk wrote on 2010/02/11 22:39:00: > > Dear Joakim Tjernlund, > > In message 005cf...@transmode.se> you wrote: > > > > > I have no idea how it is actually done in the kernel code... but gcc > > > defines it: > > > > > > gcc -dM -

Re: Endian/__BYTE_ORDER question

2010-02-12 Thread Joakim Tjernlund
ge...@sonytel.be wrote on 2010/02/12 11:33:02: > > On Fri, 12 Feb 2010, Joakim Tjernlund wrote: > > Wolfgang Denk wrote on 2010/02/11 22:39:00: > > > Dear Joakim Tjernlund, > > > > > > In message > > 005cf...@transmode.se> you wrote: > > &

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-02-18 Thread Joakim Tjernlund
> > This patch improves the recovery of the MPC's I2C bus from errors like bus > hangs resulting in timeouts: > 1. make the bus timeout configurable, as it depends on the bus clock and > the attached slave chip(s); default is still 1 second; > 2. detect any of the cases indicated by the CF, BB

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-02-18 Thread Joakim Tjernlund
"Albrecht Dreß" wrote on 2010/02/18 10:09:23: > > Hi Joakim: > > > Does this reset sequence also send a START condition for every clock? > > Please see the attached scan from a scope output, showing the first two out of > the 9 sequences at 375 kHz (that's what the 5200's divider makes from 400 k

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-02-18 Thread Joakim Tjernlund
> @@ -93,20 +94,23 @@ static irqreturn_t mpc_i2c_isr(int irq, > /* Sometimes 9th clock pulse isn't generated, and slave doesn't release >* the bus, because it wants to send ACK. >* Following sequence of enabling/disabling and sending start/stop generates > - * the pulse, so it's all OK.

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-02-18 Thread Joakim Tjernlund
n needs 150 us... > > My feeling is that the delays used in the old code are just "some" values > which work for sure, to if you like, my change is basically optimisation... The old code only works when the device is stuck at the last bit. To cope with any bit (worst case is the

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-02-18 Thread Joakim Tjernlund
glik...@secretlab.ca wrote on 2010/02/18 18:41:40: > > On Thu, Feb 18, 2010 at 10:14 AM, Joakim Tjernlund > wrote: > > "Albrecht Dreß" wrote on 2010/02/18 16:04:16: > > As far as I can tell your patch does all of the above so > > > > Signed-off-by:

default stack size for threads changed

2010-02-22 Thread Joakim Tjernlund
With current, 2.6.33-rc6, linux the default stack size changed from unlimited to 8MB: # > ulimit -s 8192 This makes NPTL allocate a 8MB stack for each thread that is created. This breaks in our embedded system. Although this can be fixed in our app I wonder if this is intentional? Jocke __

Re: default stack size for threads changed

2010-02-22 Thread Joakim Tjernlund
Joakim Tjernlund/Transmode wrote on 2010/02/22 13:20:12: > > With current, 2.6.33-rc6, linux the default stack size changed from unlimited > to 8MB: > # > ulimit -s > 8192 > > This makes NPTL allocate a 8MB stack for each thread that is created. > This breaks in our emb

Re: default stack size for threads changed

2010-02-22 Thread Joakim Tjernlund
Michael Neuling wrote on 2010/02/23 02:58:16: > > In message 0043c...@transmode.se> you wrote: > > > > With current, 2.6.33-rc6, linux the default stack size changed from > > unlimited > > to 8MB: > > # > ulimit -s > > 8192 > > > > This makes NPTL allocate a 8MB stack for each thread that is cre

[PATCH 1/4] 8xx: Optimze TLB Miss handlers

2010-02-26 Thread Joakim Tjernlund
This removes a couple of insn's from the TLB Miss handlers whithout changing functionality. --- arch/powerpc/kernel/head_8xx.S | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S index 3ef743f..ecc4a02 1

[PATCH 0/4] 8xx: Optimize TLB Miss code.

2010-02-26 Thread Joakim Tjernlund
This set of tries to optimize the TLB code on 8xx even more. If they work, it should be a noticable performance boost. I would be very happy if you could test them for me. Joakim Tjernlund (4): 8xx: Optimze TLB Miss handlers 8xx: Avoid testing for kernel space in ITLB Miss. 8xx: Don&#

[PATCH 2/4] 8xx: Avoid testing for kernel space in ITLB Miss.

2010-02-26 Thread Joakim Tjernlund
Only modules will cause ITLB Misses as we always pin the first 8MB of kernel memory. --- arch/powerpc/kernel/head_8xx.S |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/kernel/head_8xx.S b/arch/powerpc/kernel/head_8xx.S index ecc4a02..84ca1d9 100644 --- a/ar

<    1   2   3   4   5   6   7   8   >