David Miller <da...@davemloft.net> wrote on 25/03/2009 22:40:41:
>
> From: Eric Dumazet <da...@cosmosbay.com>
> Date: Wed, 25 Mar 2009 15:04:26 +0100
>
> > Joakim Tjernlund a écrit :
> > > + /* Tx event processing */
> > > + spin_lock(&ugeth->lock);
> > > + for (i = 0; i < ug_info->numQueuesTx; i++) {
> > > + ucc_geth_tx(ugeth->dev, i);
> > > + }
> > > + spin_unlock(&ugeth->lock);
> > > +
> >
> > Why tx completions dont change "howmany" ?
> > It seems strange you changed UCC_GETH_DEV_WEIGHT if not taking into
account tx event above...
>
> He should leave howmany alone for TX work and use a weight
> value of 64 just like most other drivers in the tree do.
OK, will change this to 64.
>
> Due to the abuse and random ignorant fiddling of the
> weight value, I am going to make it something the core
> rather than drivers choose.
Good, I had a hard time finding info how one should use it anyway.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
