[PATCH] powerpc: provide __bswapdi2

2013-05-10 Thread David Woodhouse
From: David Woodhouse Some versions of GCC apparently expect this to be provided by libgcc. Signed-off-by: David Woodhouse --- Untested. diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S index 19e096b..f077dc2 100644 --- a/arch/powerpc/kernel/misc_32.S +++ b/arch

Re: [PATCH] powerpc: provide __bswapdi2

2013-05-13 Thread David Woodhouse
esting, but Al saw it on a Debian system. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com Intel Corporation smime.p7s Description: S/MIME cryptographic signature ___

Re: [PATCH] powerpc: provide __bswapdi2

2013-05-13 Thread David Woodhouse
iel Paubert wrote: > Actually, I'd swap the two mr instructions to never > have an instruction that uses the result from the > previous one. Bad GCC. No biscuit. Should we file a PR? -- David WoodhouseOpen Source Technology Centre david.woodho...@inte

Re: [PATCH] powerpc: provide __bswapdi2

2013-05-13 Thread David Woodhouse
On Mon, 2013-05-13 at 11:33 +0100, David Woodhouse wrote: > > On Mon, 2013-05-13 at 09:33 +0200, Gabriel Paubert wrote: > > Actually, I'd swap the two mr instructions to never > > have an instruction that uses the result from the > > previous one. > > Bad GCC

Re: [PATCH] powerpc: provide __bswapdi2

2013-05-13 Thread David Woodhouse
is just written in C, and the compiler evidently trusts itself not to optimise that into a recursive call. Is there a compiler switch which guarantees that, which we could use without other unwanted side-effects? -- David WoodhouseOpen Source Technology Centre davi

Re: [PATCH 30/31] intel-iommu: handle page-less SG entries

2015-08-12 Thread David Woodhouse
On Wed, 2015-08-12 at 09:05 +0200, Christoph Hellwig wrote: > Just remove a BUG_ON, the code handles them just fine as-is. > > Signed-off-by: Christoph Hellwig Acked-by: David Woodhouse -- David WoodhouseOpen Source Technology Centre david.woodho...@

[PATCH] powerpc: enable ARCH_USE_BUILTIN_BSWAP

2012-12-19 Thread David Woodhouse
round. Compiled-tested only. It gave a code size reduction of almost 4% for ext2, and more like 2.5% for ext3/ext4. Signed-off-by: David Woodhouse Acked-by: H. Peter Anvin --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 95

Re: [RFC 00/15] PCI: turn some __weak functions into callbacks

2018-08-21 Thread David Woodhouse
On Mon, 2018-08-20 at 23:14 -0700, Christoph Hellwig wrote: > On Fri, Aug 17, 2018 at 12:26:30PM +0200, Arnd Bergmann wrote: > > Hi Bjorn and others, > >  > > Triggered by Christoph's patches, I had another go at converting > > all of the remaining pci host bridge implementations to be based > > on

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread David Woodhouse
On Tue, 2011-11-15 at 11:26 +, Jenkins, Clive wrote: > > fix whitespaces,tabs coding style issue and ... > > In my opinion this code was already correct, and would display correctly > at any TAB setting. This patch changes it so that it displays > incorrectly at all TAB settings other than 8.

RE: [PATCH 1/3] mtd/nand: fix coding style issue in drivers/mtd/nand/fsl_elbc.c

2011-11-15 Thread David Woodhouse
On Tue, 2011-11-15 at 14:42 +, Jenkins, Clive wrote: > This may be your (not so humble :-) opinion, and I happen to agree that > a tab setting of 8 is best, usually. However, as Linus says in his > coding style document "Coding style is very personal, and I won't _force_ > my views on anybody".

[PATCH 3/4] x86: enable ARCH_USE_BUILTIN_BSWAP

2012-12-04 Thread David Woodhouse
From: David Woodhouse With -mmovbe enabled (implicit with -march=atom), this allows the compiler to use the movbe instruction. This doesn't have a significant effect on code size (unlike on PowerPC), because the movbe instruction actually takes as many bytes to encode as a simple mov and a

[PATCH 0/4] Use compiler intrinsics for byteswapping

2012-12-04 Thread David Woodhouse
This series of patches enables the __builtin_bswapXX() series of functions that have been supported since GCC 4.4. It allows GCC to emit load-and-swap or store-and-swap instructions on architectures which support that. -- David WoodhouseOpen Source Technology Centre

[PATCH 1/4] byteorder: allow arch to opt to use GCC intrinsics for byteswapping

2012-12-04 Thread David Woodhouse
From: David Woodhouse Since GCC 4.4, there have been __builtin_bswap32() and __builtin_bswap16() intrinsics. A __builtin_bswap16() came a little later (4.6 for PowerPC, 48 for other platforms). By using these instead of the inline assembler that most architectures have in their __arch_swabXX

[PATCH 4/4] x86: add CONFIG_X86_MOVBE option

2012-12-04 Thread David Woodhouse
From: David Woodhouse Currently depends only on CONFIG_MATOM. This will change because big-core CPUs are getting movbe too... Signed-off-by: David Woodhouse --- arch/x86/Kconfig.cpu | 4 arch/x86/Makefile| 1 + 2 files changed, 5 insertions(+) diff --git a/arch/x86/Kconfig.cpu b

[PATCH 2/4] powerpc: enable ARCH_USE_BUILTIN_BSWAP

2012-12-04 Thread David Woodhouse
From: David Woodhouse By using the compiler intrinsics instead of hand-crafted opaque inline assembler for byte-swapping, we let the compiler see what's actually happening and it gets to use lwbrx/stwbrx instructions instead of a normal load/store coupled with a sequence of rlwimi instruc

Re: [PATCH 2/4] powerpc: enable ARCH_USE_BUILTIN_BSWAP

2012-12-04 Thread David Woodhouse
On Tue, 2012-12-04 at 22:02 +1100, Stephen Rothwell wrote: > > +config ARCH_USE_BUILTIN_BSWAP > > + def_bool y > > + > > This should be defined as bool in arch/Kconfig (probably in the previous > patch) and then selected from appropriate architectures. Thanks. Updated series at git://git.

Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to elbc devices

2010-10-25 Thread David Woodhouse
On Mon, 2010-10-18 at 17:46 +0800, tiejun.chen wrote: > > >>> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but > >>> here > >>> of_iomap() is already failed you should skip iounmap() > >>> fsl_lbc_ctrl_dev->regs > >>> again. So you should improve that as the following on 'e

Re: [PATCH] powerpc/mpc52xx/mtd: fix mtd-ram access for 16-bit Local Plus Bus

2009-09-04 Thread David Woodhouse
sions designed for 'simple' maps with special cases? -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com Intel Corporation ___ Linuxppc-dev mailing list Linuxppc-dev@lis

Re: [PATCH 2/6] mtd: m25p80: Convert to device table matching

2009-09-22 Thread David Woodhouse
On Wed, 2009-09-23 at 03:01 +0400, Anton Vorontsov wrote: > > And the two patches I sent on top: > > http://lkml.org/lkml/2009/8/18/364 > http://lkml.org/lkml/2009/8/18/366 Got versions of those which apply to the mtd-2.6.git tree (which I'm about to ask Linus to pull)? -- dwmw2

Re: [rtc-linux] [PATCH/RFC 0/5] Generic RTC class driver

2009-02-24 Thread David Woodhouse
PA Semi Electra, iirc), and still have stuff work on other platforms. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com Intel Corporation ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [rtc-linux] [PATCH/RFC 0/5] Generic RTC class driver

2009-02-24 Thread David Woodhouse
On Tue, 2009-02-24 at 23:11 +0100, Alessandro Zummo wrote: > On Wed, 25 Feb 2009 06:35:27 +0900 > David Woodhouse wrote: > > > > So you want us to kill the ppc_md.[gs]et_rtc_time() [ppc], mach_hwclk() > > > [m68k], > > > mach_gettod() [m68knommu] (and pro

Re: [PATCH 0/10] DMA-API debugging facility

2009-02-25 Thread David Woodhouse
On Thu, 2009-02-05 at 22:44 +, David Woodhouse wrote: > On Fri, 2008-11-21 at 18:27 +0100, Joerg Roedel wrote: > > On Fri, Nov 21, 2008 at 05:24:29PM +0000, David Woodhouse wrote: > > > On Fri, 2008-11-21 at 18:20 +0100, Joerg Roedel wrote: > > > > Ok, I will mov

Re: [PATCH 6/7] powerpc: Hook up rtc-generic, and kill rtc-ppc

2009-03-09 Thread David Woodhouse
the same functionality in a more > generic way, and supports autoloading through udev. > > Signed-off-by: Geert Uytterhoeven Acked-By: David Woodhouse -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com

Re: [PATCH v2] Check name property to determine partition nodes.

2009-03-24 Thread David Woodhouse
On Tue, 2009-03-24 at 14:27 +0100, Benjamin Krill wrote: > >>On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote: > >>> SLOF has a further node which could not be evaluate > >>> by the current routine. The current routine returns > >>> because the node hasn't the required reg property. As > >>>

Re: [PATCH 1/3 v3] mtd: physmap_of: Add multiple regions and concatenation support

2009-04-16 Thread David Woodhouse
On Thu, 16 Apr 2009, Artem Bityutskiy wrote: On Thu, 2009-04-16 at 07:46 -0600, Grant Likely wrote: On Thu, Apr 16, 2009 at 7:37 AM, Stefan Roese wrote: On Thursday 16 April 2009, Grant Likely wrote: Signed-off-by: Stefan Roese Reviewd-by: Grant Likely Yup, still looks good to me. What

Re: [MTD] ofpart: Partitions at same address cannot have the same name

2009-04-29 Thread David Woodhouse
e model I think I want to move to, and which I was toying with in http://git.infradead.org/users/dwmw2/mtd-sysfs.git (I haven't done it yet, but it's logically the next step after what I've already done). -- David WoodhouseOpen So

Re: [PATCH 1/4] Add ps3_storage module alias

2010-02-23 Thread David Woodhouse
s hack was only needed for the upgrade -- when you were running a kernel with the ps3_storage kernel and you first installed a kernel with the new ps3disk driver, you needed it to find the right module. I think we can drop it now. -- David WoodhouseOpen Source Techno

Re: [PATCH 2/4] Fix G5 thermal shutdown

2010-02-23 Thread David Woodhouse
d since about Fedora Core 5. I have no idea > > if it's really needed or not. It's kind of a dirty hack, but it was sufficient to stop my machine constantly powering itself off. > Can we have a SoB ? Signed-off-by: David Woodhouse -- David Woodhouse

Re: [PATCH 3/4] Provide VIO modalias

2010-02-23 Thread David Woodhouse
On Fri, 2010-02-05 at 08:53 -0500, Josh Boyer wrote: > Provide a modalias entry for VIO devices in sysfs. I believe > this was another initrd generation bugfix for anaconda. > > --- Signed-off-by: David Woodhouse Not entirely sure why this didn't get upstream when I first did

Re: [PATCH 4/4] Fix iMac iSight PCI bridge setup

2010-02-23 Thread David Woodhouse
can just drop the patch from the Fedora kernel and we can wait for > either silence or bug reports :) I'll dig out the machine and test. Some time next month would be the current estimate. -- David WoodhouseOpen Source Technology Centre david.woodh

Re: [Cbe-oss-dev] No otheros feature on new PS3 slim ?

2010-02-26 Thread David Woodhouse
On Fri, 2009-08-21 at 09:58 -0700, geoffrey.lev...@am.sony.com wrote: > The feature of "Install Other OS" was removed from the new > "Slim" PS3 model to focus on delivering games and other > entertainment content. > > Please be assured that SCE is committed to continue > the support for previousl

Re: [PATCH 1/3 v3] mtd: physmap_of: Add multiple regions and concatenation support

2009-06-06 Thread David Woodhouse
that you would look at that tree from time to time > and pull it. At least you may be sure I looked at the patches and > did some validation. This should save your time and help MTD > users. This was _really_ useful. Thank you very much. -- David Woodhouse

Re: [PATCH V2 2/2] mtd/maps/mtd-ram: add an of-platform driver

2009-06-06 Thread David Woodhouse
n do that. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com Intel Corporation ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH] Remove machine_is(chrp) from 64-bit kernel

2009-06-06 Thread David Woodhouse
The CHRP platform type only exists in a 32-bit build. Don't bother checking machine_is(chrp) if we're in 64-bit mode. Signed-off-by: David Woodhouse diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c index 45936c9..c22f7e8 100644 --- a/ar

Re: [PATCH Resend2] Remove 'SBC8240 Wind River' Device Driver Code

2009-07-10 Thread David Woodhouse
y need to submit it for 2.6.31? It's not a regression, is it? It's been like this for _ages_. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com Intel Corporation

[PATCH] Stop pci_set_dma_mask() from failing when RAM doesn't exceed the mask anyway

2009-07-31 Thread David Woodhouse
ystem doesn't exceed the requested limit. Signed-off-by: David Woodhouse diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c index 20a60d6..1769a8e 100644 --- a/arch/powerpc/kernel/dma.c +++ b/arch/powerpc/kernel/dma.c @@ -90,11 +90,11 @@ static void dma_direct_unmap_sg(str

Re: [PATCH] Stop pci_set_dma_mask() from failing when RAM doesn't exceed the mask anyway

2009-08-01 Thread David Woodhouse
On Sat, 2009-08-01 at 08:25 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2009-07-31 at 20:41 +0100, David Woodhouse wrote: > > On an iMac G5, the b43 driver is failing to initialise because trying to > > set the dma mask to 30-bit fails. Even though there's only 512MiB of RA

Re: [PATCH] Stop pci_set_dma_mask() from failing when RAM doesn't exceed the mask anyway

2009-08-01 Thread David Woodhouse
On Sat, 2009-08-01 at 18:00 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2009-08-01 at 08:54 +0100, David Woodhouse wrote: > > On Sat, 2009-08-01 at 08:25 +1000, Benjamin Herrenschmidt wrote: > > > On Fri, 2009-07-31 at 20:41 +0100, David Woodhouse wrote: > > > > On

[PATCH] Fix perfctr oops on ppc32

2009-08-01 Thread David Woodhouse
This seems to be the reason why the Fedora rawhide 2.6.31-rc kernel doesn't boot. With some CPUs, cur_cpu_spec->oprofile_cpu_type can be NULL -- which makes strcmp() unhappy. Signed-off-by: David Woodhouse --- At first glance, it looks like there are a bunch of other places w

Re: [PATCH] Stop pci_set_dma_mask() from failing when RAM doesn't exceed the mask anyway

2009-08-03 Thread David Woodhouse
On Sun, 2009-08-02 at 17:50 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2009-08-01 at 10:00 +0100, David Woodhouse wrote: > > I'm not sure. Losing 16MiB on a machine which only has 512MiB anyway > > doesn't seem ideal, and we'll want to make the no-iommu

Re: [PATCH] Fix perfctr oops on ppc32

2009-08-05 Thread David Woodhouse
On Thu, 2009-08-06 at 07:02 +1000, Benjamin Herrenschmidt wrote: > > Argh, ignore my Acked-by, I think the patch isn't right... Hm, good point. Doh. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com

Re: [PATCH] powerpc/perfctr: Check oprofile_cpu_type for NULL before using it

2009-08-05 Thread David Woodhouse
y be NULL on a 64-bit CPU; all 64-bit CPUs in the table have ->oprofile_cpu_type set. Of course, adding the check probably makes sense anyway. -- David WoodhouseOpen Source Technology Centre david.woodho...@intel.com

[PATCH] hvc/xen: fix event channel handling for secondary consoles

2023-10-17 Thread David Woodhouse
From: David Woodhouse The xencons_connect_backend() function allocates a local interdomain event channel with xenbus_alloc_evtchn(), then calls bind_interdomain_evtchn_to_irq_lateeoi() to bind to that port# on the *remote* domain. That doesn't work very well: (qemu) device_add xen-conso

Re: [PATCH] hvc/xen: fix event channel handling for secondary consoles

2023-10-20 Thread David Woodhouse
On Fri, 2023-10-20 at 10:51 +0200, Juergen Gross wrote: > > > (qemu) device_del con1 > > [   32.050919] [ cut here ] > > [   32.050942] Trying to free already-free IRQ 33 > > [   32.050990] WARNING: CPU: 0 PID: 51 at kernel/irq/manage.c:1895 > > __free_irq+0x1d4/0x330 > >

[PATCH v2 2/3] hvc/xen: fix error path in xen_hvc_init() to always register frontend driver

2023-10-20 Thread David Woodhouse
From: David Woodhouse The xen_hvc_init() function should always register the frontend driver, even when there's no primary console — as there may be secondary consoles. (Qemu can always add secondary consoles, but only the toolstack can add the primary because it's special.) Sig

[PATCH v2 0/3] hvc/xen: Xen console fixes.

2023-10-20 Thread David Woodhouse
y with its SMEP behaviour... David Woodhouse (3): hvc/xen: fix event channel handling for secondary consoles hvc/xen: fix error path in xen_hvc_init() to always register frontend driver hvc/xen: fix console unplug drivers/tty/hvc/hvc_xen.c | 39

[PATCH v2 3/3] hvc/xen: fix console unplug

2023-10-20 Thread David Woodhouse
From: David Woodhouse On unplug of a Xen console, xencons_disconnect_backend() unconditionally calls free_irq() via unbind_from_irqhandler(), causing a warning of freeing an already-free IRQ: (qemu) device_del con1 [ 32.050919] [ cut here ] [ 32.050942] Trying to

[PATCH v2 1/3] hvc/xen: fix event channel handling for secondary consoles

2023-10-20 Thread David Woodhouse
From: David Woodhouse The xencons_connect_backend() function allocates a local interdomain event channel with xenbus_alloc_evtchn(), then calls bind_interdomain_evtchn_to_irq_lateeoi() to bind to that port# on the *remote* domain. That doesn't work very well: (qemu) device_add xen-conso

[PATCH] x86/xen: Set MSI_FLAG_PCI_MSIX support in Xen MSI domain

2023-01-15 Thread David Woodhouse
Failed to enable and set the admin interrupts Side note: This is the first bug found, and first patch tested, by running Xen guests under QEMU/KVM instead of running under actual Xen. Fixes: 99f3d2797657 ("PCI/MSI: Reject MSI-X early") Signed-off-by: David Woodhouse --- arch/x86/pci/

Re: Yet more patches added to for-2.6.25/master branches

2007-12-22 Thread David Woodhouse
http://patchwork.ozlabs.org/linuxppc/patch?id=15192 ? -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 2/4] nand base: Give drivers a chance to do late initialization.

2008-01-07 Thread David Woodhouse
On Thu, 2007-12-13 at 11:15 -0600, Scott Wood wrote: > Some nand controllers, such as the Freescale enhanced local bus controller, > need to do late initialization based on details of the chip that has been > probed, such as chip size, large/small pages, etc. A late_init() callback > method is ad

Re: [PATCH 3/4] mtd: Factor out OF partition support from the NOR driver.

2008-01-08 Thread David Woodhouse
Please adjust for commit 4edaf56e0f8a6f71e3361bf74e3dc835811761e6 and resend. -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: add phy-handle property for fec_mpc52xx

2008-01-09 Thread David Woodhouse
On Wed, 2008-01-09 at 15:26 +, Matt Sealey wrote: > If anyone wants to help/assist/suggest any updates to efika.forth, > create binary tools which assist the installation of the script for > users and for placement on Linux distro CDs etc. I would be very > grateful, but it seems we have hit t

Re: add phy-handle property for fec_mpc52xx

2008-01-10 Thread David Woodhouse
On Thu, 2008-01-10 at 13:21 +1100, Paul Mackerras wrote: > David Woodhouse writes: > > > It would be much better if the kernel would 'just work'. The ideal way > > of achieving that is for the firmware to be fixed -- but that's been > > promised for a long

Re: Could the DTS experts look at this?

2008-02-17 Thread David Woodhouse
On Tue, 2008-02-12 at 13:10 -0600, Scott Wood wrote: > Hmm? All I meant was that it'd be nice if there were an option in the > Linux mtd code to disable the "look for another chip and cause a machine > check if it isn't there" functionality. It was an aside from the > dts-variant issue. Yeah

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread David Woodhouse
On Thu, 2008-02-21 at 23:05 -0700, Grant Likely wrote: > Can I ask; what is the intended usage of such a thing? How large > would a typical binary blob be? Device firmware? -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlab

Re: boards in arch/ppc -> arch/powerpc for 85xx

2007-10-17 Thread David Woodhouse
On Mon, 2007-10-15 at 18:07 -0500, Kumar Gala wrote: > Guys, > > I was wondering if you cared about the following boards existing in > arch/powerpc: > > * STX GP3 > * TQM 85xx > * SBC 8560 > > I'm told WR doesn't care about the SBC 8560, so I'll see if David does. Well, I found an sbc8560 in

Re: boards in arch/ppc -> arch/powerpc for 85xx

2007-10-20 Thread David Woodhouse
On Wed, 2007-10-17 at 19:54 -0500, Kumar Gala wrote: > This really cracked me up. I have to ask what the sbc8560 was doing > in the boot of your car? The Land Rover was full. -- dwmw2 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://oz

Re: [PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-11-28 Thread David Woodhouse
On Sun, 2007-11-18 at 20:49 -0500, Jon Smirl wrote: > On 11/9/07, Grant Likely <[EMAIL PROTECTED]> wrote: > > On 11/9/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > > On 09/11/07 00:31 -0500, Jon Smirl wrote: > > > > This is the reason I couldn't get user space started or connect to my > > > > nf

[PATCH] SET_NETDEV_DEV() in fec_mpc52xx.c

2007-11-28 Thread David Woodhouse
This helps to allow the Fedora installer to use the built-in Ethernet on the Efika for a network install. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- a/drivers/net/fec_mpc52xx.c +++ b/drivers/net/fec_mpc52xx.c @@ -971,6 +971,8 @@ mpc52xx_fec_probe(struct of_device *op, const

[PATCH] Stop phy code from returning success to unknown ioctls.

2007-11-28 Thread David Woodhouse
gement:off Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 9bc1177..7c9e6e3 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -406,6 +406,9 @@ int phy_mii_ioctl(struct ph

Re: [PATCH] MTD: pasemi_nand driver

2007-11-28 Thread David Woodhouse
On Wed, 2007-11-28 at 16:14 -0600, Olof Johansson wrote: > Plumbing for NAND connected via localbus on PA Semi PWRficient-based > boards. Any reason it lacks MODULE_DEVICE_TABLE() ? I note electra-ide lacks it too. So no autoload of either. -- dwmw2 ___

[PPC BOOT] Create otheros.bld next to specified output file, not in $object directory.

2007-12-02 Thread David Woodhouse
lly not be writable when the script runs). Arguably, the 'otheros.bld' ought to be created with the filename specified as the -o argument. But that's a more intrusive change. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- a/arch/powerpc/boot/wrapper +++ b/arch/powerp

[PPC BOOT] Find device-tree source file in default directory.

2007-12-02 Thread David Woodhouse
If a .dts file is given to the bootwrapper script without a full path name, look in a sensible place for it. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> --- a/arch/powerpc/boot/wrapper +++ b/arch/powerpc/boot/wrapper @@ -116,6 +118,9 @@ while [ "$#" -gt 0 ]; do done

[PPC BOOT] Allow for bootwrapper utilities being in different directory to objects

2007-12-02 Thread David Woodhouse
It's possible that the executables which are built as helpers for the bootwrapper stuff might end up in a different place to the intermediate object files. Handle that. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wr

[PPC BOOT] 'make bootwrapper_install'

2007-12-02 Thread David Woodhouse
This adds a 'bootwrapper_install' make target for the powerpc architecture, which installs the wrapper script, intermediate object files and device-tree sources for later use. This will then allow bootable zImages to be created other than in the context of a kernel build. Signed-off

Re: [PPC BOOT] Find device-tree source file in default directory.

2007-12-03 Thread David Woodhouse
On Mon, 2007-12-03 at 09:08 -0600, Scott Wood wrote: > Shouldn't this be $srctree (which doesn't seem to be passed to wrapper at > the moment), not $object? > > BTW, if we do this, we should remove the part in arch/powerpc/boot/Makefile > where this is done. It wasn't really done for the benefit

[PATCH] Generic RTC class support for ppc_md.[gs]et_rtc_time

2007-12-03 Thread David Woodhouse
It would be good to migrate the platform code to register RTC devices directly, but for now this will make them functional enough for most purposes... Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 1e6715e..3e788b7 100644

Re: [PATCH] Generic RTC class support for ppc_md.[gs]et_rtc_time

2007-12-03 Thread David Woodhouse
On Tue, 2007-12-04 at 07:45 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2007-12-03 at 17:04 +0000, David Woodhouse wrote: > > It would be good to migrate the platform code to register RTC devices > > directly, but for now this will make them functional enough for mo

Re: [PATCH] Generic RTC class support for ppc_md.[gs]et_rtc_time

2007-12-03 Thread David Woodhouse
On Tue, 2007-12-04 at 09:36 +1100, Benjamin Herrenschmidt wrote: > Worst one is time_init :-) Way too early to do any i2c babbling. Then > there used to be something with the NTP writeback, dunno if it's > changed. Setting the system time seems to be done in the new RTC class by a late_initcall()

Re: Merge dtc

2007-12-03 Thread David Woodhouse
On Tue, 2007-10-16 at 15:02 +1000, David Gibson wrote: > This very large patch incorporates a copy of dtc into the kernel > source, in arch/powerpc/boot/dtc-src. This means that dtc is no > longer an external dependency to build kernels with configurations > which need a dtb file. > > Signed-off

Re: [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info

2007-12-04 Thread David Woodhouse
On Thu, 2007-11-29 at 21:29 -0600, Olof Johansson wrote: > + continue; > + > + info.addr = *addr; > + > + i2c_register_board_info(PCI_FUNC(pdev->devfn), > &info, > + 1); > +

Re: Merge dtc

2007-12-04 Thread David Woodhouse
On Tue, 2007-12-04 at 14:10 +1100, David Gibson wrote: > We've been back and forth on this several times, Paul and I finally > concluded this was the better option. As long as I can just ignore it and use the separately-shipped dtc, I suppose it doesn't have to bother me too much. > It means we c

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread David Woodhouse
Oops: Exception in kernel mode, sig: 5 [#1] nfs: server pmac not responding, still trying SMP NR_CPUS=128 NUMA PA Semi PWRficient Modules linked in: appletouch cbc blkcipher dm_crypt dm_

Re: [PATCH 2.6.24] pasemi_mac: Fix reuse of free'd skb

2007-12-04 Thread David Woodhouse
On Tue, 2007-12-04 at 18:04 +, David Woodhouse wrote: > Oops: Exception in kernel mode, sig: 5 [#1] > > nfs: server pmac not responding, still trying Oops, sorry. That was meant to be just to Olof. And it helps if I'm actually runn

Re: Merge dtc

2007-12-04 Thread David Woodhouse
On Wed, 2007-12-05 at 09:21 +1100, Paul Mackerras wrote: > David Woodhouse writes: > > > I think this is a bad idea -- it's hardly a difficult for those people > > who _do_ need dts to obtain it separately. > > The trouble is that it's not just people who ar

Re: Merge dtc

2007-12-04 Thread David Woodhouse
On Tue, 2007-12-04 at 22:33 +, David Woodhouse wrote: > Make vmlinux the default target instead of zImage would seem like a > better answer. I'm surprised that it isn't like that already, in fact -- > and I'm only inferring that it isn't from your message. I alw

Re: [PATCH] drivers/net/: Spelling fixes

2007-12-17 Thread David Woodhouse
On Mon, 2007-12-17 at 11:40 -0800, Joe Perches wrote: > drivers/net/wireless/libertas/cmd.c|4 ++-- > drivers/net/wireless/libertas/scan.c |4 ++-- I will apply these to the libertas tree; please remove them from any resend of this patch. If we were using git properl

Re: [PATCH] Stop pmac_zilog from abusing 8250's device numbers.

2007-08-14 Thread David Woodhouse
On Tue, 2007-08-14 at 13:49 +0200, Olaf Hering wrote: > On Wed, Apr 04, Paul Mackerras wrote: > > > David Woodhouse writes: > > > > > There are proper device numbers registered for pmac_zilog now. Use them. > > Which numbers? shinybook /shiny/git/mtd-utils $ ls

Re: Patches for ppc?

2007-08-17 Thread David Woodhouse
On Fri, 2007-08-17 at 09:43 +0200, Johan Borkhuis wrote: > I am working with a PPC-kernel, and came across a problem with the PCI > initialisation. On this mailing list I see a lot of patches, but they > are all for the PowerPC architecture. Are patches for the PPC > architecture still processed

Re: Patches for ppc?

2007-08-17 Thread David Woodhouse
On Fri, 2007-08-17 at 16:36 +0200, Johan Borkhuis wrote: > Well, this is one of the minor issues I have with the ppc architecture, > but I am quite happy with it. Even for this I could make a workaround, > but I guess this is something that other might stumble upon. > > I would like to move to p

Re: [PATCH] add Kconfig option for optimizing for cell

2007-09-15 Thread David Woodhouse
On Sat, 2007-09-15 at 02:21 +0200, Arnd Bergmann wrote: > Since the PPE on cell is an in-order core, it suffers significantly > from wrong instruction scheduling. This adds an Kconfig option that > enables passing -mtune=cell to gcc in order to generate object > code that runs well on cell. Do we

Re: [PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules

2008-06-07 Thread David Woodhouse
On Thu, 2008-06-05 at 10:50 +0200, Wolfgang Grandegger wrote: > [NAND] driver extension to support NAND on TQM85xx modules > > This patch extends the FSL UPM NAND driver from Anton Vorontsov to > support NAND on the TQM85xx modules. Unfortunately, the hardware does > not support the R/B pins of th

Re: [rtc-linux] Re: state of GEN_RTC vs rtc subsystem

2008-06-07 Thread David Woodhouse
On Mon, 2008-06-02 at 15:27 -0700, Geoff Levand wrote: > > Just to follow up, I found that David Woodhouse has submitted > a patch which does this: > >http://patchwork.ozlabs.org/linuxppc/patch?id=18139 It's merged now: http://git.kernel.org/?p=linux/kernel/git/torv

Re: [PATCH 6/9] powerpc: Add VSX CPU feature

2008-06-18 Thread David Woodhouse
On Wed, 2008-06-18 at 10:47 +1000, Michael Neuling wrote: > {"ibm,vmx", 1, CPU_FTR_ALTIVEC, PPC_FEATURE_HAS_ALTIVEC}, > #endif /* CONFIG_ALTIVEC */ > +#ifdef CONFIG_VSX > + {"ibm,vmx", 2, CPU_FTR_VSX, PPC_FEATURE_HAS_VSX}, > +#endif /* CONFIG_VSX */ Should that be "ibm,vsx"? -- dw

TOC overflow on PPC64 (Ocaml)

2008-03-02 Thread David Woodhouse
In a fit of stupidity I worked on porting OCaml to PPC64: http://git.infradead.org/?p=users/dwmw2/ocaml-ppc64.git It seems to work fine, mostly -- but when building large programs such as CIL I found that I overflow the TOC -- I'm using more than 64KiB. An example of this problem is at htt

Re: V4L2: __ucmpdi2 undefined on ppc

2008-03-04 Thread David Woodhouse
On Sun, 2008-03-02 at 22:53 +0100, Segher Boessenkool wrote: > Every occurrence of r7 here is wrong (and some of the r6). Can you elucidate? > Is there any reason to do this in assembler code at all? Is there any particular reason not to? -- dwmw2 __

Re: [PATCH] windfarm: add PowerMac 12,1 support

2008-03-22 Thread David Woodhouse
On Sat, 2008-01-26 at 12:55 +0100, Étienne Bersac wrote: > From: Étienne Bersac <[EMAIL PROTECTED]> > > Implement a new driver named windfarm_pm121 which drive fans on PowerMac > 12,1 machine : iMac G5 iSight (rev C) 17" and 20". It's based on > windfarm_pm81 driver from Benjamin Herrenschmidt. I

Re: [PATCH] windfarm: add PowerMac 12,1 support

2008-03-22 Thread David Woodhouse
On Sun, 2008-03-23 at 09:13 +1100, Benjamin Herrenschmidt wrote: > On Sat, 2008-03-22 at 19:35 +0000, David Woodhouse wrote: > > On Sat, 2008-01-26 at 12:55 +0100, Étienne Bersac wrote: > > > From: Étienne Bersac <[EMAIL PROTECTED]> > > > > > > Impleme

Re: [PATCH] windfarm: add PowerMac 12,1 support

2008-03-22 Thread David Woodhouse
On Sat, 2008-03-22 at 23:02 +, David Woodhouse wrote: > > Yeah, there's weird shit going on with the sensor/control > registration. > I think GCC is be miscompiling it -- the sequence of > all = all && pm121_register_control(foo...); > all = al

Re: [PATCH] windfarm: add PowerMac 12,1 support

2008-03-22 Thread David Woodhouse
On Sun, 2008-03-23 at 10:25 +1100, Stephen Rothwell wrote: > Why would you expect otherwise (from the C standard): > > "Unlike the bitwise binary & operator, the && operator guarantees > left-to-right evaluation; there is a sequence point after the evaluation > of the first operand. If the first o

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread David Woodhouse
On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > BTW, it was reported to me that the ethernet drivers don't get > autoloaded by udev. Is this a failure of udev missing the of_plateform > support, or a deficiency of the ethernet drivers ? As far as I know, they _are_ being loaded properly.

Re: crash in init_ipic_sysfs on efika

2008-03-23 Thread David Woodhouse
On Sun, 2008-03-23 at 11:12 +0100, Sven Luther wrote: > On Sun, Mar 23, 2008 at 09:00:41AM +0000, David Woodhouse wrote: > > On Sat, 2008-03-22 at 16:25 +0100, Sven Luther wrote: > > > BTW, it was reported to me that the ethernet drivers don't get > > > autoload

Re: [PATCH 1/8] [POWERPC] fsl_elbc_nand: factor out localbus defines

2008-04-13 Thread David Woodhouse
On Fri, 2008-04-11 at 09:06 -0500, Kumar Gala wrote: > > David, can you ack this. It looks good to me but want a MTD > maintainer ack before having it go through the powerpc tree. Looks sane to me. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]

[EFIKA] Really, don't pretend to be CHRP

2008-04-13 Thread David Woodhouse
27; property too, since that's what's exposed to userspace in /proc/cpuinfo. Signed-off-by: David Woodhouse <[EMAIL PROTECTED]> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index 5ab4c84..723422e 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/p

Re: PATCH 2/5] Platform code

2008-04-14 Thread David Woodhouse
On Sat, 2008-04-12 at 14:03 -0400, Sean MacLennan wrote: > > - * Sean MacLennan <[EMAIL PROTECTED]> > + * Sean MacLennan Please don't do this. Anywhere. Ever. The spambots are quite capable of undoing it, and have been for years. The only people you inconvenience are real people trying to c

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread David Woodhouse
On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: > I thought we were using efika.forth for this in Fedora. We were, until you pointed out that the kernel actually works just fine these days without it. Now, the _only_ thing that goes wrong without it is that 'CHRP' in the machine: line -- wh

Re: [EFIKA] Really, don't pretend to be CHRP

2008-04-17 Thread David Woodhouse
On Thu, 2008-04-17 at 16:17 +0100, Matt Sealey wrote: > David Woodhouse wrote: > > On Thu, 2008-04-17 at 13:28 +0100, Matt Sealey wrote: > >> I thought we were using efika.forth for this in Fedora. > > > > We were, until you pointed out that the kernel actually

Re: removal of arch/ppc in 2.6.27?

2008-04-21 Thread David Woodhouse
On Sun, 2008-04-20 at 22:27 +1000, Paul Mackerras wrote: > Marvin writes: > > > will this be the end of life for all the PReP's ? I remember a patch posted > > some month ago, but didn't heard anything since then. Any news? Or just let > > it die quietly? > > No, I'm still planning on getting P

Re: [PATCH] MTD: fix partition scan control logic in physmap_of and fsl_elbc_nand

2008-04-22 Thread David Woodhouse
On Thu, 2008-02-28 at 20:17 +0800, Li Yang wrote: > The generic rule for partition scan is to try all supported > partition types before an usable partition table is found. > However the original code returns unsuccessful when there is > an error in any of the partition types. > > Signed-off-by: L

  1   2   >