On Mon, 2010-10-18 at 17:46 +0800, tiejun.chen wrote:
>
> >>> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but
> >>> here
> >>> of_iomap() is already failed you should skip iounmap()
> >>> fsl_lbc_ctrl_dev->regs
> >>> again. So you should improve that as the following on 'err', or layout
> >>> 'err'
> >>> in
> >>> gain.
> >>> ------
> >>> if(fsl_lbc_ctrl_dev->regs)
> >>> iounmap(fsl_lbc_ctrl_dev->regs);
> >>>
> >>> Tiejun
> >> You are right!
> >> How about
> >>
> >> if (!fsl_lbc_ctrl_dev->regs) {
> >> dev_err(&dev->dev, "failed to get memory region\n");
> >> kfree(fsl_lbc_ctrl_dev);
> >> return -ENOMEM;
> >> }
> >
> > Although this is a big problem, I prefer to return 'ENXIO' :)
> ^
> Typo: is not a ......
My God! Why did you *both* repeat over 400 lines of patch, over and over
again, just for this?
Please, make sure you quote *only* what you actually need to quote for
context. Don't make me implement a filter for the list which rejects
messages that are more than 90% quotation.
--
dwmw2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
