[PATCH] SPI: fix build with CONFIG_SPI_FSL_ESPI=m

2011-08-23 Thread Jiri Slaby
When spi_fsl_espi is chosen to be built as a module, there is a build error because we test only CONFIG_SPI_FSL_ESPI in declaration of struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. We need to add a test for CONFIG_SPI_FSL_ESPI_MODULE too. The error looks like: drivers/spi/spi_fsl_espi.c: In fu

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread Matthieu CASTET
LiuShuo a écrit : > 于 2011年08月23日 00:19, Scott Wood 写道: >> On 08/22/2011 11:13 AM, Matthieu CASTET wrote: >>> Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. >>> That's weird because our

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
于 2011年08月19日 00:25, Scott Wood 写道: On 08/17/2011 09:33 PM, b35...@freescale.com wrote: From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose page size is larger than 2K bytes, we divide a page into multi-2K pages for MTD l

Re: linux-next: boot test failure (net tree)

2011-08-23 Thread Jeff Kirsher
On Mon, 2011-08-22 at 21:02 -0700, David Miller wrote: > From: Arnaud Lacombe > Date: Mon, 22 Aug 2011 23:50:02 -0400 > > > Are you implying we need some kind of way to migrate config ? > > The issue is that the dependencies for every single ethernet driver > have changed. Some dependencies hav

Re: [PATCH] SPI: fix build with CONFIG_SPI_FSL_ESPI=m

2011-08-23 Thread Jiri Slaby
On 08/23/2011 09:59 AM, Jiri Slaby wrote: > When spi_fsl_espi is chosen to be built as a module, there is a build > error because we test only CONFIG_SPI_FSL_ESPI in declaration of > struct mpc8xxx_spi in drivers/spi/spi_fsl_lib.h. > > We need to add a test for CONFIG_SPI_FSL_ESPI_MODULE too. > >

Re: [PATCH 1/2] [hw-breakpoint] Use generic hw-breakpoint interfaces for new PPC ptrace flags

2011-08-23 Thread K.Prasad
On Tue, Aug 23, 2011 at 03:08:50PM +1000, David Gibson wrote: > On Fri, Aug 19, 2011 at 01:21:36PM +0530, K.Prasad wrote: > > PPC_PTRACE_GETHWDBGINFO, PPC_PTRACE_SETHWDEBUG and PPC_PTRACE_DELHWDEBUG are > > PowerPC specific ptrace flags that use the watchpoint register. While they > > are > > targ

Re: [PATCH 2/2] [PowerPC Book3E] Introduce new ptrace debug feature flag

2011-08-23 Thread K.Prasad
On Tue, Aug 23, 2011 at 03:09:31PM +1000, David Gibson wrote: > On Fri, Aug 19, 2011 at 01:23:38PM +0530, K.Prasad wrote: > > > > While PPC_PTRACE_SETHWDEBUG ptrace flag in PowerPC accepts > > PPC_BREAKPOINT_MODE_EXACT mode of breakpoint, the same is not intimated to > > the > > user-space debugg

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
于 2011年08月23日 16:14, Matthieu CASTET 写道: LiuShuo a écrit : 于 2011年08月23日 00:19, Scott Wood 写道: On 08/22/2011 11:13 AM, Matthieu CASTET wrote: Scott Wood a écrit : To eliminate it we'd need to do an extra data transfer without reissuing the command, which Shuo was unable to get to work. That

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread Matthieu CASTET
LiuShuo a écrit : > 于 2011年08月19日 00:25, Scott Wood 写道: >> On 08/17/2011 09:33 PM, b35...@freescale.com wrote: >>> From: Liu Shuo >>> >>> Freescale FCM controller has a 2K size limitation of buffer RAM. In order >>> to support the Nand flash chip whose page size is larger than 2K bytes, >>> we divi

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread Matthieu CASTET
LiuShuo a écrit : > 于 2011年08月23日 16:14, Matthieu CASTET 写道: >> LiuShuo a écrit : >>> 于 2011年08月23日 00:19, Scott Wood 写道: On 08/22/2011 11:13 AM, Matthieu CASTET wrote: > Scott Wood a écrit : >> To eliminate it we'd need to do an extra data transfer without reissuing >> the command

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Joerg Roedel
On Mon, Aug 22, 2011 at 08:52:18PM -0400, aafabbri wrote: > You have to enforce group/iommu domain assignment whether you have the > existing uiommu API, or if you change it to your proposed > ioctl(inherit_iommu) API. > > The only change needed to VFIO here should be to make uiommu fd assignment

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Joerg Roedel
On Tue, Aug 23, 2011 at 02:54:43AM -0400, Benjamin Herrenschmidt wrote: > Possibly, the question that interest me the most is what interface will > KVM end up using. I'm also not terribly fan with the (perceived) > discrepancy between using uiommu to create groups but using the group fd > to actual

[PATCH] powerpc: fixup QE_General4 errata

2011-08-23 Thread Joakim Tjernlund
QE_General4 should only round up the divisor iff divisor is > 3. Rounding up lower divisors makes the error too big, causing USB on MPC832x to fail. Signed-off-by: Joakim Tjernlund --- arch/powerpc/sysdev/qe_lib/qe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/

[PATCH] usb: Allocate pram dynamically.

2011-08-23 Thread Joakim Tjernlund
MPC832x does not have enough MURAM to do fixed MURAM allocation. Change to dynamic allocation. Signed-off-by: Joakim Tjernlund --- drivers/usb/host/fhci-hcd.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c in

[PATCH] perf: fix build for PowerPC with uclibc toolchains

2011-08-23 Thread Florian Fainelli
libio.h is not provided by uClibc, in order to be able to test the definition of __UCLIBC__ we need to include stdlib.h, which also includes stddef.h, providing the definition of 'NULL'. Signed-off-by: Florian Fainelli --- FYI, I submitted the exact same patch for ARM: https://patchwork.kernel.or

RE: [PATCH] RapidIO: Fix use of non-compatible registers

2011-08-23 Thread Bounine, Alexandre
Andrew Morton wrote: > On Tue, 26 Jul 2011 14:07:26 -0400 > Alexandre Bounine wrote: > > > Replace/remove use of RIO v.1.2 registers/bits that are not forward- > compatible > > with newer versions of RapidIO specification. > > > > RapidIO specification v. 1.3 removed Write Port CSR, Doorbell CS

Re: [PATCH] usb: Allocate pram dynamically.

2011-08-23 Thread Anton Vorontsov
On Tue, Aug 23, 2011 at 02:38:41PM +0200, Joakim Tjernlund wrote: > MPC832x does not have enough MURAM to do fixed MURAM allocation. > Change to dynamic allocation. > > Signed-off-by: Joakim Tjernlund Acked-by: Anton Vorontsov Thanks! p.s. You probably want to send this to Greg KH, + Cc linux

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 05:03:53PM -0400, Benjamin Herrenschmidt wrote: > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > assigned to a guest, there can also be an ioctl to bind a group to an > > address-space of another group (certainly needs some care to not allow > > t

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Roedel, Joerg
On Mon, Aug 22, 2011 at 03:17:00PM -0400, Alex Williamson wrote: > On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > assigned to a guest, there can also be an ioctl to bind a group to an > > address-space of another gro

Re: [PATCH] usb: Allocate pram dynamically.

2011-08-23 Thread Joakim Tjernlund
Anton Vorontsov wrote on 2011/08/23 15:02:53: > From: Anton Vorontsov > To: Joakim Tjernlund > Cc: linuxppc-dev@lists.ozlabs.org > Date: 2011/08/23 15:02 > Subject: Re: [PATCH] usb: Allocate pram dynamically. > > On Tue, Aug 23, 2011 at 02:38:41PM +0200, Joakim Tjernlund wrote: > > MPC832x does

MPC5200 + BestComm support in QEMU

2011-08-23 Thread steve . belanger
Hi, I'm Steve, an embedded software developper for Bombardier Transportation Canada. We use the MPC5200 for most of our onboard computers inside train control systems. To enhance our SW engineering process, we would like the emulate the MPC5200 processor using QEMU, an open source software CPU

MPC5200 + BestComm support in QEMU

2011-08-23 Thread steve . belanger
Hi, I'm Steve, an embedded software developper for Bombardier Transportation Canada. We use the MPC5200 for most of our onboard computers inside train control systems. To enhance our SW engineering process, we would like the emulate the MPC5200 processor using QEMU, an open source software CPU

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread Scott Wood
On 08/23/2011 05:02 AM, Matthieu CASTET wrote: > LiuShuo a écrit : >> We can't read the NOP from the ID on any chip. Some chips don't >> give this infomation.(e.g. Micron MT29F4G08BAC) Are there any 4K+ chips (especially ones with insufficient NOP) that don't have the info? This chip is 2K and NO

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 12:38 +1000, David Gibson wrote: > On Mon, Aug 22, 2011 at 09:45:48AM -0600, Alex Williamson wrote: > > On Mon, 2011-08-22 at 15:55 +1000, David Gibson wrote: > > > On Sat, Aug 20, 2011 at 09:51:39AM -0700, Alex Williamson wrote: > > > > We had an extremely productive VFIO BoF

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread aafabbri
On 8/23/11 4:04 AM, "Joerg Roedel" wrote: > On Mon, Aug 22, 2011 at 08:52:18PM -0400, aafabbri wrote: >> You have to enforce group/iommu domain assignment whether you have the >> existing uiommu API, or if you change it to your proposed >> ioctl(inherit_iommu) API. >> >> The only change neede

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > > > I'm not following you. > > > > You have to enforce group/iommu domain assignment whether you have the > > existing uiommu API, or if you change it to your proposed > > ioctl

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 15:14 +0200, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 03:17:00PM -0400, Alex Williamson wrote: > > On Mon, 2011-08-22 at 19:25 +0200, Joerg Roedel wrote: > > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > > assigned to a guest, there can also

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Aaron Fabbri
On 8/23/11 10:01 AM, "Alex Williamson" wrote: > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: >> >>> I'm not following you. >>> >>> You have to enforce group/iommu domain assignment whether you have the >>> existing uio

Re: [PATCH] powerpc: fixup QE_General4 errata

2011-08-23 Thread Timur Tabi
Joakim Tjernlund wrote: > QE_General4 should only round up the divisor iff divisor is > 3. > Rounding up lower divisors makes the error too big, causing USB > on MPC832x to fail. > > Signed-off-by: Joakim Tjernlund Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale __

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 10:33 -0700, Aaron Fabbri wrote: > > > On 8/23/11 10:01 AM, "Alex Williamson" wrote: > > > On Tue, 2011-08-23 at 16:54 +1000, Benjamin Herrenschmidt wrote: > >> On Mon, 2011-08-22 at 17:52 -0700, aafabbri wrote: > >> > >>> I'm not following you. > >>> > >>> You have to e

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
Julia Lawall wrote: > At this point, ehv_pic has been allocated but not stored anywhere, so it > should be freed before leaving the function. Acked-by: Timur Tabi FYI, Ashish is no longer with Freescale, so I've taken over maintainership of ehv_pic. -- Timur Tabi Linux kernel developer at Free

Re: [PATCH 8/9] arch/powerpc/sysdev/ehv_pic.c: add missing kfree

2011-08-23 Thread Timur Tabi
Ben, Kumar, can one of you take a look at my question and help me out? wrote: > On Mon, Aug 8, 2011 at 7:18 AM, Julia Lawall wrote: > >> diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c >> index af1a5df..b6731e4 100644 >> --- a/arch/powerpc/sysdev/ehv_pic.c >> +++ b/ar

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 07:01 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2011-08-22 at 09:45 -0600, Alex Williamson wrote: > > > Yes, that's the idea. An open question I have towards the configuration > > side is whether we might add iommu driver specific options to the > > groups. For instanc

Re: [PATCH part1 v2 1/9] Add udbg driver using the PS3 gelic Ethernet device

2011-08-23 Thread Geoff Levand
Hi, We had some questions as to why we have this totally separate driver from the gelic driver, so I think it worthwhile to have an explanation of why in the commit log. Otherwise, the code looks OK. -Geoff > From: Hector Martin > > Signed-off-by: Hector Martin > [a.heider: Various cleanups

Re: [PATCH part1 v2 2/9] ps3: Add helper functions to read highmem info from the repository

2011-08-23 Thread Geoff Levand
On 08/11/2011 12:31 PM, Andre Heider wrote: > An earlier step in the boot chain can preallocate the highmem region. > A boot loader doing so will place the region infos in the repository. > Provide helper functions to read the required nodes. > > Signed-off-by: Andre Heider > --- > arch/powerpc/

Re: [PATCH part1 v2 3/9] ps3: Get lv1 high memory region from the repository

2011-08-23 Thread Geoff Levand
On 08/11/2011 12:31 PM, Andre Heider wrote: > This lets the bootloader preallocate the high lv1 region and pass its > location to the kernel through the repository. Thus, it can be used to > hold the initrd. If the region info doesn't exist, the kernel retains > the old behavior and attempts to all

Re: [PATCH part1 v2 4/9] Add region 1 memory early

2011-08-23 Thread Geoff Levand
On 08/11/2011 12:31 PM, Andre Heider wrote: > From: Hector Martin > > Real mode memory can be limited and runs out quickly as memory is > allocated during kernel startup. > Having region1 available sooner fixes this. > > Signed-off-by: Hector Martin > [a.heider: Various cleanups to make checkpa

Re: [PATCH part1 v2 5/9] ps3: MEMORY_HOTPLUG is not a requirement anymore

2011-08-23 Thread Geoff Levand
On 08/11/2011 12:31 PM, Andre Heider wrote: > Signed-off-by: Andre Heider > --- > arch/powerpc/platforms/ps3/Kconfig |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/platforms/ps3/Kconfig > b/arch/powerpc/platforms/ps3/Kconfig > index 476d9d9..84df5c8 1

Re: [PATCH part1 v2 6/9] ps3: Detect the current lpar

2011-08-23 Thread Geoff Levand
Hi, On 08/11/2011 12:31 PM, Andre Heider wrote: > Detect it by reading the ss laid repository node, and make it > accessible via ps3_get_ss_laid(). I'm wondering now if we even need this. It is mainly used by your later patch 8/9 that modifies ps3flash_init() to test if we should call ps3_system

Re: [PATCH part1 v2 8/9] ps3flash: Refuse to work in lpars other than OtherOS

2011-08-23 Thread Geoff Levand
On 08/11/2011 12:31 PM, Andre Heider wrote: > The driver implements a character and misc device, meant for the > axed OtherOS to exchange various settings with GameOS. > Since Firmware 3.21 there is no support anymore to write these > settings, so test if we're running in OtherOS, and refuse to loa

Re: [Cbe-oss-dev] [PATCH part1 v2 4/9] Add region 1 memory early

2011-08-23 Thread Antonio Ospite
On Tue, 23 Aug 2011 13:53:46 -0700 Geoff Levand wrote: [...] > > > > + if (!map.r1.size) { > > + DBG("%s:%d: no region 1, not adding memory\n", > > + __func__, __LINE__); > > + } else { > > Remove brackets around a single line conditional. > > > + DBG

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
On Tue, 2011-08-23 at 15:18 +0200, Roedel, Joerg wrote: > On Mon, Aug 22, 2011 at 05:03:53PM -0400, Benjamin Herrenschmidt wrote: > > > > > I am in favour of /dev/vfio/$GROUP. If multiple devices should be > > > assigned to a guest, there can also be an ioctl to bind a group to an > > > address-sp

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
On Tue, 2011-08-23 at 10:23 -0600, Alex Williamson wrote: > > Yeah. Joerg's idea of binding groups internally (pass the fd of one > group to another via ioctl) is one option. The tricky part will be > implementing it to support hot unplug of any group from the > supergroup. > I believe Ben had a

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Benjamin Herrenschmidt
> > For us the most simple and logical approach (which is also what pHyp > > uses and what Linux handles well) is really to expose a given PCI host > > bridge per group to the guest. Believe it or not, it makes things > > easier :-) > > I'm all for easier. Why does exposing the bridge use less b

Re: [Cbe-oss-dev] [PATCH part1 v2 4/9] Add region 1 memory early

2011-08-23 Thread Geoff Levand
Hi Antonio, On 08/23/2011 03:37 PM, Antonio Ospite wrote: > Geoff Levand wrote: >> > + if (!map.r1.size) { >> > + DBG("%s:%d: no region 1, not adding memory\n", >> > + __func__, __LINE__); >> > + } else { >> >> Remove brackets around a single line conditional. >> >>

Re: [PATCH v3] mtd/nand : workaround for Freescale FCM to support large-page Nand chip

2011-08-23 Thread LiuShuo
于 2011年08月23日 18:02, Matthieu CASTET 写道: LiuShuo a écrit : 于 2011年08月19日 00:25, Scott Wood 写道: On 08/17/2011 09:33 PM, b35...@freescale.com wrote: From: Liu Shuo Freescale FCM controller has a 2K size limitation of buffer RAM. In order to support the Nand flash chip whose page size is larger

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alexander Graf
On 23.08.2011, at 18:41, Benjamin Herrenschmidt wrote: > On Tue, 2011-08-23 at 10:23 -0600, Alex Williamson wrote: >> >> Yeah. Joerg's idea of binding groups internally (pass the fd of one >> group to another via ioctl) is one option. The tricky part will be >> implementing it to support hot u

Re: kvm PCI assignment & VFIO ramblings

2011-08-23 Thread Alexander Graf
On 23.08.2011, at 18:51, Benjamin Herrenschmidt wrote: > >>> For us the most simple and logical approach (which is also what pHyp >>> uses and what Linux handles well) is really to expose a given PCI host >>> bridge per group to the guest. Believe it or not, it makes things >>> easier :-) >> >>

Re: [PATCH 2/2] [PowerPC Book3E] Introduce new ptrace debug feature flag

2011-08-23 Thread David Gibson
On Tue, Aug 23, 2011 at 02:57:56PM +0530, K.Prasad wrote: > On Tue, Aug 23, 2011 at 03:09:31PM +1000, David Gibson wrote: > > On Fri, Aug 19, 2011 at 01:23:38PM +0530, K.Prasad wrote: > > > > > > While PPC_PTRACE_SETHWDEBUG ptrace flag in PowerPC accepts > > > PPC_BREAKPOINT_MODE_EXACT mode of bre

Re: [PATCH 1/2] [hw-breakpoint] Use generic hw-breakpoint interfaces for new PPC ptrace flags

2011-08-23 Thread David Gibson
On Tue, Aug 23, 2011 at 02:55:13PM +0530, K.Prasad wrote: > On Tue, Aug 23, 2011 at 03:08:50PM +1000, David Gibson wrote: > > On Fri, Aug 19, 2011 at 01:21:36PM +0530, K.Prasad wrote: > > > PPC_PTRACE_GETHWDBGINFO, PPC_PTRACE_SETHWDEBUG and PPC_PTRACE_DELHWDEBUG > > > are > > > PowerPC specific pt