Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Kumar Gala
I'm puzzled. Could someone point me to some real code where cell- index is used as a pointer into some global data. Sorry for my ignorance. http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057254.html Yep, I saw that it's used for I2C (and SPI). But "cell-index" is also defined for networ

Re: [PATCH 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
Kumar Gala wrote: > I'm puzzled. Could someone point me to some real code where cell-index is used as a pointer into some global data. Sorry for my ignorance. >>> >>> http://ozlabs.org/pipermail/linuxppc-dev/2008-June/057254.html >> >> Yep, I saw that it's used for I2C (and SPI). But

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Jean Delvare
On Thu, 5 Jun 2008 08:22:00 +0200, Stefan Roese wrote: > On Thursday 05 June 2008, Sean MacLennan wrote: > > On Wed, 4 Jun 2008 22:05:55 -0500 > > > > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > I'm not proposing we remove that. I'm just proposing that it can be > > > derived from something other

10th Real-Time Linux Workshop - Call for Papers

2008-06-05 Thread Wang, Baojun
hi, I'm really sorry if this message disturb anybody, however.. = 10th Real-Time Linux Workshop October 29 November 1, 2008 University of Guadalajara Centro Universitario del Norte Carretera Federal # 23 Km 191, C.P.

[PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

2008-06-05 Thread Stefan Roese
This patch enables the IBM I2C driver for all PPC4xx variants by adding "ibm,iic" to the compatible list. This way all currently available arch/powerpc 4xx ports can make use of this driver without any changes. Additionally all "other" compatible entries are removed since they are not needed anymor

Re: MMIO and gcc re-ordering issue

2008-06-05 Thread Jes Sorensen
Jesse Barnes wrote: Now, in hindsight, using a PIO write set & test flag approach in writeX/spin_unlock (ala powerpc) might have been a better approach, but iirc that never came up in the discussion, probably because we were focused on PCI posting and not uncached vs. cached ordering. Hi Jess

Re: MMIO and gcc re-ordering issue

2008-06-05 Thread Benjamin Herrenschmidt
On Thu, 2008-06-05 at 10:40 +0200, Jes Sorensen wrote: > Jesse Barnes wrote: > > Now, in hindsight, using a PIO write set & test flag approach in > > writeX/spin_unlock (ala powerpc) might have been a better approach, but > > iirc > > that never came up in the discussion, probably because we wer

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Stefan Roese
On Thursday 05 June 2008, Jean Delvare wrote: > > > Maybe it is time to remove the index, or maybe we should go back to > > > using both a static and the index. But at the time we decided to > > > enforce an index. > > > > So what should we do now? Currently I2C doesn't work at all on 4xx since > >

[PATCH v2] [NAND] driver extension to support NAND on TQM85xx modules

2008-06-05 Thread Wolfgang Grandegger
[NAND] driver extension to support NAND on TQM85xx modules This patch extends the FSL UPM NAND driver from Anton Vorontsov to support NAND on the TQM85xx modules. Unfortunately, the hardware does not support the R/B pins of the NAND chip and therefore the specified maximum delay time must used. It

[PATCH v2 0/4] [POWERPC] 85xx: Add suport for TQM8548 and some TQM85xx fixes

2008-06-05 Thread Wolfgang Grandegger
Hello, it follows version 2 of patches adding support for the TQM8548 modules from TQ Components (http://www.tqc.de) and furthermore fixing some issues with other TQM85xx modules. They are already based on Kumar's powerpc Linux tree (linux-2.6-galak). The NAND support requires the patch with the

[PATCH v2 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash

2008-06-05 Thread Wolfgang Grandegger
Some TQM85xx boards could be equipped with up to 1 GiB (NOR) flash memory and therefore a modified memory map is required and setup by the board loader. This patch adds an appropriate DTS file. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |

[PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
[POWERPC] 85xx: add board support for the TQM8548 modules This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |1 arch/powerpc/boot/dts/tqm8548.dts

[PATCH v2 3/4] [POWERPC] 85xx: add local bus nodes for Flash and CAN to tqm8560.dts

2008-06-05 Thread Wolfgang Grandegger
Add local bus nodes for Flash and CAN to tqm8560.dts Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8560.dts | 65 ++ 1 file changed, 65 insertions(+) Index: linux-2.6-galak/arch/powerpc/boot/dts/tqm8560.dts =

[PATCH v2 4/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules

2008-06-05 Thread Wolfgang Grandegger
Like for the TQM5200, the vendor prefix "tqc," is now used for all TQM85xx modules from TQ-Components GmbH (http://www.tqc.de) in the corresponding DTS files. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8540.dts |4 ++-- arch/powerpc/boot/dts/t

Re: inline assembly

2008-06-05 Thread David Howells
Scott Wood <[EMAIL PROTECTED]> wrote: > int tmp; > > asm volatile("addi %1, %2, -1;" > "andc %1, %2, %1;" > "cntlzw %1, %1;" > "subfic %0, %1, 31" : "=r" (j), "=&r" (tmp) : "r" (i)); Registers are usually assumed to be 'long' in size, so I'd recommend using

Re: Linux 2.6.26-rc5

2008-06-05 Thread Olaf Hering
On Wed, Jun 04, Linus Torvalds wrote: > Another week, another batch of mostly pretty small fixes. Hopefully the > regression list is shrinking, and we've fixed at least a couple of the > oopses on Arjan's list. SATA on a dualcore G5 is broken, it happend between c3b25b32e8bef526cca748e1ba023c6b

Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 10:10:53 +0200 Stefan Roese <[EMAIL PROTECTED]> wrote: > This patch enables the IBM I2C driver for all PPC4xx variants by adding > "ibm,iic" to the compatible list. This way all currently available > arch/powerpc 4xx ports can make use of this driver without any changes. > Addi

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 10:45:42 +0200 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Thursday 05 June 2008, Jean Delvare wrote: > > > > Maybe it is time to remove the index, or maybe we should go back to > > > > using both a static and the index. But at the time we decided to > > > > enforce an index. >

Re: Linux 2.6.26-rc5 (G5 SATA broken)

2008-06-05 Thread Hugh Dickins
On Thu, 5 Jun 2008, Olaf Hering wrote: > On Wed, Jun 04, Linus Torvalds wrote: > > > Another week, another batch of mostly pretty small fixes. Hopefully the > > regression list is shrinking, and we've fixed at least a couple of the > > oopses on Arjan's list. > > SATA on a dualcore G5 is broken

Re: [PATCH v2] MTD support for the AMCC Taishan

2008-06-05 Thread Imre Kaloz
bump? :) On Mon, 17 Mar 2008 14:48:23 +0100, Imre Kaloz <[EMAIL PROTECTED]> wrote: Signed-off-by: Imre Kaloz <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/taishan.dts | 29 +++- arch/powerpc/configs/taishan_defconfig | 79 +++- 2 files changed, 1

Re: Linux 2.6.26-rc5

2008-06-05 Thread Alan Cox
On Thu, 5 Jun 2008 13:24:36 +0200 Olaf Hering <[EMAIL PROTECTED]> wrote: > On Wed, Jun 04, Linus Torvalds wrote: > > > Another week, another batch of mostly pretty small fixes. Hopefully the > > regression list is shrinking, and we've fixed at least a couple of the > > oopses on Arjan's list. >

Re: Linux 2.6.26-rc5 (G5 SATA broken)

2008-06-05 Thread Alan Cox
> And the patch I'm finding successful is below: I won't sign it off, > for all I know it's reverting part of what Alan is trying to achieve; > but I expect it'll help towards the right fix. Its the right fix ata_sff_check_altstatus() is a routine which does the altstatus check and may o

Re: [PATCH v2] MTD support for the AMCC Taishan

2008-06-05 Thread Josh Boyer
On Thu, 05 Jun 2008 14:50:41 +0200 "Imre Kaloz" <[EMAIL PROTECTED]> wrote: > bump? :) It won't apply anymore, but the fixups are trivial. I can do that if Stefan acks the changes. josh ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozla

Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Kumar Gala
On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: [POWERPC] 85xx: add board support for the TQM8548 modules This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile

[PATCH] libata: fix G5 SATA broken on -rc5

2008-06-05 Thread Hugh Dickins
Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering: fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> --- drivers

Re: [PATCH v2 2/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash

2008-06-05 Thread Kumar Gala
On Jun 5, 2008, at 4:09 AM, Wolfgang Grandegger wrote: Some TQM85xx boards could be equipped with up to 1 GiB (NOR) flash memory and therefore a modified memory map is required and setup by the board loader. This patch adds an appropriate DTS file. Signed-off-by: Wolfgang Grandegger <[EMAIL PR

Re: [PATCH v2 4/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules

2008-06-05 Thread Kumar Gala
On Jun 5, 2008, at 4:13 AM, Wolfgang Grandegger wrote: Like for the TQM5200, the vendor prefix "tqc," is now used for all TQM85xx modules from TQ-Components GmbH (http://www.tqc.de) in the corresponding DTS files. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts

[PATCH] PowerPC 44x: small warp-nand fix

2008-06-05 Thread Valentine Barshak
The "ndfc-chip" device doesn't need any resources. All resources are handled by the "ndfc-nand" device. Registering the same memory resource twice causes "cat /proc/iomem" to go into an infinite loop displaying NDFC memory addresses. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/p

[PATCH] [POWERPC] 4xx: PCIe driver now detects if a port is disabled via the dev-tree

2008-06-05 Thread Stefan Roese
This patch add a check to the PPC4xx PCIe driver to detect if the port is disabled via the device-tree. This is needed for the AMCC Canyonlands board which has an option to either select 2 PCIe ports or 1 PCIe port and one SATA port. The SATA port and the 1st PCIe port pins are multiplexed so we ca

Re: [PATCH] PowerPC 44x: small warp-nand fix

2008-06-05 Thread Stefan Roese
On Thursday 05 June 2008, Valentine Barshak wrote: > The "ndfc-chip" device doesn't need any resources. All resources > are handled by the "ndfc-nand" device. Registering the same memory > resource twice causes "cat /proc/iomem" to go into an infinite loop > displaying NDFC memory addresses. > > Si

Re: [PATCH] libata: fix G5 SATA broken on -rc5

2008-06-05 Thread Olaf Hering
On Thu, Jun 05, Hugh Dickins wrote: > Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering: > fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff: > Fix oops reported in kerneloops.org for pnp devices with no ctl > > Signed-off-by: Hugh Dickins <[EMAIL PROTECTED]> > Ack

4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Josh Boyer
This commit (patch omitted due to size) is sitting in my local tree: commit 0d7efc1e80fc262bcc507a605482c5681e3f082a Author: Josh Boyer <[EMAIL PROTECTED]> Date: Thu Jun 5 09:46:17 2008 -0500 ppc/4xx: Remove 4xx support from arch/ppc Remove support for PPC 403, 405, and 440 process

[RFC][PATCH] powerpc/85xx: add DOZE/NAP support for e500 core

2008-06-05 Thread Kumar Gala
From: Dave Liu <[EMAIL PROTECTED]> The e500 core enter DOZE/NAP power-saving modes when the core go to cpu_idle routine. The power management default running mode is DOZE, If the user echo 1 > /proc/sys/kernel/powersave-nap the system will change to NAP running mode. --- I'm post this for rev

Re: [PATCH 3/3] mmc: change .get_ro() callback semantics

2008-06-05 Thread Anton Vorontsov
On Tue, Jun 03, 2008 at 12:07:49PM +0200, Marc Pignat wrote: > Hi all! > > On Friday 23 May 2008, Anton Vorontsov wrote: > > get_ro() callback must return values >= 0 for its logical state, and > ... > > static void pxamci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > > diff --git a/includ

Re: 4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 8:52 AM, Josh Boyer <[EMAIL PROTECTED]> wrote: > This commit (patch omitted due to size) is sitting in my local tree: > > commit 0d7efc1e80fc262bcc507a605482c5681e3f082a > Author: Josh Boyer <[EMAIL PROTECTED]> > Date: Thu Jun 5 09:46:17 2008 -0500 > >ppc/4xx: Remove 4x

Re: 4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 09:11:48 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > On Thu, Jun 5, 2008 at 8:52 AM, Josh Boyer <[EMAIL PROTECTED]> wrote: > > This commit (patch omitted due to size) is sitting in my local tree: > > > > commit 0d7efc1e80fc262bcc507a605482c5681e3f082a > > Author: Josh Boye

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Josh Boyer wrote: > From a device tree perspective, index and cell-index are both > incorrect. The IIC macros don't share register blocks with anything, > are enumerated as unique instances per macro in the device tree, and > should be able to be distinguished by "regs" and/or unit address. I th

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Josh Boyer wrote: > seems to be a more distinct definition of what this is. But I have no > idea how well that would go over, and it would probably need to be > changed in all the fsl boards as well. Which would end up breaking backwards compatibility with older device trees. Like I said earlier

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Stefan Roese wrote: > So what should we do now? Currently I2C doesn't work at all on 4xx since the > driver expects the "index" property and no dts sets this property. Personally > I would like to move to using cell-index here, since this seems to be more > common. But I could also life with re

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 9:13 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Josh Boyer wrote: > >> From a device tree perspective, index and cell-index are both >> incorrect. The IIC macros don't share register blocks with anything, >> are enumerated as unique instances per macro in the device tree, a

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Grant Likely wrote: > if you need explicit indexing then use an alias. My opinion however > is that explicit indexing is unnecessary and is just an artifact of > current i2c subsystem internals. There is already enough information > in the device tree to match i2c devices with i2c busses without

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Jochen Friedrich
Hi Timur, > In situations where it doesn't matter which I2C bus is #1 and which one is #2, > then I think the code should just initialize idx based on the order the nodes > are found in the tree. > > In situations where it does matter, then we should use cell-index. that's what I did in i2c-cpm,

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Segher Boessenkool
I think we should just expand the definition of cell-index to include standard device enumeration for when it's needed. The original definition is too limited, IMHO. nak if you need explicit indexing then use an alias. My opinion however is that explicit indexing is unnecessary and is just

RE: 4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Stephen Neuendorffer
> -Original Message- > From: [EMAIL PROTECTED] [mailto:linuxppc-dev- > [EMAIL PROTECTED] On Behalf Of Josh Boyer > Sent: Thursday, June 05, 2008 8:19 AM > To: Grant Likely > Cc: linuxppc-dev@ozlabs.org; Paul Mackerras > Subject: Re: 4xx support in arch/ppc is going away Real Soon Now > > O

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Jochen Friedrich wrote: > Hi Timur, > >> In situations where it doesn't matter which I2C bus is #1 and which one is >> #2, >> then I think the code should just initialize idx based on the order the nodes >> are found in the tree. >> >> In situations where it does matter, then we should use cell-i

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Jochen Friedrich
Hi Grant, > if you need explicit indexing then use an alias. My opinion however > is that explicit indexing is unnecessary and is just an artifact of > current i2c subsystem internals. There is already enough information > in the device tree to match i2c devices with i2c busses without > resorti

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Segher Boessenkool
if you need explicit indexing then use an alias. My opinion however is that explicit indexing is unnecessary and is just an artifact of current i2c subsystem internals. There is already enough information in the device tree to match i2c devices with i2c busses without resorting to indexes. Not

Re: [PATCH] Fix definitions for dbcr0, dbcr1, & dbcr2 register for bookE processors

2008-06-05 Thread Jerone Young
On Wed, 2008-06-04 at 21:14 -0500, Josh Boyer wrote: > On Wed, 04 Jun 2008 17:26:44 -0500 > Jerone Young <[EMAIL PROTECTED]> wrote: > > > Taken from the PowerPC ISA BookIII-E specifies that DBCR0 is different > > for all others that are not ppc405 chips. So I have now chnaged the > > conditional t

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 9:52 AM, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Grant, > >> if you need explicit indexing then use an alias. My opinion however >> is that explicit indexing is unnecessary and is just an artifact of >> current i2c subsystem internals. There is already enough infor

[PATCH] [v2] Fix definitions for dbcr0, dbcr1, & dbcr2 register for bookE processors

2008-06-05 Thread Jerone Young
Update: Consolidated dbcr1 & dbcr2 under one define. Taken from the PowerPC ISA BookIII-E specifies that DBCR0 is different for all others that are not ppc405 chips. So I have now chnaged the conditional to reflect this. Also added definitions needed for DBCR1 & DBCR2. Signed-off-by: Jerone Youn

Re: [PATCH 3/3] mmc: change .get_ro() callback semantics

2008-06-05 Thread Marc Pignat
On Thursday 05 June 2008, Anton Vorontsov wrote: > On Tue, Jun 03, 2008 at 12:07:49PM +0200, Marc Pignat wrote: > > Hi all! > > > > On Friday 23 May 2008, Anton Vorontsov wrote: > > > get_ro() callback must return values >= 0 for its logical state, and > > ... > > > static void pxamci_set_ios(str

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 9:43 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > >> if you need explicit indexing then use an alias. My opinion however >> is that explicit indexing is unnecessary and is just an artifact of >> current i2c subsystem internals. There is already enough i

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Segher Boessenkool wrote: > Sounds to me like both simply need to use adapter->nr. How can a non-I2C driver get the adapter structure for another driver that is an I2C driver? > For access to > Linux-internal data structures (and that is what this "index" is), you > shouldn't have to go via the

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 9:50 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Jochen Friedrich wrote: >> Hi Timur, >> >>> In situations where it doesn't matter which I2C bus is #1 and which one is >>> #2, >>> then I think the code should just initialize idx based on the order the >>> nodes >>> are foun

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Grant Likely wrote: > That is still Linux internal artifacts leaking out. Don't encode that > data into the device tree. The I2C bus number is *not* an internal artifact. On Freescale parts, the one I2C adapter is specifically designated I2C1, and the 2nd one is specifically designated I2C2. T

[PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Anton Vorontsov
Here is v3. I'm out of ideas if you won't like it. :-) v3: - Now these bindings are using bus notifiers chain, thus we adhere to the spi bus. By the way, this scheme (IMO) looks good for I2C devices which needs platform_data extracted from the device tree too (Cc'ing Jochen). - Plus change

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Grant Likely wrote: > [EMAIL PROTECTED] { > #size-cells = <1>; > #address-cells = <1>; > ranges = <0 0xe 0x1000>; > [EMAIL PROTECTED] { > cell-index = <0>; > regs = <0 0x100>; > } > [EMAIL PROTECTED] { >

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 05 Jun 2008 11:13:23 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > > > That is still Linux internal artifacts leaking out. Don't encode that > > data into the device tree. > > The I2C bus number is *not* an internal artifact. On Freescale parts, the one > I2C adap

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Jochen Friedrich
Hi Timur, > It's a little late for that. I'm okay with coming up with a new property to > provide system-level indexing, but it needs to be the same property name for > each type of device. I don't want linux,i2c-index and linux,dma-index and > linux,ssi-index, etc. I also don't understand why

Re: [PATCH] [v2] Fix definitions for dbcr0, dbcr1, & dbcr2 register for bookE processors

2008-06-05 Thread Kumar Gala
On Jun 5, 2008, at 10:56 AM, Jerone Young wrote: Update: Consolidated dbcr1 & dbcr2 under one define. Taken from the PowerPC ISA BookIII-E specifies that DBCR0 is different for all others that are not ppc405 chips. So I have now chnaged the conditional to reflect this. Also added definitions n

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Scott Wood
On Thu, Jun 05, 2008 at 11:09:16AM -0500, Timur Tabi wrote: > The fabric driver doesn't have access to any I2C structures when it starts > looking for the codec driver. The fabric driver is like an OF platform > driver, > in that it's OF-aware and machine-specific. By parsing the device tree (wh

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 10:22 AM, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Timur, > >> It's a little late for that. I'm okay with coming up with a new property to >> provide system-level indexing, but it needs to be the same property name for >> each type of device. I don't want linux,i2c-

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Josh Boyer wrote: > And it does. It does so by the unique "regs" properties and > unit-names. You can assign the index that the i2c subsystem needs > based on probe order, like I already said. The probe order is not sufficient on platforms that specifically enumerate their I2C (or whatever) dev

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 10:18 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Grant Likely wrote: > >> [EMAIL PROTECTED] { >> #size-cells = <1>; >> #address-cells = <1>; >> ranges = <0 0xe 0x1000>; >> [EMAIL PROTECTED] { >> cell-index = <0>; >>

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 10:25 AM, Timur Tabi <[EMAIL PROTECTED]> wrote: > Josh Boyer wrote: > >> And it does. It does so by the unique "regs" properties and >> unit-names. You can assign the index that the i2c subsystem needs >> based on probe order, like I already said. > > The probe order is not

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Grant Likely wrote: > 2) for i2c purposes, explicit enumeration is not needed or desired. > All the necessary data is already present in the device tree in that > i2c device nodes are children of i2c bus nodes. The i2c bus numbers > should be dynamically assigned. NACK. For ASoC driver, they ca

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > Here is v3. I'm out of ideas if you won't like it. :-) > > v3: > - Now these bindings are using bus notifiers chain, thus we adhere to the > spi bus. > > By the way, this scheme (IMO) looks good for I2C devices which ne

Re: inline assembly

2008-06-05 Thread Scott Wood
On Thu, Jun 05, 2008 at 11:44:51AM +0100, David Howells wrote: > Scott Wood <[EMAIL PROTECTED]> wrote: > > > int tmp; > > > > asm volatile("addi %1, %2, -1;" > > "andc %1, %2, %1;" > > "cntlzw %1, %1;" > > "subfic %0, %1, 31" : "=r" (j), "=&r" (tmp) : "r" (i

[PATCH] mmc: toughen get_ro() and get_cd() return values

2008-06-05 Thread Anton Vorontsov
For the sake of safety, document that drivers should return only 1 or 0 from the get_ro() and get_cd() callbacks. Also document context in which these callbacks should be executed. wbsd driver modified to comply with this requirement. Also, fix mmc_spi driver to not return raw values from the pla

[PATCH v3 1/4] [POWERPC] 85xx: correct vendor prefix in DTS files for TQM85xx modules

2008-06-05 Thread Wolfgang Grandegger
Like for the TQM5200, the vendor prefix "tqc," is now used for all TQM85xx modules from TQ-Components GmbH (http://www.tqc.de) in the corresponding DTS files. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8540.dts |4 ++-- arch/powerpc/boot/dts/tqm854

[PATCH v3 2/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
This patch adds support for the TQM8548 modules from TQ-Components GmbH (http://www.tqc.de). Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |1 arch/powerpc/boot/dts/tqm8548.dts | 365 + arch/powerpc/boot/wrapper

[PATCH v3 3/4] [POWERPC] 85xx: support for the TQM8548 module using the big Flash

2008-06-05 Thread Wolfgang Grandegger
Some TQM85xx boards could be equipped with up to 1 GiB (NOR) flash memory and therefore a modified memory map is required and setup by the board loader. This patch adds an appropriate DTS file. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8548-bigflash.dts |

[PATCH v3 4/4] [POWERPC] 85xx: add local bus nodes for Flash and CAN to tqm8560.dts

2008-06-05 Thread Wolfgang Grandegger
Add local bus nodes for Flash and CAN to the DTS file of the TQM8650 module. Signed-off-by: Wolfgang Grandegger <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/tqm8560.dts | 65 ++ 1 file changed, 65 insertions(+) Index: linux-2.6-galak/arch/powerpc/boot/dts/t

Re: [PATCH v2 1/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
Kumar Gala wrote: > > On Jun 5, 2008, at 4:05 AM, Wolfgang Grandegger wrote: > >> [POWERPC] 85xx: add board support for the TQM8548 modules >> >> This patch adds support for the TQM8548 modules from TQ-Components >> GmbH (http://www.tqc.de). >> >> Signed-off-by: Wolfgang Grandegger <[EMAIL PROTEC

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Anton Vorontsov
On Thu, Jun 05, 2008 at 10:45:17AM -0600, Grant Likely wrote: > On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov > <[EMAIL PROTECTED]> wrote: > > Here is v3. I'm out of ideas if you won't like it. :-) > > > > v3: > > - Now these bindings are using bus notifiers chain, thus we adhere to the > > spi

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Jun 05, 2008 at 10:45:17AM -0600, Grant Likely wrote: >> On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov >> <[EMAIL PROTECTED]> wrote: >> > Here is v3. I'm out of ideas if you won't like it. :-) >> > >> > v3: >>

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Scott Wood wrote: > No, it's not. It can determine that it's at address 0x4f on the i2c bus > at 0xe0003100. This is exactly how the ethernet phy lookup is done. But how does the fabric driver know whether e0003100 is I2C1 or I2C2? And how does the codec driver, which sees only I2C information

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Anton Vorontsov
On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote: > On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov > <[EMAIL PROTECTED]> wrote: > > On Thu, Jun 05, 2008 at 10:45:17AM -0600, Grant Likely wrote: > >> On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov > >> <[EMAIL PROTECTED]> wrote: > >>

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Scott Wood
Timur Tabi wrote: Scott Wood wrote: No, it's not. It can determine that it's at address 0x4f on the i2c bus at 0xe0003100. This is exactly how the ethernet phy lookup is done. But how does the fabric driver know whether e0003100 is I2C1 or I2C2? It shouldn't have to care. And how does t

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote: >> On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov >> <[EMAIL PROTECTED]> wrote: >> > Well, I mentioned the usb_add_hcd()-alike approach for the mmc_spi >> >

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 05 Jun 2008 11:25:23 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > Josh Boyer wrote: > > > And it does. It does so by the unique "regs" properties and > > unit-names. You can assign the index that the i2c subsystem needs > > based on probe order, like I already said. > > The probe orde

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Anton Vorontsov
On Thu, Jun 05, 2008 at 12:18:56PM -0600, Grant Likely wrote: > On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov > <[EMAIL PROTECTED]> wrote: > > On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote: > >> On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov > >> <[EMAIL PROTECTED]> wrote: > >>

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Josh Boyer wrote: > I don't understand this statement. Are your I2C macros hot-pluggable? > Can you dynamically add/remove an I2C engine on your hardware somehow? > Are you mucking about with the DTB and randomly moving around the I2C > node blobs so they probe order differs from boot to boot? >

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 05 Jun 2008 13:35:18 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > Josh Boyer wrote: > > > I don't understand this statement. Are your I2C macros hot-pluggable? > > Can you dynamically add/remove an I2C engine on your hardware somehow? > > Are you mucking about with the DTB and randomly

Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 12:31 PM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Thu, Jun 05, 2008 at 12:18:56PM -0600, Grant Likely wrote: >> On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov >> <[EMAIL PROTECTED]> wrote: >> > On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote: >> >> On T

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 12:27 PM, Josh Boyer <[EMAIL PROTECTED]> wrote: > On Thu, 05 Jun 2008 11:25:23 -0500 > Timur Tabi <[EMAIL PROTECTED]> wrote: > >> Josh Boyer wrote: >> >> > And it does. It does so by the unique "regs" properties and >> > unit-names. You can assign the index that the i2c sub

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 12:46:39 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > > (And I'm talking about I2C, not DMA. I don't care about DMA because > > this conversation will go off into the weeds if we start talking about > > cell-index and every possible device out there.) > > I need to disagr

Re: [PATCH v3 2/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Kumar Gala
=== --- /dev/null +++ linux-2.6-galak/arch/powerpc/boot/dts/tqm8548.dts + memory { + device_type = "memory"; + reg = <0x 0x2000>; + }; is memory fixed on this board to 256M?

Re: 4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Kumar Gala
On Jun 5, 2008, at 10:18 AM, Josh Boyer wrote: On Thu, 5 Jun 2008 09:11:48 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: On Thu, Jun 5, 2008 at 8:52 AM, Josh Boyer <[EMAIL PROTECTED] > wrote: This commit (patch omitted due to size) is sitting in my local tree: commit 0d7efc1e80fc262bcc507

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 12:56 PM, Josh Boyer <[EMAIL PROTECTED]> wrote: > On Thu, 5 Jun 2008 12:46:39 -0600 > "Grant Likely" <[EMAIL PROTECTED]> wrote: > >> In Timur's case, it is absolutely appropriate to use cell-index and/or >> a phandle to make sure it gets the correct DMA registers (which is >>

Re: 4xx support in arch/ppc is going away Real Soon Now

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 13:59:44 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Jun 5, 2008, at 10:18 AM, Josh Boyer wrote: > > > On Thu, 5 Jun 2008 09:11:48 -0600 > > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > >> On Thu, Jun 5, 2008 at 8:52 AM, Josh Boyer <[EMAIL PROTECTED] > >> > wrote: >

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Josh Boyer
On Thu, 5 Jun 2008 13:14:00 -0600 "Grant Likely" <[EMAIL PROTECTED]> wrote: > On Thu, Jun 5, 2008 at 12:56 PM, Josh Boyer <[EMAIL PROTECTED]> wrote: > > On Thu, 5 Jun 2008 12:46:39 -0600 > > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > >> In Timur's case, it is absolutely appropriate to use cel

Re: "cell-index" vs. "index" vs. no index in I2C device nodes

2008-06-05 Thread Timur Tabi
Grant Likely wrote: > No; use an alias in the aliases node. That is what aliases is designed > for. Something like 'index' is a reinvention of the wheel. Do aliases work in reverse? That is, if I have a pointer to a device node, can I look up its alias directly? Or do I have to scan the alias

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Arnd Bergmann
On Thursday 05 June 2008, Stephen Neuendorffer wrote: > > "Grant Likely" <[EMAIL PROTECTED]> wrote: > > > > > Paulus, Can we just kill all of arch/ppc for .27 right now? > > > > Acked-by: Josh Boyer <[EMAIL PROTECTED]> > Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Grant Likely
On Thu, Jun 5, 2008 at 2:12 PM, Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Thursday 05 June 2008, Stephen Neuendorffer wrote: >> > "Grant Likely" <[EMAIL PROTECTED]> wrote: >> > >> > > Paulus, Can we just kill all of arch/ppc for .27 right now? >> > >> > Acked-by: Josh Boyer <[EMAIL PROTECTED]>

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Olof Johansson
On Jun 5, 2008, at 3:12 PM, Arnd Bergmann wrote: On Thursday 05 June 2008, Stephen Neuendorffer wrote: "Grant Likely" <[EMAIL PROTECTED]> wrote: Paulus, Can we just kill all of arch/ppc for .27 right now? Acked-by: Josh Boyer <[EMAIL PROTECTED]> Acked-by: Stephen Neuendorffer <[EMAIL PROT

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Scott Wood
Olof Johansson wrote: On Jun 5, 2008, at 3:12 PM, Arnd Bergmann wrote: On Thursday 05 June 2008, Stephen Neuendorffer wrote: "Grant Likely" <[EMAIL PROTECTED]> wrote: Paulus, Can we just kill all of arch/ppc for .27 right now? Acked-by: Josh Boyer <[EMAIL PROTECTED]> Acked-by: Stephen Ne

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Becky Bruce
On Jun 5, 2008, at 3:30 PM, Scott Wood wrote: Olof Johansson wrote: On Jun 5, 2008, at 3:12 PM, Arnd Bergmann wrote: On Thursday 05 June 2008, Stephen Neuendorffer wrote: "Grant Likely" <[EMAIL PROTECTED]> wrote: Paulus, Can we just kill all of arch/ppc for .27 right now? Acked-by: Josh

Re: [PATCH v3 2/4] [POWERPC] 85xx: add board support for the TQM8548 modules

2008-06-05 Thread Wolfgang Grandegger
Kumar Gala wrote: > >> === >> --- /dev/null >> +++ linux-2.6-galak/arch/powerpc/boot/dts/tqm8548.dts >> > >> +memory { >> +device_type = "memory"; >> +reg = <0x 0x2000>; >> +}; > > is memory fixed

Re: arch/ppc is going away Real Soon Now

2008-06-05 Thread Segher Boessenkool
[Fixed up the collision between Grant and Olof] "Grant Likely" <[EMAIL PROTECTED]> wrote: Paulus, Can we just kill all of arch/ppc for .27 right now? Acked-by: Josh Boyer <[EMAIL PROTECTED]> Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> Ack

  1   2   >