On Thu, Jun 5, 2008 at 10:16 AM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > Here is v3. I'm out of ideas if you won't like it. :-) > > v3: > - Now these bindings are using bus notifiers chain, thus we adhere to the > spi bus. > > By the way, this scheme (IMO) looks good for I2C devices which needs > platform_data extracted from the device tree too (Cc'ing Jochen). > > - Plus changed the OF bindings themselves, implemented voltage-range > property. (Pierre, please take a look at vddrange_to_ocrmask(). I > wonder if you would like this in the MMC core instead, with a kernel > doc, of course.) > > v2: > - Bindings were adhered to the MMC_SPI driver. Withdrawn by Pierre Ossman.
Personally I think your v2 was better, and if I'm interpreting Pierre's comments correctly I think his main point is that instead of using the 'stock' probe/remove hooks for the spi mmc driver, the driver should be mildly reworked to provide a common block of code that can be used by both the OF and non-OF versions of the probe/remove routines. I also think that is the way to go. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
