Re: Powerbook shuts down hard when hot, patch found

2007-10-01 Thread Michel Dänzer
On Sun, 2007-09-30 at 12:16 +0200, Michael Buesch wrote: > > Ah, forgot to say. > It does not crash immediately when the register is written. It takes about > two seconds > to crash. And when the machine is colder to begin with, it takes slightly > longer to trigger. That _might_ support your ov

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-01 Thread Jens Axboe
On Sun, Sep 30 2007, Grant Likely wrote: > On 9/30/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > + if ((rc = platform_driver_register(&ace_platform_driver)) != 0) > > > + goto err_plat; > > > > rc = p

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-01 Thread Grant Likely
On 10/1/07, Jens Axboe <[EMAIL PROTECTED]> wrote: > On Sun, Sep 30 2007, Grant Likely wrote: > > On 9/30/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > > + if ((rc = platform_driver_register(&ace_platform_driver)) != 0)

[PATCH] PowerPC: Add RGMII support for Sequoia 440EPx

2007-10-01 Thread Valentine Barshak
This adds RGMII support to Sequoia DTS and sets correct phy-mode for EMACs. According to Sequoia datasheet, both ethernet ports are connected to RGMII interface, while ZMII is used only for MDIO. Signed-off-by: Valentine Barshak <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/sequoia.dts | 14 ++

PowerPC: new EMAC driver typo fix

2007-10-01 Thread Valentine Barshak
This looks like typo. Please, apply this patch to fix. diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c linux-2.6/drivers/net/ibm_newemac/core.c --- linux-2.6.orig/drivers/net/ibm_newemac/core.c 2007-10-01 17:23:35.0 +0400 +++ linux-2.6/drivers/net/ibm_newemac/core.c200

[PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jan-Bernd Themann
Due to stability issues in high load situations the HW queue handling has to be changed. The HW queues are now stopped and restarted again instead of destroying and allocating new HW queues. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |4 +- drivers

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Due to stability issues in high load situations the HW queue handling > has to be changed. The HW queues are now stopped and restarted again instead > of destroying and allocating new HW queues. > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> May I presume thi

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jan-Bernd Themann
Hi, On Monday 01 October 2007 16:44, Jeff Garzik wrote: > Jan-Bernd Themann wrote: > > Due to stability issues in high load situations the HW queue handling > > has to be changed. The HW queues are now stopped and restarted again instead > > of destroying and allocating new HW queues. > > > > Si

Re: [PATCH] ehea: DLPAR memory add fix

2007-10-01 Thread Jeff Garzik
Jan-Bernd Themann wrote: > Hi, > > On Monday 01 October 2007 16:44, Jeff Garzik wrote: >> Jan-Bernd Themann wrote: >>> Due to stability issues in high load situations the HW queue handling >>> has to be changed. The HW queues are now stopped and restarted again instead >>> of destroying and alloca

Re: [PATCHv2 4/4] Virtex: Add generic Xilinx Virtex board support

2007-10-01 Thread Stephen Rothwell
On Sun, 30 Sep 2007 16:20:52 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/platforms/40x/virtex.c > +#include /me puts on broken record voice :-) linux/of_platform.h, please -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sf

Re: [PATCHv2 3/4] Virtex: add xilinx interrupt controller driver

2007-10-01 Thread Stephen Rothwell
On Sun, 30 Sep 2007 16:20:43 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > diff --git a/arch/powerpc/sysdev/xilinx_intc.c > b/arch/powerpc/sysdev/xilinx_intc.c > new file mode 100644 > index 000..69f05cd > --- /dev/null > +++ b/arch/powerpc/sysdev/xilinx_intc.c > @@ -0,0 +1,151 @@ > +#incl

Re: [PATCHv2 4/4] Virtex: Add generic Xilinx Virtex board support

2007-10-01 Thread Grant Likely
On 10/1/07, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On Sun, 30 Sep 2007 16:20:52 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > > > +++ b/arch/powerpc/platforms/40x/virtex.c > > +#include > > /me puts on broken record voice :-) > > linux/of_platform.h, please Done -- Grant Likely, B.S

Re: [PATCHv2 3/4] Virtex: add xilinx interrupt controller driver

2007-10-01 Thread Grant Likely
On 10/1/07, Stephen Rothwell <[EMAIL PROTECTED]> wrote: > On Sun, 30 Sep 2007 16:20:43 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > > > > diff --git a/arch/powerpc/sysdev/xilinx_intc.c > > b/arch/powerpc/sysdev/xilinx_intc.c > > new file mode 100644 > > index 000..69f05cd > > --- /dev/null

Re: [PATCH] cpm: Describe multi-user ram in its own device node.

2007-10-01 Thread Scott Wood
Kumar Gala wrote: > > On Sep 29, 2007, at 1:49 AM, Vitaly Bordug wrote: >> cpms have dpram, qe has muram. these two are the same stuff in fact. >> Or you are asking about have QE stuff utilize such a binding at the >> same pass? > > I was asking about both these things. As stated in the commit

[RFC] Get rid of linuxppc-embedded?

2007-10-01 Thread Mark A. Greer
With the merging of the powerpc trees I'm not sure there is a clear reason why we have 2 separate powerpc lists anymore (linuxppc-dev and linuxppc-embedded). linuxppc-embedded is fairly low volume/noise but there is still the occasional patch posted there that should really be posted to linuxppc-d

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Matthew Wilcox
On Thu, Sep 27, 2007 at 06:34:37PM -0500, Linas Vepstas wrote: > Good catch. But no ... and I had to study this a bit. Bear with me: I agree with the analysis which I've now snipped. > I think the race you describe above is harmless. The first time > that sym_eh_handler() will run, it will be wit

[PATCH] powerpc: Implement logging of unhandled signals

2007-10-01 Thread Olof Johansson
Implement exception-trace sysctl + support to print when a process is killed due to unhandled signals just as i386 and x86_64 does. Just like on x86, it can be disabled by setting the sysctl variable debug.exception-trace, and the messages are rate limited to not create a DoS exposure. Signed-off

Re: [RFC] Get rid of linuxppc-embedded?

2007-10-01 Thread Grant Likely
On 10/1/07, Mark A. Greer <[EMAIL PROTECTED]> wrote: > With the merging of the powerpc trees I'm not sure there is a clear > reason why we have 2 separate powerpc lists anymore (linuxppc-dev and > linuxppc-embedded). > > linuxppc-embedded is fairly low volume/noise but there is still the occasional

Problem with OF interrupt parsing code

2007-10-01 Thread Gerhard Pircher
Hi, I think I found an issue in the OF interrupt parsing code, although I have to admit that my device tree source doesn't really follow the specification. First some information about my target setup. I didn't specify an interrupt-map and interrupt-map-mask property in the pci node, because AFAI

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Gerhard Pircher
And here comes the device tree source: /* * AmigaOne Device Tree Source * * Copyright 2007 Gerhard Pircher ([EMAIL PROTECTED]) * * This program is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by the * Free Softw

Re: Powerbook shuts down hard when hot, patch found

2007-10-01 Thread Michael Buesch
On Monday 01 October 2007 10:00:02 Michel Dänzer wrote: > > On Sun, 2007-09-30 at 12:16 +0200, Michael Buesch wrote: > > > > Ah, forgot to say. > > It does not crash immediately when the register is written. It takes about > > two seconds > > to crash. And when the machine is colder to begin wit

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Scott Wood
Gerhard Pircher wrote: > First some information about my target setup. I didn't specify an > interrupt-map and interrupt-map-mask property in the pci node, because > AFAIK there are three different AmigaOne models with different IRQ > routing. So detect which one you're running on in the bootwrapp

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 23:00 +0200, Gerhard Pircher wrote: > Hi, > > I think I found an issue in the OF interrupt parsing code, although I > have to admit that my device tree source doesn't really follow the > specification. > > First some information about my target setup. I didn't specify an >

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Scott Wood
Scott Wood wrote: >> The problem occurs now, if there is no device node defined for another >> PCI device. In this case, of_irq_map_pci() checks for an interrupt pin, >> searches again for the host bridge node and calls of_irq_map_raw() with >> the device node of the host bridge. The function finds

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 23:11 +0200, Gerhard Pircher wrote: > [EMAIL PROTECTED] { > device_type = "pci"; > compatible = "mai-logic,articia-s"; > bus-frequency = <01fca055>; // 33.3MHz > bus-range = <0 ff>; >

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 16:37 -0500, Scott Wood wrote: > Scott Wood wrote: > >> The problem occurs now, if there is no device node defined for another > >> PCI device. In this case, of_irq_map_pci() checks for an interrupt pin, > >> searches again for the host bridge node and calls of_irq_map_raw()

nap/dfs on 7448

2007-10-01 Thread Leisner, Martin
I asked this on linuxppc-embedded a week ago (I didn't even know this list existed until last week -- another reason to get rid of linuxpcc-embedded). Has anyone gotten NAP/DFS to reliably work on a 7448? I'm seeing strange problems with peripherals...(using a ram disk works fine). marty ___

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Scott Wood
Benjamin Herrenschmidt wrote: > On Mon, 2007-10-01 at 16:37 -0500, Scott Wood wrote: >> Scott Wood wrote: >> Actually, it doesn't -- it should stop when it sees the >> interrupt-controller property in the i8259 node, at which point it'll be >> trying to use the raw PCI IRQ pin number as an i8259

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 16:48 -0500, Scott Wood wrote: > Benjamin Herrenschmidt wrote: > > On Mon, 2007-10-01 at 16:37 -0500, Scott Wood wrote: > >> Scott Wood wrote: > >> Actually, it doesn't -- it should stop when it sees the > >> interrupt-controller property in the i8259 node, at which point it

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Segher Boessenkool
> i8259: [EMAIL PROTECTED] { > device_type = "interrupt-controller"; > compatible = "pnpPNP,000"; > interrupt-controller; > reg = <0001 0020 0002

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: > > I think the fundamental problem is that completions aren't really > supposed to be used like this. Here's one attempt at using completions > perhaps a little more the way they're supposed to be used, Yes, that looks very good t

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Tue, 2007-10-02 at 00:33 +0200, Segher Boessenkool wrote: > > i8259: [EMAIL PROTECTED] { > > device_type = "interrupt-controller"; > > compatible = "pnpPNP,000"; > > interrupt-controller; > >

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Benjamin Herrenschmidt
On Tue, 2007-10-02 at 08:54 +1000, Benjamin Herrenschmidt wrote: > It shoudn't normally happen. The reason it -does- happen in fact is > that > the above node is also missing the #interrupt-cells property, which > cause the parent-lookup routine to skip it before it gets a chance to > see that the

Re: [PATCH 2/7] [POWERPC] Fix QEIC->MPIC cascading

2007-10-01 Thread Benjamin Herrenschmidt
On Tue, 2007-09-25 at 18:34 +0400, Anton Vorontsov wrote: > set_irq_chained_handler overwrites MPIC's handle_irq function > (handle_fasteoi_irq) thus MPIC never gets eoi event from the > cascaded IRQ. This situation hangs MPIC on MPC8568E. > > Patch adds flow level "end" handler to the MPIC, and

Re: Problem with OF interrupt parsing code

2007-10-01 Thread Segher Boessenkool
>> This is an interrupt controller (it has an "interrupt-controller" >> property, and it has no interrupt parent (there is no >> "interrupt-parent" >> property, for interrupt controllers you do not follow the "normal" >> tree >> parent), so it is the root interrupt controller and there is no loop

Re: [PATCH] powerpc: Implement logging of unhandled signals

2007-10-01 Thread Stephen Rothwell
Hi Olof, On Mon, 1 Oct 2007 15:32:42 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > + char fmt32[] = KERN_INFO "%s[%d]: unhandled signal %d " \ > + "at %08lx nip %08lx lr %08lx code %x\n"; > + char fmt64[] = KERN_INFO "%s[%d]: unhandled signal %d " \ > +

Re: [PATCH] PowerPC: Add RGMII support for Sequoia 440EPx

2007-10-01 Thread Josh Boyer
On Mon, 2007-10-01 at 18:12 +0400, Valentine Barshak wrote: > This adds RGMII support to Sequoia DTS and sets correct phy-mode > for EMACs. According to Sequoia datasheet, both ethernet ports > are connected to RGMII interface, while ZMII is used only for MDIO. I'm going to hold off on this one un

Re: PowerPC: new EMAC driver typo fix

2007-10-01 Thread Josh Boyer
On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote: > This looks like typo. Please, apply this patch to fix. > > diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c > linux-2.6/drivers/net/ibm_newemac/core.c > --- linux-2.6.orig/drivers/net/ibm_newemac/core.c 2007-10-01 > 17:23:

Re: PowerPC: new EMAC driver typo fix

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 18:57 -0500, Josh Boyer wrote: > On Mon, 2007-10-01 at 18:23 +0400, Valentine Barshak wrote: > > This looks like typo. Please, apply this patch to fix. > > > > diff -ruNp linux-2.6.orig/drivers/net/ibm_newemac/core.c > > linux-2.6/drivers/net/ibm_newemac/core.c > > --- linu

Re: [RFC] Get rid of linuxppc-embedded?

2007-10-01 Thread Mark A. Greer
On Mon, Oct 01, 2007 at 02:59:14PM -0600, Grant Likely wrote: > On 10/1/07, Mark A. Greer <[EMAIL PROTECTED]> wrote: > > With the merging of the powerpc trees I'm not sure there is a clear > > reason why we have 2 separate powerpc lists anymore (linuxppc-dev and > > linuxppc-embedded). > > > > linu

[PATCH] powerpc: Change MAINTAINER references linuxppc-embedded

2007-10-01 Thread Mark A. Greer
Powerpc patches should be posted to linuxppc-dev@ozlabs.org so modify MAINTAINERS to no longer reference [EMAIL PROTECTED] Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- MAINTAINERS | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) --- diff --git a/MAINTAINERS b/MA

Re: [PATCH] powerpc: Change MAINTAINER references linuxppc-embedded

2007-10-01 Thread Mark A. Greer
On Mon, Oct 01, 2007 at 05:20:53PM -0700, Mark A. Greer wrote: > Powerpc patches should be posted to linuxppc-dev@ozlabs.org so modify > MAINTAINERS to no longer reference [EMAIL PROTECTED] > > Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> /me sighs. Disregard this. I send before I had the p

Re: [PATCH] powerpc: Implement logging of unhandled signals

2007-10-01 Thread Olof Johansson
On Tue, Oct 02, 2007 at 09:41:30AM +1000, Stephen Rothwell wrote: > Hi Olof, > > On Mon, 1 Oct 2007 15:32:42 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > > + char fmt32[] = KERN_INFO "%s[%d]: unhandled signal %d " \ > > + "at %08lx nip %08lx lr %08lx code %x\n"; > > +

Re: [PATCH] powerpc: MAINTAINERS shouldn't reference linuxppc-embedded

2007-10-01 Thread Mark A. Greer
Powerpc patches should be posted to linuxppc-dev@ozlabs.org so modify MAINTAINERS to no longer reference [EMAIL PROTECTED] Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- MAINTAINERS | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) --- diff --git a/MAINTAINERS b/M

Re: [PATCH 05/18] Add PowerPC Xilinx Virtex entry to maintainers

2007-10-01 Thread Paul Mackerras
Grant Likely writes: > On 9/28/07, Grant Likely <[EMAIL PROTECTED]> wrote: > > From: Grant Likely <[EMAIL PROTECTED]> > > > > Signed-off-by: Grant Likely <[EMAIL PROTECTED]> > > --- > > > > Paul, is this okay by you? Josh has already okayed it. > > Specifically, I'll collect the virtex changes an

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Matthew Wilcox
On Mon, Oct 01, 2007 at 05:41:32PM -0500, Linas Vepstas wrote: > On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: > > I think the fundamental problem is that completions aren't really > > supposed to be used like this. Here's one attempt at using completions > > perhaps a little mor

[PATCH v3 01/12] Virtex: Add uartlite bootwrapper driver

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Allows the bootwrapper to use the uartlite device for console output. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/boot/Makefile |2 + arch/powerpc/boot/ops.h |1 + arch/powerpc/boot/serial.c |2 + arch/powerpc/boot

[PATCH v3 00/12] Xilinx Virtex and Uartlite arch/powerpc patches ready for merge

2007-10-01 Thread Grant Likely
Josh, Here is the Xilinx Virtex and Uartlite series of patches to add support to arch/powerpc. Please merge. Device tree source files (.dts) and defconfigs to follow in a subsuquent patch series. Thanks, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd.

[PATCH v3 03/12] Virtex: add xilinx interrupt controller driver

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Adds support for the Xilinx opb-intc interrupt controller Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/Makefile |1 arch/powerpc/sysdev/xilinx_intc.c | 151 + include/asm-powerpc/xil

[PATCH v3 05/12] Add PowerPC Xilinx Virtex entry to maintainers

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8f80068..bca4ca5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2304,6 +2304,13 @@

[PATCH v3 07/12] Uartlite: change name of ports to ulite_ports

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Changed to match naming convention used in the rest of the module Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/serial/uartlite.c b/dr

[PATCH v3 11/12] Uartlite: Add of-platform-bus binding

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Add of_platform bus binding so this driver can be used with arch/powerpc Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 96 +++-- 1 files changed, 92 insertions(+), 4 deletions(-)

[PATCH v3 12/12] Uartlite: Let the console be initialized earlier

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> By configuring it earlier we get console output sooner which is helpful for debugging when the kernel crashes before the serial drivers are initialized. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 41 ++

[PATCH v3 04/12] Virtex: Add generic Xilinx Virtex board support

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Adds support for generic Xilinx Virtex boards. Any board which specifies "xilinx,virtex" in the compatible property will make use of this board support. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/platforms/40x/Makefile |1 + arch

[PATCH v3 06/12] Uartlite: Fix reg io to access documented register size

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> The Uartlite data sheet defines the registers as 32 bit wide. This patch changes the register access to use 32 bit transfers and eliminates the magic +3 offset which is currently required to make the device work. Signed-off-by: Grant Likely <[EMAIL PROTECTE

[PATCH v3 02/12] Virtex: Add Kconfig macros for Xilinx Virtex board support

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Add the needed kconfig macros to enable Xilinx Virtex board support Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- arch/powerpc/platforms/40x/Kconfig | 38 1 files changed, 25 insertions(+), 13 deletions(-) diff

[PATCH v3 09/12] Uartlite: Separate the bus binding from the driver proper

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Separate the bus binding code from the driver structure allocation code in preparation for adding the of_platform_bus bindings needed by arch/powerpc Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 99 +

[PATCH v3 08/12] Uartlite: Add macro for uartlite device name

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Changed to make the following OF_platform bus binding patch a wee bit cleaner Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/serial/uartlite

[PATCH v3 10/12] Uartlite: Comment block tidy

2007-10-01 Thread Grant Likely
From: Grant Likely <[EMAIL PROTECTED]> Tidy the comments to split the driver into logical section; the main driver, the console driver, the platform bus binding, and module initialization and teardown. Signed-off-by: Grant Likely <[EMAIL PROTECTED]> --- drivers/serial/uartlite.c | 43

Re: [PATCH] powerpc: fix pci domain detection

2007-10-01 Thread Benjamin Herrenschmidt
On Wed, 2007-09-26 at 16:02 +0200, Arnd Bergmann wrote: > The /proc/bus/pci/* files list PCI domain numbers only for > devices that claim to be on a multi-domain system. The check > for this is broken on powerpc, because the buid value is > truncated to 32 bits. > > There is at least one machine

Please pull powerpc.git merge branch

2007-10-01 Thread Paul Mackerras
Linus, Please do git pull \ git://git.kernel.org/pub/scm/linux/kernel/git/paulus/powerpc.git merge to get a bug-fix from Anton Blanchard for 2.6.23. Thanks, Paul. arch/powerpc/platforms/pseries/xics.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit e48395f1753cab0fde6c03f1

[PATCH] [POWERPC] Limit range of __init_ref_ok somewhat

2007-10-01 Thread Stephen Rothwell
This patch introduces zalloc_maybe_bootmem and uses it so that we don;t have to mark a whole (largish) routine as __init_ref_ok. Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- arch/powerpc/kernel/irq.c| 10 ++ arch/powerpc/lib/alloc.c | 15 +++ include/asm

Re: [PATCH] Make sure to of_node_get() the result of pci_device_to_OF_node()

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:03 +1000, Michael Ellerman wrote: > pci_device_to_OF_node() returns the device node attached to a PCI device, > but doesn't actually grab a reference - we need to do it ourselves. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[

Re: [PATCH 1/7] Store the base address in dcr_host_t

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > In its current form, dcr_map() doesn't remember the base address you passed > it, which means you need to store it somewhere else. Rather than adding the > base to another struct it seems simpler to store it in the dcr_host_t. > > Signe

Re: [PATCH 2/7] Update mpic to use dcr_host_t.base

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > Now that dcr_host_t contains the base address, we can use that in the mpic > code, rather than storing it separately. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > --- >

Re: [PATCH 3/7] Use dcr_host_t.base in ibm_emac_mal

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > This requires us to do a sort-of fake dcr_map(), so that base is set > properly. This will be fixed/removed when the device-tree-aware emac driver > is merged. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin

Re: [PATCH 4/7] Update axon_msi to use dcr_host_t.base

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > Now that dcr_host_t contains the base address, we can use that in the > axon_msi code, rather than storing it separately. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > -

Re: [PATCH 5/7] Add dcr_host_t.base in dcr_read()/dcr_write()

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > Now that all users of dcr_read()/dcr_write() add the dcr_host_t.base, we can > save them the trouble and do it in dcr_read()/dcr_write(). > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Please, fixup the changeset comment to be

Re: [PATCH 6/7] Add dcr_map_reg() helper

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > Add a helper routine to map dcr's based on the "dcr-reg" property of > a device node. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Wouldn't it be more consistent to call it of_map_dcr ? Or maybe find an even better name, but

Re: [PATCH 7/7] Remove msic_dcr_read() and use dcr_map_reg() in axon_msi.c

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > msic_dcr_read() doesn't really do anything useful, just replace it with > direct calls to dcr_read(). > > Use dcr_map_reg() in the axon_msi setup code, rather than essentially doing > it by hand. > > Signed-off-by: Michael Ellerman <[E

Re: [PATCH 1/4] Simplify error logic in u3msi_setup_msi_irqs()

2007-10-01 Thread Benjamin Herrenschmidt
On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > u3msi_setup_msi_irqs() doesn't need to call teardown() itself, > the generic code will do this for us as long as we return a non > zero value. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[E

Re: [PATCH 2/4] Simplify error logic in rtas_setup_msi_irqs()

2007-10-01 Thread Benjamin Herrenschmidt
On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > rtas_setup_msi_irqs() doesn't need to call teardown() itself, > the generic code will do this for us as long as we return a non > zero value. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EM

Re: [PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-10-01 Thread Benjamin Herrenschmidt
On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > Currently rtas_change_msi() returns either the error code from RTAS, or if > the RTAS call succeeded the number of irqs that were configured by RTAS. > This makes checking the return value more complicated than it needs to be. > > Inste

Re: [PATCH 4/4] Inline u3msi_compose_msi_msg()

2007-10-01 Thread Benjamin Herrenschmidt
On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > In the MPIC U3 MSI code, we call u3msi_compose_msi_msg() once for each MSI. > This is overkill, as the address is per pci device, not per MSI. So setup > the address once, and just set the data per MSI. > > Signed-off-by: Michael Ellerm

[PATCH v2] powerpc: Implement logging of unhandled signals

2007-10-01 Thread Olof Johansson
Implement show_unhandled_signals sysctl + support to print when a process is killed due to unhandled signals just as i386 and x86_64 does. Signed-off-by: Olof Johansson <[EMAIL PROTECTED]> --- Fixed the const char definitions, plus the two warnings that the change brought (printing a ptr as %lx

Re: [PATCH 6/7] Add dcr_map_reg() helper

2007-10-01 Thread Michael Ellerman
On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > > Add a helper routine to map dcr's based on the "dcr-reg" property of > > a device node. > > > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > > Wouldn't it be

Re: [PATCH 2 6/7] Uartlite: Add of-platform-bus binding

2007-10-01 Thread Benjamin Herrenschmidt
On Sun, 2007-09-30 at 16:42 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > Add of_platform bus binding so this driver can be used with arch/powerpc Another option is to have a "constructor" in the platform code that generates the platform device from the DT. It might eve

Re: [PATCH v2 5/6] Sysace: Move IRQ handler registration to occur after FSM is initialized

2007-10-01 Thread Benjamin Herrenschmidt
On Sun, 2007-09-30 at 16:57 -0600, Grant Likely wrote: > val |= ACE_CTRL_DATABUFRDYIRQ | ACE_CTRL_ERRORIRQ; > ace_out(ace, ACE_CTRL, val); > > + /* Now we can hook up the irq handler */ > + if (ace->irq != NO_IRQ) { > + rc = request_irq(ace->irq, ace_int

Re: [PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-10-01 Thread Michael Ellerman
On Tue, 2007-10-02 at 15:23 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > > Currently rtas_change_msi() returns either the error code from RTAS, or if > > the RTAS call succeeded the number of irqs that were configured by RTAS. > > This makes ch

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 13:59 +0200, Jens Axboe wrote: > On Sun, Sep 30 2007, Grant Likely wrote: > > On 9/30/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > > + if ((rc = platform_driver_register(&ace_platform_driver)) !

Re: nap/dfs on 7448

2007-10-01 Thread Benjamin Herrenschmidt
On Mon, 2007-10-01 at 17:32 -0400, Leisner, Martin wrote: > I asked this on linuxppc-embedded a week ago (I didn't even know this > list existed until last week -- another reason to get rid of > linuxpcc-embedded). > > Has anyone gotten NAP/DFS to reliably work on a 7448? > > I'm seeing strange

Re: [PATCH 3/7] Use dcr_host_t.base in ibm_emac_mal

2007-10-01 Thread Michael Ellerman
On Tue, 2007-10-02 at 15:13 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > > This requires us to do a sort-of fake dcr_map(), so that base is set > > properly. This will be fixed/removed when the device-tree-aware emac driver > > is merged. > >

Re: [PATCH 6/7] Add dcr_map_reg() helper

2007-10-01 Thread Benjamin Herrenschmidt
On Tue, 2007-10-02 at 15:51 +1000, Michael Ellerman wrote: > On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > > > Add a helper routine to map dcr's based on the "dcr-reg" property of > > > a device node. > > > > > >

Re: [PATCH 3/4] Simplify rtas_change_msi() error semantics

2007-10-01 Thread Benjamin Herrenschmidt
On Tue, 2007-10-02 at 15:58 +1000, Michael Ellerman wrote: > > Looks allright, just a question tho... what do we do if it fails ? > Do we > > try to fallback to a lower number of MSIs ? Or what ? Dead device ? > > That's all up to the device driver. In theory the driver could try again > with a l

Re: [PATCH v2 2/6] Sysace: Use the established platform bus api

2007-10-01 Thread Jens Axboe
On Tue, Oct 02 2007, Benjamin Herrenschmidt wrote: > > On Mon, 2007-10-01 at 13:59 +0200, Jens Axboe wrote: > > On Sun, Sep 30 2007, Grant Likely wrote: > > > On 9/30/07, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > On Sun, Sep 30, 2007 at 04:57:09PM -0600, Grant Likely wrote: > > > > > +

Re: Powerbook shuts down hard when hot, patch found

2007-10-01 Thread Michel Dänzer
On Mon, 2007-10-01 at 22:58 +0200, Michael Buesch wrote: > On Monday 01 October 2007 10:00:02 Michel Dänzer wrote: > > > > On Sun, 2007-09-30 at 12:16 +0200, Michael Buesch wrote: > > > > > > Ah, forgot to say. > > > It does not crash immediately when the register is written. It takes > > > abo