On Tue, 2007-10-02 at 15:51 +1000, Michael Ellerman wrote: > On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote: > > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > > > Add a helper routine to map dcr's based on the "dcr-reg" property of > > > a device node. > > > > > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > > > > Wouldn't it be more consistent to call it of_map_dcr ? Or maybe find an > > even better name, but dcr_map_reg really sucks :-) > > That would give us dcr_map(), dcr_unmap() and of_map_dcr() - which > doesn't strike me as more consistent. > > I don't particularly like dcr_map_reg(), but I think it's at least > obvious that it's a variant of dcr_map() and that it has something to do > with a "reg" .. maybe even a "dcr-reg" :)
dcr_map_node maybe ? dcr_map_device ? dcr_map_property ? hrm... allright, keep it that way if you want but heh, at least see if you can come up with something better before it gets merged :-) Ben _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
