On Tue, 2007-10-02 at 15:23 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2007-09-20 at 16:36 +1000, Michael Ellerman wrote: > > Currently rtas_change_msi() returns either the error code from RTAS, or if > > the RTAS call succeeded the number of irqs that were configured by RTAS. > > This makes checking the return value more complicated than it needs to be. > > > > Instead, have rtas_change_msi() check that the number of irqs configured by > > RTAS is equal to what we requested - and return an error otherwise. This > > makes > > the return semantics match the usual 0 for success, something else for > > error. > > > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > > Looks allright, just a question tho... what do we do if it fails ? Do we > try to fallback to a lower number of MSIs ? Or what ? Dead device ?
That's all up to the device driver. In theory the driver could try again with a lower count - but that might require extra logic in the driver to handle shared irq handlers etc. In practice I think the current drivers will just fail. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
